knapsack_pro 3.1.1 → 3.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a66b28a9f7bdfa3aaa0492c3099b62d020b2a01a48030865c503448ccb4ff77
-  data.tar.gz: c0fae2955b72521decd338c64be57c31eacc2f33d41dbce39610be0584183aab
+  metadata.gz: 7970b3bcbc62109c8b7e2161e75d5b4a8337494516817dbd8c2b4929b46bbd10
+  data.tar.gz: 60b57c64958cb342a9b21c1dc0db32bfa70e8e105ab4680e18fd430d4148a1b7
 SHA512:
-  metadata.gz: c142d923945cb4ed649535b93d0a632f5ed705513c9b3528e776784e0f6e5959ce08b81c084e69a89dd42027e453f32c2830743e8f366afe2d0fb4ddca5d8ae7
-  data.tar.gz: 6ca8aa6ac8ad655bb267e17ba93564b5f44585b0dcaac74e195c7e818323f9aa954da067753c7c0b9b7c3782d3d3ecbf2e3829e7c147a9f054cde3af56898ad8
+  metadata.gz: 0b0a4160292a07b8ae1cc21f34c2cf0d8de1ce53d4e0501b4ba4715feb9aa51317e3f1503e3e00532d048daec816e58cd3a95dec2111fedd77f7a47206d81dcb
+  data.tar.gz: c083b70fb826837650d206c6f433f207cac995bbd3e6a36c386b038302bbf7b5bd90d3df201af9e8f5cdf5f68b38d4f45e1a4a7cdc0c4b9c2a533559b45cfe99

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+### 3.1.2
+
+* Fix bug when test files have no recorded time execution then they should not be detected as slow test files for RSpec split by test examples feature
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/163
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.1.1...v3.1.2
+
 ### 3.1.1
 
 * Rephrase log outputs in the Queue Mode RSpec runner

data/lib/knapsack_pro/slow_test_file_determiner.rb

@@ -8,7 +8,8 @@ module KnapsackPro
       time_threshold = (time_execution / KnapsackPro::Config::Env.ci_node_total) * TIME_THRESHOLD_PER_CI_NODE
 
       test_files.select do |test_file|
-        test_file.fetch('time_execution') >= time_threshold
+        time_execution = test_file.fetch('time_execution')
+        time_execution >= time_threshold && time_execution > 0
       end
     end
 

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '3.1.1'
+  VERSION = '3.1.2'
 end

data/spec/knapsack_pro/slow_test_file_determiner_spec.rb

@@ -1,16 +1,6 @@
 describe KnapsackPro::SlowTestFileDeterminer do
   describe '.call' do
     let(:node_total) { 4 }
-    let(:time_execution) { 20.0 }
-    let(:test_files) do
-      [
-        { 'path' => 'a_spec.rb', 'time_execution' => 1.0 },
-        { 'path' => 'b_spec.rb', 'time_execution' => 3.4 },
-        # slow tests are above 3.5s threshold (20.0 / 4 * 0.7 = 3.5)
-        { 'path' => 'c_spec.rb', 'time_execution' => 3.5 },
-        { 'path' => 'd_spec.rb', 'time_execution' => 5.9 },
-      ]
-    end
 
     before do
       expect(KnapsackPro::Config::Env).to receive(:ci_node_total).and_return(node_total)
@@ -18,11 +8,38 @@ describe KnapsackPro::SlowTestFileDeterminer do
 
     subject { described_class.call(test_files, time_execution) }
 
-    it do
-      expect(subject).to eq([
-        { 'path' => 'c_spec.rb', 'time_execution' => 3.5 },
-        { 'path' => 'd_spec.rb', 'time_execution' => 5.9 },
-      ])
+    context 'when test files have recorded time execution' do
+      let(:time_execution) { 20.0 }
+      let(:test_files) do
+        [
+          { 'path' => 'a_spec.rb', 'time_execution' => 1.0 },
+          { 'path' => 'b_spec.rb', 'time_execution' => 3.4 },
+          # slow tests are above 3.5s threshold (20.0 / 4 * 0.7 = 3.5)
+          { 'path' => 'c_spec.rb', 'time_execution' => 3.5 },
+          { 'path' => 'd_spec.rb', 'time_execution' => 5.9 },
+        ]
+      end
+
+      it do
+        expect(subject).to eq([
+          { 'path' => 'c_spec.rb', 'time_execution' => 3.5 },
+          { 'path' => 'd_spec.rb', 'time_execution' => 5.9 },
+        ])
+      end
+    end
+
+    context 'when test files have no recorded time execution' do
+      let(:time_execution) { 0.0 }
+      let(:test_files) do
+        [
+          { 'path' => 'a_spec.rb', 'time_execution' => 0.0 },
+          { 'path' => 'b_spec.rb', 'time_execution' => 0.0 },
+        ]
+      end
+
+      it do
+        expect(subject).to eq([])
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.1.2
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-09-10 00:00:00.000000000 Z
+date: 2021-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake