knapsack_pro 3.1.0 → 3.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b6b697b425c2b1d68ff8e6816703e3b49528483d85cf581b529a62161d3e9ad4
-  data.tar.gz: 39d542d0ecb1537ef711210d22bc79775d54d82e9dc033345dfa2b94495a3039
+  metadata.gz: 4fec041f1d838c8672e70c4a3703a2adfd3d727c912b2543c88c3cf01fe9ae65
+  data.tar.gz: 789349de506fcc48e3e76a881f9f87205544792c8d49243e4f20342c01627b01
 SHA512:
-  metadata.gz: 3f1329d908f489309178bc989bac548a81fd8d3d53fa3a968d40eaa12d4fd67cef1788c177a4351e03ec65dd06c5785bc1ee15b9e8ade03648866519f5833f9c
-  data.tar.gz: 6162c988f814c28e764567bec7a5fdaa15056626f857eb8a59d0895ec0103837dfa0c2c8ea0f1cca68ff0eab430b69ab584b21b9f3ecc1df086028b783cb2871
+  metadata.gz: b28ea456bda112b8c2329a4728b82fa5d3363a883d090a10066023bf246f6f12f98c573f62cefc3d791aacca27f18a37cfc294ddd61b6b5f43af4027e4818e16
+  data.tar.gz: 90ee101ba4dc5a01e13960fe1fd469259b3242b0b0daeccfbc38300c20a3b0d7bf9f3849be6ffc8ebd649705838549a06519e031c13ba4c0896d0f019b3e255c

data/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Change Log
 
+### 3.1.3
+
+* Run Fallback Mode when `Errno::ECONNRESET` exception happens
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/164
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.1.2...v3.1.3
+
+### 3.1.2
+
+* Fix bug when test files have no recorded time execution then they should not be detected as slow test files for RSpec split by test examples feature
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/163
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.1.1...v3.1.2
+
+### 3.1.1
+
+* Rephrase log outputs in the Queue Mode RSpec runner
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/160
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.1.0...v3.1.1
+
 ### 3.1.0
 
 * Use `.knapsack_pro` directory for temporary files instead of the `tmp` directory in the user's project directory

data/README.md

@@ -1714,6 +1714,11 @@ $ gem push knapsack_pro-X.X.X.gem
 
 Update the latest available gem version in `TestSuiteClientVersionChecker` for the Knapsack Pro API repository.
 
+Update knapsack_pro gem version in:
+
+* https://github.com/KnapsackPro/rails-app-with-knapsack_pro
+* our private Knapsack Pro API repository
+
 ## Mentions
 
 List of articles where people mentioned Knapsack Pro:

data/lib/knapsack_pro/client/connection.rb

@@ -119,7 +119,7 @@ module KnapsackPro
         end
 
         response_body
-      rescue ServerError, Errno::ECONNREFUSED, Errno::ETIMEDOUT, Errno::EPIPE, EOFError, SocketError, Net::OpenTimeout, Net::ReadTimeout, OpenSSL::SSL::SSLError => e
+      rescue ServerError, Errno::ECONNREFUSED, Errno::ECONNRESET, Errno::ETIMEDOUT, Errno::EPIPE, EOFError, SocketError, Net::OpenTimeout, Net::ReadTimeout, OpenSSL::SSL::SSLError => e
         logger.warn("#{action.http_method.to_s.upcase} #{endpoint_url}")
         logger.warn('Request failed due to:')
         logger.warn(e.inspect)

data/lib/knapsack_pro/runners/queue/rspec_runner.rb

@@ -110,9 +110,9 @@ module KnapsackPro
         def self.log_rspec_command(cli_args, test_file_paths, type)
           case type
           when :subset_queue
-            KnapsackPro.logger.info("To retry in development the subset of tests fetched from API queue please run below command on your machine. If you use --order random then remember to add proper --seed 123 that you will find at the end of rspec command.")
+            KnapsackPro.logger.info("To retry the last batch of tests fetched from the API Queue, please run the following command on your machine. (If you use the `-- order random` option, remember to add correct `--seed 123` that you can find at the end of the RSpec output.)")
           when :end_of_queue
-            KnapsackPro.logger.info("To retry in development the tests for this CI node please run below command on your machine. It will run all tests in a single run. If you need to reproduce a particular subset of tests fetched from API queue then above after each request to Knapsack Pro API you will find example rspec command.")
+            KnapsackPro.logger.info("To retry all the tests assigned to this CI node, please run the following command on your machine:")
           end
 
           stringify_cli_args = cli_args.join(' ')

data/lib/knapsack_pro/slow_test_file_determiner.rb

@@ -8,7 +8,8 @@ module KnapsackPro
       time_threshold = (time_execution / KnapsackPro::Config::Env.ci_node_total) * TIME_THRESHOLD_PER_CI_NODE
 
       test_files.select do |test_file|
-        test_file.fetch('time_execution') >= time_threshold
+        time_execution = test_file.fetch('time_execution')
+        time_execution >= time_threshold && time_execution > 0
       end
     end
 

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '3.1.0'
+  VERSION = '3.1.3'
 end

data/spec/knapsack_pro/slow_test_file_determiner_spec.rb

@@ -1,16 +1,6 @@
 describe KnapsackPro::SlowTestFileDeterminer do
   describe '.call' do
     let(:node_total) { 4 }
-    let(:time_execution) { 20.0 }
-    let(:test_files) do
-      [
-        { 'path' => 'a_spec.rb', 'time_execution' => 1.0 },
-        { 'path' => 'b_spec.rb', 'time_execution' => 3.4 },
-        # slow tests are above 3.5s threshold (20.0 / 4 * 0.7 = 3.5)
-        { 'path' => 'c_spec.rb', 'time_execution' => 3.5 },
-        { 'path' => 'd_spec.rb', 'time_execution' => 5.9 },
-      ]
-    end
 
     before do
       expect(KnapsackPro::Config::Env).to receive(:ci_node_total).and_return(node_total)
@@ -18,11 +8,38 @@ describe KnapsackPro::SlowTestFileDeterminer do
 
     subject { described_class.call(test_files, time_execution) }
 
-    it do
-      expect(subject).to eq([
-        { 'path' => 'c_spec.rb', 'time_execution' => 3.5 },
-        { 'path' => 'd_spec.rb', 'time_execution' => 5.9 },
-      ])
+    context 'when test files have recorded time execution' do
+      let(:time_execution) { 20.0 }
+      let(:test_files) do
+        [
+          { 'path' => 'a_spec.rb', 'time_execution' => 1.0 },
+          { 'path' => 'b_spec.rb', 'time_execution' => 3.4 },
+          # slow tests are above 3.5s threshold (20.0 / 4 * 0.7 = 3.5)
+          { 'path' => 'c_spec.rb', 'time_execution' => 3.5 },
+          { 'path' => 'd_spec.rb', 'time_execution' => 5.9 },
+        ]
+      end
+
+      it do
+        expect(subject).to eq([
+          { 'path' => 'c_spec.rb', 'time_execution' => 3.5 },
+          { 'path' => 'd_spec.rb', 'time_execution' => 5.9 },
+        ])
+      end
+    end
+
+    context 'when test files have no recorded time execution' do
+      let(:time_execution) { 0.0 }
+      let(:test_files) do
+        [
+          { 'path' => 'a_spec.rb', 'time_execution' => 0.0 },
+          { 'path' => 'b_spec.rb', 'time_execution' => 0.0 },
+        ]
+      end
+
+      it do
+        expect(subject).to eq([])
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.3
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-17 00:00:00.000000000 Z
+date: 2021-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake