knapsack_pro 2.18.1 → 2.18.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dfa70d9f5566c820f5ca45bc6c0dc52302ee7de056f4b50ad86739b3ca34960d
-  data.tar.gz: a5c877f7c89a4c94bbcd247a6fe75b8ff01a9e2be7f82b82fe4ac42dcdac489c
+  metadata.gz: 6a298724c7651190199978edc99b96116abcbb827d12237e128f2c5d87297847
+  data.tar.gz: 2750130109b114747278d86fd4bc2477d143b2f1f3564f7b36d224f5044e29cf
 SHA512:
-  metadata.gz: 390be4aa9a3bfa79da3149bbc7acdec09905aed17ddbac32998e7324cc23571bcb321e3ba541d3890df1993ab5a125c10edf5cfcf28f8568347ff96af8b18a94
-  data.tar.gz: 431ec87a1b9c17fb9e2c5dfde14d93118e0378731f6c70ff7fcb1ed4f74dcef773bd861be33d0d4327689d4d8fb9df333df59630f44c9be3212b3915f2ab5cd4
+  metadata.gz: 7742dbaf98eb6bc1aeda1c15c2dd3b8f627fe27c91fa58a4f46e71d2ff4839d5899005b36deddcb619745689dd6426f9319df1b70ad26f317be2cea2e6922799
+  data.tar.gz: a102bc5ab00cabc5ec4f7007e52081fd97ca194ea8e84072b2df8fb66664c6e320ea7b76d0970aa702ed9549e36bd5c702a7156de914b5fbdf9fe00c43de8351

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+### 2.18.2
+
+* Track all test files assigned to a CI node in Regular Mode including pending test files in order to retry proper set of tests on the retried CI node
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/152
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v2.18.1...v2.18.2
+
 ### 2.18.1
 
 * Ensure RSpec is loaded to check its version for RSpec split by test examples feature

data/README.md

@@ -440,13 +440,13 @@ If your test suite is very long and the RSpec output is too long for your CI nod
 ### Additional info about queue mode
 
 * You should use a separate API token for queue mode than for regular mode to avoid problems with test suite split (especially in case you would like to go back to regular mode).
-There might be some cached test suite splits for git commits you have run in past for API token you used in queue mode because of the [flag `KNAPSACK_PRO_FIXED_TEST_SUITE_SPLIT=true` for regular mode which is default](#knapsack_pro_fixed_test_suite_splite-test-suite-split-based-on-seed).
+There might be some cached test suite splits for git commits you have run in past for API token you used in queue mode because of the [flag `KNAPSACK_PRO_FIXED_TEST_SUITE_SPLIT=true` for regular mode which is default](#knapsack_pro_fixed_test_suite_split-test-suite-split-based-on-seed).
 
 * If you are not using one of the [supported CI providers](#supported-ci-providers) then please note that the knapsack_pro gem doesn't have a CI build ID in order to generate a queue for each particular CI build. This may result in two different CI builds taking tests from the same queue when CI builds are running at the same time against the same git commit.
 
   To avoid this you should specify a unique `KNAPSACK_PRO_CI_NODE_BUILD_ID` environment variable for each CI build. This mean that each CI node that is part of particular CI build should have the same value for `KNAPSACK_PRO_CI_NODE_BUILD_ID`.
 
-* Note that in the Queue Mode by default you cannot retry the failed CI node with exactly the same subset of tests that were run on the CI node in the first place. It's possible in regular mode ([read more](#knapsack_pro_fixed_test_suite_splite-test-suite-split-based-on-seed)). If you want to have similar behavior in Queue Mode you need to explicitly [enable it](#knapsack_pro_fixed_queue_split-remember-queue-split-on-retry-ci-node).
+* Note that in the Queue Mode by default you cannot retry the failed CI node with exactly the same subset of tests that were run on the CI node in the first place. It's possible in regular mode ([read more](#knapsack_pro_fixed_test_suite_split-test-suite-split-based-on-seed)). If you want to have similar behavior in Queue Mode you need to explicitly [enable it](#knapsack_pro_fixed_queue_split-remember-queue-split-on-retry-ci-node).
 
   By default the Queue Mode works this way:
 
@@ -626,7 +626,7 @@ This is only for maintainer of knapsack_pro gem. Not for the end users.
 
 ### Required CI configuration if you use retry single failed CI node feature on your CI server when KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true (in Queue Mode) or KNAPSACK_PRO_FIXED_TEST_SUITE_SPLIT=true (in Regular Mode)
 
-Read below required configuration step if you use Queue Mode and you set [`KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true`](#knapsack_pro_fixed_queue_split-remember-queue-split-on-retry-ci-node) or you use Regular Mode which has by default [`KNAPSACK_PRO_FIXED_TEST_SUITE_SPLIT=true`](#knapsack_pro_fixed_test_suite_splite-test-suite-split-based-on-seed).
+Read below required configuration step if you use Queue Mode and you set [`KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true`](#knapsack_pro_fixed_queue_split-remember-queue-split-on-retry-ci-node) or you use Regular Mode which has by default [`KNAPSACK_PRO_FIXED_TEST_SUITE_SPLIT=true`](#knapsack_pro_fixed_test_suite_split-test-suite-split-based-on-seed).
 
 * __IMPORTANT:__ If you use __the feature to retry only a single failed CI node__ on your CI server (for instance you use Buildkite and you use [auto-retry](https://buildkite.com/docs/pipelines/command-step#retry-attributes) for the failed job) then you need to be aware of [a race condition that could happen](https://github.com/KnapsackPro/knapsack_pro-ruby/pull/100). knapsack_pro should not allow running tests in Fallback Mode in the case when the failed CI node was retried to prevent running the wrong set of tests.
 

data/lib/knapsack_pro/config/env.rb

@@ -257,6 +257,14 @@ module KnapsackPro
           ENV['KNAPSACK_PRO_LOG_DIR']
         end
 
+        def test_runner_adapter
+          ENV['KNAPSACK_PRO_TEST_RUNNER_ADAPTER']
+        end
+
+        def set_test_runner_adapter(adapter_class)
+          ENV['KNAPSACK_PRO_TEST_RUNNER_ADAPTER'] = adapter_class.to_s.split('::').last
+        end
+
         private
 
         def required_env(env_name)

data/lib/knapsack_pro/runners/cucumber_runner.rb

@@ -6,11 +6,14 @@ module KnapsackPro
         ENV['KNAPSACK_PRO_RECORDING_ENABLED'] = 'true'
 
         adapter_class = KnapsackPro::Adapters::CucumberAdapter
+        KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)
         runner = new(adapter_class)
 
         if runner.test_files_to_execute_exist?
           adapter_class.verify_bind_method_called
 
+          KnapsackPro.tracker.set_prerun_tests(runner.test_file_paths)
+
           require 'cucumber/rake/task'
 
           task_name = 'knapsack_pro:cucumber_run'

data/lib/knapsack_pro/runners/minitest_runner.rb

@@ -6,11 +6,14 @@ module KnapsackPro
         ENV['KNAPSACK_PRO_RECORDING_ENABLED'] = 'true'
 
         adapter_class = KnapsackPro::Adapters::MinitestAdapter
+        KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)
         runner = new(adapter_class)
 
         if runner.test_files_to_execute_exist?
           adapter_class.verify_bind_method_called
 
+          KnapsackPro.tracker.set_prerun_tests(runner.test_file_paths)
+
           task_name = 'knapsack_pro:minitest_run'
 
           if Rake::Task.task_defined?(task_name)

data/lib/knapsack_pro/runners/queue/cucumber_runner.rb

@@ -9,7 +9,9 @@ module KnapsackPro
           ENV['KNAPSACK_PRO_QUEUE_RECORDING_ENABLED'] = 'true'
           ENV['KNAPSACK_PRO_QUEUE_ID'] = KnapsackPro::Config::EnvGenerator.set_queue_id
 
-          runner = new(KnapsackPro::Adapters::CucumberAdapter)
+          adapter_class = KnapsackPro::Adapters::CucumberAdapter
+          KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)
+          runner = new(adapter_class)
 
           accumulator = {
             status: :next,

data/lib/knapsack_pro/runners/queue/minitest_runner.rb

@@ -9,7 +9,9 @@ module KnapsackPro
           ENV['KNAPSACK_PRO_QUEUE_RECORDING_ENABLED'] = 'true'
           ENV['KNAPSACK_PRO_QUEUE_ID'] = KnapsackPro::Config::EnvGenerator.set_queue_id
 
-          runner = new(KnapsackPro::Adapters::MinitestAdapter)
+          adapter_class = KnapsackPro::Adapters::MinitestAdapter
+          KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)
+          runner = new(adapter_class)
 
           # Add test_dir to load path to make work:
           #   require 'test_helper'

data/lib/knapsack_pro/runners/queue/rspec_runner.rb

@@ -12,6 +12,7 @@ module KnapsackPro
           ENV['KNAPSACK_PRO_QUEUE_ID'] = KnapsackPro::Config::EnvGenerator.set_queue_id
 
           adapter_class = KnapsackPro::Adapters::RSpecAdapter
+          KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)
           runner = new(adapter_class)
 
           cli_args = (args || '').split

data/lib/knapsack_pro/runners/rspec_runner.rb

@@ -6,6 +6,7 @@ module KnapsackPro
         ENV['KNAPSACK_PRO_RECORDING_ENABLED'] = 'true'
 
         adapter_class = KnapsackPro::Adapters::RSpecAdapter
+        KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)
         runner = new(adapter_class)
 
         if runner.test_files_to_execute_exist?
@@ -14,6 +15,8 @@ module KnapsackPro
           cli_args = (args || '').split
           adapter_class.ensure_no_tag_option_when_rspec_split_by_test_examples_enabled!(cli_args)
 
+          KnapsackPro.tracker.set_prerun_tests(runner.test_file_paths)
+
           require 'rspec/core/rake_task'
 
           task_name = 'knapsack_pro:rspec_run'

data/lib/knapsack_pro/runners/spinach_runner.rb

@@ -5,11 +5,14 @@ module KnapsackPro
         ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN'] = KnapsackPro::Config::Env.test_suite_token_spinach
 
         adapter_class = KnapsackPro::Adapters::SpinachAdapter
+        KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)
         runner = new(adapter_class)
 
         if runner.test_files_to_execute_exist?
           adapter_class.verify_bind_method_called
 
+          KnapsackPro.tracker.set_prerun_tests(runner.test_file_paths)
+
           cmd = %Q[KNAPSACK_PRO_RECORDING_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=#{ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN']} bundle exec spinach #{args} --features_path #{runner.test_dir} -- #{runner.stringify_test_file_paths}]
 
           Kernel.system(cmd)

data/lib/knapsack_pro/runners/test_unit_runner.rb

@@ -6,11 +6,14 @@ module KnapsackPro
         ENV['KNAPSACK_PRO_RECORDING_ENABLED'] = 'true'
 
         adapter_class = KnapsackPro::Adapters::TestUnitAdapter
+        KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)
         runner = new(adapter_class)
 
         if runner.test_files_to_execute_exist?
           adapter_class.verify_bind_method_called
 
+          KnapsackPro.tracker.set_prerun_tests(runner.test_file_paths)
+
           cli_args =
             (args || '').split +
             runner.test_file_paths.map do |f|

data/lib/knapsack_pro/tracker.rb

@@ -6,16 +6,22 @@ module KnapsackPro
     # to better allocate it in Queue Mode for future CI build runs
     DEFAULT_TEST_FILE_TIME = 0.0 # seconds
 
-    attr_reader :global_time_since_beginning, :global_time, :test_files_with_time
+    attr_reader :global_time_since_beginning, :global_time, :test_files_with_time, :prerun_tests_loaded
     attr_writer :current_test_path
 
     def initialize
       @global_time_since_beginning = 0
+      FileUtils.mkdir_p(tracker_dir_path)
       set_defaults
     end
 
     def reset!
       set_defaults
+
+      # Remove report only when the reset! method is called explicitly.
+      # The report should be persisted on the disk so that multiple tracker instances can share the report state.
+      # Tracker instance can be created by knapsack_pro process and a separate tracker is created by rake task (e.g., RSpec) in Regular Mode.
+      File.delete(prerun_tests_report_path) if File.exists?(prerun_tests_report_path)
     end
 
     def start_timer
@@ -54,9 +60,18 @@ module KnapsackPro
           measured_time: false,
         }
       end
+
+      save_prerun_tests_report(@test_files_with_time)
+
+      @prerun_tests_loaded = true
     end
 
     def to_a
+      # When the test files are not loaded in the memory then load them from the disk.
+      # Useful for the Regular Mode when the memory is not shared between tracker instances.
+      # Tracker instance can be created by knapsack_pro process and a separate tracker is created by rake task (e.g., RSpec)
+      load_prerun_tests unless prerun_tests_loaded
+
       test_files = []
       @test_files_with_time.each do |path, hash|
         test_files << {
@@ -73,6 +88,44 @@ module KnapsackPro
       @global_time = 0
       @test_files_with_time = {}
       @current_test_path = nil
+      @prerun_tests_loaded = false
+    end
+
+    def tracker_dir_path
+      "#{KnapsackPro::Config::Env::TMP_DIR}/tracker"
+    end
+
+    def prerun_tests_report_path
+      raise 'Test runner adapter not set. Report a bug to the Knapsack Pro support.' unless KnapsackPro::Config::Env.test_runner_adapter
+      report_name = "prerun_tests_#{KnapsackPro::Config::Env.test_runner_adapter}_node_#{KnapsackPro::Config::Env.ci_node_index}.json"
+      File.join(tracker_dir_path, report_name)
+    end
+
+    def save_prerun_tests_report(hash)
+      report_json = JSON.pretty_generate(hash)
+
+      File.open(prerun_tests_report_path, 'w+') do |f|
+        f.write(report_json)
+      end
+    end
+
+    def read_prerun_tests_report
+      JSON.parse(File.read(prerun_tests_report_path))
+    end
+
+    def load_prerun_tests
+      read_prerun_tests_report.each do |test_file_path, hash|
+        # Load only test files that were not measured. For example,
+        # track test files assigned to CI node but never executed by test runner (e.g., pending RSpec spec files).
+        next if @test_files_with_time.key?(test_file_path)
+
+        @test_files_with_time[test_file_path] = {
+          time_execution: hash.fetch('time_execution'),
+          measured_time: hash.fetch('measured_time'),
+        }
+      end
+
+      @prerun_tests_loaded = true
     end
 
     def update_global_time(execution_time)

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '2.18.1'
+  VERSION = '2.18.2'
 end

data/spec/knapsack_pro/config/env_spec.rb

@@ -950,4 +950,29 @@ describe KnapsackPro::Config::Env do
       it { should be_nil }
     end
   end
+
+  describe '.test_runner_adapter' do
+    subject { described_class.test_runner_adapter }
+
+    context 'when ENV exists' do
+      let(:test_runner_adapter) { 'RSpecAdapter' }
+      before { stub_const('ENV', { 'KNAPSACK_PRO_TEST_RUNNER_ADAPTER' => test_runner_adapter }) }
+      it { should eql 'RSpecAdapter' }
+    end
+
+    context "when ENV doesn't exist" do
+      it { should be_nil }
+    end
+  end
+
+  describe '.set_test_runner_adapter' do
+    let(:adapter_class) { KnapsackPro::Adapters::RSpecAdapter }
+
+    subject { described_class.set_test_runner_adapter(adapter_class) }
+
+    it 'sets test runner adapter' do
+      subject
+      expect(described_class.test_runner_adapter).to eql 'RSpecAdapter'
+    end
+  end
 end

data/spec/knapsack_pro/runners/cucumber_runner_spec.rb

@@ -18,16 +18,20 @@ describe KnapsackPro::Runners::CucumberRunner do
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_cucumber)
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_RECORDING_ENABLED', 'true')
 
+      expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::CucumberAdapter)
+
       expect(described_class).to receive(:new)
       .with(KnapsackPro::Adapters::CucumberAdapter).and_return(runner)
     end
 
     context 'when test files were returned by Knapsack Pro API' do
       let(:test_dir) { 'fake-test-dir' }
-      let(:stringify_test_file_paths) { 'features/fake1.scenario features/fake2.scenario' }
+      let(:test_file_paths) { ['features/fake1.scenario', 'features/fake2.scenario'] }
+      let(:stringify_test_file_paths) { test_file_paths.join(' ') }
       let(:runner) do
         instance_double(described_class,
                         test_dir: test_dir,
+                        test_file_paths: test_file_paths,
                         stringify_test_file_paths: stringify_test_file_paths,
                         test_files_to_execute_exist?: true)
       end
@@ -36,6 +40,10 @@ describe KnapsackPro::Runners::CucumberRunner do
       before do
         expect(KnapsackPro::Adapters::CucumberAdapter).to receive(:verify_bind_method_called)
 
+        tracker = instance_double(KnapsackPro::Tracker)
+        expect(KnapsackPro).to receive(:tracker).and_return(tracker)
+        expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
+
         expect(Rake::Task).to receive(:[]).with('knapsack_pro:cucumber_run').at_least(1).and_return(task)
 
         t = double

data/spec/knapsack_pro/runners/queue/cucumber_runner_spec.rb

@@ -19,6 +19,8 @@ describe KnapsackPro::Runners::Queue::CucumberRunner do
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_RECORDING_ENABLED', 'true')
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_ID', queue_id)
 
+      expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::CucumberAdapter)
+
       expect(described_class).to receive(:new).with(KnapsackPro::Adapters::CucumberAdapter).and_return(runner)
     end
 

data/spec/knapsack_pro/runners/queue/minitest_runner_spec.rb

@@ -19,6 +19,8 @@ describe KnapsackPro::Runners::Queue::MinitestRunner do
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_RECORDING_ENABLED', 'true')
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_ID', queue_id)
 
+      expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::MinitestAdapter)
+
       expect(described_class).to receive(:new).with(KnapsackPro::Adapters::MinitestAdapter).and_return(runner)
 
       expect($LOAD_PATH).to receive(:unshift).with(test_dir)

data/spec/knapsack_pro/runners/queue/rspec_runner_spec.rb

@@ -26,6 +26,8 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_RECORDING_ENABLED', 'true')
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_ID', queue_id)
 
+      expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::RSpecAdapter)
+
       expect(described_class).to receive(:new).with(KnapsackPro::Adapters::RSpecAdapter).and_return(runner)
     end
 

data/spec/knapsack_pro/runners/rspec_runner_spec.rb

@@ -18,16 +18,20 @@ describe KnapsackPro::Runners::RSpecRunner do
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_rspec)
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_RECORDING_ENABLED', 'true')
 
+      expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::RSpecAdapter)
+
       expect(described_class).to receive(:new)
       .with(KnapsackPro::Adapters::RSpecAdapter).and_return(runner)
     end
 
     context 'when test files were returned by Knapsack Pro API' do
       let(:test_dir) { 'fake-test-dir' }
-      let(:stringify_test_file_paths) { "spec/a_spec.rb spec/b_spec.rb[1:1]" }
+      let(:test_file_paths) { ['spec/a_spec.rb', 'spec/b_spec.rb[1:1]'] }
+      let(:stringify_test_file_paths) { test_file_paths.join(' ') }
       let(:runner) do
         instance_double(described_class,
                         test_dir: test_dir,
+                        test_file_paths: test_file_paths,
                         stringify_test_file_paths: stringify_test_file_paths,
                         test_files_to_execute_exist?: true)
       end
@@ -37,6 +41,10 @@ describe KnapsackPro::Runners::RSpecRunner do
         expect(KnapsackPro::Adapters::RSpecAdapter).to receive(:verify_bind_method_called).ordered
         expect(KnapsackPro::Adapters::RSpecAdapter).to receive(:ensure_no_tag_option_when_rspec_split_by_test_examples_enabled!).with(['--profile', '--color']).ordered
 
+        tracker = instance_double(KnapsackPro::Tracker)
+        expect(KnapsackPro).to receive(:tracker).and_return(tracker)
+        expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
+
         expect(Rake::Task).to receive(:[]).with('knapsack_pro:rspec_run').at_least(1).and_return(task)
 
         t = double

data/spec/knapsack_pro/runners/spinach_runner_spec.rb

@@ -11,16 +11,20 @@ describe KnapsackPro::Runners::SpinachRunner do
     before do
       stub_const("ENV", { 'KNAPSACK_PRO_TEST_SUITE_TOKEN_SPINACH' => 'spinach-token' })
 
+      expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::SpinachAdapter)
+
       expect(described_class).to receive(:new)
       .with(KnapsackPro::Adapters::SpinachAdapter).and_return(runner)
     end
 
     context 'when test files were returned by Knapsack Pro API' do
-      let(:stringify_test_file_paths) { 'features/a.feature features/b.feature' }
+      let(:test_file_paths) { ['features/a.feature', 'features/b.feature'] }
+      let(:stringify_test_file_paths) { test_file_paths.join(' ') }
       let(:test_dir) { 'fake-test-dir' }
       let(:runner) do
         instance_double(described_class,
                         test_dir: test_dir,
+                        test_file_paths: test_file_paths,
                         stringify_test_file_paths: stringify_test_file_paths,
                         test_files_to_execute_exist?: true)
       end
@@ -29,6 +33,10 @@ describe KnapsackPro::Runners::SpinachRunner do
       before do
         expect(KnapsackPro::Adapters::SpinachAdapter).to receive(:verify_bind_method_called)
 
+        tracker = instance_double(KnapsackPro::Tracker)
+        expect(KnapsackPro).to receive(:tracker).and_return(tracker)
+        expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
+
         expect(Kernel).to receive(:system).with('KNAPSACK_PRO_RECORDING_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=spinach-token bundle exec spinach --custom-arg --features_path fake-test-dir -- features/a.feature features/b.feature')
 
         allow(described_class).to receive(:child_status).and_return(child_status)

data/spec/knapsack_pro/tracker_spec.rb

@@ -1,11 +1,18 @@
 shared_examples 'default trakcer attributes' do
   it { expect(tracker.global_time).to eql 0 }
   it { expect(tracker.test_files_with_time).to eql({}) }
+  it { expect(tracker.prerun_tests_loaded).to be false }
 end
 
 describe KnapsackPro::Tracker do
+  let(:adapter) { 'RSpecAdapter' }
   let(:tracker) { described_class.send(:new) }
 
+  before do
+    allow(KnapsackPro::Config::Env).to receive(:test_runner_adapter).and_return(adapter)
+    allow(KnapsackPro::Config::Env).to receive(:ci_node_index).and_return(0)
+  end
+
   it_behaves_like 'default trakcer attributes'
 
   describe '#current_test_path' do
@@ -34,6 +41,10 @@ describe KnapsackPro::Tracker do
     let(:test_paths) { ['a_spec.rb', 'b_spec.rb'] }
     let(:delta) { 0.02 }
 
+    before do
+      tracker.set_prerun_tests(test_paths)
+    end
+
     shared_examples '#to_a' do
       subject { tracker.to_a }
 
@@ -55,13 +66,14 @@ describe KnapsackPro::Tracker do
       end
 
       it { expect(tracker.global_time).to be_within(delta).of(0.3) }
+      it { expect(tracker.prerun_tests_loaded).to be true }
       it { expect(tracker.test_files_with_time.keys.size).to eql 2 }
       it { expect(tracker.test_files_with_time['a_spec.rb'][:time_execution]).to be_within(delta).of(0.1) }
       it { expect(tracker.test_files_with_time['b_spec.rb'][:time_execution]).to be_within(delta).of(0.2) }
       it_behaves_like '#to_a'
     end
 
-    context "with Timecop - Timecop shouldn't have impact on measured test time" do
+    context "with Timecop - Timecop shouldn't have impact on the measured test time" do
       let(:now) { Time.now }
 
       before do
@@ -80,6 +92,7 @@ describe KnapsackPro::Tracker do
 
       it { expect(tracker.global_time).to be > 0 }
       it { expect(tracker.global_time).to be_within(delta).of(0) }
+      it { expect(tracker.prerun_tests_loaded).to be true }
       it { expect(tracker.test_files_with_time.keys.size).to eql 2 }
       it { expect(tracker.test_files_with_time['a_spec.rb'][:time_execution]).to be_within(delta).of(0) }
       it { expect(tracker.test_files_with_time['b_spec.rb'][:time_execution]).to be_within(delta).of(0) }
@@ -96,6 +109,7 @@ describe KnapsackPro::Tracker do
       end
 
       it { expect(tracker.global_time).to be > 0 }
+      it { expect(tracker.prerun_tests_loaded).to be true }
       it { expect(tracker.test_files_with_time.keys.size).to eql 2 }
       it { expect(tracker.test_files_with_time['a_spec.rb'][:time_execution]).to eq 0 }
       it '2nd spec (b_spec.rb) should have recorded time execution - because start_time was set during first call of stop_timer for the first spec (a_spec.rb)' do
@@ -103,15 +117,62 @@ describe KnapsackPro::Tracker do
       end
       it_behaves_like '#to_a'
     end
+
+    context 'when a new tracker instance is created' do
+      let(:non_pending_test_paths) { ['a_spec.rb', 'b_spec.rb'] }
+      let(:test_paths) { non_pending_test_paths + ['pending_spec.rb'] }
+
+      before do
+        # measure tests only for non pending tests
+        non_pending_test_paths.each_with_index do |test_path, index|
+          tracker.current_test_path = test_path
+          tracker.start_timer
+          sleep index.to_f / 10 + 0.1
+          tracker.stop_timer
+        end
+      end
+
+      it '2nd tracker instance loads prerun tests from the disk' do
+        expect(tracker.prerun_tests_loaded).to be true
+        expect(tracker.to_a.size).to eq 3
+        expect(tracker.to_a[0][:path]).to eq 'a_spec.rb'
+        expect(tracker.to_a[0][:time_execution]).to be >= 0
+        expect(tracker.to_a[1][:path]).to eq 'b_spec.rb'
+        expect(tracker.to_a[1][:time_execution]).to be >= 0
+        expect(tracker.to_a[2][:path]).to eq 'pending_spec.rb'
+        expect(tracker.to_a[2][:time_execution]).to eq 0
+
+        tracker2 = described_class.send(:new)
+        expect(tracker2.prerun_tests_loaded).to be false
+        expect(tracker2.to_a.size).to eq 3
+        expect(tracker2.to_a[0][:path]).to eq 'a_spec.rb'
+        expect(tracker2.to_a[0][:time_execution]).to be >= 0
+        expect(tracker2.to_a[1][:path]).to eq 'b_spec.rb'
+        expect(tracker2.to_a[1][:time_execution]).to be >= 0
+        expect(tracker2.to_a[2][:path]).to eq 'pending_spec.rb'
+        expect(tracker2.to_a[2][:time_execution]).to eq 0
+        expect(tracker2.prerun_tests_loaded).to be true
+      end
+    end
   end
 
   describe '#reset!' do
+    let(:test_file_path) { 'a_spec.rb' }
+
     before do
-      tracker.current_test_path = 'a_spec.rb'
+      tracker.set_prerun_tests([test_file_path])
+    end
+
+    before do
+      expect(tracker.prerun_tests_loaded).to be true
+
+      tracker.current_test_path = test_file_path
       tracker.start_timer
       sleep 0.1
       tracker.stop_timer
+
       expect(tracker.global_time).not_to eql 0
+
       tracker.reset!
     end
 
@@ -120,5 +181,9 @@ describe KnapsackPro::Tracker do
     it "global time since beginning won't be reset" do
       expect(tracker.global_time_since_beginning).to be >= 0.1
     end
+
+    it 'resets prerun_tests_loaded to false' do
+      expect(tracker.prerun_tests_loaded).to be false
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 2.18.1
+  version: 2.18.2
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-22 00:00:00.000000000 Z
+date: 2021-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake