knapsack_pro 2.13.0 → 2.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1e1ee6f214c79d86f5ae94658f147e5f3060a77460e1e26109752e57fdd92bed
-  data.tar.gz: 3bde2c1578bd8e3d3e3ae39880eac80b598464cb57d8c6698440088ab7c552e0
+  metadata.gz: ebb896076bc1dc61363682126869b0add7f9ca6a9a8dfde47c8b7472d3ebb2cb
+  data.tar.gz: 86ee89293cbc0425c1d2c521c98983d4dd4d41954e614661979ca69e7d300c6b
 SHA512:
-  metadata.gz: 197ea0eeff47c4ed54d3baee9f94b9f00cf2c24b61ecb9ae1aaab4c9c8bca3bb247affb26db99e5fcfc3a172be83fefb765e0d4763f48eab4e243b84e262dddf
-  data.tar.gz: 681cfbb090e0152190fcf54266ef3b9eb70bca40c17494a7f0679846241a3612a8b9b2e2fa37e624deec7e474352cd0b39ac206add49fc48c31185f4cfe4cd30
+  metadata.gz: 8caa055376e60414a8596a941782fa99d24f92bc6c7bb6fa4aa26937d645d7b217b4fcc091a6d277edfbad29caccc08c09ce2c07db03fa375f0891dc69d4c5b0
+  data.tar.gz: d7f922e9a271d761f038eec7d1df91a86e51d54ad9e77dd304bba2507540ccae097269919861c8e1204e71f39f6c604fbd6d6555c097a3375a72bdfea5556451

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+### 2.14.0
+
+* Track time spend in RSpec context hook
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/143
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v2.13.0...v2.14.0
+
 ### 2.13.0
 
 * Update FAQ links in `knapsack_pro` warnings and remove FAQ from readme

data/lib/knapsack_pro/adapters/rspec_adapter.rb

@@ -21,6 +21,10 @@ module KnapsackPro
 
       def bind_time_tracker
         ::RSpec.configure do |config|
+          config.prepend_before(:context) do
+            KnapsackPro.tracker.start_timer
+          end
+
           config.around(:each) do |example|
             current_example_group =
               if ::RSpec.respond_to?(:current_example)
@@ -38,10 +42,10 @@ module KnapsackPro
                 current_test_path
               end
 
-            KnapsackPro.tracker.start_timer
-
             example.run
+          end
 
+          config.append_after(:context) do
             KnapsackPro.tracker.stop_timer
           end
 

data/lib/knapsack_pro/tracker.rb

@@ -24,14 +24,18 @@ module KnapsackPro
 
     def stop_timer
       execution_time = @start_time ? now_without_mock_time.to_f - @start_time : 0.0
-      update_global_time(execution_time)
-      update_test_file_time(execution_time)
+
+      if current_test_path
+        update_global_time(execution_time)
+        update_test_file_time(execution_time)
+        @current_test_path = nil
+      end
+
       execution_time
     end
 
     def current_test_path
-      raise("current_test_path needs to be set by Knapsack Pro Adapter's bind method") unless @current_test_path
-      KnapsackPro::TestFileCleaner.clean(@current_test_path)
+      KnapsackPro::TestFileCleaner.clean(@current_test_path) if @current_test_path
     end
 
     def set_prerun_tests(test_file_paths)
@@ -63,7 +67,7 @@ module KnapsackPro
     def set_defaults
       @global_time = 0
       @test_files_with_time = {}
-      @test_path = nil
+      @current_test_path = nil
     end
 
     def update_global_time(execution_time)

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '2.13.0'
+  VERSION = '2.14.0'
 end

data/spec/knapsack_pro/adapters/rspec_adapter_spec.rb

@@ -86,7 +86,9 @@ describe KnapsackPro::Adapters::RSpecAdapter do
         end
 
         it 'records time for current test path' do
+          expect(config).to receive(:prepend_before).with(:context).and_yield
           expect(config).to receive(:around).with(:each).and_yield(example)
+          expect(config).to receive(:append_after).with(:context).and_yield
           expect(config).to receive(:after).with(:suite).and_yield
           expect(::RSpec).to receive(:configure).and_yield(config)
 
@@ -94,12 +96,12 @@ describe KnapsackPro::Adapters::RSpecAdapter do
           expect(described_class).to receive(:test_path).with(example_group).and_return(test_path)
 
           allow(KnapsackPro).to receive(:tracker).and_return(tracker)
-          expect(tracker).to receive(:current_test_path=).with(test_path)
-          expect(tracker).to receive(:start_timer)
+          expect(tracker).to receive(:start_timer).ordered
+          expect(tracker).to receive(:current_test_path=).with(test_path).ordered
 
           expect(example).to receive(:run)
 
-          expect(tracker).to receive(:stop_timer)
+          expect(tracker).to receive(:stop_timer).ordered
 
           expect(KnapsackPro::Presenter).to receive(:global_time).and_return(global_time)
           expect(KnapsackPro).to receive(:logger).and_return(logger)
@@ -124,7 +126,9 @@ describe KnapsackPro::Adapters::RSpecAdapter do
           it 'records time for example.id' do
             expect(example).to receive(:id).and_return(test_example_path)
 
+            expect(config).to receive(:prepend_before).with(:context).and_yield
             expect(config).to receive(:around).with(:each).and_yield(example)
+            expect(config).to receive(:append_after).with(:context).and_yield
             expect(config).to receive(:after).with(:suite).and_yield
             expect(::RSpec).to receive(:configure).and_yield(config)
 
@@ -132,12 +136,12 @@ describe KnapsackPro::Adapters::RSpecAdapter do
             expect(described_class).to receive(:test_path).with(example_group).and_return(test_path)
 
             allow(KnapsackPro).to receive(:tracker).and_return(tracker)
-            expect(tracker).to receive(:current_test_path=).with(test_example_path)
-            expect(tracker).to receive(:start_timer)
+            expect(tracker).to receive(:start_timer).ordered
+            expect(tracker).to receive(:current_test_path=).with(test_example_path).ordered
 
             expect(example).to receive(:run)
 
-            expect(tracker).to receive(:stop_timer)
+            expect(tracker).to receive(:stop_timer).ordered
 
             expect(KnapsackPro::Presenter).to receive(:global_time).and_return(global_time)
             expect(KnapsackPro).to receive(:logger).and_return(logger)
@@ -153,7 +157,9 @@ describe KnapsackPro::Adapters::RSpecAdapter do
           end
 
           it 'records time for current test path' do
+            expect(config).to receive(:prepend_before).with(:context).and_yield
             expect(config).to receive(:around).with(:each).and_yield(example)
+            expect(config).to receive(:append_after).with(:context).and_yield
             expect(config).to receive(:after).with(:suite).and_yield
             expect(::RSpec).to receive(:configure).and_yield(config)
 
@@ -161,12 +167,12 @@ describe KnapsackPro::Adapters::RSpecAdapter do
             expect(described_class).to receive(:test_path).with(example_group).and_return(test_path)
 
             allow(KnapsackPro).to receive(:tracker).and_return(tracker)
-            expect(tracker).to receive(:current_test_path=).with(test_path)
-            expect(tracker).to receive(:start_timer)
+            expect(tracker).to receive(:start_timer).ordered
+            expect(tracker).to receive(:current_test_path=).with(test_path).ordered
 
             expect(example).to receive(:run)
 
-            expect(tracker).to receive(:stop_timer)
+            expect(tracker).to receive(:stop_timer).ordered
 
             expect(KnapsackPro::Presenter).to receive(:global_time).and_return(global_time)
             expect(KnapsackPro).to receive(:logger).and_return(logger)

data/spec/knapsack_pro/tracker_spec.rb

@@ -12,9 +12,7 @@ describe KnapsackPro::Tracker do
     subject { tracker.current_test_path }
 
     context 'when current_test_path not set' do
-      it do
-        expect { subject }.to raise_error("current_test_path needs to be set by Knapsack Pro Adapter's bind method")
-      end
+      it { expect(subject).to be_nil }
     end
 
     context 'when current_test_path set' do
@@ -58,6 +56,9 @@ describe KnapsackPro::Tracker do
       it { expect(tracker.test_files_with_time.keys.size).to eql 2 }
       it { expect(tracker.test_files_with_time['a_spec.rb'][:time_execution]).to be_within(delta).of(0.1) }
       it { expect(tracker.test_files_with_time['b_spec.rb'][:time_execution]).to be_within(delta).of(0.2) }
+      it 'resets current_test_path after time is measured' do
+        expect(tracker.current_test_path).to be_nil
+      end
       it_behaves_like '#to_a'
     end
 
@@ -83,6 +84,9 @@ describe KnapsackPro::Tracker do
       it { expect(tracker.test_files_with_time.keys.size).to eql 2 }
       it { expect(tracker.test_files_with_time['a_spec.rb'][:time_execution]).to be_within(delta).of(0) }
       it { expect(tracker.test_files_with_time['b_spec.rb'][:time_execution]).to be_within(delta).of(0) }
+      it 'resets current_test_path after time is measured' do
+        expect(tracker.current_test_path).to be_nil
+      end
       it_behaves_like '#to_a'
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 2.13.0
+  version: 2.14.0
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-13 00:00:00.000000000 Z
+date: 2021-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake