knapsack_pro 2.1.1 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 653a964b0c75547cec30531146adeb0075f251e6bc6511d4d85d710b778cf539
-  data.tar.gz: 21bb3baafa53c8dcc609d87e8fd8adb2b700df40f3275908968dee74f4186921
+  metadata.gz: b399cf5cff114341276acbcc1c9c372ff4bfb51ffc05a5ee5b59cf531dc64feb
+  data.tar.gz: aed0dea9791ab8589c63192e53b3f64c2a071f690553bc0d450be61d20b51b1e
 SHA512:
-  metadata.gz: a09a6f1318b285910c1db3eb8828a2d79034cfd7a1cf23926995b91b89d68f768bdab003f33ee4fc1480c1431fd22cffe6236bc69413494147bc9d12619ee73e
-  data.tar.gz: 1aa7010f7a371a8dca1f333a1254261341bfec1143e101dc2e6a717aa0dac43f31f4382050da248bb87a387268bd2ef39eeeb64ed76f348293dd5efafe9607e3
+  metadata.gz: d44d7d00c68d618d7ec41b764b28a8bcd7e5f2c62329d7246f2ee760f0d956ce7f1ffbbf6e8fae2adedf3cbd62d83a255f0b89a1dff9c8cc216d42cd11a89603
+  data.tar.gz: 403cbc599ff70473aa07ae92abb73016a942c3ed21a2bbcb376ade1e8d0fe62e1ea64677fd6527c5a2b8822bd65fa7c6139ffb6c0850f273b795303974724bab

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+### 2.2.0
+
+* Allow defining Queue Mode hooks multiple times (`KnapsackPro::Hooks::Queue.before_queue`, `KnapsackPro::Hooks::Queue.after_subset_queue`, `KnapsackPro::Hooks::Queue.after_queue`)
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/122
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v2.1.1...v2.2.0
+
 ### 2.1.1
 
 * Explicitly call root test runner class to avoid a confusing error when test runner gem is not loaded

data/README.md

@@ -2737,6 +2737,8 @@ end
 
 #### What hooks are supported in Queue Mode?
 
+Note: Each hook type can be defined multiple times. For instance, if you define `KnapsackPro::Hooks::Queue.before_queue` twice then both block of code will be called when running your tests.
+
 * RSpec in knapsack_pro Queue Mode supports hooks:
 
 ```ruby

data/lib/knapsack_pro/hooks/queue.rb

@@ -2,54 +2,63 @@ module KnapsackPro
   module Hooks
     class Queue
       class << self
-        attr_reader :before_queue,
-          :after_subset_queue,
-          :after_queue
+        attr_reader :before_queue_store,
+          :after_subset_queue_store,
+          :after_queue_store
 
         def reset_before_queue
-          @before_queue = nil
+          @before_queue_store = nil
         end
 
         def reset_after_subset_queue
-          @after_subset_queue = nil
+          @after_subset_queue_store = nil
         end
 
         def reset_after_queue
-          @after_queue = nil
+          @after_queue_store = nil
         end
 
         def before_queue(&block)
-          @before_queue ||= block
+          @before_queue_store ||= []
+          @before_queue_store << block
         end
 
         def after_subset_queue(&block)
-          @after_subset_queue ||= block
+          @after_subset_queue_store ||= []
+          @after_subset_queue_store << block
         end
 
         def after_queue(&block)
-          @after_queue ||= block
+          @after_queue_store ||= []
+          @after_queue_store << block
         end
 
         def call_before_queue
-          return unless before_queue
-          before_queue.call(
-            KnapsackPro::Config::Env.queue_id
-          )
+          return unless before_queue_store
+          before_queue_store.each do |block|
+            block.call(
+              KnapsackPro::Config::Env.queue_id
+            )
+          end
         end
 
         def call_after_subset_queue
-          return unless after_subset_queue
-          after_subset_queue.call(
-            KnapsackPro::Config::Env.queue_id,
-            KnapsackPro::Config::Env.subset_queue_id
-          )
+          return unless after_subset_queue_store
+          after_subset_queue_store.each do |block|
+            block.call(
+              KnapsackPro::Config::Env.queue_id,
+              KnapsackPro::Config::Env.subset_queue_id
+            )
+          end
         end
 
         def call_after_queue
-          return unless after_queue
-          after_queue.call(
-            KnapsackPro::Config::Env.queue_id
-          )
+          return unless after_queue_store
+          after_queue_store.each do |block|
+            block.call(
+              KnapsackPro::Config::Env.queue_id
+            )
+          end
         end
       end
     end

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '2.1.1'
+  VERSION = '2.2.0'
 end

data/spec/knapsack_pro/hooks/queue_spec.rb

@@ -10,18 +10,30 @@ describe KnapsackPro::Hooks::Queue do
       it { should be_nil }
     end
 
-    context 'when callback is set' do
+    context 'when callback is set multiple times' do
       let(:queue_id) { double }
 
       before do
-        expect(KnapsackPro::Config::Env).to receive(:queue_id).and_return(queue_id)
+        expect(KnapsackPro::Config::Env).to receive(:queue_id).twice.and_return(queue_id)
 
+        $expected_called_blocks = []
+
+        described_class.before_queue do |q_id|
+          $expected_called_blocks << [:block_1_called, q_id]
+        end
         described_class.before_queue do |q_id|
-          [:fake_value, q_id]
+          $expected_called_blocks << [:block_2_called, q_id]
         end
       end
 
-      it { should eq [:fake_value, queue_id] }
+      it 'each block is called' do
+        subject
+
+        expect($expected_called_blocks).to eq([
+          [:block_1_called, queue_id],
+          [:block_2_called, queue_id],
+        ])
+      end
     end
   end
 
@@ -36,20 +48,32 @@ describe KnapsackPro::Hooks::Queue do
       it { should be_nil }
     end
 
-    context 'when callback is set' do
+    context 'when callback is set multiple times' do
       let(:queue_id) { double }
       let(:subset_queue_id) { double }
 
       before do
-        expect(KnapsackPro::Config::Env).to receive(:queue_id).and_return(queue_id)
-        expect(KnapsackPro::Config::Env).to receive(:subset_queue_id).and_return(subset_queue_id)
+        expect(KnapsackPro::Config::Env).to receive(:queue_id).twice.and_return(queue_id)
+        expect(KnapsackPro::Config::Env).to receive(:subset_queue_id).twice.and_return(subset_queue_id)
+
+        $expected_called_blocks = []
 
         described_class.after_subset_queue do |q_id, subset_q_id|
-          [:fake_value, q_id, subset_q_id]
+          $expected_called_blocks << [:block_1_called, q_id, subset_q_id]
+        end
+        described_class.after_subset_queue do |q_id, subset_q_id|
+          $expected_called_blocks << [:block_2_called, q_id, subset_q_id]
         end
       end
 
-      it { should eq [:fake_value, queue_id, subset_queue_id] }
+      it 'each block is called' do
+        subject
+
+        expect($expected_called_blocks).to eq([
+          [:block_1_called, queue_id, subset_queue_id],
+          [:block_2_called, queue_id, subset_queue_id],
+        ])
+      end
     end
   end
 
@@ -64,18 +88,30 @@ describe KnapsackPro::Hooks::Queue do
       it { should be_nil }
     end
 
-    context 'when callback is set' do
+    context 'when callback is set multiple times' do
       let(:queue_id) { double }
 
       before do
-        expect(KnapsackPro::Config::Env).to receive(:queue_id).and_return(queue_id)
+        expect(KnapsackPro::Config::Env).to receive(:queue_id).twice.and_return(queue_id)
+
+        $expected_called_blocks = []
 
         described_class.after_queue do |q_id|
-          [:fake_value, q_id]
+          $expected_called_blocks << [:block_1_called, q_id]
+        end
+        described_class.after_queue do |q_id|
+          $expected_called_blocks << [:block_2_called, q_id]
         end
       end
 
-      it { should eq [:fake_value, queue_id] }
+      it 'each block is called' do
+        subject
+
+        expect($expected_called_blocks).to eq([
+          [:block_1_called, queue_id],
+          [:block_2_called, queue_id],
+        ])
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 2.2.0
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-18 00:00:00.000000000 Z
+date: 2020-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake