knapsack_pro 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8608ce6cc56baf7be7b0be2a09c8ecbb0e4f5aa2e0e80ce796284aba9d2fc9bf
-  data.tar.gz: b249d1169e73ecf370d055169189e158b0d0b2cee526540a07eb13b92bb12f6e
+  metadata.gz: 6c90349dc3633e515ef14c71464df3023abf3d43176547bfb2f1d3d9862195c0
+  data.tar.gz: bfda6b2b50c900b141fcd3e5c074a1195346fcc8ff8cd9caf8d1e0ca2b97157e
 SHA512:
-  metadata.gz: 5868feda23ff81b692ba3053876c3036379e373f77e9004460b29691f18beb35ccbccd32175434f2b98ca8bb973a321f28cd4ac096f346e034a664534b82ccb1
-  data.tar.gz: 76efa329752999c325af61c9479f5b496719b84aac9e0b0de2b8ab4838ebd2303a3ba05951e54adcf1f5eb32d552fb482ac2b9e6a836d0a8780ff1687f9d3384
+  metadata.gz: fd531919cc65cc8130d39573b328bedfb55f2528618b2492d695b463340d250619598e204719090d130ffb5f6963fa7b64104b00a67d387e16983ec03df1f699
+  data.tar.gz: 535766bb3747204085c54147dd19d1bb3b8f0fe76a77b941df0a2e17cf2e5d886fc034cbf6342120f240366a896fa7c5d2a9cae2a076ccd544316582d307b098

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 * TODO
 
+### 1.1.0
+
+* Add test file exclude pattern.
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/72
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v1.0.2...v1.1.0
+
 ### 1.0.2
 
 * Track time execution of all tests assigned to CI node in Queue Mode even when they did not run due syntax error or being pending/empty in test run.

data/README.md

@@ -155,6 +155,7 @@ The knapsack_pro has also [queue mode](#queue-mode) to get an optimal test suite
     - [Why I don't see all test files being recorded in user dashboard](#why-i-dont-see-all-test-files-being-recorded-in-user-dashboard)
     - [Why when I use 2 different CI providers then not all test files are executed?](#why-when-i-use-2-different-ci-providers-then-not-all-test-files-are-executed)
     - [How to run only RSpec feature tests or non feature tests?](#how-to-run-only-rspec-feature-tests-or-non-feature-tests)
+    - [How to exclude tests from running them?](#how-to-exclude-tests-from-running-them)
     - [How to use CodeClimate with knapsack_pro?](#how-to-use-codeclimate-with-knapsack_pro)
     - [How to run knapsack_pro only on a few parallel CI nodes instead of all?](#how-to-run-knapsack_pro-only-on-a-few-parallel-ci-nodes-instead-of-all)
     - [How to use simplecov in Queue Mode?](#how-to-use-simplecov-in-queue-mode)
@@ -1864,6 +1865,27 @@ KNAPSACK_PRO_TEST_FILE_PATTERN="spec/features/**{,/*/**}/*_spec.rb" \
 bundle exec rake knapsack_pro:queue:rspec
 ```
 
+You can also learn [how to use exclude pattern](#how-to-exclude-tests-from-running-them).
+
+#### How to exclude tests from running them?
+
+For instance you would like to run all tests except tests in `features` directory then you could do:
+
+```
+KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN="spec/features/**{,/*/**}/*_spec.rb" \
+bundle exec rake knapsack_pro:queue:rspec
+```
+
+You can define at the same time the pattern for tests you would like to run and the exclude pattern. For instance run all controller tests except admin controller tests.
+
+```
+KNAPSACK_PRO_TEST_FILE_PATTERN="spec/controllers/**{,/*/**}/*_spec.rb" \
+KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN="spec/controllers/admin/**{,/*/**}/*_spec.rb" \
+bundle exec rake knapsack_pro:queue:rspec
+```
+
+The test file pattern and exclude pattern support any glob pattern handled by [`Dir.glob`](http://ruby-doc.org/core-2.4.1/Dir.html#method-c-glob).
+
 #### How to use CodeClimate with knapsack_pro?
 
 You can check CodeClimate docs about [parallel and multiple test suites](https://docs.codeclimate.com/docs/configuring-test-coverage#section-parallel-and-multiple-test-suites).

data/lib/knapsack_pro/config/env.rb

@@ -47,6 +47,10 @@ module KnapsackPro
           ENV['KNAPSACK_PRO_TEST_FILE_PATTERN']
         end
 
+        def test_file_exclude_pattern
+          ENV['KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN']
+        end
+
         def test_dir
           ENV['KNAPSACK_PRO_TEST_DIR']
         end

data/lib/knapsack_pro/test_file_finder.rb

@@ -21,7 +21,16 @@ module KnapsackPro
     attr_reader :test_file_pattern
 
     def test_files
-      Dir.glob(test_file_pattern).uniq.sort
+      test_file_paths = Dir.glob(test_file_pattern).uniq
+
+      excluded_test_file_paths =
+        if KnapsackPro::Config::Env.test_file_exclude_pattern
+          Dir.glob(KnapsackPro::Config::Env.test_file_exclude_pattern).uniq
+        else
+          []
+        end
+
+      (test_file_paths - excluded_test_file_paths).sort
     end
 
     def test_file_hash_for(test_file_path)

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '1.0.2'
+  VERSION = '1.1.0'
 end

data/spec/knapsack_pro/config/env_spec.rb

@@ -153,6 +153,20 @@ describe KnapsackPro::Config::Env do
     end
   end
 
+  describe '.test_file_exclude_pattern' do
+    subject { described_class.test_file_exclude_pattern }
+
+    context 'when ENV exists' do
+      let(:test_file_exclude_pattern) { 'spec/features/*_spec.rb' }
+      before { stub_const("ENV", { 'KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN' => test_file_exclude_pattern }) }
+      it { should eq test_file_exclude_pattern }
+    end
+
+    context "when ENV doesn't exist" do
+      it { should be_nil }
+    end
+  end
+
   describe '.test_dir' do
     subject { described_class.test_dir }
 

data/spec/knapsack_pro/test_file_finder_spec.rb

@@ -18,18 +18,39 @@ describe KnapsackPro::TestFileFinder do
 
     subject { described_class.new(test_file_pattern).call }
 
-    it do
-      should eq([
-        {
-          'path' => 'spec_fake/controllers/users_controller_spec.rb',
-        },
-        {
-          'path' => 'spec_fake/models/admin_spec.rb',
-        },
-        {
-          'path' => 'spec_fake/models/user_spec.rb',
-        },
-      ])
+    context 'when KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN is not defined' do
+      it do
+        should eq([
+          {
+            'path' => 'spec_fake/controllers/users_controller_spec.rb',
+          },
+          {
+            'path' => 'spec_fake/models/admin_spec.rb',
+          },
+          {
+            'path' => 'spec_fake/models/user_spec.rb',
+          },
+        ])
+      end
+    end
+
+    context 'when KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN is defined' do
+      let(:test_file_exclude_pattern) { 'spec_fake/controllers/*_spec.rb' }
+
+      before do
+        stub_const("ENV", { 'KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN' => test_file_exclude_pattern })
+      end
+
+      it do
+        should eq([
+          {
+            'path' => 'spec_fake/models/admin_spec.rb',
+          },
+          {
+            'path' => 'spec_fake/models/user_spec.rb',
+          },
+        ])
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-26 00:00:00.000000000 Z
+date: 2018-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake