knapsack_pro 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a9d12ed730f59a34f2fe1842ac39d712275f72fe292cc870f77596d899ee100
-  data.tar.gz: f246cb0437c435f76c3540a4b789098c7249dff4acc9263a361a90712e3e1ddb
+  metadata.gz: cd3738b3ce978cfd66c03f8a3a125bbf243c51ded0ca237d911b39e5e1bd49a1
+  data.tar.gz: b840297f936a9a9d81af47a67795a7287fd69e996449f88291b5c8a7cd6dc5d8
 SHA512:
-  metadata.gz: c7476ae1b247a4ebe47bc0af7cf982b290021d5a566668873db9784b25e38bc32ae14bd511082b53e2a3c4f26153fc7b4f642a2c0ae0469cf1d2eeb1b6975794
-  data.tar.gz: ecf515f604be60a9e44906eeddb4292222c6af02a427fd1e73bfc69ac9234e5af02dc9b67ae933b2d462582bac9ae599e32c4e3c713c0ac553ebef44aa30f2fe
+  metadata.gz: c6b64eef137993948a9ab9e6fd001c2bf55d1a05adeb25d1de46c6548db0cc47505019ee9b0b8da4bf0620944be61639eb4372aef620f9ee976dc64219668b28
+  data.tar.gz: d51a9c073f15feb17455a0151d6e655307be2dbdb16796795b2ef751a66f046040256d6549dd2e27b1a27dcd7789c6160d55a624080d2d71ab97fc085c73ac85

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 * TODO
 
+### 1.0.1
+
+* Fix bug with not being able to set log level via logger wrapper.
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/70
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v1.0.0...v1.0.1
+
 ### 1.0.0
 
 * Release 1.0.0 is backward compatible with all previous releases.

data/README.md

@@ -319,7 +319,12 @@ KnapsackPro.logger = Logger.new(STDOUT)
 KnapsackPro.logger.level = Logger::DEBUG
 ```
 
-Debug is default log level and this is recommended. [Read more](#how-can-i-change-log-level).
+Debug is default log level and it is recommended. [Read more](#how-can-i-change-log-level).
+
+Note your own logger is configured in `spec_helper.rb` or `rails_helper.rb` and it will start working when those files will be loaded.
+It means the very first request to Knapsack Pro API will be log to `STDOUT` using logger built into knapsack_pro instead of your custom logger.
+
+If you want to change log level globally than just for your custom log level, please [see this](#how-can-i-change-log-level).
 
 ### Setup your CI server (How to set up 2 of 3)
 
@@ -404,13 +409,15 @@ things like external requests done in individual tests).
 On the Knapsack Pro API side, there is test file queue generated for your CI build. Each CI node periodically requests the Knapsack Pro API for test files
 that should be executed next. Thanks to that each CI node will finish tests at the same time.
 
+See how it works and what problems can be solved with Queue Mode https://youtu.be/hUEB1XDKEFY
+
 ### How to use queue mode?
 
 Please use a separate API token for queue mode from one used already for regular mode.
 
 Use this command to run queue mode:
 
-    # RSpec
+    # RSpec >= 3.x
     bundle exec rake knapsack_pro:queue:rspec
 
     # Minitest

data/lib/knapsack_pro.rb

@@ -10,7 +10,6 @@ require_relative 'knapsack_pro/version'
 require_relative 'knapsack_pro/extensions/time'
 require_relative 'knapsack_pro/hooks/queue'
 require_relative 'knapsack_pro/utils'
-require_relative 'knapsack_pro/logger_wrapper'
 require_relative 'knapsack_pro/config/ci/base'
 require_relative 'knapsack_pro/config/ci/app_veyor'
 require_relative 'knapsack_pro/config/ci/circle'
@@ -25,6 +24,7 @@ require_relative 'knapsack_pro/config/ci/codeship'
 require_relative 'knapsack_pro/config/ci/heroku'
 require_relative 'knapsack_pro/config/env'
 require_relative 'knapsack_pro/config/env_generator'
+require_relative 'knapsack_pro/logger_wrapper'
 require_relative 'knapsack_pro/client/api/action'
 require_relative 'knapsack_pro/client/api/v1/base'
 require_relative 'knapsack_pro/client/api/v1/build_distributions'

data/lib/knapsack_pro/config/env.rb

@@ -1,6 +1,14 @@
 module KnapsackPro
   module Config
     class Env
+      LOG_LEVELS = {
+        'fatal'  => ::Logger::FATAL,
+        'error'  => ::Logger::ERROR,
+        'warn'  => ::Logger::WARN,
+        'info'  => ::Logger::INFO,
+        'debug' => ::Logger::DEBUG,
+      }
+
       class << self
         def ci_node_total
           (ENV['KNAPSACK_PRO_CI_NODE_TOTAL'] ||
@@ -172,13 +180,7 @@ module KnapsackPro
         end
 
         def log_level
-          {
-            'fatal'  => ::Logger::FATAL,
-            'error'  => ::Logger::ERROR,
-            'warn'  => ::Logger::WARN,
-            'info'  => ::Logger::INFO,
-            'debug' => ::Logger::DEBUG,
-          }[ENV['KNAPSACK_PRO_LOG_LEVEL'].to_s.downcase] || ::Logger::DEBUG
+          LOG_LEVELS[ENV['KNAPSACK_PRO_LOG_LEVEL'].to_s.downcase] || ::Logger::DEBUG
         end
 
         private

data/lib/knapsack_pro/logger_wrapper.rb

@@ -8,9 +8,13 @@ module KnapsackPro
 
     attr_reader :logger
 
-    def method_missing(m, *args, &block)
-      args[0] = "[knapsack_pro] #{args[0]}"
-      logger.send(m, *args, &block)
+    LOG_LEVEL_METHODS = KnapsackPro::Config::Env::LOG_LEVELS.keys.map(&:to_sym)
+
+    def method_missing(method, *args, &block)
+      if LOG_LEVEL_METHODS.include?(method)
+        args[0] = "[knapsack_pro] #{args[0]}"
+      end
+      logger.send(method, *args, &block)
     end
   end
 end

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/spec/knapsack_pro/logger_wrapper_spec.rb

@@ -12,4 +12,10 @@ describe KnapsackPro::LoggerWrapper do
       it { should include "[knapsack_pro] Test message\n" }
     end
   end
+
+  it 'can set logger level via logger wrapper' do
+    logger_wrapper.level = ::Logger::INFO
+
+    expect(logger_wrapper.level).to eq 1
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-28 00:00:00.000000000 Z
+date: 2018-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake