knapsack_pro 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2c09245212dbcd947f2d0ef42545a102cb066726
-  data.tar.gz: 41b113222a7516b0a896d234e7139a342216ac83
+  metadata.gz: c1b41d8fa8f1fbc4132753ff2bed7bd753fa5e70
+  data.tar.gz: 2274a0c7340c7095e1a118a232025df0f54d6995
 SHA512:
-  metadata.gz: 3a94e5bf2d47d45948c575a5c65ce7c998a68664682e35a396444770246719f1979f755806aa6e8f41797fe5c9a351dce3a61051f01df30d3cde4dee48faf603
-  data.tar.gz: b0796d9c973b86cdfea8a7976fab67e0013b8132d3ab57932b2b5f84327ce3f323c56ccb28883b1e9038f4cd4c78b793da72265461cd8f11c20379474b00441d
+  metadata.gz: 767bf32a466b2049bdc802d4080da52c80387c375f6ad7c4162eb3042b40e6210f0cfd05543a984fc549c9d2f353c72191e4ef8554651da9a9d5676dd9db72d4
+  data.tar.gz: e16b193127919aa1132fc55746e7ae444b446d6dda38170d59bc8246a9a8f6d5f1d0965e0fca66093ef83aa72475638a195bd588f687d519a877dca0976fb350

data/CHANGELOG.md

@@ -2,10 +2,21 @@
 
 * TODO
 
+### 0.7.1
+
+* Don't fail when there are no tests to run on a node
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/issues/7
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/9
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v0.7.0...v0.7.1
+
 ### 0.7.0
 
 * Add support for older cucumber versions than 1.3
 
+    https://github.com/KnapsackPro/knapsack_pro-ruby/issues/5
+
 https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v0.6.1...v0.7.0
 
 ### 0.6.1

data/README.md

@@ -97,7 +97,7 @@ And then execute:
     $ bundle
 
 
-Add this line at the bottom of `Rakefile` if your project has it:
+Add this lines at the bottom of `Rakefile` if your project has it:
 
 ```ruby
 KnapsackPro.load_tasks if defined?(KnapsackPro)
@@ -106,9 +106,13 @@ KnapsackPro.load_tasks if defined?(KnapsackPro)
 If you are using [VCR gem](https://github.com/vcr/vcr) then add Knapsack Pro API subdomain to [ignore hosts](https://www.relishapp.com/vcr/vcr/v/2-9-3/docs/configuration/ignore-request):
 
 ```ruby
+# spec/spec_helper.rb or wherever is your VCR configuration
+
 VCR.configure do |config|
   config.ignore_hosts 'localhost', '127.0.0.1', '0.0.0.0', 'api.knapsackpro.com'
 end
+
+WebMock.disable_net_connect!(:allow => 'api.knapsackpro.com') if defined?(WebMock)
 ```
 
 ## How to set up

data/lib/knapsack_pro/report.rb

@@ -1,13 +1,20 @@
 module KnapsackPro
   class Report
     def self.save
+      test_files = KnapsackPro.tracker.to_a
+
+      if test_files.empty?
+        KnapsackPro.logger.info("Didn't save time execution report on API server because there are no test files matching criteria on this node. Probably reason might be very narrowed tests list - you run only tests with specified tag and there are fewer test files with the tag than node total number.")
+        return
+      end
+
       repository_adapter = KnapsackPro::RepositoryAdapterInitiator.call
       action = KnapsackPro::Client::API::V1::BuildSubsets.create(
         commit_hash: repository_adapter.commit_hash,
         branch: repository_adapter.branch,
         node_total: KnapsackPro::Config::Env.ci_node_total,
         node_index: KnapsackPro::Config::Env.ci_node_index,
-        test_files: KnapsackPro.tracker.to_a,
+        test_files: test_files,
       )
       connection = KnapsackPro::Client::Connection.new(action)
       response = connection.call

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '0.7.0'
+  VERSION = '0.7.1'
 end

data/spec/knapsack_pro/report_spec.rb

@@ -3,66 +3,82 @@ describe KnapsackPro::Report do
     subject { described_class.save }
 
     before do
-      commit_hash = double
-      branch = double
-      repository_adapter = instance_double(KnapsackPro::RepositoryAdapters::EnvAdapter, commit_hash: commit_hash, branch: branch)
-      expect(KnapsackPro::RepositoryAdapterInitiator).to receive(:call).and_return(repository_adapter)
-
-      node_total = double
-      node_index = double
-      expect(KnapsackPro::Config::Env).to receive(:ci_node_total).and_return(node_total)
-      expect(KnapsackPro::Config::Env).to receive(:ci_node_index).and_return(node_index)
-
-      test_files = double
       tracker = instance_double(KnapsackPro::Tracker, to_a: test_files)
       expect(KnapsackPro).to receive(:tracker).and_return(tracker)
+    end
 
-      action = double
-      expect(KnapsackPro::Client::API::V1::BuildSubsets).to receive(:create).with({
-        commit_hash: commit_hash,
-        branch: branch,
-        node_total: node_total,
-        node_index: node_index,
-        test_files: test_files,
-      }).and_return(action)
-
-      connection = instance_double(KnapsackPro::Client::Connection, success?: success?, errors?: errors?)
-      expect(KnapsackPro::Client::Connection).to receive(:new).with(action).and_return(connection).and_return(connection)
+    context "when test files doesn't exist" do
+      let(:test_files) { [] }
 
-      response = double
-      expect(connection).to receive(:call).and_return(response)
+      it do
+        logger = instance_double(Logger)
+        expect(KnapsackPro).to receive(:logger).and_return(logger)
+        expect(logger).to receive(:info).with("Didn't save time execution report on API server because there are no test files matching criteria on this node. Probably reason might be very narrowed tests list - you run only tests with specified tag and there are fewer test files with the tag than node total number.")
+        subject
+      end
     end
 
-    context 'when success' do
-      let(:success?) { true }
+    context 'when test files exists' do
+      let(:test_files) { [double] }
 
-      context 'when response has errors' do
-        let(:errors?) { true }
+      before do
+        commit_hash = double
+        branch = double
+        repository_adapter = instance_double(KnapsackPro::RepositoryAdapters::EnvAdapter, commit_hash: commit_hash, branch: branch)
+        expect(KnapsackPro::RepositoryAdapterInitiator).to receive(:call).and_return(repository_adapter)
 
-        it do
-          expect {
-            subject
-          }.to raise_error(ArgumentError)
-        end
+        node_total = double
+        node_index = double
+        expect(KnapsackPro::Config::Env).to receive(:ci_node_total).and_return(node_total)
+        expect(KnapsackPro::Config::Env).to receive(:ci_node_index).and_return(node_index)
+
+        action = double
+        expect(KnapsackPro::Client::API::V1::BuildSubsets).to receive(:create).with({
+          commit_hash: commit_hash,
+          branch: branch,
+          node_total: node_total,
+          node_index: node_index,
+          test_files: test_files,
+        }).and_return(action)
+
+        connection = instance_double(KnapsackPro::Client::Connection, success?: success?, errors?: errors?)
+        expect(KnapsackPro::Client::Connection).to receive(:new).with(action).and_return(connection).and_return(connection)
+
+        response = double
+        expect(connection).to receive(:call).and_return(response)
       end
 
-      context 'when response has no errors' do
-        let(:errors?) { false }
+      context 'when success' do
+        let(:success?) { true }
+
+        context 'when response has errors' do
+          let(:errors?) { true }
+
+          it do
+            expect {
+              subject
+            }.to raise_error(ArgumentError)
+          end
+        end
+
+        context 'when response has no errors' do
+          let(:errors?) { false }
 
-        it do
-          logger = instance_double(Logger)
-          expect(KnapsackPro).to receive(:logger).and_return(logger)
-          expect(logger).to receive(:info).with('Saved time execution report on API server.')
-          subject
+          it do
+            logger = instance_double(Logger)
+            expect(KnapsackPro).to receive(:logger).and_return(logger)
+            expect(logger).to receive(:info).with('Saved time execution report on API server.')
+            subject
+          end
         end
       end
-    end
 
-    context 'when failure' do
-      let(:success?) { false }
-      let(:errors?) { nil }
+      context 'when failure' do
+        let(:success?) { false }
+        let(:errors?) { nil }
 
-      it { subject }
+        it { subject }
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-23 00:00:00.000000000 Z
+date: 2016-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake