knapsack_pro 0.57.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 653d33cf8cec36e3f29ba1e3f5c1fd2ccd791e2c5f28dc9f902c61f634f6b881
-  data.tar.gz: 838eef54f03ff2bc88d0c4553ff0c535fd232f9aa7986e4ecac8734cbc297e25
+  metadata.gz: 6a9d12ed730f59a34f2fe1842ac39d712275f72fe292cc870f77596d899ee100
+  data.tar.gz: f246cb0437c435f76c3540a4b789098c7249dff4acc9263a361a90712e3e1ddb
 SHA512:
-  metadata.gz: c969994628a4db7b5f55f97260902a8d5e7ee76396db08103592daeec3a391ff92ac1b3b0a00f32ab0af6e46f50d07b7a688feb3675a21f500bb207d919e1c83
-  data.tar.gz: 5c188e1d96c4caf3274cfff5c8f791e6a243d67d3abd7ad30f9ebb4c7b3e851be8f227ec86dcc4be0dbabc563e2c108d4e43832b1a3826a9935e0ef9e6519fc1
+  metadata.gz: c7476ae1b247a4ebe47bc0af7cf982b290021d5a566668873db9784b25e38bc32ae14bd511082b53e2a3c4f26153fc7b4f642a2c0ae0469cf1d2eeb1b6975794
+  data.tar.gz: ecf515f604be60a9e44906eeddb4292222c6af02a427fd1e73bfc69ac9234e5af02dc9b67ae933b2d462582bac9ae599e32c4e3c713c0ac553ebef44aa30f2fe

data/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 * TODO
 
+### 1.0.0
+
+* Release 1.0.0 is backward compatible with all previous releases.
+* Run tests in Fallback Mode when API response is 5xx
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/69
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v0.57.0...v1.0.0
+
 ### 0.57.0
 
 * Add support for Solano CI and AppVeyor

data/README.md

@@ -166,6 +166,7 @@ The knapsack_pro has also [queue mode](#queue-mode) to get an optimal test suite
 - [Gem tests](#gem-tests)
   - [Spec](#spec)
 - [Contributing](#contributing)
+  - [Publishing](#publishing)
 - [Mentions](#mentions)
 
 <!-- END doctoc generated TOC please keep comment here to allow auto update -->
@@ -773,7 +774,7 @@ end
 
 #### Info for Travis users
 
-You can parallelize your builds across virtual machines with [travis matrix feature](http://docs.travis-ci.com/user/speeding-up-the-build/#Parallelizing-your-builds-across-virtual-machines). Edit `.travis.yml`
+You can parallelize your builds across virtual machines with [travis matrix feature](http://docs.travis-ci.com/user/speeding-up-the-build/#parallelizing-your-builds-across-virtual-machines). Edit `.travis.yml`
 
 ```yaml
 script:
@@ -812,7 +813,7 @@ Such configuration will generate matrix with 2 following ENV rows:
     KNAPSACK_PRO_CI_NODE_TOTAL=2 KNAPSACK_PRO_CI_NODE_INDEX=0 KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC=rspec-token KNAPSACK_PRO_TEST_SUITE_TOKEN_CUCUMBER=cucumber-token KNAPSACK_PRO_TEST_SUITE_TOKEN_MINITEST=minitest-token KNAPSACK_PRO_TEST_SUITE_TOKEN_TEST_UNIT=test-unit-token KNAPSACK_PRO_TEST_SUITE_TOKEN_SPINACH=spinach-token
     KNAPSACK_PRO_CI_NODE_TOTAL=2 KNAPSACK_PRO_CI_NODE_INDEX=1 KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC=rspec-token KNAPSACK_PRO_TEST_SUITE_TOKEN_CUCUMBER=cucumber-token KNAPSACK_PRO_TEST_SUITE_TOKEN_MINITEST=minitest-token KNAPSACK_PRO_TEST_SUITE_TOKEN_TEST_UNIT=test-unit-token KNAPSACK_PRO_TEST_SUITE_TOKEN_SPINACH=spinach-token
 
-More info about global and matrix ENV configuration in [travis docs](https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix).
+More info about global and matrix ENV configuration in [travis docs](https://docs.travis-ci.com/user/customizing-the-build/#build-matrix).
 
 #### Info for semaphoreapp.com users
 
@@ -1945,6 +1946,29 @@ To run specs for Knapsack Pro gem type:
 5. You can create example tests in related repository with example of [rails application and knapsack_pro gem usage](https://github.com/KnapsackPro/rails-app-with-knapsack_pro).
 6. Create a new Pull Request
 
+### Publishing
+
+Update version in `lib/knapsack_pro/version.rb` and `CHANGELOG.md`:
+
+```
+$ git commit -m "Bump version X.X.X"
+$ git push origin master
+```
+
+Create git tag for release:
+
+```
+$ git tag -a vX.X.X -m "Release vX.X.X"
+$ git push --tags
+```
+
+Build gem and publish it to RubyGems.org:
+
+```
+$ gem build knapsack_pro.gemspec
+$ gem push knapsack_pro-X.X.X.gem
+```
+
 ## Mentions
 
 List of articles where people mentioned Knapsack Pro:

data/lib/knapsack_pro/client/connection.rb

@@ -13,16 +13,19 @@ module KnapsackPro
       end
 
       def success?
-        !!response
+        return false if !response_body
+
+        status = http_response.code.to_i
+        status >= 200 && status < 500
       end
 
       def errors?
-        !!(response && (response['errors'] || response['error']))
+        !!(response_body && (response_body['errors'] || response_body['error']))
       end
 
       private
 
-      attr_reader :action, :response
+      attr_reader :action, :http_response, :response_body
 
       def logger
         KnapsackPro.logger
@@ -61,7 +64,7 @@ module KnapsackPro
         }
       end
 
-      def parse_response(body)
+      def parse_response_body(body)
         return '' if body == '' || body.nil?
         JSON.parse(body)
       rescue JSON::ParserError
@@ -69,8 +72,8 @@ module KnapsackPro
       end
 
       def seed
-        return if @response.nil? || @response == ''
-        response['build_distribution_id']
+        return if @response_body.nil? || @response_body == ''
+        response_body['build_distribution_id']
       end
 
       def has_seed?
@@ -85,8 +88,8 @@ module KnapsackPro
         http.open_timeout = TIMEOUT
         http.read_timeout = TIMEOUT
 
-        http_response = http.post(uri.path, request_body, json_headers)
-        @response = parse_response(http_response.body)
+        @http_response = http.post(uri.path, request_body, json_headers)
+        @response_body = parse_response_body(http_response.body)
 
         request_uuid = http_response.header['X-Request-Id']
 
@@ -94,12 +97,12 @@ module KnapsackPro
         logger.debug("Test suite split seed: #{seed}") if has_seed?
         logger.debug('API response:')
         if errors?
-          logger.error(response)
+          logger.error(response_body)
         else
-          logger.debug(response)
+          logger.debug(response_body)
         end
 
-        response
+        response_body
       rescue Errno::ECONNREFUSED, Errno::ETIMEDOUT, EOFError, SocketError, Net::OpenTimeout, Net::ReadTimeout => e
         logger.warn(e.inspect)
         retries += 1

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '0.57.0'
+  VERSION = '1.0.0'
 end

data/spec/knapsack_pro/client/connection_spec.rb

@@ -34,7 +34,7 @@ describe KnapsackPro::Client::Connection do
         expect(http).to receive(:read_timeout=).with(15)
 
         header = { 'X-Request-Id' => 'fake-uuid' }
-        http_response = instance_double(Net::HTTPOK, body: body, header: header)
+        http_response = instance_double(Net::HTTPOK, body: body, header: header, code: code)
         expect(http).to receive(:post).with(
           endpoint_path,
           "{\"fake\":\"hash\",\"test_suite_token\":\"3fa64859337f6e56409d49f865d13fd7\"}",
@@ -47,8 +47,9 @@ describe KnapsackPro::Client::Connection do
         ).and_return(http_response)
       end
 
-      context 'when body response is json' do
+      context 'when body response is json and API response code is 400' do
         let(:body) { '{"errors": "value"}' }
+        let(:code) { '400' } # it must be string code
 
         before do
           expect(KnapsackPro).to receive(:logger).exactly(3).and_return(logger)
@@ -67,8 +68,30 @@ describe KnapsackPro::Client::Connection do
         end
       end
 
+      context 'when body response is json and API response code is 500' do
+        let(:body) { '{"error": "Internal Server Error"}' }
+        let(:code) { '500' } # it must be string code
+
+        before do
+          expect(KnapsackPro).to receive(:logger).exactly(3).and_return(logger)
+          expect(logger).to receive(:debug).with('API request UUID: fake-uuid')
+          expect(logger).to receive(:debug).with('API response:')
+        end
+
+        it do
+          parsed_response = { 'error' => 'Internal Server Error' }
+
+          expect(logger).to receive(:error).with(parsed_response)
+
+          expect(subject).to eq(parsed_response)
+          expect(connection.success?).to be false
+          expect(connection.errors?).to be true
+        end
+      end
+
       context 'when body response is json with build_distribution_id' do
         let(:body) { '{"build_distribution_id": "seed-uuid"}' }
+        let(:code) { '200' } # it must be string code
 
         before do
           expect(KnapsackPro).to receive(:logger).exactly(4).and_return(logger)
@@ -90,6 +113,7 @@ describe KnapsackPro::Client::Connection do
 
       context 'when body response is empty' do
         let(:body) { '' }
+        let(:code) { '200' } # it must be string code
 
         before do
           expect(KnapsackPro).to receive(:logger).exactly(3).and_return(logger)
@@ -112,21 +136,48 @@ describe KnapsackPro::Client::Connection do
     subject { connection.success? }
 
     before do
-      allow(connection).to receive(:response).and_return(response)
+      allow(connection).to receive(:response_body).and_return(response_body)
     end
 
     context 'when response has no value' do
-      let(:response) { nil }
+      let(:response_body) { nil }
 
       it { should be false }
     end
 
     context 'when response has value' do
-      let(:response) do
+      let(:response_body) do
         { 'fake' => 'response' }
       end
 
-      it { should be true }
+      before do
+        http_response = double(code: code)
+        allow(connection).to receive(:http_response).and_return(http_response)
+      end
+
+      context 'when response code is 200' do
+        let(:code) { '200' } # it must be string code
+
+        it { should be true }
+      end
+
+      context 'when response code is 300' do
+        let(:code) { '300' } # it must be string code
+
+        it { should be true }
+      end
+
+      context 'when response code is 400' do
+        let(:code) { '400' } # it must be string code
+
+        it { should be true }
+      end
+
+      context 'when response code is 500' do
+        let(:code) { '500' } # it must be string code
+
+        it { should be false }
+      end
     end
   end
 
@@ -134,18 +185,18 @@ describe KnapsackPro::Client::Connection do
     subject { connection.errors? }
 
     before do
-      allow(connection).to receive(:response).and_return(response)
+      allow(connection).to receive(:response_body).and_return(response_body)
     end
 
     context 'when response has no value' do
-      let(:response) { nil }
+      let(:response_body) { nil }
 
       it { should be false }
     end
 
     context 'when response has value' do
       context 'when response has no errors' do
-        let(:response) do
+        let(:response_body) do
           { 'fake' => 'response' }
         end
 
@@ -153,7 +204,7 @@ describe KnapsackPro::Client::Connection do
       end
 
       context 'when response has errors' do
-        let(:response) do
+        let(:response_body) do
           { 'errors' => [{ 'field' => 'is wrong' }] }
         end
 
@@ -161,7 +212,7 @@ describe KnapsackPro::Client::Connection do
       end
 
       context 'when response has error (i.e. internal server error)' do
-        let(:response) do
+        let(:response_body) do
           { 'error' => 'Internal Server Error' }
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 0.57.0
+  version: 1.0.0
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-06 00:00:00.000000000 Z
+date: 2018-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake