knapsack_pro 0.14.0 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e7b7869def18504a9c41c6bae22b4ab188fd4101
-  data.tar.gz: 93e72ce429f519ccc6c55ab483e73c8b1dca9510
+  metadata.gz: ef44ff94f42a889b3f6cc1d896d484237b6a88f1
+  data.tar.gz: 5a5485e24f6ea5498382cc220578106f27760760
 SHA512:
-  metadata.gz: af07b77b591317891a261dd6b77eacb769dcfb32fdf5072763f81d8787204662aaefe456e95186fcdacac306b98bd2ae62843104d2d2ae2e34ac1a7a611760dd
-  data.tar.gz: 937a91770dd1e0325036f67ab32a4203cd4ffcf93d4b1e7a8e890537182973fac5129120ef99b2a62d1e16ec51a15fd4e89d3ece66575494d97ea74bf2b28bca
+  metadata.gz: 59e8f09d9bd4c317ffc7edf9308aa13848cbe615bfab4b881ac1ddad32b83ab29d7df765c193fafc44c60fd892b64e7651feedd083f3cc22d8daac8591cc01f2
+  data.tar.gz: c3bac7fff236e23715bffa05468cfd5c85663953acce36ba23b189e4295ae32bd78c9759beb69ba2578d59a9092d42996712ab3bdea15dbb3f2192ecd7206c66

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 * TODO
 
+### 0.15.0
+
+* Handle case when API returns no test files to execute on the node.
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/19
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v0.14.0...v0.15.0
+
 ### 0.14.0
 
 * Use rake invoke for rspec and cucumber tasks.

data/lib/knapsack_pro/runners/base_runner.rb

@@ -22,6 +22,15 @@ module KnapsackPro
         allocator_builder.test_dir
       end
 
+      def test_files_to_execute_exist?
+        if test_file_paths.empty?
+          KnapsackPro.logger.info("Knapsack Pro API returned no test files to execute for the node this time. The reason might be that you changed recently a number of total nodes or you removed some test files. Please create a new commit to get a better test suite split next time.")
+          false
+        else
+          true
+        end
+      end
+
       private
 
       attr_reader :allocator_builder,

data/lib/knapsack_pro/runners/cucumber_runner.rb

@@ -7,17 +7,19 @@ module KnapsackPro
 
         runner = new(KnapsackPro::Adapters::CucumberAdapter)
 
-        require 'cucumber/rake/task'
+        if runner.test_files_to_execute_exist?
+          require 'cucumber/rake/task'
 
-        task_name = 'knapsack_pro:cucumber_run'
-        if Rake::Task.task_defined?(task_name)
-          Rake::Task[task_name].clear
-        end
+          task_name = 'knapsack_pro:cucumber_run'
+          if Rake::Task.task_defined?(task_name)
+            Rake::Task[task_name].clear
+          end
 
-        Cucumber::Rake::Task.new(task_name) do |t|
-          t.cucumber_opts = "#{args} --require #{runner.test_dir} -- #{runner.stringify_test_file_paths}"
+          Cucumber::Rake::Task.new(task_name) do |t|
+            t.cucumber_opts = "#{args} --require #{runner.test_dir} -- #{runner.stringify_test_file_paths}"
+          end
+          Rake::Task[task_name].invoke
         end
-        Rake::Task[task_name].invoke
       end
     end
   end

data/lib/knapsack_pro/runners/minitest_runner.rb

@@ -7,20 +7,22 @@ module KnapsackPro
 
         runner = new(KnapsackPro::Adapters::MinitestAdapter)
 
-        task_name = 'knapsack_pro:minitest_run'
+        if runner.test_files_to_execute_exist?
+          task_name = 'knapsack_pro:minitest_run'
 
-        if Rake::Task.task_defined?(task_name)
-          Rake::Task[task_name].clear
-        end
+          if Rake::Task.task_defined?(task_name)
+            Rake::Task[task_name].clear
+          end
 
-        Rake::TestTask.new(task_name) do |t|
-          t.warning = false
-          t.libs << runner.test_dir
-          t.test_files = runner.test_file_paths
-          t.options = args
-        end
+          Rake::TestTask.new(task_name) do |t|
+            t.warning = false
+            t.libs << runner.test_dir
+            t.test_files = runner.test_file_paths
+            t.options = args
+          end
 
-        Rake::Task[task_name].invoke
+          Rake::Task[task_name].invoke
+        end
       end
     end
   end

data/lib/knapsack_pro/runners/rspec_runner.rb

@@ -7,18 +7,20 @@ module KnapsackPro
 
         runner = new(KnapsackPro::Adapters::RSpecAdapter)
 
-        require 'rspec/core/rake_task'
+        if runner.test_files_to_execute_exist?
+          require 'rspec/core/rake_task'
 
-        task_name = 'knapsack_pro:rspec_run'
-        if Rake::Task.task_defined?(task_name)
-          Rake::Task[task_name].clear
-        end
+          task_name = 'knapsack_pro:rspec_run'
+          if Rake::Task.task_defined?(task_name)
+            Rake::Task[task_name].clear
+          end
 
-        RSpec::Core::RakeTask.new(task_name) do |t|
-          t.rspec_opts = "#{args} --default-path #{runner.test_dir}"
-          t.pattern = runner.test_file_paths
+          RSpec::Core::RakeTask.new(task_name) do |t|
+            t.rspec_opts = "#{args} --default-path #{runner.test_dir}"
+            t.pattern = runner.test_file_paths
+          end
+          Rake::Task[task_name].invoke
         end
-        Rake::Task[task_name].invoke
       end
     end
   end

data/lib/knapsack_pro/runners/spinach_runner.rb

@@ -6,10 +6,12 @@ module KnapsackPro
 
         runner = new(KnapsackPro::Adapters::SpinachAdapter)
 
-        cmd = %Q[KNAPSACK_PRO_RECORDING_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=#{ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN']} bundle exec spinach #{args} --features_path #{runner.test_dir} -- #{runner.stringify_test_file_paths}]
+        if runner.test_files_to_execute_exist?
+          cmd = %Q[KNAPSACK_PRO_RECORDING_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=#{ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN']} bundle exec spinach #{args} --features_path #{runner.test_dir} -- #{runner.stringify_test_file_paths}]
 
-        Kernel.system(cmd)
-        Kernel.exit($?.exitstatus) unless $?.exitstatus.zero?
+          Kernel.system(cmd)
+          Kernel.exit($?.exitstatus) unless $?.exitstatus.zero?
+        end
       end
     end
   end

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '0.14.0'
+  VERSION = '0.15.0'
 end

data/spec/knapsack_pro/runners/base_runner_spec.rb

@@ -57,5 +57,31 @@ describe KnapsackPro::Runners::BaseRunner do
 
       it { should eq test_dir }
     end
+
+    describe '#test_files_to_execute_exist?' do
+      subject { runner.test_files_to_execute_exist? }
+
+      before do
+        expect(runner).to receive(:test_file_paths).and_return(test_file_paths)
+      end
+
+      context 'when test files exists' do
+        let(:test_file_paths) { ['a_spec.rb'] }
+
+        it { should be true }
+      end
+
+      context "when test files doesn't exist" do
+        let(:test_file_paths) { [] }
+
+        before do
+          logger = instance_double(Logger)
+          expect(KnapsackPro).to receive(:logger).and_return(logger)
+          expect(logger).to receive(:info).with("Knapsack Pro API returned no test files to execute for the node this time. The reason might be that you changed recently a number of total nodes or you removed some test files. Please create a new commit to get a better test suite split next time.")
+        end
+
+        it { should be false }
+      end
+    end
   end
 end

data/spec/knapsack_pro/runners/cucumber_runner_spec.rb

@@ -1,3 +1,5 @@
+require 'cucumber/rake/task'
+
 describe KnapsackPro::Runners::CucumberRunner do
   subject { described_class.new(KnapsackPro::Adapters::CucumberAdapter) }
 
@@ -6,41 +8,74 @@ describe KnapsackPro::Runners::CucumberRunner do
   describe '.run' do
     let(:args) { '--custom-arg' }
 
-    after { described_class.run(args) }
+    let(:test_suite_token_cucumber) { 'fake-token' }
+
+    subject { described_class.run(args) }
 
     before do
-      stub_const("ENV", { 'KNAPSACK_PRO_TEST_SUITE_TOKEN_CUCUMBER' => 'cucumber-token' })
+      expect(KnapsackPro::Config::Env).to receive(:test_suite_token_cucumber).and_return(test_suite_token_cucumber)
+
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_cucumber)
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_RECORDING_ENABLED', 'true')
 
-      stringify_test_file_paths = 'features/a.feature features/b.feature'
-      runner = instance_double(described_class,
-                               stringify_test_file_paths: stringify_test_file_paths)
       expect(described_class).to receive(:new)
       .with(KnapsackPro::Adapters::CucumberAdapter).and_return(runner)
-
-      expect(Kernel).to receive(:system).with('KNAPSACK_PRO_RECORDING_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=cucumber-token bundle exec cucumber --custom-arg -- features/a.feature features/b.feature')
     end
 
-    context 'when command exit with success code' do
-      let(:exitstatus) { 0 }
+    context 'when test files were returned by Knapsack Pro API' do
+      let(:test_dir) { 'fake-test-dir' }
+      let(:stringify_test_file_paths) { 'features/fake1.scenario features/fake2.scenario' }
+      let(:runner) do
+        instance_double(described_class,
+                        test_dir: test_dir,
+                        stringify_test_file_paths: stringify_test_file_paths,
+                        test_files_to_execute_exist?: true)
+      end
+      let(:task) { double }
 
       before do
-        expect($?).to receive(:exitstatus).and_return(exitstatus)
+        expect(Rake::Task).to receive(:[]).with('knapsack_pro:cucumber_run').at_least(1).and_return(task)
+
+        t = double
+        expect(Cucumber::Rake::Task).to receive(:new).with('knapsack_pro:cucumber_run').and_yield(t)
+        expect(t).to receive(:cucumber_opts=).with('--custom-arg --require fake-test-dir -- features/fake1.scenario features/fake2.scenario')
       end
 
-      it do
-        expect(Kernel).not_to receive(:exit)
+      context 'when task already exists' do
+        before do
+          expect(Rake::Task).to receive(:task_defined?).with('knapsack_pro:cucumber_run').and_return(true)
+          expect(task).to receive(:clear)
+        end
+
+        it do
+          result = double(:result)
+          expect(task).to receive(:invoke).and_return(result)
+          expect(subject).to eq result
+        end
       end
-    end
 
-    context 'when command exit without success code' do
-      let(:exitstatus) { 1 }
+      context "when task doesn't exist" do
+        before do
+          expect(Rake::Task).to receive(:task_defined?).with('knapsack_pro:cucumber_run').and_return(false)
+          expect(task).not_to receive(:clear)
+        end
 
-      before do
-        expect($?).to receive(:exitstatus).twice.and_return(exitstatus)
+        it do
+          result = double(:result)
+          expect(task).to receive(:invoke).and_return(result)
+          expect(subject).to eq result
+        end
+      end
+    end
+
+    context 'when test files were not returned by Knapsack Pro API' do
+      let(:runner) do
+        instance_double(described_class,
+                        test_files_to_execute_exist?: false)
       end
 
-      it do
-        expect(Kernel).to receive(:exit).with(exitstatus)
+      it "doesn't run tests" do
+        subject
       end
     end
   end

data/spec/knapsack_pro/runners/minitest_runner_spec.rb

@@ -13,22 +13,36 @@ describe KnapsackPro::Runners::MinitestRunner do
       stub_const("ENV", { 'KNAPSACK_PRO_TEST_SUITE_TOKEN_MINITEST' => 'minitest-token' })
     end
 
-    it do
-      test_file_paths = ['test_fake/a_test.rb', 'test_fake/b_test.rb']
-      runner = instance_double(described_class,
-                               test_dir: 'test',
-                               test_file_paths: test_file_paths)
-      expect(described_class).to receive(:new)
-      .with(KnapsackPro::Adapters::MinitestAdapter).and_return(runner)
+    context 'when test files were returned by Knapsack Pro API' do
+      it 'runs tests' do
+        test_file_paths = ['test_fake/a_test.rb', 'test_fake/b_test.rb']
+        runner = instance_double(described_class,
+                                 test_dir: 'test',
+                                 test_file_paths: test_file_paths,
+                                 test_files_to_execute_exist?: true)
+        expect(described_class).to receive(:new)
+        .with(KnapsackPro::Adapters::MinitestAdapter).and_return(runner)
 
-      expect(Rake::Task.task_defined?(task_name)).to be false
+        expect(Rake::Task.task_defined?(task_name)).to be false
 
-      subject
+        subject
 
-      expect(Rake::Task.task_defined?(task_name)).to be true
+        expect(Rake::Task.task_defined?(task_name)).to be true
 
-      expect(ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN']).to eq 'minitest-token'
-      expect(ENV['KNAPSACK_PRO_RECORDING_ENABLED']).to eq 'true'
+        expect(ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN']).to eq 'minitest-token'
+        expect(ENV['KNAPSACK_PRO_RECORDING_ENABLED']).to eq 'true'
+      end
+    end
+
+    context 'when test files were not returned by Knapsack Pro API' do
+      it "doesn't run tests" do
+        runner = instance_double(described_class,
+                                 test_files_to_execute_exist?: false)
+        expect(described_class).to receive(:new)
+        .with(KnapsackPro::Adapters::MinitestAdapter).and_return(runner)
+
+        subject
+      end
     end
   end
 end

data/spec/knapsack_pro/runners/rspec_runner_spec.rb

@@ -1,3 +1,5 @@
+require 'rspec/core/rake_task'
+
 describe KnapsackPro::Runners::RSpecRunner do
   subject { described_class.new(KnapsackPro::Adapters::RSpecAdapter) }
 
@@ -6,43 +8,75 @@ describe KnapsackPro::Runners::RSpecRunner do
   describe '.run' do
     let(:args) { '--profile --color' }
 
-    after { described_class.run(args) }
+    let(:test_suite_token_rspec) { 'fake-token' }
+
+    subject { described_class.run(args) }
 
     before do
-      stub_const("ENV", { 'KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC' => 'rspec-token' })
+      expect(KnapsackPro::Config::Env).to receive(:test_suite_token_rspec).and_return(test_suite_token_rspec)
+
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_rspec)
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_RECORDING_ENABLED', 'true')
 
-      stringify_test_file_paths = 'spec/a_spec.rb spec/b_spec.rb'
-      runner = instance_double(described_class,
-                               test_dir: 'spec',
-                               stringify_test_file_paths: stringify_test_file_paths)
       expect(described_class).to receive(:new)
       .with(KnapsackPro::Adapters::RSpecAdapter).and_return(runner)
-
-      expect(Kernel).to receive(:system)
-      .with('KNAPSACK_PRO_RECORDING_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=rspec-token bundle exec rspec --profile --color --default-path spec -- spec/a_spec.rb spec/b_spec.rb')
     end
 
-    context 'when command exit with success code' do
-      let(:exitstatus) { 0 }
+    context 'when test files were returned by Knapsack Pro API' do
+      let(:test_dir) { 'fake-test-dir' }
+      let(:test_file_paths) { double(:test_file_paths) }
+      let(:runner) do
+        instance_double(described_class,
+                        test_dir: test_dir,
+                        test_file_paths: test_file_paths,
+                        test_files_to_execute_exist?: true)
+      end
+      let(:task) { double }
 
       before do
-        expect($?).to receive(:exitstatus).and_return(exitstatus)
+        expect(Rake::Task).to receive(:[]).with('knapsack_pro:rspec_run').at_least(1).and_return(task)
+
+        t = double
+        expect(RSpec::Core::RakeTask).to receive(:new).with('knapsack_pro:rspec_run').and_yield(t)
+        expect(t).to receive(:rspec_opts=).with('--profile --color --default-path fake-test-dir')
+        expect(t).to receive(:pattern=).with(test_file_paths)
       end
 
-      it do
-        expect(Kernel).not_to receive(:exit)
+      context 'when task already exists' do
+        before do
+          expect(Rake::Task).to receive(:task_defined?).with('knapsack_pro:rspec_run').and_return(true)
+          expect(task).to receive(:clear)
+        end
+
+        it do
+          result = double(:result)
+          expect(task).to receive(:invoke).and_return(result)
+          expect(subject).to eq result
+        end
       end
-    end
 
-    context 'when command exit without success code' do
-      let(:exitstatus) { 1 }
+      context "when task doesn't exist" do
+        before do
+          expect(Rake::Task).to receive(:task_defined?).with('knapsack_pro:rspec_run').and_return(false)
+          expect(task).not_to receive(:clear)
+        end
 
-      before do
-        expect($?).to receive(:exitstatus).twice.and_return(exitstatus)
+        it do
+          result = double(:result)
+          expect(task).to receive(:invoke).and_return(result)
+          expect(subject).to eq result
+        end
+      end
+    end
+
+    context 'when test files were not returned by Knapsack Pro API' do
+      let(:runner) do
+        instance_double(described_class,
+                        test_files_to_execute_exist?: false)
       end
 
-      it do
-        expect(Kernel).to receive(:exit).with(exitstatus)
+      it "doesn't run tests" do
+        subject
       end
     end
   end

data/spec/knapsack_pro/runners/spinach_runner_spec.rb

@@ -6,41 +6,64 @@ describe KnapsackPro::Runners::SpinachRunner do
   describe '.run' do
     let(:args) { '--custom-arg' }
 
-    after { described_class.run(args) }
+    subject { described_class.run(args) }
 
     before do
       stub_const("ENV", { 'KNAPSACK_PRO_TEST_SUITE_TOKEN_SPINACH' => 'spinach-token' })
 
-      stringify_test_file_paths = 'features/a.feature features/b.feature'
-      runner = instance_double(described_class,
-                               stringify_test_file_paths: stringify_test_file_paths)
       expect(described_class).to receive(:new)
       .with(KnapsackPro::Adapters::SpinachAdapter).and_return(runner)
-
-      expect(Kernel).to receive(:system).with('KNAPSACK_PRO_RECORDING_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=spinach-token bundle exec spinach --custom-arg -- features/a.feature features/b.feature')
     end
 
-    context 'when command exit with success code' do
-      let(:exitstatus) { 0 }
+    context 'when test files were returned by Knapsack Pro API' do
+      let(:stringify_test_file_paths) { 'features/a.feature features/b.feature' }
+      let(:test_dir) { 'fake-test-dir' }
+      let(:runner) do
+        instance_double(described_class,
+                        test_dir: test_dir,
+                        stringify_test_file_paths: stringify_test_file_paths,
+                        test_files_to_execute_exist?: true)
+      end
 
       before do
-        expect($?).to receive(:exitstatus).and_return(exitstatus)
+        expect(Kernel).to receive(:system).with('KNAPSACK_PRO_RECORDING_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=spinach-token bundle exec spinach --custom-arg --features_path fake-test-dir -- features/a.feature features/b.feature')
       end
 
-      it do
-        expect(Kernel).not_to receive(:exit)
+      after { subject }
+
+      context 'when command exit with success code' do
+        let(:exitstatus) { 0 }
+
+        before do
+          expect($?).to receive(:exitstatus).and_return(exitstatus)
+        end
+
+        it do
+          expect(Kernel).not_to receive(:exit)
+        end
       end
-    end
 
-    context 'when command exit without success code' do
-      let(:exitstatus) { 1 }
+      context 'when command exit without success code' do
+        let(:exitstatus) { 1 }
 
-      before do
-        expect($?).to receive(:exitstatus).twice.and_return(exitstatus)
+        before do
+          expect($?).to receive(:exitstatus).twice.and_return(exitstatus)
+        end
+
+        it do
+          expect(Kernel).to receive(:exit).with(exitstatus)
+        end
+      end
+    end
+
+    context 'when test files were not returned by Knapsack Pro API' do
+      let(:runner) do
+        instance_double(described_class,
+                        test_files_to_execute_exist?: false)
       end
 
-      it do
-        expect(Kernel).to receive(:exit).with(exitstatus)
+      it "doesn't run tests" do
+        subject
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-25 00:00:00.000000000 Z
+date: 2016-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake