knapsack 1.9.0 → 1.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 52112d867f2e7b5e6f3cdc4c314fdbbc161840aa
-  data.tar.gz: 3e86872b9ccef2564ec99ab63a46b634c17ac9c5
+  metadata.gz: 04c056b1aca1e07b752f190165b9bf7d8b3d20c8
+  data.tar.gz: 4f6546493271a2edcfab8735e672b7966197b21e
 SHA512:
-  metadata.gz: 3c77c58339d2caacaf9b5f49ab6b4cee405391c7665aeca22113316f2ca49380cc58ff0d42b49f54dc27b3b418a0a68f51141d1cc6a855ea2171af2cdc416554
-  data.tar.gz: 899af246bf1d34d9cbedb4cabf8427d3bc001b2438e4a8d2d5b83104fb1210ffbf1b3377530bb1e3c31c7abd082703cc9dd4be05269bf791c9fc4c2efce2f09a
+  metadata.gz: 263a43a683b096a68c6a0f3bc3c88c63893383d46069c0753b75e6dca22907aaae3789a2cc19f86d29fc5a4a7007019b18014630930e348c12f77132fe3569d8
+  data.tar.gz: be3932dfa2720b181319501886dcdeef30f73add44616d445ab856faff125cf76bfee03cac6f2694430f3ca9931e0b9c56c55e8b52df791a721daf58bbd1fbf8

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 * TODO
 
+### 1.10.0
+
+* Log the time offset warning at INFO if time not exceeded
+
+    https://github.com/ArturT/knapsack/pull/40
+
+https://github.com/ArturT/knapsack/compare/v1.9.0...v1.10.0
+
 ### 1.9.0
 
 * Use Knapsack.logger for runner output

data/lib/knapsack/adapters/cucumber_adapter.rb

@@ -26,7 +26,10 @@ module Knapsack
 
       def bind_time_offset_warning
         ::Kernel.at_exit do
-          Knapsack.logger.warn(Presenter.time_offset_warning)
+          Knapsack.logger.log(
+            Presenter.time_offset_log_level,
+            Presenter.time_offset_warning
+          )
         end
       end
 

data/lib/knapsack/adapters/minitest_adapter.rb

@@ -37,7 +37,10 @@ module Knapsack
 
       def bind_time_offset_warning
         add_post_run_callback do
-          Knapsack.logger.warn(Presenter.time_offset_warning)
+          Knapsack.logger.log(
+            Presenter.time_offset_log_level,
+            Presenter.time_offset_warning
+          )
         end
       end
 

data/lib/knapsack/adapters/rspec_adapter.rb

@@ -39,7 +39,10 @@ module Knapsack
       def bind_time_offset_warning
         ::RSpec.configure do |config|
           config.after(:suite) do
-            Knapsack.logger.warn(Presenter.time_offset_warning)
+            Knapsack.logger.log(
+              Presenter.time_offset_log_level,
+              Presenter.time_offset_warning
+            )
           end
         end
       end

data/lib/knapsack/logger.rb

@@ -6,6 +6,20 @@ module Knapsack
     INFO = 1
     WARN = 2
 
+    UnknownLogLevel = Class.new(StandardError)
+
+    def log(level, text=nil)
+      level_method =
+        case level
+        when DEBUG then :debug
+        when INFO then :info
+        when WARN then :warn
+        else raise UnknownLogLevel
+        end
+
+      public_send(level_method, text)
+    end
+
     def debug(text=nil)
       return if level != DEBUG
       puts text

data/lib/knapsack/presenter.rb

@@ -35,6 +35,14 @@ module Knapsack
         "Exceeded time: #{exceeded_time}"
       end
 
+      def time_offset_log_level
+        if Knapsack.tracker.time_exceeded?
+          Knapsack::Logger::WARN
+        else
+          Knapsack::Logger::INFO
+        end
+      end
+
       def time_offset_warning
         str = %{\n========= Knapsack Time Offset Warning ==========
 #{Presenter.time_offset}

data/lib/knapsack/version.rb

@@ -1,3 +1,3 @@
 module Knapsack
-  VERSION = '1.9.0'
+  VERSION = '1.10.0'
 end

data/spec/knapsack/adapters/cucumber_adapter_spec.rb

@@ -12,7 +12,7 @@ describe Knapsack::Adapters::CucumberAdapter do
     let(:logger) { instance_double(Knapsack::Logger) }
 
     before do
-      expect(Knapsack).to receive(:logger).and_return(logger)
+      allow(Knapsack).to receive(:logger).and_return(logger)
     end
 
     describe '#bind_time_tracker' do
@@ -83,11 +83,13 @@ describe Knapsack::Adapters::CucumberAdapter do
 
     describe '#bind_time_offset_warning' do
       let(:time_offset_warning) { 'Time offset warning' }
+      let(:log_level) { :info }
 
-      it do
+      it 'creates an at-exit callback to log the time offset message at the specified log level' do
         expect(::Kernel).to receive(:at_exit).and_yield
         expect(Knapsack::Presenter).to receive(:time_offset_warning).and_return(time_offset_warning)
-        expect(logger).to receive(:warn).with(time_offset_warning)
+        expect(Knapsack::Presenter).to receive(:time_offset_log_level).and_return(log_level)
+        expect(logger).to receive(:log).with(log_level, time_offset_warning)
 
         subject.bind_time_offset_warning
       end

data/spec/knapsack/adapters/minitest_adapter_spec.rb

@@ -74,12 +74,14 @@ describe Knapsack::Adapters::MinitestAdapter do
 
     describe '#bind_time_offset_warning' do
       let(:time_offset_warning) { 'Time offset warning' }
+      let(:log_level) { :info }
 
-      it do
+      it 'creates a post-run callback to log the time offset message at the specified log level' do
         expect(::Minitest).to receive(:after_run).and_yield
 
         expect(Knapsack::Presenter).to receive(:time_offset_warning).and_return(time_offset_warning)
-        expect(logger).to receive(:warn).with(time_offset_warning)
+        expect(Knapsack::Presenter).to receive(:time_offset_log_level).and_return(log_level)
+        expect(logger).to receive(:log).with(log_level, time_offset_warning)
 
         subject.bind_time_offset_warning
       end

data/spec/knapsack/adapters/rspec_adapter_spec.rb

@@ -65,13 +65,15 @@ describe Knapsack::Adapters::RSpecAdapter do
 
     describe '#bind_time_offset_warning' do
       let(:time_offset_warning) { 'Time offset warning' }
+      let(:log_level) { :info }
 
-      it do
+      it 'creates a post-suite callback to log the time offset message at the specified log level' do
         expect(config).to receive(:after).with(:suite).and_yield
         expect(::RSpec).to receive(:configure).and_yield(config)
 
         expect(Knapsack::Presenter).to receive(:time_offset_warning).and_return(time_offset_warning)
-        expect(logger).to receive(:warn).with(time_offset_warning)
+        expect(Knapsack::Presenter).to receive(:time_offset_log_level).and_return(log_level)
+        expect(logger).to receive(:log).with(log_level, time_offset_warning)
 
         subject.bind_time_offset_warning
       end

data/spec/knapsack/logger_spec.rb

@@ -57,4 +57,25 @@ describe Knapsack::Logger do
       it { expect { subject.warn(text) }.to output(/#{text}/).to_stdout }
     end
   end
+
+  describe '#log' do
+    let(:log_level) { Knapsack::Logger::INFO }
+    let(:log_message) { 'log-message' }
+
+    it 'delegates to the method matching the specified log level' do
+      expect(subject).to receive(:info).with(log_message)
+
+      subject.log(log_level, log_message)
+    end
+
+    context 'when the log level is unknown' do
+      let(:log_level) { 5 }
+
+      it 'raises an UnknownLogLevel error' do
+        expect {
+          subject.log(log_level, log_message)
+        }.to raise_error Knapsack::Logger::UnknownLogLevel
+      end
+    end
+  end
 end

data/spec/knapsack/presenter_spec.rb

@@ -45,6 +45,29 @@ describe Knapsack::Presenter do
     it { should eql "Knapsack report was generated. Preview:\n{}" }
   end
 
+  describe '.time_offset_log_level' do
+    before do
+      allow(Knapsack).to receive(:tracker) { tracker }
+      allow(tracker).to receive(:time_exceeded?).and_return(time_exceeded)
+    end
+
+    context 'when the time offset is exceeded' do
+      let(:time_exceeded) { true }
+
+      it 'returns a WARN log level' do
+        expect(described_class.time_offset_log_level).to eq(Knapsack::Logger::WARN)
+      end
+    end
+
+    context 'when the time offset is not exceeded' do
+      let(:time_exceeded) { false }
+
+      it 'returns an INFO log level' do
+        expect(described_class.time_offset_log_level).to eq(Knapsack::Logger::INFO)
+      end
+    end
+  end
+
   describe '.time_offset_warning' do
     let(:time_offset_in_seconds) { 30 }
     let(:max_node_time_execution) { 60 }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack
 version: !ruby/object:Gem::Version
-  version: 1.9.0
+  version: 1.10.0
 platform: ruby
 authors:
 - ArturT
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-20 00:00:00.000000000 Z
+date: 2016-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake