klastera 1.5.4 → 1.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b05f393fbe67e0822de3526d5b46dc7081a79226f45b5fe63985424d73331742
-  data.tar.gz: '09623883ce4911b3cd0df6382c558c7d82f080eb504f3e0dae4e74262acd8df7'
+  metadata.gz: 1f9a474c54506a3e2a3b92ce5961de94a71dd28699354b671be08337b4bdfac5
+  data.tar.gz: 01db2dd1040338587462593e22ef1103f3c7ecd6ce13e48656dcd47eb7cf31c9
 SHA512:
-  metadata.gz: 9589942522f4442bf44304cb735a022819bb40f0885c077d77289791caf79f266a1f258d3db7f14fc242d0d80858a8c82027b0314f2faf5ef156e45bcf1c89a7
-  data.tar.gz: 3b5d0a9505bd241d3374077ab01d8ddcd2ca83d3f4787763de1658c56f362680b3cb2350e44992a2041834181b7b379c5ad506d4ba83278d140ba6a7d6a775da
+  metadata.gz: a54cf22f075c58094950f74345fe924686f79ab8454ca6afc4b80555bbe26367d56500867b1fbf83f3f270d9f0effe9d9907ceacdbc18f02f32f35654abf237d
+  data.tar.gz: d197f19bc4c590359364cbd965295fb981dedfc22f0e33cf02673c75bfc5228b50f6543d316ee2de887437deec92ceb65bcadc617f1d6a4b1af3f2e44f53ae05

data/app/models/klastera/concerns/clusterizable.rb

@@ -14,6 +14,7 @@ module Klastera::Concerns::Clusterizable
     validate :uniqueness_of_cluster_entity_record
 
     scope :includes_cluster, -> { includes(cluster_entities: :cluster) }
+    scope :with_clusters, -> { includes(cluster_entities: :cluster) }
 
     def at_least_one_cluster_entity
       if cluster_entities.length == 0 || cluster_entities.reject{|cluster_entity| cluster_entity._destroy == true}.empty?
@@ -26,11 +27,24 @@ module Klastera::Concerns::Clusterizable
     end
 
     ##
-     # This is a legacy method and we don't recommend using it.
-     # Implement directly Klastera.entity_clusters_string_list instead of this method.
-     # TODO: In order to deprecate it, you will need to perform some changes in the main app
+     # This method has been optimized to use preloaded associations when available
+     # Falls back to efficient single-query approach when associations aren't preloaded
      ##
-    def clusters_string_separated_by(separator,attribute=:name)
+    def clusters_string_separated_by(separator, attribute=:name)
+      # Use Rails cache for frequently accessed cluster strings
+      cache_key = [self.cache_key_with_version, :clusters_string, separator, attribute]
+      
+      Rails.cache.fetch(cache_key, expires_in: 30.minutes) do
+        Klastera.entity_clusters_string_list!(
+          cluster_entities, separator, attribute
+        )
+      end
+    end
+
+    ##
+     # Optimized version without cache for real-time updates
+     ##
+    def clusters_string_separated_by_uncached(separator, attribute=:name)
       Klastera.entity_clusters_string_list!(
         cluster_entities, separator, attribute
       )
@@ -53,5 +67,49 @@ module Klastera::Concerns::Clusterizable
     def cluster_entity_params
       [ :cluster_id, { cluster_entities_attributes: [:id, :cluster_id, :_destroy] } ]
     end
+
+    ##
+     # Efficiently preload clusters for a collection of entities
+     # This prevents N+1 queries when calling clusters_string_separated_by on multiple entities
+     ##
+    def preload_clusters(collection)
+      return collection if collection.empty?
+      
+      ActiveRecord::Associations::Preloader.new.preload(
+        collection, 
+        cluster_entities: :cluster
+      )
+      collection
+    end
+
+    ##
+     # Batch update cluster assignments for multiple entities
+     # More efficient than individual updates
+     ##
+    def batch_assign_clusters(entity_ids, cluster_ids)
+      return if entity_ids.empty? || cluster_ids.empty?
+
+      # Clear existing assignments
+      Klastera::ClusterEntity.where(
+        entity_type: self.name,
+        entity_id: entity_ids
+      ).destroy_all
+
+      # Create new assignments
+      cluster_assignments = []
+      entity_ids.each do |entity_id|
+        cluster_ids.each do |cluster_id|
+          cluster_assignments << {
+            entity_type: self.name,
+            entity_id: entity_id,
+            cluster_id: cluster_id,
+            created_at: Time.current,
+            updated_at: Time.current
+          }
+        end
+      end
+
+      Klastera::ClusterEntity.insert_all(cluster_assignments) if cluster_assignments.any?
+    end
   end
 end

data/db/migrate/20250429110829_add_entity_id_index_to_cluster_entities.rb

@@ -0,0 +1,6 @@
+class AddEntityIdIndexToClusterEntities < ActiveRecord::Migration[5.2]
+  disable_ddl_transaction!
+  def change
+    add_index :cluster_entities, :entity_id, algorithm: :concurrently
+  end
+end

data/db/migrate/20250429110830_add_entity_id_index_and_entity_type_index_to_cluster_entities.klastera.rb

@@ -0,0 +1,7 @@
+# This migration comes from klastera (originally 20250429110947)
+class AddEntityIdIndexAndEntityTypeIndexToClusterEntities < ActiveRecord::Migration[5.2]
+  disable_ddl_transaction!
+  def change
+    add_index :cluster_entities, [:entity_id,:entity_type], algorithm: :concurrently
+  end
+end

data/lib/klastera/version.rb

@@ -1,3 +1,3 @@
 module Klastera
-  VERSION = "1.5.4"
+  VERSION = "1.5.5"
 end

data/lib/klastera.rb

@@ -46,15 +46,32 @@ module Klastera
     ##
      # Return a string with cluster attribute separated by separator argument
      # A array of cluster ids can be passed fo filter the result
+     # Optimized version that uses preloaded associations when available
      #
     def entity_clusters_string_list!(cluster_entities,separator,attribute=:name,allowed_cluster_ids=nil)
       _cluster_entities = cluster_entities.reject(&:nil?)
       if allowed_cluster_ids.is_a?(Array)
         _cluster_entities.select!{|ce| allowed_cluster_ids.include?(ce.cluster_id)}
       end
-      _cluster_entities.map do |ce|
-        ce.cluster.try(attribute)
-      end.compact.sort.join(separator)
+      
+      # Performance optimization: Use preloaded data when available
+      if cluster_entities.respond_to?(:loaded?) && cluster_entities.loaded? &&
+         _cluster_entities.all? { |ce| ce.association(:cluster).loaded? }
+        # Use in-memory data (much faster)
+        _cluster_entities.map do |ce|
+          ce.cluster.try(attribute)
+        end.compact.sort.join(separator)
+      else
+        # Fallback to original method with database query
+        # But use a single query instead of N+1
+        cluster_ids = _cluster_entities.map(&:cluster_id).compact.uniq
+        return "" if cluster_ids.empty?
+        
+        clusters_hash = ::Cluster.where(id: cluster_ids).pluck(:id, attribute).to_h
+        _cluster_entities.map do |ce|
+          clusters_hash[ce.cluster_id]
+        end.compact.sort.join(separator)
+      end
     end
 
     ##

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: klastera
 version: !ruby/object:Gem::Version
-  version: 1.5.4
+  version: 1.5.5
 platform: ruby
 authors:
 - Gino Barahona
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-12 00:00:00.000000000 Z
+date: 2025-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.1.3.2
+        version: 5.2.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.1.3.2
+        version: 5.2.6
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -95,6 +95,8 @@ files:
 - db/migrate/20200518142609_create_klastera_cluster_entities.rb
 - db/migrate/20200908180057_add_cluster_config_to_organization.rb
 - db/migrate/20220602222332_add_unique_index_to_cluster_entities.rb
+- db/migrate/20250429110829_add_entity_id_index_to_cluster_entities.rb
+- db/migrate/20250429110830_add_entity_id_index_and_entity_type_index_to_cluster_entities.klastera.rb
 - lib/klastera.rb
 - lib/klastera/engine.rb
 - lib/klastera/version.rb