klarna-checkout 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a053d316d105c8a76dd3e33ca77688c8d0b750cd
-  data.tar.gz: 85e72b92faac5dea652d0222ebad043b5bb34abf
+  metadata.gz: 99dbc87a1758ccba7b8707c8afa2fbcb5a4d5271
+  data.tar.gz: b5f08fb9d850af9cb1dd82dc8c9d4d3084d236b4
 SHA512:
-  metadata.gz: 52ed946b853c40f42532642834872404372abf665e16587fba4bd6245933391008037cede47e648b7b6a10f2192151fa5457027701c8a6dc6ef9b209d604783d
-  data.tar.gz: 696ada5b3d440b29a3ea74df2cd4257cfd3af2d4f0dbc3814a69d5347bceac3837d23bbf5a35fcacbf0df972864725a542e4eca645038f04339be6fbd3138357
+  metadata.gz: 7adf77484ebe60253d5c2cad1b800edaea3ebc25d5af7aa23720367b28df80f7acc92f11fe71b3bdb2f2de72073ba919a971a31a40bf7e6e6eddccb1e7e413f9
+  data.tar.gz: 2c8122a05a62840e2f2ab2aa06923b0c9c8a37e3249f7192e7e07d9d4faa25d21de9294c3268803d55f2907282270df3de2813fb048bd16de94c1cb024962543

data/README.md

@@ -1,3 +1,5 @@
+[![Build Status](https://magnum.travis-ci.com/Skalar/klarna-checkout-ruby.png?token=e2yW3RUEf8aqmbRkK1DS)](https://magnum.travis-ci.com/Skalar/klarna-checkout-ruby) [![Code Climate](https://codeclimate.com/github/Skalar/klarna-checkout-ruby.png)](https://codeclimate.com/github/Skalar/klarna-checkout-ruby)
+
 # Klarna Checkout
 
 Unofficial Ruby Wrapper for Klarnas Checkout Rest API.
@@ -59,7 +61,6 @@ order = client.read_order("1234ABCD")
 
 ## TODO
 
-* Raise exceptions on errors from API
 * Validation of objects according to documentation
 * Respect readonly attributes
 

data/lib/klarna/checkout/client.rb

@@ -2,6 +2,8 @@ require 'digest/sha2'
 require 'base64'
 require 'faraday'
 
+require 'klarna/checkout/exceptions'
+
 module Klarna
   module Checkout
     class Client
@@ -48,6 +50,8 @@ module Klarna
 
           req.body = request_body
         end
+        handle_status_code(response.status)
+
         order.id = response.headers['Location'].split('/').last
         order
       end
@@ -60,6 +64,8 @@ module Klarna
           req.headers['Accept']          = 'application/vnd.klarna.checkout.aggregated-order-v2+json'
           req.headers['Accept-Encoding'] = ''
         end
+        handle_status_code(response.status)
+
         Order.new(JSON.parse(response.body))
       end
 
@@ -70,6 +76,25 @@ module Klarna
         Digest::SHA256.base64digest(payload)
       end
 
+      def handle_status_code(code, &blk)
+        case Integer(code)
+        when 200, 201
+          yield if block_given?
+        when 401
+          raise Klarna::Checkout::UnauthorizedException.new
+        when 403
+          raise Klarna::Checkout::ForbiddenException.new
+        when 404
+          raise Klarna::Checkout::NotFoundException.new
+        when 405
+          raise Klarna::Checkout::MethodNotAllowedException.new
+        when 406
+          raise Klarna::Checkout::NotAcceptableException.new
+        when 415
+          raise Klarna::Checkout::UnsupportedMediaTypeException.new
+        end
+      end
+
       private
 
       def https_connection

data/lib/klarna/checkout/exceptions.rb

@@ -0,0 +1,20 @@
+class Klarna::Checkout::Exception < Exception
+end
+
+class Klarna::Checkout::UnauthorizedException < Klarna::Checkout::Exception
+end
+
+class Klarna::Checkout::ForbiddenException < Klarna::Checkout::Exception
+end
+
+class Klarna::Checkout::NotFoundException < Klarna::Checkout::Exception
+end
+
+class Klarna::Checkout::MethodNotAllowedException < Klarna::Checkout::Exception
+end
+
+class Klarna::Checkout::NotAcceptableException < Klarna::Checkout::Exception
+end
+
+class Klarna::Checkout::UnsupportedMediaTypeException < Klarna::Checkout::Exception
+end

data/lib/klarna/checkout/version.rb

@@ -1,5 +1,5 @@
 module Klarna
   module Checkout
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/spec/lib/klarna/checkout/client_spec.rb

@@ -51,10 +51,12 @@ describe Klarna::Checkout::Client do
 
     let(:order) { double('Order', to_json: JSON.generate({ foo: "bar" }), :id= => true) }
 
-    it "sends a json representation of the object to Klarna" do
+    before(:each) do
       stub_request(:post, "https://checkout.testdrive.klarna.com/checkout/orders")
-        .to_return(headers: { 'Location' => 'https://checkout.testdrive.klarna.com/checkout/orders/143F7BC0A1090B11C39E7220000' })
+        .to_return(headers: { 'Location' => 'https://checkout.testdrive.klarna.com/checkout/orders/143F7BC0A1090B11C39E7220000' }, status: 201)
+    end
 
+    it "sends a json representation of the object to Klarna" do
       subject.create_order(order)
 
       assert_requested :post, "https://checkout.testdrive.klarna.com/checkout/orders",
@@ -67,15 +69,108 @@ describe Klarna::Checkout::Client do
         :body => JSON.generate({ foo: "bar" }),
         :times   => 1
     end
+
+    it "checks the response" do
+      subject.should receive(:handle_status_code).with(201)
+      subject.create_order(order)
+    end
+  end
+
+  describe "#handle_status_code" do
+    context "with 200" do
+      it "just yields the block given" do
+        yielded = false
+        subject.handle_status_code 200 do
+          yielded = true
+        end
+        yielded.should be_true
+      end
+
+      context "without block" do
+        it "does nothing" do
+          expect {
+            subject.handle_status_code(200)
+          }.to_not raise_error
+        end
+      end
+    end
+
+    context "with 201" do
+      it "just yields the block given" do
+        yielded = false
+        subject.handle_status_code 201 do
+          yielded = true
+        end
+        yielded.should be_true
+      end
+
+      context "without block" do
+        it "does nothing" do
+          expect {
+            subject.handle_status_code(201)
+          }.to_not raise_error
+        end
+      end
+    end
+
+    context "with 401" do
+      it "raises a Klarna::Checkout::UnauthorizedException" do
+        expect {
+          subject.handle_status_code(401)  
+        }.to raise_error(Klarna::Checkout::UnauthorizedException)
+      end
+    end
+
+    context "with 403" do
+      it "raises a Klarna::Checkout::ForbiddenException" do
+        expect {
+          subject.handle_status_code(403)  
+        }.to raise_error(Klarna::Checkout::ForbiddenException)
+      end
+    end
+
+    context "with 404" do
+      it "raises a Klarna::Checkout::NotFoundException" do
+        expect {
+          subject.handle_status_code(404)  
+        }.to raise_error(Klarna::Checkout::NotFoundException)
+      end
+    end
+
+    context "with 405" do
+      it "raises a Klarna::Checkout::MethodNotAllowedException" do
+        expect {
+          subject.handle_status_code(405)  
+        }.to raise_error(Klarna::Checkout::MethodNotAllowedException)
+      end
+    end
+
+    context "with 406" do
+      it "raises a Klarna::Checkout::NotAcceptableException" do
+        expect {
+          subject.handle_status_code(406)  
+        }.to raise_error(Klarna::Checkout::NotAcceptableException)
+      end
+    end
+
+    context "with 415" do
+      it "raises a Klarna::Checkout::UnsupportedMediaTypeException" do
+        expect {
+          subject.handle_status_code(415)  
+        }.to raise_error(Klarna::Checkout::UnsupportedMediaTypeException)
+      end
+    end
   end
 
   describe "#read_order" do
     subject { described_class.new({shared_secret: 'foobar'}) }
 
-    it "uses the correct endpoint at klarna" do
+    before(:each) do
       stub_request(:get, "https://checkout.testdrive.klarna.com/checkout/orders/143F7BC0A1090B11C39E7220000")
         .to_return(body: JSON.generate({ id: "143F7BC0A1090B11C39E7220000" }))
+    end
 
+    it "uses the correct endpoint at klarna" do
       subject.read_order('143F7BC0A1090B11C39E7220000')
 
       assert_requested :get, "https://checkout.testdrive.klarna.com/checkout/orders/143F7BC0A1090B11C39E7220000",
@@ -86,6 +181,11 @@ describe Klarna::Checkout::Client do
         },
         :times   => 1
     end
+
+    it "checks the response" do
+      subject.should receive(:handle_status_code).with(200)
+      subject.read_order('143F7BC0A1090B11C39E7220000')
+    end
   end
 
   describe "#sign_payload" do

data/spec/lib/klarna/checkout/version_spec.rb

@@ -1,5 +1,5 @@
 require 'klarna/checkout/version'
 
 describe Klarna::Checkout::VERSION do
-  it { should eq '0.0.3' }
+  it { should eq '0.0.4' }
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: klarna-checkout
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Theodor Tonum
@@ -24,20 +24,6 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: activemodel
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -136,20 +122,6 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: shoulda-matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Ruby Wrapper for Klarna Checkout Rest API
 email:
 - theodor@tonum.no
@@ -157,15 +129,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- Gemfile
-- Guardfile
 - LICENSE.txt
 - README.md
-- Rakefile
-- klarna-checkout.gemspec
-- lib/klarna/checkout.rb
 - lib/klarna/checkout/address.rb
 - lib/klarna/checkout/cart.rb
 - lib/klarna/checkout/cart_item.rb
@@ -173,11 +138,13 @@ files:
 - lib/klarna/checkout/concerns/has_many.rb
 - lib/klarna/checkout/concerns/has_one.rb
 - lib/klarna/checkout/customer.rb
+- lib/klarna/checkout/exceptions.rb
 - lib/klarna/checkout/gui.rb
 - lib/klarna/checkout/merchant.rb
 - lib/klarna/checkout/order.rb
 - lib/klarna/checkout/resource.rb
 - lib/klarna/checkout/version.rb
+- lib/klarna/checkout.rb
 - spec/acceptance/create_order_spec.rb
 - spec/acceptance/read_order_spec.rb
 - spec/fixtures/vcr_cassettes/create_order_spec.yml
@@ -190,7 +157,7 @@ files:
 - spec/support/matchers/have_attribute.rb
 - spec/support/matchers/have_many.rb
 - spec/support/matchers/have_one.rb
-homepage: ''
+homepage: https://github.com/Skalar/klarna-checkout-ruby
 licenses:
 - MIT
 metadata: {}

data/.gitignore

@@ -1,17 +0,0 @@
-*.gem
-*.rbc
-.bundle
-.config
-.yardoc
-Gemfile.lock
-InstalledFiles
-_yardoc
-coverage
-doc/
-lib/bundler/man
-pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp

data/.rspec

@@ -1 +0,0 @@
---color

data/Gemfile

@@ -1,4 +0,0 @@
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in klarna-checkout.gemspec
-gemspec

data/Guardfile

@@ -1,5 +0,0 @@
-guard :rspec, failed_mode: :none do
-  watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
-  watch('spec/spec_helper.rb')  { "spec" }
-end

data/Rakefile

@@ -1 +0,0 @@
-require "bundler/gem_tasks"

data/klarna-checkout.gemspec

@@ -1,32 +0,0 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'klarna/checkout/version'
-
-Gem::Specification.new do |spec|
-  spec.name          = "klarna-checkout"
-  spec.version       = Klarna::Checkout::VERSION
-  spec.authors       = ["Theodor Tonum"]
-  spec.email         = ["theodor@tonum.no"]
-  spec.description   = %q{Ruby Wrapper for Klarna Checkout Rest API}
-  spec.summary       = %q{...}
-  spec.homepage      = ""
-  spec.license       = "MIT"
-
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-
-  spec.add_dependency "faraday"
-  spec.add_dependency "activemodel"
-
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "guard"
-  spec.add_development_dependency "guard-rspec"
-  spec.add_development_dependency "webmock"
-  spec.add_development_dependency "vcr"
-  spec.add_development_dependency "shoulda-matchers"
-end