kithe 0.3.0 → 1.0.0

data/spec/factories/kithe_assets.rb

@@ -22,5 +22,13 @@ FactoryBot.define do
         end
       end
     end
+
+    # No bytestreams, but a derivative
+    trait :faked_derivatives do
+      derivatives {[
+        Kithe::Derivative.new(key: "one"),
+        Kithe::Derivative.new(key: "two")
+      ]}
+    end
   end
 end

data/spec/models/kithe/asset/asset_promotion_hooks_spec.rb

@@ -216,13 +216,13 @@ describe "Kithe::Asset promotion hooks", queue_adapter: :inline do
     it "can set from class attribute" do
       Kithe::Asset.promotion_directives = { promote: :inline }
       asset = Kithe::Asset.new
-      expect(asset.file_attacher.promotion_directives).to eq(promote: :inline)
+      expect(asset.file_attacher.promotion_directives).to eq("promote" => "inline")
     end
 
     it "can set from instance writer" do
       asset = Kithe::Asset.new
       asset.set_promotion_directives(promote: :inline)
-      expect(asset.file_attacher.promotion_directives).to eq(promote: :inline)
+      expect(asset.file_attacher.promotion_directives).to eq("promote" => "inline")
     end
   end
 end

data/spec/models/kithe/asset_spec.rb

@@ -192,5 +192,17 @@ RSpec.describe Kithe::Asset, type: :model do
       expect{ existing_derivative.reload }.to raise_error(ActiveRecord::RecordNotFound)
       expect(existing_stored_file.exists?).to be(false)
     end
+
+    it "allows derivative to be set on un-promoted file though" do
+      # mostly needed for testing scenarios, not otherwise expected.
+      filepath = Kithe::Engine.root.join("spec/test_support/images/1x1_pixel.jpg")
+      asset = Kithe::Asset.new(file: File.open(filepath), title: "test").tap do |a|
+        a.file_attacher.set_promotion_directives(skip_callbacks: true)
+      end
+      asset.derivatives << Kithe::Derivative.new(file: File.open(filepath), key: "test")
+      asset.save!
+      asset.reload
+      expect(asset.derivatives.count).to eq 1
+    end
   end
 end

data/spec/models/kithe/model_spec.rb

@@ -73,5 +73,24 @@ module Kithe
       end
     end
 
+    describe "with_representative_derivatives scope" do
+      let(:work) {
+        FactoryBot.create(:kithe_work, title: "test for preload",
+          members: [
+            FactoryBot.create(:kithe_work, representative: FactoryBot.create(:kithe_asset, :faked_derivatives)),
+            FactoryBot.create(:kithe_asset, :faked_derivatives),
+            FactoryBot.create(:kithe_asset, :faked_derivatives)
+          ])
+      }
+      it "pre-loads all representatives and derivatives" do
+        members = work.members.with_representative_derivatives.to_a
+
+        members.each do |member|
+          expect(member.association(:leaf_representative)).to be_loaded
+          expect(member.leaf_representative.association(:derivatives)).to be_loaded
+        end
+      end
+    end
+
   end
 end

data/spec/simple_form_enhancements/repeatable_input_generator_spec.rb

@@ -216,6 +216,24 @@ describe Kithe::RepeatableInputGenerator, type: :helper do
       expect(id_values.count).to eq(id_values.uniq.count)
     end
 
+    describe(:with_html_attributes) do
+      let(:generator) do
+        generator = nil
+        helper.simple_form_for(instance, url: "http://example/target") do |form|
+          generator = Kithe::RepeatableInputGenerator.new(form,
+            :string_array, nil,
+            html_attributes: { data: { foo: "bar" } } )
+        end
+        generator
+      end
+
+      it "has attributes on input" do
+        links = assert_select('input[name="test_work[string_array_attributes][]"]:not([type=hidden])')
+        expect(links.all? {|el| el['data-foo'] == "bar"}).to be(true)
+      end
+
+    end
+
     describe "build: :at_least_one" do
       let(:generator) do
         generator = nil

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kithe
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Jonathan Rochkind
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-13 00:00:00.000000000 Z
+date: 2019-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -48,16 +48,22 @@ dependencies:
   name: simple_form
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: shrine
   requirement: !ruby/object:Gem::Requirement
@@ -224,6 +230,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: dimensions
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -314,6 +334,7 @@ files:
 - app/models/kithe/model.rb
 - app/models/kithe/model_contains.rb
 - app/models/kithe/parameters.rb
+- app/models/kithe/timing_promotion_directive.rb
 - app/models/kithe/validators/model_parent.rb
 - app/models/kithe/work.rb
 - app/simple_form_enhancements/kithe/form_builder.rb
@@ -433,7 +454,7 @@ files:
 - spec/test_support/shrine_spec_support.rb
 - spec/test_support/temporary_class_for_specs.rb
 - spec/validators/array_inclusion_validator_spec.rb
-homepage: 
+homepage: https://github.com/sciencehistory/kithe
 licenses:
 - MIT
 metadata: {}
@@ -456,8 +477,7 @@ rubyforge_project:
 rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
-summary: An in-progress experiment in shareable tools/components for building a digital
-  collections app in Rails.
+summary: Shareable tools/components for building a digital collections app in Rails.
 test_files:
 - spec/derivative_transformers/ffmpeg_transformer_spec.rb
 - spec/derivative_transformers/vips_cli_image_to_jpeg_spec.rb