kitchen-vra 3.3.3 → 3.3.4

data/lib/kitchen/driver/vra_version.rb

@@ -18,8 +18,11 @@
 # limitations under the License.
 #
 
+# Test Kitchen's top-level namespace.
 module Kitchen
+  # Test Kitchen's driver plugins.
   module Driver
-    VRA_VERSION = "3.3.3"
+    # The version of the kitchen-vra gem.
+    VRA_VERSION = "3.3.4"
   end
 end

data/renovate.json

@@ -1,6 +1,8 @@
 {
   "$schema": "https://docs.renovatebot.com/renovate-schema.json",
   "extends": [
-    "config:recommended"
+    "config:recommended",
+    ":disableDependencyDashboard",
+    "schedule:automergeEarlyMondays"
   ]
 }

data/spec/vra_spec.rb

@@ -19,6 +19,8 @@
 #
 
 require "spec_helper"
+require "tmpdir"
+require "fileutils"
 require "kitchen/driver/vra"
 require "kitchen/provisioner/dummy"
 require "kitchen/transport/dummy"
@@ -447,7 +449,7 @@ describe Kitchen::Driver::Vra do
         }
       end
 
-      it "sets extra parmeters" do
+      it "sets extra parameters" do
         expect(catalog_request).to receive(:set_parameters).with("key1", { type: "string", value: "value1" })
         expect(catalog_request).to receive(:set_parameters).with("key2", { type: "integer", value: 123 })
         driver.catalog_request
@@ -510,4 +512,99 @@ describe Kitchen::Driver::Vra do
       end
     end
   end
+
+  describe "credential caching" do
+    let(:cache_dir)  { Dir.mktmpdir("kitchen-vra-spec") }
+    let(:cache_file) { File.join(cache_dir, ".kitchen", "cached_vra") }
+
+    # c_save/c_load address the cache by a path relative to the working
+    # directory, so each example runs inside a throwaway directory.
+    around do |example|
+      Dir.chdir(cache_dir) { example.run }
+    end
+
+    after { FileUtils.remove_entry(cache_dir) }
+
+    describe "#c_save" do
+      it "creates the cache file" do
+        driver.c_save
+        expect(File.exist?(cache_file)).to be true
+      end
+
+      it "creates the .kitchen directory when it does not exist" do
+        expect { driver.c_save }.to change { Dir.exist?(File.join(cache_dir, ".kitchen")) }.from(false).to(true)
+      end
+
+      it "writes the file readable only by its owner" do
+        driver.c_save
+        expect(File.stat(cache_file).mode & 0o777).to eq(0o600)
+      end
+
+      it "does not write the password in the clear" do
+        driver.c_save
+        expect(File.read(cache_file)).not_to include("mypassword")
+      end
+    end
+
+    describe "#c_load" do
+      it "restores credentials written by #c_save" do
+        driver.c_save
+
+        reader = Kitchen::Driver::Vra.new(config.reject { |k, _v| %i{username password}.include?(k) })
+        allow(reader).to receive(:instance).and_return(instance)
+        reader.c_load
+
+        expect(reader[:username]).to eq("myuser")
+        expect(reader[:password]).to eq("mypassword")
+      end
+
+      it "does nothing when no cache file exists" do
+        driver.c_load
+        expect(driver[:username]).to eq("myuser")
+      end
+
+      it "refuses a cache written against a different base_url" do
+        driver.c_save
+
+        other = Kitchen::Driver::Vra.new(config.merge(base_url: "https://other.corp.local")
+                                               .reject { |k, _v| %i{username password}.include?(k) })
+        allow(other).to receive(:instance).and_return(instance)
+        expect(other).to receive(:warn).with(/Failed to load cached credentials/)
+        other.c_load
+
+        expect(other[:username]).to be_nil
+        expect(other[:password]).to be_nil
+      end
+
+      it "refuses a corrupted cache rather than returning garbage" do
+        driver.c_save
+        File.write(cache_file, File.read(cache_file).succ)
+
+        loader = Kitchen::Driver::Vra.new(config.reject { |k, _v| %i{username password}.include?(k) })
+        allow(loader).to receive(:instance).and_return(instance)
+        expect(loader).to receive(:warn).with(/Failed to load cached credentials/)
+        loader.c_load
+
+        expect(loader[:username]).to be_nil
+      end
+    end
+
+    describe "#check_config" do
+      it "uses the cache instead of prompting" do
+        driver.c_save
+
+        reader = Kitchen::Driver::Vra.new(config.reject { |k, _v| %i{username password}.include?(k) })
+        allow(reader).to receive(:instance).and_return(instance)
+        allow(ENV).to receive(:[]).and_call_original
+        allow(ENV).to receive(:[]).with("VRA_USER_NAME").and_return(nil)
+        allow(ENV).to receive(:[]).with("VRA_USER_PASSWORD").and_return(nil)
+        expect(reader).not_to receive(:ask)
+
+        reader.check_config
+
+        expect(reader[:username]).to eq("myuser")
+        expect(reader[:password]).to eq("mypassword")
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kitchen-vra
 version: !ruby/object:Gem::Version
-  version: 3.3.3
+  version: 3.3.4
 platform: ruby
 authors:
-- Chef Commmunity Tools Team
+- Chef Community Tools Team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-06-27 00:00:00.000000000 Z
+date: 2026-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: test-kitchen
@@ -106,14 +106,16 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/CODEOWNERS"
-- ".github/dependabot.yml"
 - ".github/workflows/linters.yml"
 - ".github/workflows/publish.yml"
 - ".gitignore"
 - ".markdownlint.yaml"
 - ".release-please-manifest.json"
 - ".rubocop.yml"
+- ".yamllint"
+- ".yardopts"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -144,10 +146,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: A Test Kitchen driver for VMware vRealize Automation (vRA)
-test_files:
-- spec/spec_helper.rb
-- spec/vra_spec.rb
+test_files: []

data/.github/dependabot.yml

@@ -1,8 +0,0 @@
----
-version: 2
-updates:
-  - package-ecosystem: bundler
-    directory: "/"
-    schedule:
-      interval: daily
-    open-pull-requests-limit: 10