kitchen-rackspace 0.21.2 → 0.22.1

data/spec/kitchen/driver/rackspace/server_name_spec.rb

@@ -0,0 +1,63 @@
+RSpec.describe Kitchen::Driver::Rackspace do
+  include_context "a driver for an instance"
+
+  describe "#default_name" do
+    subject(:name) { driver.default_name }
+
+    let(:login) { "user" }
+    let(:hostname) { "host" }
+
+    before do
+      allow(Etc).to receive(:getlogin).and_return(login)
+      allow(Socket).to receive(:gethostname).and_return(hostname)
+    end
+
+    it "generates a name" do
+      expect(name).to match(/^potatoes-user-host-(\S*)/)
+    end
+
+    context "a local node with a long hostname" do
+      let(:hostname) { "ab.c" * 20 }
+
+      it "limits the generated name to 63 characters" do
+        expect(name.length).to be <= 63
+      end
+    end
+
+    context "a long hostname, username, and base name" do
+      let(:login) { "abcd" * 20 }
+      let(:hostname) { "efgh" * 20 }
+      let(:instance_name) { "ijkl" * 20 }
+
+      it "limits the generated name to 63 characters" do
+        expect(name.length).to eq(63)
+      end
+    end
+
+    context "a login and hostname with punctuation in them" do
+      let(:login) { "some.u-se-r" }
+      let(:hostname) { "a.host-name" }
+      let(:instance_name) { "a.instance-name" }
+
+      it "strips out the dots to prevent bad server names" do
+        expect(name).to_not include(".")
+      end
+
+      it "strips out all but the three hyphen separators" do
+        expect(name.count("-")).to eq(3)
+      end
+    end
+
+    context "a non-login shell" do
+      let(:login) { nil }
+
+      it "subs in a placeholder login string" do
+        expect(name).to match(/^potatoes-nologin-/)
+      end
+    end
+
+    it "does not repeat itself" do
+      expect(driver.default_name).to_not eq(driver.default_name)
+    end
+  end
+end

data/spec/kitchen/driver/rackspace/status_spec.rb

@@ -0,0 +1,151 @@
+RSpec.describe Kitchen::Driver::Rackspace do
+  include_context "a driver for an instance"
+
+  describe "#status" do
+    let(:server) { double("server", state: "ACTIVE") }
+    let(:servers) { instance_double(Fog::Compute::RackspaceV2::Servers) }
+
+    before do
+      allow_any_instance_of(described_class).to receive(:compute)
+        .and_return(double("compute", servers:))
+    end
+
+    context "with no server in state" do
+      it "reports an unknown status" do
+        expect(driver.status({})).to include(live: nil, state: "unknown")
+      end
+    end
+
+    context "with a server Rackspace does not know" do
+      it "reports an unknown status" do
+        expect(servers).to receive(:get).with("gone").and_return(nil)
+
+        expect(driver.status(server_id: "gone")).to include(state: "unknown")
+      end
+    end
+
+    context "with a live server" do
+      before do
+        allow(servers).to receive(:get).with("12345").and_return(server)
+      end
+
+      it "reports the server as live" do
+        expect(driver.status(server_id: "12345")).to include(
+          live: true,
+          state: "ACTIVE",
+          source: "driver",
+          resource_id: "12345"
+        )
+      end
+
+      it "stamps when the check happened" do
+        expect(driver.status(server_id: "12345")[:checked_at])
+          .to match(/\A\d{4}-\d{2}-\d{2}T/)
+      end
+    end
+
+    context "with a server that is not active" do
+      it "reports the server as not live" do
+        allow(servers).to receive(:get)
+          .with("12345").and_return(double("server", state: "ERROR"))
+
+        expect(driver.status(server_id: "12345"))
+          .to include(live: false, state: "ERROR")
+      end
+    end
+
+    context "when Rackspace cannot be reached" do
+      it "reports an unknown status rather than raising" do
+        allow(servers).to receive(:get)
+          .and_raise(Fog::Errors::Error.new("boom"))
+
+        expect(driver.status(server_id: "12345")).to include(state: "unknown")
+      end
+
+      it "survives an Excon error too" do
+        allow(servers).to receive(:get)
+          .and_raise(Excon::Errors::SocketError.new(StandardError.new("nope")))
+
+        expect(driver.status(server_id: "12345")).to include(state: "unknown")
+      end
+    end
+  end
+
+  describe "#doctor" do
+    let(:config) do
+      { image_id: "img-1", public_key_path: "/home/user/.ssh/id_rsa.pub" }
+    end
+    let(:servers) do
+      instance_double(Fog::Compute::RackspaceV2::Servers, all: [])
+    end
+
+    before do
+      allow(driver).to receive(:compute)
+        .and_return(double("compute", servers:))
+    end
+
+    it "reports no problem when the configuration is complete" do
+      expect(driver.doctor(state)).to eq(false)
+    end
+
+    # `summary` is not a method fog-rackspace has. Stubbing the collection with
+    # a verifying double is what keeps that mistake from coming back.
+    it "asks Rackspace for something fog actually implements" do
+      driver.doctor(state)
+
+      expect(servers).to have_received(:all)
+    end
+
+    context "with no resolvable image" do
+      let(:config) { { public_key_path: "/key.pub" } }
+
+      it "reports a problem" do
+        allow(driver).to receive(:default_image).and_return(nil)
+
+        expect(driver.doctor(state)).to eq(true)
+        expect(logged_output.string).to match(/No image_id is set/)
+      end
+    end
+
+    context "with no public key" do
+      let(:config) { { image_id: "img-1", public_key_path: nil } }
+
+      it "reports a problem" do
+        expect(driver.doctor(state)).to eq(true)
+        expect(logged_output.string).to match(/No public key was found/)
+      end
+    end
+
+    context "with credentials Rackspace rejects" do
+      it "reports a problem" do
+        allow(driver).to receive(:compute)
+          .and_raise(Fog::Errors::Error.new("unauthorized"))
+
+        expect(driver.doctor(state)).to eq(true)
+        expect(logged_output.string)
+          .to match(/rejected the configured credentials/)
+      end
+
+      it "names the region it tried" do
+        config[:rackspace_region] = "ord"
+        allow(driver).to receive(:compute)
+          .and_raise(Fog::Errors::Error.new("unauthorized"))
+
+        driver.doctor(state)
+
+        expect(logged_output.string).to match(/region ord/)
+      end
+    end
+
+    it "reports every problem it finds, not just the first" do
+      config.delete(:image_id)
+      config[:public_key_path] = nil
+      allow(driver).to receive(:default_image).and_return(nil)
+
+      driver.doctor(state)
+
+      expect(logged_output.string).to match(/No image_id is set/)
+      expect(logged_output.string).to match(/No public key was found/)
+    end
+  end
+end

data/spec/kitchen/driver/rackspace/tcp_check_spec.rb

@@ -0,0 +1,37 @@
+RSpec.describe Kitchen::Driver::Rackspace do
+  include_context "a driver for an instance"
+
+  describe "#tcp_check" do
+    before do
+      allow_any_instance_of(described_class).to receive(:wait_for_sshd)
+      allow_any_instance_of(described_class).to receive(:sleep)
+    end
+
+    context "the default non-skipping behavior" do
+      it "uses Kitchen's own SSH check" do
+        expect(driver).to receive(:wait_for_sshd).with(state)
+        expect(driver).to_not receive(:sleep)
+
+        driver.send(:tcp_check, state)
+      end
+    end
+
+    context "a config set to wait instead of TCP check" do
+      let(:config) { { no_ssh_tcp_check: true } }
+
+      it "uses a sleep instead of a port check" do
+        expect(driver).to_not receive(:wait_for_sshd)
+        expect(driver).to receive(:sleep)
+
+        driver.send(:tcp_check, state)
+      end
+
+      it "sleeps for the configured number of seconds" do
+        config[:no_ssh_tcp_check_sleep] = 42
+        expect(driver).to receive(:sleep).with(42)
+
+        driver.send(:tcp_check, state)
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,12 +1,28 @@
-require "rake"
-require "rspec"
 require "logger"
 require "stringio" unless defined?(StringIO)
 require "kitchen"
 
 require_relative "../lib/kitchen/driver/rackspace"
+
+# `require "fog/rackspace"` only registers the services; it does not load the
+# model classes. Load the ones the specs verify doubles against, so that a
+# stubbed method which fog does not actually implement fails the example
+# instead of quietly passing.
+require "fog/rackspace/models/compute_v2/servers"
+
+Dir[File.expand_path("support/**/*.rb", __dir__)].sort.each { |f| require f }
+
 RSpec.configure do |config|
-  config.run_all_when_everything_filtered = true
-  config.filter_run(:focus)
-  config.order = "random"
+  config.disable_monkey_patching!
+  config.filter_run_when_matching :focus
+  config.order = :random
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
 end

data/spec/support/driver_context.rb

@@ -0,0 +1,51 @@
+# Everything a driver needs to exist outside a real Test Kitchen run: an
+# instance to belong to, a logger to talk to, and a config hash to read.
+#
+# Individual example groups override `config`, `platform_name`, and
+# `instance_name` with `let` to describe the situation under test.
+RSpec.shared_context "a driver for an instance" do
+  let(:logged_output) { StringIO.new }
+  let(:logger) { Logger.new(logged_output) }
+  let(:config) { {} }
+  let(:state) { {} }
+  let(:platform_name) { "ubuntu" }
+  let(:instance_name) { "potatoes" }
+
+  let(:instance) do
+    double("instance",
+           name: instance_name,
+           logger:,
+           to_str: "instance",
+           platform: double("platform", name: platform_name))
+  end
+
+  let(:driver) { described_class.new(config) }
+
+  before do
+    allow_any_instance_of(described_class).to receive(:instance)
+      .and_return(instance)
+    ENV["RACKSPACE_USERNAME"] = "user"
+    ENV["RACKSPACE_API_KEY"] = "key"
+  end
+end
+
+# A server that has finished building and is reachable, as `#create` sees it.
+RSpec.shared_context "a built server" do
+  let(:server) do
+    double("server",
+           id: "test123",
+           wait_for: true,
+           update: nil,
+           public_ip_address: "1.2.3.4",
+           private_ip_address: "10.9.8.7")
+  end
+
+  before do
+    allow_any_instance_of(described_class).to receive(:default_name)
+      .and_return("a_monkey!")
+    allow_any_instance_of(described_class).to receive(:create_server)
+      .and_return(server)
+    allow_any_instance_of(described_class).to receive(:tcp_check)
+      .and_return(true)
+  end
+end

data/spec/support/rackspace_environment.rb

@@ -0,0 +1,27 @@
+# The driver reads its credentials and its region straight out of the
+# environment, and several examples set those variables to prove it. Without
+# this the values leak from one example into the next, and out of the suite
+# into whatever else the process goes on to do.
+RACKSPACE_ENVIRONMENT_VARIABLES = %w{
+  RACKSPACE_USERNAME
+  RACKSPACE_API_KEY
+  RACKSPACE_REGION
+  OS_USERNAME
+  OS_PASSWORD
+  OS_REGION_NAME
+}.freeze
+
+RSpec.configure do |config|
+  config.around do |example|
+    saved = RACKSPACE_ENVIRONMENT_VARIABLES.to_h { |name| [name, ENV.fetch(name, nil)] }
+    RACKSPACE_ENVIRONMENT_VARIABLES.each { |name| ENV.delete(name) }
+
+    begin
+      example.run
+    ensure
+      saved.each do |name, value|
+        value.nil? ? ENV.delete(name) : ENV[name] = value
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kitchen-rackspace
 version: !ruby/object:Gem::Version
-  version: 0.21.2
+  version: 0.22.1
 platform: ruby
 authors:
 - Jonathan Hartman
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-08-22 00:00:00.000000000 Z
+date: 2026-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fog-rackspace
@@ -33,7 +33,7 @@ dependencies:
         version: '1.35'
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.6.1
+        version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -43,14 +43,14 @@ dependencies:
         version: '1.35'
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.6.1
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: test-kitchen
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '3.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
@@ -60,7 +60,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '3.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
@@ -72,30 +72,44 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/CODEOWNERS"
-- ".github/dependabot.yml"
 - ".github/workflows/linters.yml"
 - ".github/workflows/publish.yaml"
 - ".gitignore"
 - ".markdownlint.yaml"
 - ".release-please-manifest.json"
+- ".rspec"
 - ".rubocop.yml"
+- ".yamllint"
+- ".yardopts"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - data/images.json
+- helpers/dump_flavor_list.rb
 - helpers/dump_image_list.rb
 - kitchen-rackspace.gemspec
 - lib/kitchen/driver/rackspace.rb
 - lib/kitchen/driver/rackspace_version.rb
 - release-please-config.json
 - renovate.json
-- spec/kitchen/driver/rackspace_spec.rb
+- spec/kitchen/driver/rackspace/compute_spec.rb
+- spec/kitchen/driver/rackspace/configuration_spec.rb
+- spec/kitchen/driver/rackspace/create_spec.rb
+- spec/kitchen/driver/rackspace/destroy_spec.rb
+- spec/kitchen/driver/rackspace/image_spec.rb
+- spec/kitchen/driver/rackspace/plugin_spec.rb
+- spec/kitchen/driver/rackspace/server_name_spec.rb
+- spec/kitchen/driver/rackspace/status_spec.rb
+- spec/kitchen/driver/rackspace/tcp_check_spec.rb
 - spec/spec_helper.rb
+- spec/support/driver_context.rb
+- spec/support/rackspace_environment.rb
 homepage: https://github.com/test-kitchen/kitchen-rackspace
 licenses:
-- Apache
+- Apache-2.0
 metadata: {}
 post_install_message:
 rdoc_options: []
@@ -116,6 +130,4 @@ rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: A Test Kitchen Rackspace driver built on Fog
-test_files:
-- spec/kitchen/driver/rackspace_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/.github/dependabot.yml

@@ -1,8 +0,0 @@
----
-version: 2
-updates:
-  - package-ecosystem: bundler
-    directory: "/"
-    schedule:
-      interval: daily
-    open-pull-requests-limit: 10