kitchen-puppet 0.0.16 → 0.0.17

data/lib/kitchen/provisioner/puppet_apply.rb

@@ -25,11 +25,9 @@ require 'kitchen/provisioner/base'
 require 'kitchen/provisioner/puppet/librarian'
 
 module Kitchen
-
   class Busser
-
     def non_suite_dirs
-      %w{data data_bags environments nodes roles puppet}
+      %w(data data_bags environments nodes roles puppet)
     end
   end
 
@@ -41,7 +39,7 @@ module Kitchen
       attr_accessor :tmp_dir
 
       default_config :require_puppet_omnibus, false
-      # TODO use something like https://github.com/fnichol/omnibus-puppet
+      # TODO: use something like https://github.com/fnichol/omnibus-puppet
       default_config :puppet_omnibus_url, nil
       default_config :puppet_omnibus_remote_path, '/opt/puppet'
       default_config :puppet_version, nil
@@ -49,9 +47,9 @@ module Kitchen
       default_config :require_chef_for_busser, true
       default_config :resolve_with_librarian_puppet, true
       default_config :puppet_environment, nil
-      default_config :puppet_apt_repo, "http://apt.puppetlabs.com/puppetlabs-release-precise.deb"
-      default_config :puppet_yum_repo, "https://yum.puppetlabs.com/puppetlabs-release-el-6.noarch.rpm"
-      default_config :chef_bootstrap_url, "https://www.getchef.com/chef/install.sh"
+      default_config :puppet_apt_repo, 'http://apt.puppetlabs.com/puppetlabs-release-precise.deb'
+      default_config :puppet_yum_repo, 'https://yum.puppetlabs.com/puppetlabs-release-el-6.noarch.rpm'
+      default_config :chef_bootstrap_url, 'https://www.getchef.com/chef/install.sh'
 
       default_config :puppet_apply_command, nil
 
@@ -59,14 +57,14 @@ module Kitchen
       default_config :manifest, 'site.pp'
 
       default_config :manifests_path do |provisioner|
-        provisioner.calculate_path('manifests') or
-          raise 'No manifests_path detected. Please specify one in .kitchen.yml'
+        provisioner.calculate_path('manifests') ||
+          fail('No manifests_path detected. Please specify one in .kitchen.yml')
       end
 
       default_config :modules_path do |provisioner|
         modules_path = provisioner.calculate_path('modules')
         if modules_path.nil? && provisioner.calculate_path('Puppetfile', :file).nil?
-          raise 'No modules_path detected. Please specify one in .kitchen.yml'
+          fail 'No modules_path detected. Please specify one in .kitchen.yml'
         end
         modules_path
       end
@@ -78,7 +76,7 @@ module Kitchen
       default_config :hiera_data_path do |provisioner|
         provisioner.calculate_path('hiera')
       end
-      
+
       default_config :puppet_config_path do |provisioner|
         provisioner.calculate_path('puppet.conf', :file)
       end
@@ -107,7 +105,6 @@ module Kitchen
         provisioner.calculate_path('manifests', :directory)
       end
 
-
       default_config :puppet_debug, false
       default_config :puppet_verbose, false
       default_config :puppet_noop, false
@@ -115,14 +112,15 @@ module Kitchen
       default_config :update_package_repos, true
       default_config :remove_puppet_repo, false
       default_config :custom_facts, {}
+      default_config :facter_file, nil
       default_config :librarian_puppet_ssl_file, nil
-      
+
       default_config :hiera_eyaml, false
       default_config :hiera_eyaml_key_remote_path, '/etc/puppet/secure/keys'
-      
+
       default_config :hiera_eyaml_key_path do |provisioner|
-         provisioner.calculate_path('hiera_keys')
-      end 
+        provisioner.calculate_path('hiera_keys')
+      end
 
       def calculate_path(path, type = :directory)
         base = config[:test_base_path]
@@ -137,14 +135,16 @@ module Kitchen
         end
       end
 
+      # TODO: refactor for smaller cyclomatic complexity and perceived complexity
+      # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
       def install_command
-        return unless config[:require_puppet_omnibus] or config[:require_puppet_repo]
+        return unless config[:require_puppet_omnibus] || config[:require_puppet_repo]
         if config[:require_puppet_omnibus]
-          info("Installing puppet using puppet omnibus")
-          version = if !config[:puppet_version].nil?
-            "-v #{config[:puppet_version]}"
+          info('Installing puppet using puppet omnibus')
+          if !config[:puppet_version].nil?
+            version = "-v #{config[:puppet_version]}"
           else
-            ""
+            version = ''
           end
           <<-INSTALL
           #{Util.shell_helpers}
@@ -158,72 +158,72 @@ module Kitchen
           INSTALL
         else
           case puppet_platform
-          when "debian", "ubuntu"
-          info("Installing puppet on #{puppet_platform}")
-          <<-INSTALL
-          if [ ! $(which puppet) ]; then
-            #{sudo('wget')} #{puppet_apt_repo}
-            #{sudo('dpkg')} -i #{puppet_apt_repo_file}
-            #{update_packages_debian_cmd}
-            #{sudo('apt-get')} -y install puppet-common#{puppet_debian_version}
-            #{sudo('apt-get')} -y install puppet#{puppet_debian_version}
-          fi
-          #{install_busser}
-          INSTALL
-                 when "redhat", "centos", "fedora"
-                  info("Installing puppet on #{puppet_platform}")
-          <<-INSTALL
-          if [ ! $(which puppet) ]; then
-            #{sudo('rpm')} -ivh #{puppet_yum_repo}
-                    #{update_packages_redhat_cmd}
-            #{sudo('yum')} -y install puppet#{puppet_redhat_version}
-          fi
-          #{install_busser}
-          INSTALL
-         else
-          info("Installing puppet, will try to determine platform os")
-          <<-INSTALL
-          if [ ! $(which puppet) ]; then
-            if [ -f /etc/centos-release ] || [ -f /etc/redhat-release ] || [ -f /etc/oracle-release ]; then
-               #{sudo('rpm')} -ivh #{puppet_yum_repo}
-               #{update_packages_redhat_cmd}
-               #{sudo('yum')} -y install puppet#{puppet_redhat_version}
-            else
-               if [ -f /etc/system-release ] || [ grep -q 'Amazon Linux' /etc/system-release ]; then 
+          when 'debian', 'ubuntu'
+            info("Installing puppet on #{puppet_platform}")
+            <<-INSTALL
+              if [ ! $(which puppet) ]; then
+                #{sudo('wget')} #{puppet_apt_repo}
+                #{sudo('dpkg')} -i #{puppet_apt_repo_file}
+                #{update_packages_debian_cmd}
+                #{sudo('apt-get')} -y install puppet-common#{puppet_debian_version}
+                #{sudo('apt-get')} -y install puppet#{puppet_debian_version}
+              fi
+              #{install_busser}
+            INSTALL
+          when 'redhat', 'centos', 'fedora'
+            info("Installing puppet on #{puppet_platform}")
+            <<-INSTALL
+              if [ ! $(which puppet) ]; then
+                #{sudo('rpm')} -ivh #{puppet_yum_repo}
+                #{update_packages_redhat_cmd}
+                #{sudo('yum')} -y install puppet#{puppet_redhat_version}
+              fi
+              #{install_busser}
+            INSTALL
+          else
+            info('Installing puppet, will try to determine platform os')
+            <<-INSTALL
+              if [ ! $(which puppet) ]; then
+                if [ -f /etc/centos-release ] || [ -f /etc/redhat-release ] || [ -f /etc/oracle-release ]; then
                   #{sudo('rpm')} -ivh #{puppet_yum_repo}
                   #{update_packages_redhat_cmd}
-                  #{sudo('yum')} -y install puppet#{puppet_redhat_version}            
-               else
-                  #{sudo('wget')} #{puppet_apt_repo}
-                  #{sudo('dpkg')} -i #{puppet_apt_repo_file}
-                  #{update_packages_debian_cmd}
-                  #{sudo('apt-get')} -y install puppet-common#{puppet_debian_version}
-                  #{sudo('apt-get')} -y install puppet#{puppet_debian_version}
-               fi   
-            fi
-          fi
-          #{install_eyaml}
-          #{install_busser}
-          INSTALL
-         end
+                  #{sudo('yum')} -y install puppet#{puppet_redhat_version}
+                else
+                  if [ -f /etc/system-release ] || [ grep -q 'Amazon Linux' /etc/system-release ]; then
+                    #{sudo('rpm')} -ivh #{puppet_yum_repo}
+                    #{update_packages_redhat_cmd}
+                    #{sudo('yum')} -y install puppet#{puppet_redhat_version}
+                  else
+                    #{sudo('wget')} #{puppet_apt_repo}
+                    #{sudo('dpkg')} -i #{puppet_apt_repo_file}
+                    #{update_packages_debian_cmd}
+                    #{sudo('apt-get')} -y install puppet-common#{puppet_debian_version}
+                    #{sudo('apt-get')} -y install puppet#{puppet_debian_version}
+                  fi
+                fi
+              fi
+              #{install_eyaml}
+              #{install_busser}
+            INSTALL
+          end
         end
       end
-      
-     def install_eyaml
-	if config[:hiera_eyaml]
-          <<-INSTALL
+      # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+
+      def install_eyaml
+        return unless config[:hiera_eyaml]
+        <<-INSTALL
           # A backend for Hiera that provides per-value asymmetric encryption of sensitive data
-          if [[ $(#{sudo('gem')} list hiera-eyaml -i) == 'false' ]]; then 
+          if [[ $(#{sudo('gem')} list hiera-eyaml -i) == 'false' ]]; then
             echo "-----> Installing hiera-eyaml to provide encryption of hiera data"
             #{sudo('gem')} install --no-ri --no-rdoc hiera-eyaml
-          fi 
-          INSTALL
-        end
-      end            
+          fi
+        INSTALL
+      end
 
       def install_busser
-	    if config[:require_chef_for_busser]
-          <<-INSTALL
+        return unless config[:require_chef_for_busser]
+        <<-INSTALL
           #{Util.shell_helpers}
           # install chef omnibus so that busser works as this is needed to run tests :(
           # TODO: work out how to install enough ruby
@@ -235,390 +235,393 @@ module Kitchen
             do_download #{chef_url} /tmp/install.sh
             #{sudo('sh')} /tmp/install.sh
           fi
-          INSTALL
+        INSTALL
+      end
+
+      def init_command
+        dirs = %w(modules manifests files hiera hiera.yaml)
+        .map { |dir| File.join(config[:root_path], dir) }.join(' ')
+        cmd = "#{sudo('rm')} -rf #{dirs} #{hiera_data_remote_path} /etc/hiera.yaml /etc/puppet/hiera.yaml /etc/puppet/fileserver.conf;"
+        cmd += " mkdir -p #{config[:root_path]}"
+        debug(cmd)
+        cmd
+      end
+
+      def create_sandbox
+        super
+        debug("Creating local sandbox in #{sandbox_path}")
+        yield if block_given?
+        prepare_modules
+        prepare_manifests
+        prepare_files
+        prepare_puppet_config
+        prepare_hiera_config
+        prepare_fileserver_config
+        prepare_hiera_data
+        info('Finished Preparing files for transfer')
+      end
+
+      def cleanup_sandbox
+        return if sandbox_path.nil?
+        debug("Cleaning up local sandbox in #{sandbox_path}")
+        FileUtils.rmtree(sandbox_path)
+      end
+
+      # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+      def prepare_command
+        commands = []
+        if puppet_config
+          commands << [
+            sudo('cp'),
+            File.join(config[:root_path], 'puppet.conf'),
+            '/etc/puppet'
+          ].join(' ')
         end
-	  end	
-		  
-		  
-
-        def init_command
-          dirs = %w{modules manifests files hiera hiera.yaml}.
-          map { |dir| File.join(config[:root_path], dir) }.join(" ")
-          cmd = "#{sudo('rm')} -rf #{dirs} #{hiera_data_remote_path} /etc/hiera.yaml /etc/puppet/hiera.yaml /etc/puppet/fileserver.conf;"
-          cmd = cmd+" mkdir -p #{config[:root_path]}"
-          debug(cmd)
-          cmd
+
+        if hiera_config
+          commands << [
+            sudo('cp'), File.join(config[:root_path], 'hiera.yaml'), '/etc/'
+          ].join(' ')
+
+          commands << [
+            sudo('cp'), File.join(config[:root_path], 'hiera.yaml'), '/etc/puppet/'
+          ].join(' ')
         end
 
-        def create_sandbox
-          super
-          debug("Creating local sandbox in #{sandbox_path}")
+        if fileserver_config
+          commands << [
+            sudo('cp'),
+            File.join(config[:root_path], 'fileserver.conf'),
+            '/etc/puppet'
+          ].join(' ')
+        end
 
-          yield if block_given?
+        if hiera_data && hiera_data_remote_path == '/var/lib/hiera'
+          commands << [
+            sudo('cp -r'), File.join(config[:root_path], 'hiera'), '/var/lib/'
+          ].join(' ')
+        end
 
-          prepare_modules
-          prepare_manifests
-          prepare_files
-          prepare_puppet_config
-          prepare_hiera_config
-          prepare_fileserver_config
-          prepare_hiera_data
-          info('Finished Preparing files for transfer')
+        if hiera_data && hiera_data_remote_path != '/var/lib/hiera'
+          commands << [
+            sudo('mkdir -p'), hiera_data_remote_path
+          ].join(' ')
+          commands << [
+            sudo('cp -r'), File.join(config[:root_path], 'hiera/*'), hiera_data_remote_path
+          ].join(' ')
+        end
 
+        if hiera_eyaml
+          commands << [
+            sudo('mkdir -p'), hiera_eyaml_key_remote_path
+          ].join(' ')
+          commands << [
+            sudo('cp -r'), File.join(config[:root_path], 'hiera_keys/*'), hiera_eyaml_key_remote_path
+          ].join(' ')
         end
 
-        def cleanup_sandbox
-          return if sandbox_path.nil?
-          debug("Cleaning up local sandbox in #{sandbox_path}")
-          FileUtils.rmtree(sandbox_path)
+        command = commands.join(' && ')
+        debug(command)
+        command
+      end
+      # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+
+      def run_command
+        if !config[:puppet_apply_command].nil?
+          return config[:puppet_apply_command]
+        else
+          [
+            custom_facts,
+            facter_facts,
+            sudo('puppet'),
+            'apply',
+            File.join(config[:root_path], 'manifests', manifest),
+            "--modulepath=#{File.join(config[:root_path], 'modules')}",
+            "--manifestdir=#{File.join(config[:root_path], 'manifests')}",
+            "--fileserverconfig=#{File.join(config[:root_path], 'fileserver.conf')}",
+            puppet_environment_flag,
+            puppet_noop_flag,
+            puppet_verbose_flag,
+            puppet_debug_flag,
+            remove_repo
+          ].join(' ')
         end
-        
-        def prepare_command
-          commands = []
-
-          if puppet_config
-            commands << [
-              sudo('cp'),
-              File.join(config[:root_path], 'puppet.conf'),
-              '/etc/puppet',
-            ].join(' ')
-          end
+      end
 
-          if hiera_config
-            commands << [
-              sudo('cp'), File.join(config[:root_path],'hiera.yaml'), '/etc/',
-            ].join(' ')
+      protected
 
-            commands << [
-              sudo('cp'), File.join(config[:root_path],'hiera.yaml'), '/etc/puppet/',
-            ].join(' ')
-          end
+      def load_needed_dependencies!
+        return unless File.exist?(puppetfile)
+        return unless config[:resolve_with_librarian_puppet]
+        debug("Puppetfile found at #{puppetfile}, loading Librarian-Puppet")
+        Puppet::Librarian.load!(logger)
+      end
 
-          if fileserver_config
-            commands << [
-              sudo('cp'),
-              File.join(config[:root_path], 'fileserver.conf'),
-              '/etc/puppet',
-            ].join(' ')
-          end
+      def tmpmodules_dir
+        File.join(sandbox_path, 'modules')
+      end
 
-          if hiera_data and hiera_data_remote_path == '/var/lib/hiera'
-            commands << [
-              sudo('cp -r'), File.join(config[:root_path], 'hiera'), '/var/lib/'
-            ].join(' ')
-          end
+      def puppetfile
+        config[:puppetfile_path] || ''
+      end
 
-          if hiera_data and hiera_data_remote_path != '/var/lib/hiera'
-            commands << [
-              sudo('mkdir -p'), hiera_data_remote_path
-            ].join(' ')
-            commands << [
-              sudo('cp -r'), File.join(config[:root_path], 'hiera/*'), hiera_data_remote_path
-            ].join(' ')
-          end
+      def modulefile
+        config[:modulefile_path] || ''
+      end
 
-          if hiera_eyaml 
-            commands << [
-              sudo('mkdir -p'), hiera_eyaml_key_remote_path
-            ].join(' ')
-            commands << [
-              sudo('cp -r'), File.join(config[:root_path], 'hiera_keys/*'), hiera_eyaml_key_remote_path
-            ].join(' ')
-          end
+      def metadata_json
+        config[:metadata_json_path] || ''
+      end
 
-          command = commands.join(' && ')
-          debug(command)
-          command
-        end
+      def manifest
+        config[:manifest]
+      end
 
-        def run_command
-          if !config[:puppet_apply_command].nil?
-             return config[:puppet_apply_command]
-          else
-            [
-              custom_facts,
-              sudo('puppet'),
-              'apply',
-              File.join(config[:root_path], 'manifests', manifest),
-              "--modulepath=#{File.join(config[:root_path], 'modules')}",
-              "--manifestdir=#{File.join(config[:root_path], 'manifests')}",
-              "--fileserverconfig=#{File.join(config[:root_path], 'fileserver.conf')}",
-              puppet_environment_flag,
-              puppet_noop_flag,
-              puppet_verbose_flag,
-              puppet_debug_flag,
-              remove_repo
-            ].join(" ")
-          end
-        end
+      def manifests
+        config[:manifests_path]
+      end
 
-        protected
+      def modules
+        config[:modules_path]
+      end
 
-        def load_needed_dependencies!
-          if File.exists?(puppetfile) and config[:resolve_with_librarian_puppet]
-            debug("Puppetfile found at #{puppetfile}, loading Librarian-Puppet")
-            Puppet::Librarian.load!(logger)
-          end
-        end
+      def files
+        config[:files_path] || 'files'
+      end
 
-        def tmpmodules_dir
-          File.join(sandbox_path, 'modules')
-        end
+      def puppet_config
+        config[:puppet_config_path]
+      end
 
-        def puppetfile
-          config[:puppetfile_path] or ''
-        end
+      def puppet_environment
+        config[:puppet_environment]
+      end
 
-        def modulefile
-          config[:modulefile_path] or ''
-        end
+      def hiera_config
+        config[:hiera_config_path]
+      end
 
-        def metadata_json
-          config[:metadata_json_path] or ''
-        end
+      def fileserver_config
+        config[:fileserver_config_path]
+      end
 
-        def manifest
-          config[:manifest]
-        end
+      def hiera_data
+        config[:hiera_data_path]
+      end
 
-        def manifests
-          config[:manifests_path]
-        end
+      def hiera_data_remote_path
+        config[:hiera_data_remote_path]
+      end
 
-        def modules
-          config[:modules_path]
-        end
+      def hiera_eyaml
+        config[:hiera_eyaml]
+      end
 
-        def files
-          config[:files_path] || 'files'
-        end
+      def hiera_eyaml_key_path
+        config[:hiera_eyaml_key_path]
+      end
 
-        def puppet_config
-          config[:puppet_config_path]
-        end
-        
-        def puppet_environment
-          config[:puppet_environment]
-        end
-        
-        def hiera_config
-          config[:hiera_config_path]
-        end
+      def hiera_eyaml_key_remote_path
+        config[:hiera_eyaml_key_remote_path]
+      end
 
-        def fileserver_config
-          config[:fileserver_config_path]
-        end
+      def librarian_puppet_ssl_file
+        config[:librarian_puppet_ssl_file]
+      end
 
-        def hiera_data
-          config[:hiera_data_path]
-        end
+      def puppet_debian_version
+        config[:puppet_version] ? "=#{config[:puppet_version]}" : nil
+      end
 
-        def hiera_data_remote_path
-          config[:hiera_data_remote_path]
-        end
-        
-        def hiera_eyaml
-	  config[:hiera_eyaml]
-	end        
-        
-        def hiera_eyaml_key_path
-	  config[:hiera_eyaml_key_path]
-	end
-
-        def hiera_eyaml_key_remote_path
-	  config[:hiera_eyaml_key_remote_path]
-	end
-
-        def librarian_puppet_ssl_file
-	  config[:librarian_puppet_ssl_file]
-	end
-
-        def puppet_debian_version
-          config[:puppet_version] ? "=#{config[:puppet_version]}" : nil
-        end
+      def puppet_redhat_version
+        config[:puppet_version] ? "-#{config[:puppet_version]}" : nil
+      end
 
-        def puppet_redhat_version
-          config[:puppet_version] ? "-#{config[:puppet_version]}" : nil
-        end
+      def puppet_environment_flag
+        config[:puppet_environment] ? "--environment=#{config[:puppet_environment]}" : nil
+      end
 
-        def puppet_environment_flag
-          config[:puppet_environment] ? "--environment=#{config[:puppet_environment]}" : nil
-        end
+      def puppet_noop_flag
+        config[:puppet_noop] ? '--noop' : nil
+      end
 
-        def puppet_noop_flag
-          config[:puppet_noop] ? '--noop' : nil
-        end
+      def puppet_debug_flag
+        config[:puppet_debug] ? '-d' : nil
+      end
 
-        def puppet_debug_flag
-          config[:puppet_debug] ? '-d' : nil
-        end
+      def puppet_verbose_flag
+        config[:puppet_verbose] ? '-v' : nil
+      end
 
-        def puppet_verbose_flag
-          config[:puppet_verbose] ? '-v' : nil
-        end
+      def puppet_platform
+        config[:puppet_platform].to_s.downcase
+      end
 
-        def puppet_platform
-          config[:puppet_platform].to_s.downcase
+      def facter_facts
+        return nil unless config[:facter_file]
+        fact_vars = "export "
+        fact_hash = YAML.load_file(config[:facter_file])
+        fact_hash.each do |key, value|
+          fact_vars << "FACTER_#{key}=#{value} "
         end
+        fact_vars << ";"
+        fact_vars
+      end
 
-        def update_packages_debian_cmd
-          config[:update_package_repos] ? "#{sudo('apt-get')} update" : nil
-        end
+      def update_packages_debian_cmd
+        config[:update_package_repos] ? "#{sudo('apt-get')} update" : nil
+      end
 
-        def update_packages_redhat_cmd
-          config[:update_package_repos] ? "#{sudo('yum')} makecache" : nil
-        end
-        
-        def remove_puppet_repo
-          config[:remove_puppet_repo]
-        end
-        
-        def custom_facts
-          return nil if config[:custom_facts].none?
-          bash_vars = config[:custom_facts].map { |k,v| "FACTER_#{k}=#{v}" }.join(" ")
-          bash_vars = "export #{bash_vars};"
-          debug(bash_vars)
-          bash_vars
-        end
+      def update_packages_redhat_cmd
+        config[:update_package_repos] ? "#{sudo('yum')} makecache" : nil
+      end
 
-        def remove_repo
-          if remove_puppet_repo
-            "; #{sudo('rm')} -rf /tmp/kitchen #{hiera_data_remote_path} #{hiera_eyaml_key_remote_path} /etc/puppet/* " 
-          else  
-            nil
-          end
-        end
-        
-        def puppet_apt_repo
-          config[:puppet_apt_repo]
-        end
+      def remove_puppet_repo
+        config[:remove_puppet_repo]
+      end
 
-        def puppet_apt_repo_file
-          config[:puppet_apt_repo].split('/').last
-        end
+      def custom_facts
+        return nil if config[:custom_facts].none?
+        bash_vars = config[:custom_facts].map { |k, v| "FACTER_#{k}=#{v}" }.join(' ')
+        bash_vars = "export #{bash_vars};"
+        debug(bash_vars)
+        bash_vars
+      end
 
-        def puppet_yum_repo
-          config[:puppet_yum_repo]
+      def remove_repo
+        if remove_puppet_repo
+          "; #{sudo('rm')} -rf /tmp/kitchen #{hiera_data_remote_path} #{hiera_eyaml_key_remote_path} /etc/puppet/* "
+        else
+          nil
         end
+      end
 
-        def chef_url
-          config[:chef_bootstrap_url]
-        end
+      def puppet_apt_repo
+        config[:puppet_apt_repo]
+      end
 
-        def prepare_manifests
-          info('Preparing manifests')
-          debug("Using manifests from #{manifests}")
+      def puppet_apt_repo_file
+        config[:puppet_apt_repo].split('/').last
+      end
 
-          tmp_manifests_dir = File.join(sandbox_path, 'manifests')
-          FileUtils.mkdir_p(tmp_manifests_dir)
-          FileUtils.cp_r(Dir.glob("#{manifests}/*"), tmp_manifests_dir)
-        end
+      def puppet_yum_repo
+        config[:puppet_yum_repo]
+      end
 
-        def prepare_files
-          info('Preparing files')
+      def chef_url
+        config[:chef_bootstrap_url]
+      end
 
-          unless File.directory?(files)
-            info 'nothing to do for files'
-            return
-          end
+      def prepare_manifests
+        info('Preparing manifests')
+        debug("Using manifests from #{manifests}")
 
-          debug("Using files from #{files}")
+        tmp_manifests_dir = File.join(sandbox_path, 'manifests')
+        FileUtils.mkdir_p(tmp_manifests_dir)
+        FileUtils.cp_r(Dir.glob("#{manifests}/*"), tmp_manifests_dir)
+      end
 
-          tmp_files_dir = File.join(sandbox_path, 'files')
-          FileUtils.mkdir_p(tmp_files_dir)
-          FileUtils.cp_r(Dir.glob("#{files}/*"), tmp_files_dir)
+      def prepare_files
+        info('Preparing files')
+        unless File.directory?(files)
+          info 'nothing to do for files'
+          return
         end
 
-        def prepare_modules
-          info('Preparing modules')
+        debug("Using files from #{files}")
 
-          FileUtils.mkdir_p(tmpmodules_dir)
-		  
-	  resolve_with_librarian if File.exists?(puppetfile) and config[:resolve_with_librarian_puppet]
+        tmp_files_dir = File.join(sandbox_path, 'files')
+        FileUtils.mkdir_p(tmp_files_dir)
+        FileUtils.cp_r(Dir.glob("#{files}/*"), tmp_files_dir)
+      end
 
-          if modules && File.directory?(modules)
-            debug("Copying modules from #{modules} to #{tmpmodules_dir}")
-            FileUtils.cp_r(Dir.glob("#{modules}/*"), tmpmodules_dir, remove_destination: true)
-          else
-            info 'nothing to do for modules'
-          end
+      def prepare_modules
+        info('Preparing modules')
+
+        FileUtils.mkdir_p(tmpmodules_dir)
+        resolve_with_librarian if File.exist?(puppetfile) && config[:resolve_with_librarian_puppet]
 
-          copy_self_as_module
+        if modules && File.directory?(modules)
+          debug("Copying modules from #{modules} to #{tmpmodules_dir}")
+          FileUtils.cp_r(Dir.glob("#{modules}/*"), tmpmodules_dir, remove_destination: true)
+        else
+          info 'nothing to do for modules'
         end
 
-        def copy_self_as_module
-          if File.exists?(modulefile)
-            warn('Modulefile found but this is depricated, ignoring it, see https://tickets.puppetlabs.com/browse/PUP-1188')
-          end
+        copy_self_as_module
+      end
 
-          if File.exists?(metadata_json)
-            module_name = nil
-            begin
-              module_name = JSON.parse(IO.read(metadata_json))['name'].split('-').last
-            rescue
-              error("not able to load or parse #{metadata_json_path} for the name of the module")
-            end
-
-            if module_name
-              module_target_path = File.join(sandbox_path, 'modules', module_name)
-              FileUtils.mkdir_p(module_target_path)
-              FileUtils.cp_r(
-                Dir.glob(File.join(config[:kitchen_root], '*')).reject { |entry| entry =~ /modules/ },
-                module_target_path,
-                remove_destination: true
-              )
-            end
-          end
+      def copy_self_as_module
+        if File.exist?(modulefile)
+          warn('Modulefile found but this is depricated, ignoring it, see https://tickets.puppetlabs.com/browse/PUP-1188')
         end
 
-        def prepare_puppet_config
-          return unless puppet_config
+        return unless File.exist?(metadata_json)
+        module_name = nil
+        begin
+          module_name = JSON.parse(IO.read(metadata_json))['name'].split('-').last
+        rescue
+          error("not able to load or parse #{metadata_json_path} for the name of the module")
+        end
 
-          info('Preparing puppet.conf')
-          debug("Using puppet config from #{puppet_config}")
+        return unless module_name
+        module_target_path = File.join(sandbox_path, 'modules', module_name)
+        FileUtils.mkdir_p(module_target_path)
+        FileUtils.cp_r(
+          Dir.glob(File.join(config[:kitchen_root], '*')).reject { |entry| entry =~ /modules$/ },
+          module_target_path,
+          remove_destination: true
+        )
+      end
 
-          FileUtils.cp_r(puppet_config, File.join(sandbox_path, 'puppet.conf'))
-        end
+      def prepare_puppet_config
+        return unless puppet_config
 
-        def prepare_hiera_config
-          return unless hiera_config
+        info('Preparing puppet.conf')
+        debug("Using puppet config from #{puppet_config}")
 
-          info('Preparing hiera')
-          debug("Using hiera from #{hiera_config}")
+        FileUtils.cp_r(puppet_config, File.join(sandbox_path, 'puppet.conf'))
+      end
 
-          FileUtils.cp_r(hiera_config, File.join(sandbox_path, 'hiera.yaml'))
-        end
+      def prepare_hiera_config
+        return unless hiera_config
 
-        def prepare_fileserver_config
-          return unless fileserver_config
+        info('Preparing hiera')
+        debug("Using hiera from #{hiera_config}")
 
-          info('Preparing fileserver')
-          debug("Using fileserver config from #{fileserver_config}")
+        FileUtils.cp_r(hiera_config, File.join(sandbox_path, 'hiera.yaml'))
+      end
 
-          FileUtils.cp_r(fileserver_config, File.join(sandbox_path, 'fileserver.conf'))
-        end
+      def prepare_fileserver_config
+        return unless fileserver_config
 
-        def prepare_hiera_data
-          return unless hiera_data
-          info('Preparing hiera data')
-	  tmp_hiera_dir = File.join(sandbox_path, 'hiera')
-	  debug("Copying hiera data from #{hiera_data} to #{tmp_hiera_dir}")
-          FileUtils.mkdir_p(tmp_hiera_dir)
-          FileUtils.cp_r(Dir.glob("#{hiera_data}/*"), tmp_hiera_dir)
-          return unless hiera_eyaml_key_path
-          tmp_hiera_key_dir = File.join(sandbox_path, 'hiera_keys')
-	  debug("Copying hiera eyaml keys from #{hiera_eyaml_key_path} to #{tmp_hiera_key_dir}")
-	  FileUtils.mkdir_p(tmp_hiera_key_dir)
-          FileUtils.cp_r(Dir.glob("#{hiera_eyaml_key_path}/*"), tmp_hiera_key_dir)
-        end
+        info('Preparing fileserver')
+        debug("Using fileserver config from #{fileserver_config}")
 
-        def resolve_with_librarian
-          Kitchen.mutex.synchronize do
-            ENV["SSL_CERT_FILE"]=librarian_puppet_ssl_file if librarian_puppet_ssl_file
-            Puppet::Librarian.new(puppetfile, tmpmodules_dir, logger).resolve
-            ENV["SSL_CERT_FILE"]='' if librarian_puppet_ssl_file
-          end
+        FileUtils.cp_r(fileserver_config, File.join(sandbox_path, 'fileserver.conf'))
+      end
+
+      def prepare_hiera_data
+        return unless hiera_data
+        info('Preparing hiera data')
+        tmp_hiera_dir = File.join(sandbox_path, 'hiera')
+        debug("Copying hiera data from #{hiera_data} to #{tmp_hiera_dir}")
+        FileUtils.mkdir_p(tmp_hiera_dir)
+        FileUtils.cp_r(Dir.glob("#{hiera_data}/*"), tmp_hiera_dir)
+        return unless hiera_eyaml_key_path
+        tmp_hiera_key_dir = File.join(sandbox_path, 'hiera_keys')
+        debug("Copying hiera eyaml keys from #{hiera_eyaml_key_path} to #{tmp_hiera_key_dir}")
+        FileUtils.mkdir_p(tmp_hiera_key_dir)
+        FileUtils.cp_r(Dir.glob("#{hiera_eyaml_key_path}/*"), tmp_hiera_key_dir)
+      end
+
+      def resolve_with_librarian
+        Kitchen.mutex.synchronize do
+          ENV['SSL_CERT_FILE'] = librarian_puppet_ssl_file if librarian_puppet_ssl_file
+          Puppet::Librarian.new(puppetfile, tmpmodules_dir, logger).resolve
+          ENV['SSL_CERT_FILE'] = '' if librarian_puppet_ssl_file
         end
+      end
     end
   end
 end