kitchen-proxmox 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9431e030d0300d57c9fac8a20047375865cedf9f4a48b34b3039370f2d62a98a
-  data.tar.gz: 62e91255a7b9b2586eeef54bcd76bb7110b782ae8c948853ef0691a13e11df5e
+  metadata.gz: 8592a8c21a5245c5517893fb3de6c2c2a9cae921cdb8c499fd3a7bcfcc8dc35a
+  data.tar.gz: eb18680f687a41ef9a5a5c2f4b290e586e867de4795cdc5733998189fb3b4e85
 SHA512:
-  metadata.gz: e974ac8b7626ed1232e608073c259f5bb90c65aa47bdaf9327195a255dfbcbb7eb969a6cd88c5781c929835daa84f52a63e83aa6e291199de3d32889c244300b
-  data.tar.gz: 4b36857b3cfb877ff3bcf292049389cbe26cd43ab2393fb235d3236e8ad5d50ba74ed1ae55076961f97294f2df14e9a8d98d683a50afe4f37af5253ca3066f63
+  metadata.gz: 8da473dbe9ddf5891bff39a77fe3a55db3fd263a4413592e0c55d826387dbde2e60f77287516f31dd5083200d8d5c962ceaf811f43ad0b89e1a794311ece678b
+  data.tar.gz: c93d6729fa61fbc286cdd6b64e03febad2ea3995c1a29e346e5c35037f51339f84aef79370c90443ce96f4ec94fb494225fbf05a3ad27942378c97b54e2d9e36

data/lib/kitchen/driver/proxmox/api_client.rb

@@ -27,6 +27,10 @@ module Kitchen
           get('/api2/json/cluster/nextid')
         end
 
+        def validate_vmid(vm_id)
+          get("/api2/json/cluster/nextid?vmid=#{vm_id}")
+        end
+
         def clone_vm(node:, template_id:, new_id:, **options)
           full = options.fetch(:full, true)
           body = { newid: new_id, full: full ? 1 : 0, target: node }
@@ -76,7 +80,14 @@ module Kitchen
           deadline = Time.now + timeout
           loop do
             status = task_status(node:, upid:)
-            return status if status['status'] == 'stopped'
+            if status['status'] == 'stopped'
+              exitstatus = status['exitstatus'].to_s
+              unless exitstatus == 'OK'
+                raise ProxmoxErrors::ApiError.new(500, exitstatus)
+              end
+
+              return status
+            end
             raise "Task timeout after #{timeout}s: #{upid}" if Time.now > deadline
 
             sleep interval

data/lib/kitchen/driver/proxmox/errors.rb

@@ -13,12 +13,25 @@ module Kitchen
           super("Proxmox API error #{status_code}: #{response_body}")
         end
 
-        # Returns true when the error indicates a VMID is already in use.
+        # Returns true when the error indicates a VMID is already in use
+        # or cannot be locked (concurrent clone race).
         def vmid_conflict?
           return false unless status_code == 400 || status_code == 500
 
           response_body.match?(/already exists/i) ||
-            response_body.match?(/unable to create VM \d+/i)
+            response_body.match?(/unable to create VM \d+/i) ||
+            response_body.match?(/can't lock file.*lock-\d+/i)
+        end
+
+        # Returns true when the error indicates another process owns the VM
+        # (lost a VMID race — VM was started or configured by another clone).
+        def vmid_race_lost?
+          return false unless status_code == 400 || status_code == 500
+
+          response_body.match?(/already running/i) ||
+            response_body.match?(/hotplug problem/i) ||
+            response_body.match?(/does not exist/i) ||
+            response_body.match?(/can't lock file.*lock-\d+/i)
         end
       end
     end

data/lib/kitchen/driver/proxmox.rb

@@ -36,6 +36,8 @@ module Kitchen
       default_config :start_timeout, 300
       default_config :ip_wait_timeout, 120
       default_config :clone_retries, 5
+      default_config :vmid_range_min, 900_000
+      default_config :vmid_range_max, 999_999
 
       def create(state)
         return if state[:vm_id]
@@ -67,16 +69,33 @@ module Kitchen
       end
 
       def clone_and_start(state)
-        info("Creating Proxmox VM from template #{config[:template_id]}...")
+        retries = config[:clone_retries]
+        last_error = nil
+
+        retries.times do |attempt|
+          info("Creating Proxmox VM from template #{config[:template_id]}...")
+
+          vm_id, vm_name = allocate_and_clone
+          state[:vm_id] = vm_id
+          state[:vm_name] = vm_name
 
-        vm_id, vm_name = allocate_and_clone
-        state[:vm_id] = vm_id
-        state[:vm_name] = vm_name
+          begin
+            configure_hardware(vm_id)
+            start_and_wait_for_ip(state, vm_id)
+            info("Proxmox VM #{vm_name} (#{vm_id}) created.")
+            return
+          rescue ApiError => e
+            raise unless e.vmid_race_lost?
 
-        configure_hardware(vm_id)
-        start_and_wait_for_ip(state, vm_id)
+            last_error = e
+            warn("VMID #{vm_id} race lost (attempt #{attempt + 1}/#{retries}): #{e.message}")
+            warn("Another process owns VM #{vm_id} — abandoning and retrying...")
+            clear_state(state)
+            sleep backoff_delay(attempt)
+          end
+        end
 
-        info("Proxmox VM #{vm_name} (#{vm_id}) created.")
+        raise last_error
       end
 
       def allocate_and_clone
@@ -107,7 +126,9 @@ module Kitchen
       end
 
       def allocate_vm_id
-        Integer(api_client.next_vm_id)
+        vm_id = rand(config[:vmid_range_min]..config[:vmid_range_max])
+        api_client.validate_vmid(vm_id)
+        vm_id
       end
 
       def generate_vm_name(suite_name)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kitchen-proxmox
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Richard Nixon
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-05-03 00:00:00.000000000 Z
+date: 2026-05-04 00:00:00.000000000 Z
 dependencies: []
 description: A Test Kitchen driver for Proxmox VE. Manages VM lifecycle (create, destroy)
   via the Proxmox REST API. Supports cloning from templates.