kippt 2.0.1 → 3.0

data/spec/kippt/favorite_spec.rb

@@ -0,0 +1,38 @@
+require "spec_helper"
+
+describe Kippt::Favorite do
+  describe "#save" do
+    let(:client) { double :client }
+    let(:clip) { double :clip }
+    let(:collection) { double :likes_collection_resource }
+    let(:favorite) { Kippt::Favorite.new(clip, client) }
+
+    it "tells collection resource to save itself" do
+      collection.should_receive(:save_resource).with(favorite).and_return({success: true})
+      client.should_receive(:collection_resource_for).with(Kippt::Favorites, clip).and_return(collection)
+
+      favorite.save.should be_true
+    end
+
+    it "sets errors if there is any" do
+      collection.stub(:save_resource).and_return({success: false, error_message: "PROBLEM"})
+      client.stub(:collection_resource_for).and_return(collection)
+
+      favorite.save.should be_false
+      favorite.errors.should eq ["PROBLEM"]
+    end
+  end
+
+  describe "#destroy" do
+    let(:client) { double :client }
+    let(:clip) { double :clip }
+    let(:collection) { double :likes_collection_resource }
+    let(:favorite) { Kippt::Favorite.new(clip, client) }
+
+    it "tells collection resource to destroy itself" do
+      client.stub(:collection_resource_for).and_return(collection)
+      collection.should_receive(:destroy_resource).with(favorite).and_return(true)
+      favorite.destroy.should be_true
+    end
+  end
+end

data/spec/kippt/favorites_spec.rb

@@ -0,0 +1,18 @@
+require "spec_helper"
+require "kippt/favorites"
+
+describe Kippt::Favorites do
+  let(:client) { Kippt::Client.new(valid_user_credentials) }
+  let(:clip) { stub :user, :id => 100, :all_favorites_embedded? => false }
+  subject { Kippt::Favorites.new(client, clip) }
+  let(:base_uri) { "clips/#{clip.id}/favorites" }
+
+  describe "#destroy_resource" do
+    it "uses only the base_uri" do
+      favorite = double :favorite
+      response = double :response, success?: true
+      client.should_receive(:delete).with("clips/100/favorites").and_return(response)
+      subject.destroy_resource(favorite).should be_true
+    end
+  end
+end

data/spec/kippt/follow_relationship_spec.rb

@@ -12,6 +12,16 @@ describe Kippt::FollowRelationship do
         to_return(:status => 200, :body => '{"following": true}')
       subject.following?.should be_true
     end
+
+    context "when request is not successful" do
+      it "raises an exception" do
+        fail_response = double :fail_response, success?: false, body: {"message" => "NOT FOUND"}
+        client.stub(:get).and_return(fail_response)
+        expect {
+          subject.following?
+        }.to raise_exception Kippt::APIError, "Resource could not be loaded: NOT FOUND"
+      end
+    end
   end
 
   describe "#follow" do
@@ -21,6 +31,16 @@ describe Kippt::FollowRelationship do
          to_return(:status => 200, :body => "", :headers => {})
       subject.follow.should be_true
     end
+
+    context "when request is not successful" do
+      it "raises an exception" do
+        fail_response = double :fail_response, success?: false, body: {"message" => "NOT FOUND"}
+        client.stub(:post).and_return(fail_response)
+        expect {
+          subject.follow
+        }.to raise_exception Kippt::APIError, "Problem with following: NOT FOUND"
+      end
+    end
   end
 
   describe "#unfollow" do
@@ -30,5 +50,15 @@ describe Kippt::FollowRelationship do
          to_return(:status => 200, :body => "", :headers => {})
       subject.unfollow.should be_true
     end
+
+    context "when request is not successful" do
+      it "raises an exception" do
+        fail_response = double :fail_response, success?: false, body: {"message" => "NOT FOUND"}
+        client.stub(:post).and_return(fail_response)
+        expect {
+          subject.unfollow
+        }.to raise_exception Kippt::APIError, "Problem with unfollowing: NOT FOUND"
+      end
+    end
   end
 end

data/spec/kippt/followers_spec.rb

@@ -4,14 +4,11 @@ require "kippt/followers"
 describe Kippt::Followers do
   let(:client) { Kippt::Client.new(valid_user_credentials) }
   subject { Kippt::User.new({:id => 10}, client).followers }
+  let(:base_uri) { "users/10/followers" }
+  let(:singular_fixture) { "user" }
+  let(:collection_fixture) { "users" }
+  let(:resource_class) { Kippt::User }
+  let(:collection_class) { Kippt::UserCollection }
 
-  it "is a collection resource" do
-    subject.should be_a Kippt::CollectionResource
-  end
-
-  it "uses the correct base uri" do
-    stub_get("/users/10/followers").
-      to_return(:status => 200, :body => fixture("users.json"))
-    subject.all
-  end
+  it_behaves_like "read collection resource"
 end

data/spec/kippt/following_spec.rb

@@ -4,14 +4,11 @@ require "kippt/following"
 describe Kippt::Following do
   let(:client) { Kippt::Client.new(valid_user_credentials) }
   subject { Kippt::User.new({:id => 10}, client).following }
+  let(:base_uri) { "users/10/following" }
+  let(:singular_fixture) { "user" }
+  let(:collection_fixture) { "users" }
+  let(:resource_class) { Kippt::User }
+  let(:collection_class) { Kippt::UserCollection }
 
-  it "is a collection resource" do
-    subject.should be_a Kippt::CollectionResource
-  end
-
-  it "uses the correct base uri" do
-    stub_get("/users/10/following").
-      to_return(:status => 200, :body => fixture("users.json"))
-    subject.all
-  end
+  it_behaves_like "read collection resource"
 end

data/spec/kippt/like_spec.rb

@@ -0,0 +1,38 @@
+require "spec_helper"
+
+describe Kippt::Like do
+  describe "#save" do
+    let(:client) { double :client }
+    let(:clip) { double :clip }
+    let(:collection) { double :likes_collection_resource }
+    let(:like) { Kippt::Like.new(clip, client) }
+
+    it "tells collection resource to save itself" do
+      collection.should_receive(:save_resource).with(like).and_return({success: true})
+      client.should_receive(:collection_resource_for).with(Kippt::Likes, clip).and_return(collection)
+
+      like.save.should be_true
+    end
+
+    it "sets errors if there is any" do
+      collection.stub(:save_resource).and_return({success: false, error_message: "PROBLEM"})
+      client.stub(:collection_resource_for).and_return(collection)
+
+      like.save.should be_false
+      like.errors.should eq ["PROBLEM"]
+    end
+  end
+
+  describe "#destroy" do
+    let(:client) { double :client }
+    let(:clip) { double :clip }
+    let(:collection) { double :likes_collection_resource }
+    let(:like) { Kippt::Like.new(clip, client) }
+
+    it "tells collection resource to destroy itself" do
+      client.stub(:collection_resource_for).and_return(collection)
+      collection.should_receive(:destroy_resource).with(like).and_return(true)
+      like.destroy.should be_true
+    end
+  end
+end

data/spec/kippt/likes_spec.rb

@@ -0,0 +1,21 @@
+require "spec_helper"
+require "kippt/likes"
+
+describe Kippt::Likes do
+  let(:client) { Kippt::Client.new(valid_user_credentials) }
+  let(:clip) { stub :user, :id => 100, :all_likes_embedded? => false }
+  subject { Kippt::Likes.new(client, clip) }
+  let(:base_uri) { "clips/#{clip.id}/likes" }
+  let(:singular_fixture) { "user" }
+  let(:collection_class) { Kippt::UserCollection }
+  let(:resource_class) { Kippt::User }
+
+  describe "#destroy_resource" do
+    it "uses only the base_uri" do
+      like = double :like
+      response = double :response, success?: true
+      client.should_receive(:delete).with("clips/100/likes").and_return(response)
+      subject.destroy_resource(like).should be_true
+    end
+  end
+end

data/spec/kippt/list_spec.rb

@@ -37,29 +37,62 @@ describe Kippt::List do
     subject { Kippt::List.new({ "id" => 10 }, client).clips }
 
     it "returns the clips for the list" do
-      stub_get("/lists/#{10}/clips").
+      stub_get("/lists/10/clips").
         to_return(:status => 200, :body => fixture("clips.json"))
-      subject.should be_a Kippt::ClipCollection
+      subject.should be_a Kippt::Clips
+      subject.base_uri.should eq "lists/10/clips"
     end
   end
 
-  describe "#follow" do
+  describe "#following?" do
     context "when request is successful" do
       let(:client) { Kippt::Client.new(valid_user_credentials) }
 
+      it "returns value from the response" do
+        response = stub(:success? => true, body: {"following" => false})
+        client.should_receive(:get).with("/api/lists/10/relationship").and_return(response)
+        list = Kippt::List.new(json_fixture("list.json"), client)
+        list.following?.should be_false
+      end
+
       it "makes a request" do
+        stub_request(:get, "https://kippt.com/api/lists/10/relationship").
+           to_return(:status => 200, :body => "{\"following\":true}")
+        list = Kippt::List.new(json_fixture("list.json"), client)
+        list.following?
+      end
+    end
+
+    context "when request is unsuccessful" do
+      it "raises an exception" do
+        response = stub(:success? => false, :body => {"message" => "Weird issue going on."})
+        client.should_receive(:get).with("/api/lists/10/relationship").and_return(response)
+        list = Kippt::List.new(json_fixture("list.json"), client)
+
+        expect {
+          list.following?
+        }.to raise_error(Kippt::APIError, "There was an error with the request: Weird issue going on.")
+      end
+    end
+  end
+
+  describe "#follow" do
+    context "when request is successful" do
+      let(:client) { Kippt::Client.new(valid_user_credentials) }
+
+      it "returns true" do
         response = stub(:success? => true)
         client.should_receive(:post).with("/api/lists/10/relationship", :data => {:action => "follow"}).and_return(response)
         list = Kippt::List.new(json_fixture("list.json"), client)
-        list.follow
+        list.follow.should eq true
       end
 
-      it "returns true" do
+      it "makes a request" do
         stub_request(:post, "https://kippt.com/api/lists/10/relationship").
            with(:body => "{\"action\":\"follow\"}").
            to_return(:status => 200, :body => "{\"folloring\":true}")
         list = Kippt::List.new(json_fixture("list.json"), client)
-        list.follow.should eq true
+        list.follow
       end
     end
 
@@ -80,19 +113,19 @@ describe Kippt::List do
     context "when request is successful" do
       let(:client) { Kippt::Client.new(valid_user_credentials) }
 
-      it "makes a request" do
+      it "returns true" do
         response = stub(:success? => true)
         client.should_receive(:post).with("/api/lists/10/relationship", :data => {:action => "unfollow"}).and_return(response)
         list = Kippt::List.new(json_fixture("list.json"), client)
-        list.unfollow
+        list.unfollow.should eq true
       end
 
-      it "returns true" do
+      it "makes a request" do
         stub_request(:post, "https://kippt.com/api/lists/10/relationship").
            with(:body => "{\"action\":\"unfollow\"}").
            to_return(:status => 200, :body => "{\"folloring\":false}")
         list = Kippt::List.new(json_fixture("list.json"), client)
-        list.unfollow.should eq true
+        list.unfollow
       end
     end
 

data/spec/kippt/lists_spec.rb

@@ -6,8 +6,20 @@ describe Kippt::Lists do
   subject { client.lists }
   let(:base_uri) { "lists" }
   let(:singular_fixture) { "list" }
+  let(:collection_fixture) { "lists" }
   let(:collection_class) { Kippt::ListCollection }
   let(:resource_class) { Kippt::List }
 
   it_behaves_like "collection resource"
+
+  describe "#build" do
+    it "returns new resource" do
+      subject.build.should be_a(resource_class)
+    end
+
+    it "accepts parameters" do
+      subject.object_class.should_receive(:new).with({:an => "attribute"}, client)
+      subject.build(:an => "attribute")
+    end
+  end
 end

data/spec/kippt/saves_spec.rb

@@ -6,15 +6,15 @@ describe Kippt::Saves do
   let(:clip) { stub :clip, :saves_data => fixture("users.json") }
   subject { Kippt::Saves.new(client, clip) }
 
-  describe "#all" do
+  describe "#fetch" do
     it "returns collection class" do
-      all_resources = subject.all
+      all_resources = subject.fetch
       all_resources.is_a? Kippt::UserCollection
     end
 
     it "uses the clip saves data" do
       Kippt::UserCollection.should_receive(:new).with({"objects" => clip.saves_data}, client)
-      subject.all
+      subject.fetch
     end
   end
 end

data/spec/kippt/user_clips_spec.rb

@@ -6,16 +6,28 @@ describe Kippt::UserClips do
   subject { Kippt::User.new({:id => 10}, client).clips }
   let(:base_uri) { "users/#{10}/clips" }
   let(:singular_fixture) { "clip" }
+  let(:collection_fixture) { "clips" }
   let(:collection_class) { Kippt::ClipCollection }
   let(:resource_class) { Kippt::Clip }
 
   it_behaves_like "collection resource"
 
+  describe "#build" do
+    it "returns new resource" do
+      subject.build.should be_a(resource_class)
+    end
+
+    it "accepts parameters" do
+      subject.object_class.should_receive(:new).with({:an => "attribute"}, client)
+      subject.build(:an => "attribute")
+    end
+  end
+
   describe "#favorites" do
     it "returns ClipCollection" do
       stub_get("/#{base_uri}/favorites").
         to_return(:status => 200, :body => fixture("clips.json"))
-      subject.favorites.should be_a Kippt::ClipCollection
+      subject.favorites.should be_a Kippt::Clips
     end
   end
 
@@ -23,7 +35,7 @@ describe Kippt::UserClips do
     it "returns ClipCollection" do
       stub_get("/#{base_uri}/likes").
         to_return(:status => 200, :body => fixture("clips.json"))
-      subject.likes.should be_a Kippt::ClipCollection
+      subject.likes.should be_a Kippt::Clips
     end
   end
 end

data/spec/kippt/user_likes_spec.rb

@@ -0,0 +1,14 @@
+require "spec_helper"
+require "kippt/user_likes"
+
+describe Kippt::UserLikes do
+  let(:client) { Kippt::Client.new(valid_user_credentials) }
+  subject { Kippt::User.new({:id => 10}, client).likes }
+  let(:base_uri) { "users/10/clips/likes" }
+  let(:singular_fixture) { "clip" }
+  let(:collection_fixture) { "clips" }
+  let(:collection_class) { Kippt::ClipCollection }
+  let(:resource_class) { Kippt::Clip }
+
+  it_behaves_like "read collection resource"
+end

data/spec/kippt/user_lists_spec.rb

@@ -6,8 +6,20 @@ describe Kippt::UserLists do
   subject { Kippt::User.new({:id => 10}, client).lists }
   let(:base_uri) { "users/#{10}/lists" }
   let(:singular_fixture) { "list" }
+  let(:collection_fixture) { "lists" }
   let(:collection_class) { Kippt::ListCollection }
   let(:resource_class) { Kippt::List }
 
   it_behaves_like "collection resource"
+
+  describe "#build" do
+    it "returns new resource" do
+      subject.build.should be_a(resource_class)
+    end
+
+    it "accepts parameters" do
+      subject.object_class.should_receive(:new).with({:an => "attribute"}, client)
+      subject.build(:an => "attribute")
+    end
+  end
 end

data/spec/kippt/user_spec.rb

@@ -25,6 +25,17 @@ describe Kippt::User do
     end
   end
 
+  describe "#likes" do
+    it "returns correctly configured user likes proxy" do
+      client = double :client
+      user = Kippt::User.new(nil, client)
+
+      likes = user.likes
+      likes.should be_a(Kippt::UserLikes)
+      likes.user.should eq user
+    end
+  end
+
   describe "#following?" do
     it "uses Kippt::FollowRelationship to get the information" do
       follow_relationship = mock(:follow_relationship,

data/spec/kippt/users_spec.rb

@@ -6,10 +6,11 @@ describe Kippt::Users do
   subject { client.users }
   let(:base_uri) { "users" }
   let(:singular_fixture) { "user" }
+  let(:collection_fixture) { "users" }
   let(:collection_class) { Kippt::UserCollection }
   let(:resource_class) { Kippt::User }
 
-  it_behaves_like "collection resource"
+  it_behaves_like "read collection resource"
 
   describe "#search" do
     subject { Kippt::Client.new(valid_user_credentials).users }