kintsugi 0.5.4 → 0.6.2

data/spec/kintsugi_apply_change_to_project_spec.rb

@@ -27,6 +27,13 @@ describe Kintsugi, :apply_change_to_project do
     end
   end
 
+  it "not raises when change is nil or doesn't have root object" do
+    expect {
+      described_class.apply_change_to_project(base_project, nil)
+      described_class.apply_change_to_project(base_project, {})
+    }.not_to raise_error
+  end
+
   it "adds new target" do
     theirs_project = create_copy_of_project(base_project.path, "theirs")
     theirs_project.new_target("com.apple.product-type.library.static", "foo", :ios)
@@ -34,7 +41,6 @@ describe Kintsugi, :apply_change_to_project do
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(theirs_project)
   end
@@ -46,7 +52,6 @@ describe Kintsugi, :apply_change_to_project do
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(theirs_project)
   end
@@ -60,7 +65,6 @@ describe Kintsugi, :apply_change_to_project do
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(theirs_project)
   end
@@ -72,29 +76,29 @@ describe Kintsugi, :apply_change_to_project do
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(theirs_project, ignore_keys: ["containerPortal"])
   end
 
-  it "adds subproject that already exists" do
-    theirs_project = create_copy_of_project(base_project.path, "theirs")
+  it "removes reference proxy from subproject with the same display name as another reference proxy" do
+    framework_filename = "baz"
+    subproject = add_new_subproject_to_project(base_project, "subproj", framework_filename)
 
-    subproject = add_new_subproject_to_project(theirs_project, "foo", "foo")
-    theirs_project.save
+    subproject.new_target("com.apple.product-type.library.static", framework_filename, :ios)
+    base_project.root_object.project_references[0][:product_group] <<
+      create_reference_proxy_from_product_reference(base_project,
+                                                    base_project.root_object.project_references[0][:project_ref],
+                                                    subproject.products_group.files[-1])
+    base_project.save
 
-    ours_project = create_copy_of_project(base_project.path, "ours")
-    add_existing_subproject_to_project(ours_project, subproject, "foo")
+    theirs_project = create_copy_of_project(base_project.path, "theirs")
+    theirs_project.root_object.project_references[0][:product_group].children[-1].remove_from_project
 
     changes_to_apply = get_diff(theirs_project, base_project)
 
-    described_class.apply_change_to_project(ours_project, changes_to_apply)
-    ours_project.save
+    described_class.apply_change_to_project(base_project, changes_to_apply)
 
-    expect(ours_project.root_object.project_references[0][:project_ref].uuid)
-      .not_to equal(ours_project.root_object.project_references[1][:project_ref].uuid)
-    expect(ours_project.root_object.project_references[0][:project_ref].proxy_containers).not_to be_empty
-    expect(ours_project.root_object.project_references[1][:project_ref].proxy_containers).not_to be_empty
+    expect(base_project).to be_equivalent_to_project(theirs_project)
   end
 
   # Checks that the order the changes are applied in is correct.
@@ -110,7 +114,6 @@ describe Kintsugi, :apply_change_to_project do
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(theirs_project, ignore_keys: ["containerPortal"])
   end
@@ -152,11 +155,28 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
 
+    it "raises when a file is split into two" do
+      base_project.main_group.find_subpath("new_group", true)
+      base_project.main_group.find_subpath("new_group2", true)
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      new_group = theirs_project.main_group.find_subpath("new_group")
+      file_reference = theirs_project.main_group.find_file_by_path(filepath)
+      file_reference.move(new_group)
+      theirs_project.main_group.find_subpath("new_group2").new_reference(filepath)
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      expect {
+        described_class.apply_change_to_project(base_project, changes_to_apply)
+      }.to raise_error(Kintsugi::MergeError)
+    end
+
     it "adds file to new group" do
       theirs_project = create_copy_of_project(base_project.path, "theirs")
 
@@ -165,8 +185,70 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
+
+      expect(base_project).to be_equivalent_to_project(theirs_project)
+    end
+
+    it "removes group" do
+      base_project.main_group.find_subpath("new_group", true)
       base_project.save
 
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      theirs_project["new_group"].remove_from_project
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      described_class.apply_change_to_project(base_project, changes_to_apply)
+
+      expect(base_project).to be_equivalent_to_project(theirs_project)
+    end
+
+    it "moves a group with files in it" do
+      new_group = base_project.main_group.find_subpath("new_group", true)
+      new_group.new_reference("new_file")
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      new_group2 = theirs_project.main_group.find_subpath("new_group2", true)
+      theirs_project["new_group"].move(new_group2)
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      described_class.apply_change_to_project(base_project, changes_to_apply)
+
+      expect(base_project).to be_equivalent_to_project(theirs_project)
+    end
+
+    it "moves a group with a group in it" do
+      new_group = base_project.main_group.find_subpath("new_group", true)
+      new_group.find_subpath("sub_group", true)
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      new_group2 = theirs_project.main_group.find_subpath("new_group2", true)
+      theirs_project["new_group"].move(new_group2)
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      described_class.apply_change_to_project(base_project, changes_to_apply)
+
+      expect(base_project).to be_equivalent_to_project(theirs_project)
+    end
+
+    it "moves a group with a group with a file in it" do
+      new_group = base_project.main_group.find_subpath("new_group", true)
+      sub_group = new_group.find_subpath("sub_group", true)
+      sub_group.new_reference("new_file")
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      new_group2 = theirs_project.main_group.find_subpath("new_group2", true)
+      theirs_project["new_group"].move(new_group2)
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      described_class.apply_change_to_project(base_project, changes_to_apply)
+
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
 
@@ -179,7 +261,6 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -203,7 +284,6 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -225,6 +305,22 @@ describe Kintsugi, :apply_change_to_project do
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
 
+    it "ignores removal of a non-existent group" do
+      base_project.main_group.find_subpath("new_group", true)
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      theirs_project.main_group.children.delete_at(-1)
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      base_project.main_group.children.delete_at(-1)
+
+      described_class.apply_change_to_project(base_project, changes_to_apply)
+
+      expect(base_project).to be_equivalent_to_project(theirs_project)
+    end
+
     it "removes build files of a removed file" do
       target = base_project.new_target("com.apple.product-type.library.static", "foo", :ios)
       target.source_build_phase.add_file_reference(
@@ -244,7 +340,6 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -260,7 +355,6 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -275,25 +369,21 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
 
     it "handles moved file to an existing group with a different path on filesystem" do
       base_project.main_group.find_subpath("new_group", true).path = "some_path"
-
       base_project.save
-      theirs_project = create_copy_of_project(base_project.path, "theirs")
 
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
       new_group = theirs_project.main_group.find_subpath("new_group")
-
       theirs_project.main_group.find_file_by_path(filepath).move(new_group)
 
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -312,7 +402,6 @@ describe Kintsugi, :apply_change_to_project do
         ours_project_before_applying_changes = create_copy_of_project(ours_project.path, "ours")
 
         described_class.apply_change_to_project(ours_project, changes_to_apply)
-        ours_project.save
 
         expect(ours_project).to be_equivalent_to_project(ours_project_before_applying_changes)
       end
@@ -330,7 +419,6 @@ describe Kintsugi, :apply_change_to_project do
         ours_project_before_applying_changes = create_copy_of_project(ours_project.path, "ours")
 
         described_class.apply_change_to_project(ours_project, changes_to_apply)
-        ours_project.save
 
         expect(ours_project).to be_equivalent_to_project(ours_project_before_applying_changes)
       end
@@ -348,7 +436,6 @@ describe Kintsugi, :apply_change_to_project do
         ours_project_before_applying_changes = create_copy_of_project(ours_project.path, "ours")
 
         described_class.apply_change_to_project(ours_project, changes_to_apply)
-        ours_project.save
 
         expect(ours_project).to be_equivalent_to_project(ours_project_before_applying_changes)
       end
@@ -363,7 +450,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, base_project)
 
         described_class.apply_change_to_project(ours_project, changes_to_apply)
-        ours_project.save
 
         expect(ours_project).to be_equivalent_to_project(theirs_project)
       end
@@ -377,6 +463,54 @@ describe Kintsugi, :apply_change_to_project do
       base_project.save
     end
 
+    it "moves file that is referenced by a target from main group to a new group" do
+      file_reference = base_project.main_group.new_reference("bar")
+      base_project.targets[0].source_build_phase.add_file_reference(file_reference)
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      new_group = theirs_project.main_group.find_subpath("new_group", true)
+      file_reference = theirs_project.main_group.find_file_by_path("bar")
+      file_reference.move(new_group)
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      described_class.apply_change_to_project(base_project, changes_to_apply)
+
+      expect(base_project).to be_equivalent_to_project(theirs_project)
+    end
+
+    it "moves file that is referenced by a target from a group to the main group" do
+      file_reference = base_project.main_group.find_subpath("new_group", true).new_reference("bar")
+      base_project.targets[0].source_build_phase.add_file_reference(file_reference)
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      file_reference = theirs_project["new_group/bar"]
+      file_reference.move(theirs_project.main_group)
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      described_class.apply_change_to_project(base_project, changes_to_apply)
+
+      expect(base_project).to be_equivalent_to_project(theirs_project)
+    end
+
+    it "moves file that is referenced by a target and has a different file encoding" do
+      file_reference = base_project.main_group.find_subpath("new_group", true).new_reference("bar")
+      target.frameworks_build_phase.add_file_reference(file_reference)
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      file_reference = theirs_project["new_group/bar"]
+      file_reference.move(theirs_project.main_group)
+      file_reference.fileEncoding = "4"
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      described_class.apply_change_to_project(base_project, changes_to_apply)
+
+      expect(base_project).to be_equivalent_to_project(theirs_project)
+    end
+
     it "changes framework from file reference to reference proxy" do
       framework_filename = "baz"
 
@@ -389,7 +523,7 @@ describe Kintsugi, :apply_change_to_project do
       theirs_project = create_copy_of_project(base_project.path, "theirs")
 
       build_phase = theirs_project.targets[0].frameworks_build_phase
-      build_phase.files[0].remove_from_project
+      build_phase.files.find { |build_file| build_file.display_name == "baz" }.remove_from_project
       build_phase.add_file_reference(
         theirs_project.root_object.project_references[0][:product_group].children[0]
       )
@@ -397,7 +531,6 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -410,7 +543,6 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -440,7 +572,6 @@ describe Kintsugi, :apply_change_to_project do
       # hierarchy.
       base_project.files[-1].name = "foo"
       theirs_project.files[-1].name = "foo"
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -467,7 +598,6 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply["rootObject"].delete("projectReferences")
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -494,7 +624,6 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -511,11 +640,26 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project, ignore_keys: ["containerPortal"])
     end
 
+    it "adds build when there is a build file without file ref" do
+      target = base_project.new_target("com.apple.product-type.library.static", "foo", :ios)
+      target.frameworks_build_phase.add_file_reference(nil)
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      file_reference = theirs_project.main_group.new_reference("bar")
+      theirs_project.targets[0].frameworks_build_phase.add_file_reference(file_reference)
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+      other_project = create_copy_of_project(base_project.path, "theirs")
+      described_class.apply_change_to_project(other_project, changes_to_apply)
+
+      expect(other_project).to be_equivalent_to_project(theirs_project)
+    end
+
     it "adds product ref to build file" do
       base_project.main_group.new_reference("bar")
       base_project.save
@@ -531,16 +675,13 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project, ignore_keys: ["containerPortal"])
     end
 
     it "adds build file to a file reference that already exists" do
       base_project.main_group.new_reference("bar")
-
       base_project.main_group.new_reference("bar")
-
       base_project.save
 
       theirs_project = create_copy_of_project(base_project.path, "theirs")
@@ -554,17 +695,14 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
 
     it "adds file reference to build file" do
       file_reference = base_project.main_group.new_reference("bar")
-
       build_file = base_project.targets[0].frameworks_build_phase.add_file_reference(file_reference)
       build_file.file_ref = nil
-
       base_project.save
 
       theirs_project = create_copy_of_project(base_project.path, "theirs")
@@ -575,7 +713,6 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project, ignore_keys: ["containerPortal"])
     end
@@ -585,7 +722,6 @@ describe Kintsugi, :apply_change_to_project do
       base_project.save
 
       theirs_project = create_copy_of_project(base_project.path, "theirs")
-
       file_reference = theirs_project.main_group.files.find { |file| file.display_name == "bar" }
       build_file =
         theirs_project.targets[0].frameworks_build_phase.add_file_reference(file_reference)
@@ -595,7 +731,6 @@ describe Kintsugi, :apply_change_to_project do
 
       other_project = create_copy_of_project(base_project.path, "other")
       described_class.apply_change_to_project(other_project, changes_to_apply)
-      other_project.save
 
       expect(other_project).to be_equivalent_to_project(base_project)
     end
@@ -621,7 +756,6 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project, ignore_keys: ["containerPortal"])
     end
@@ -637,7 +771,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, base_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -646,7 +779,6 @@ describe Kintsugi, :apply_change_to_project do
         base_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings = {}
         end
-
         theirs_project = create_copy_of_project(base_project.path, "theirs")
 
         theirs_project.targets[0].build_configurations.each do |configuration|
@@ -659,7 +791,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, base_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -677,7 +808,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, base_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -701,7 +831,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, base_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -718,10 +847,8 @@ describe Kintsugi, :apply_change_to_project do
         ours_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings["HEADER_SEARCH_PATHS"] = "baz"
         end
-        ours_project.save
 
         described_class.apply_change_to_project(ours_project, changes_to_apply)
-        ours_project.save
 
         expected_project = create_copy_of_project(base_project.path, "expected")
         expected_project.targets[0].build_configurations.each do |configuration|
@@ -742,10 +869,8 @@ describe Kintsugi, :apply_change_to_project do
         ours_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings["HEADER_SEARCH_PATHS"] = %w[bar foo]
         end
-        ours_project.save
 
         described_class.apply_change_to_project(ours_project, changes_to_apply)
-        ours_project.save
 
         expected_project = create_copy_of_project(base_project.path, "expected")
         expected_project.targets[0].build_configurations.each do |configuration|
@@ -761,10 +886,9 @@ describe Kintsugi, :apply_change_to_project do
             "$(SRCROOT)/../Bar"
           ]
         end
-
         base_project.save
-        theirs_project = create_copy_of_project(base_project.path, "theirs")
 
+        theirs_project = create_copy_of_project(base_project.path, "theirs")
         theirs_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings["HEADER_SEARCH_PATHS"] = nil
         end
@@ -772,7 +896,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, base_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -781,10 +904,9 @@ describe Kintsugi, :apply_change_to_project do
         base_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings["HEADER_SEARCH_PATHS"] = "bar"
         end
-
         base_project.save
-        theirs_project = create_copy_of_project(base_project.path, "theirs")
 
+        theirs_project = create_copy_of_project(base_project.path, "theirs")
         theirs_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings =
             configuration.build_settings.reject { |key, _| key == "HEADER_SEARCH_PATHS" }
@@ -793,7 +915,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, base_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -802,8 +923,8 @@ describe Kintsugi, :apply_change_to_project do
         base_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings["HEADER_SEARCH_PATHS"] = "bar"
         end
-
         base_project.save
+
         theirs_project = create_copy_of_project(base_project.path, "theirs")
         theirs_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings = nil
@@ -812,7 +933,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, base_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -822,8 +942,8 @@ describe Kintsugi, :apply_change_to_project do
           configuration.build_settings["HEADER_SEARCH_PATHS"] = "bar"
           configuration.build_settings["foo"] = "baz"
         end
-
         base_project.save
+
         theirs_project = create_copy_of_project(base_project.path, "theirs")
         theirs_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings = nil
@@ -837,7 +957,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, base_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -858,7 +977,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, before_theirs_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -879,7 +997,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, before_theirs_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -940,10 +1057,9 @@ describe Kintsugi, :apply_change_to_project do
         base_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings["HEADER_SEARCH_PATHS"] = %w[bar foo]
         end
-
         base_project.save
-        theirs_project = create_copy_of_project(base_project.path, "theirs")
 
+        theirs_project = create_copy_of_project(base_project.path, "theirs")
         theirs_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings["HEADER_SEARCH_PATHS"] = "baz"
         end
@@ -951,7 +1067,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, base_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -960,10 +1075,9 @@ describe Kintsugi, :apply_change_to_project do
         base_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings["HEADER_SEARCH_PATHS"] = "bar"
         end
-
         base_project.save
-        theirs_project = create_copy_of_project(base_project.path, "theirs")
 
+        theirs_project = create_copy_of_project(base_project.path, "theirs")
         theirs_project.targets[0].build_configurations.each do |configuration|
           configuration.build_settings["HEADER_SEARCH_PATHS"] = %w[baz foo]
         end
@@ -971,7 +1085,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, base_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(theirs_project)
       end
@@ -998,7 +1111,6 @@ describe Kintsugi, :apply_change_to_project do
         changes_to_apply = get_diff(theirs_project, before_theirs_project)
 
         described_class.apply_change_to_project(base_project, changes_to_apply)
-        base_project.save
 
         expect(base_project).to be_equivalent_to_project(expected_project)
       end
@@ -1062,37 +1174,32 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
 
     it "adds build phase with a simple attribute value that has non nil default" do
       theirs_project = create_copy_of_project(base_project.path, "theirs")
-
       theirs_project.targets[0].new_shell_script_build_phase("bar")
       theirs_project.targets[0].build_phases.last.shell_script = "Other value"
 
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
 
     it "removes build phase" do
       base_project.targets[0].new_shell_script_build_phase("bar")
-
       base_project.save
-      theirs_project = create_copy_of_project(base_project.path, "theirs")
 
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
       theirs_project.targets[0].shell_script_build_phases[0].remove_from_project
 
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -1102,33 +1209,29 @@ describe Kintsugi, :apply_change_to_project do
       file = variant_group.new_reference("Base")
       file.last_known_file_type = "text.plist.strings"
       target.resources_build_phase.add_file_reference(variant_group)
-
       base_project.save
-      theirs_project = create_copy_of_project(base_project.path, "theirs")
 
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
       theirs_variant_group = theirs_project.main_group.find_subpath("foo.strings")
       theirs_variant_group.new_reference("en")
 
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
 
     it "adds target dependency" do
       base_project.new_target("com.apple.product-type.library.static", "bar", :ios)
-
       base_project.save
-      theirs_project = create_copy_of_project(base_project.path, "theirs")
 
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
       theirs_project.targets[1].add_dependency(theirs_project.targets[0])
 
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -1137,10 +1240,9 @@ describe Kintsugi, :apply_change_to_project do
       base_project.targets[0].build_configurations.each do |configuration|
         configuration.build_settings["GCC_PREFIX_HEADER"] = "foo"
       end
-
       base_project.save
-      theirs_project = create_copy_of_project(base_project.path, "theirs")
 
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
       theirs_project.targets[0].build_configurations.each do |configuration|
         configuration.build_settings["GCC_PREFIX_HEADER"] = "bar"
       end
@@ -1148,16 +1250,13 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
 
     it "adds build settings to new target" do
       theirs_project = create_copy_of_project(base_project.path, "theirs")
-
       theirs_project.new_target("com.apple.product-type.library.static", "bar", :ios)
-
       theirs_project.targets[1].build_configurations.each do |configuration|
         configuration.build_settings["GCC_PREFIX_HEADER"] = "baz"
       end
@@ -1165,7 +1264,6 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
@@ -1174,7 +1272,6 @@ describe Kintsugi, :apply_change_to_project do
       base_project.main_group.new_reference("baz")
 
       theirs_project = create_copy_of_project(base_project.path, "theirs")
-
       configuration_reference = theirs_project.main_group.find_subpath("baz")
       theirs_project.targets[0].build_configurations.each do |configuration|
         configuration.base_configuration_reference = configuration_reference
@@ -1183,35 +1280,29 @@ describe Kintsugi, :apply_change_to_project do
       changes_to_apply = get_diff(theirs_project, base_project)
 
       described_class.apply_change_to_project(base_project, changes_to_apply)
-      base_project.save
 
       expect(base_project).to be_equivalent_to_project(theirs_project)
     end
   end
 
   it "adds known regions" do
-    base_project.save
     theirs_project = create_copy_of_project(base_project.path, "theirs")
-
     theirs_project.root_object.known_regions += ["fr"]
 
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(theirs_project)
   end
 
   it "removes known regions" do
     theirs_project = create_copy_of_project(base_project.path, "theirs")
-
     theirs_project.root_object.known_regions = nil
 
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(theirs_project)
   end
@@ -1225,7 +1316,6 @@ describe Kintsugi, :apply_change_to_project do
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(theirs_project)
   end
@@ -1235,14 +1325,12 @@ describe Kintsugi, :apply_change_to_project do
     base_project.save
 
     theirs_project = create_copy_of_project(base_project.path, "theirs")
-
     theirs_project.root_object.attributes["TargetAttributes"] =
       {"foo" => {"LastSwiftMigration" => "1140"}}
 
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(theirs_project)
   end
@@ -1252,14 +1340,12 @@ describe Kintsugi, :apply_change_to_project do
     base_project.save
 
     theirs_project = create_copy_of_project(base_project.path, "theirs")
-
     theirs_project.root_object.attributes["TargetAttributes"] =
       {"foo" => {"LastSwiftMigration" => "1140"}}
 
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(theirs_project)
   end
@@ -1270,13 +1356,11 @@ describe Kintsugi, :apply_change_to_project do
     base_project.save
 
     theirs_project = create_copy_of_project(base_project.path, "theirs")
-
     theirs_project.root_object.attributes["TargetAttributes"]["foo"] = {}
 
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(theirs_project)
   end
@@ -1295,7 +1379,6 @@ describe Kintsugi, :apply_change_to_project do
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(ours_project, changes_to_apply)
-    ours_project.save
 
     expect(ours_project).to be_equivalent_to_project(theirs_project)
   end
@@ -1313,7 +1396,6 @@ describe Kintsugi, :apply_change_to_project do
     changes_to_apply = get_diff(theirs_project, base_project)
 
     described_class.apply_change_to_project(ours_project, changes_to_apply)
-    ours_project.save
 
     expect(ours_project).to be_equivalent_to_project(theirs_project)
   end
@@ -1341,7 +1423,6 @@ describe Kintsugi, :apply_change_to_project do
     changes_to_apply = get_diff(ours_project, theirs_project)
 
     described_class.apply_change_to_project(base_project, changes_to_apply)
-    base_project.save
 
     expect(base_project).to be_equivalent_to_project(ours_project, ignore_keys: ["containerPortal"])
   end
@@ -1365,6 +1446,30 @@ describe Kintsugi, :apply_change_to_project do
     expect(base_project).to be_equivalent_to_project(theirs_project)
   end
 
+  it "adds build configuration list" do
+    base_project.root_object.build_configuration_list = nil
+    base_project.save
+
+    theirs_project = create_copy_of_project(base_project.path, "theirs")
+    theirs_project.root_object.build_configuration_list =
+      theirs_project.new(Xcodeproj::Project::XCConfigurationList)
+
+    changes_to_apply = get_diff(theirs_project, base_project)
+
+    described_class.apply_change_to_project(base_project, changes_to_apply)
+    expect(base_project).to be_equivalent_to_project(theirs_project)
+  end
+
+  it "removes build configuration list" do
+    theirs_project = create_copy_of_project(base_project.path, "theirs")
+    theirs_project.build_configuration_list.remove_from_project
+
+    changes_to_apply = get_diff(theirs_project, base_project)
+
+    described_class.apply_change_to_project(base_project, changes_to_apply)
+    expect(base_project).to be_equivalent_to_project(theirs_project)
+  end
+
   it "adds group to product group" do
     base_project_path = make_temp_directory("base", ".xcodeproj")
     base_project = Xcodeproj::Project.new(base_project_path)
@@ -1400,6 +1505,154 @@ describe Kintsugi, :apply_change_to_project do
     expect(base_project).to be_equivalent_to_project(theirs_project)
   end
 
+  describe "avoiding duplicate references to the same component" do
+    it "avoids adding file reference that already exists" do
+      base_project.main_group.new_reference("bar")
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      theirs_project.main_group.new_reference("bar")
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+      other_project = create_copy_of_project(base_project.path, "theirs")
+      described_class.apply_change_to_project(other_project, changes_to_apply)
+
+      expect(other_project).to be_equivalent_to_project(base_project)
+    end
+
+    it "avoids adding group that already exists" do
+      base_project.main_group.new_group("bar")
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      theirs_project.main_group.new_group("bar")
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+      other_project = create_copy_of_project(base_project.path, "theirs")
+      described_class.apply_change_to_project(other_project, changes_to_apply)
+
+      expect(other_project).to be_equivalent_to_project(base_project)
+    end
+
+    it "avoids adding variant group that already exists" do
+      base_project.main_group.new_variant_group("bar")
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      theirs_project.main_group.new_variant_group("bar")
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+      other_project = create_copy_of_project(base_project.path, "theirs")
+      described_class.apply_change_to_project(other_project, changes_to_apply)
+
+      expect(other_project).to be_equivalent_to_project(base_project)
+    end
+
+    it "avoids adding subproject that already exists" do
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+
+      subproject = add_new_subproject_to_project(theirs_project, "foo", "foo")
+
+      ours_project = create_copy_of_project(base_project.path, "ours")
+      add_existing_subproject_to_project(ours_project, subproject, "foo")
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      described_class.apply_change_to_project(ours_project, changes_to_apply)
+
+      expect(ours_project.root_object.project_references.count).to equal(1)
+    end
+
+    it "avoids adding build file that already exists" do
+      file_reference = base_project.main_group.new_reference("bar")
+      target = base_project.new_target("com.apple.product-type.library.static", "foo", :ios)
+      target.frameworks_build_phase.add_file_reference(file_reference)
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      file_reference = theirs_project.main_group.new_reference("bar")
+      theirs_project.targets[0].frameworks_build_phase.add_file_reference(file_reference)
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+      other_project = create_copy_of_project(base_project.path, "theirs")
+      described_class.apply_change_to_project(other_project, changes_to_apply)
+
+      expect(other_project).to be_equivalent_to_project(base_project)
+    end
+
+    it "avoids adding reference proxy that already exists" do
+      framework_filename = "baz"
+      subproject = add_new_subproject_to_project(base_project, "subproj", framework_filename)
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+
+      theirs_project.root_object.project_references[0][:product_group] <<
+        create_reference_proxy_from_product_reference(theirs_project,
+                                                      theirs_project.root_object.project_references[0][:project_ref],
+                                                      subproject.products_group.files[-1])
+
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      other_project = create_copy_of_project(base_project.path, "theirs")
+      described_class.apply_change_to_project(other_project, changes_to_apply)
+
+      expect(other_project).to be_equivalent_to_project(base_project)
+    end
+
+    it "keeps array if adding string value that already exists in array" do
+      base_project.new_target("com.apple.product-type.library.static", "bar", :ios)
+      base_project.save
+
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+      theirs_project.targets[0].build_configurations.each do |configuration|
+        configuration.build_settings["HEADER_SEARCH_PATHS"] = "bar"
+      end
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      ours_project = create_copy_of_project(base_project.path, "ours")
+      ours_project.targets[0].build_configurations.each do |configuration|
+        configuration.build_settings["HEADER_SEARCH_PATHS"] = %w[bar foo]
+      end
+      ours_project.save
+
+      expected_project = create_copy_of_project(ours_project.path, "expected")
+
+      described_class.apply_change_to_project(ours_project, changes_to_apply)
+
+      expect(ours_project).to be_equivalent_to_project(expected_project)
+    end
+  end
+
+  describe "allowing adding reference to the same component" do
+    before do
+      Kintsugi::Settings.allow_duplicates = true
+    end
+
+    after do
+      Kintsugi::Settings.allow_duplicates = false
+    end
+
+    it "adds subproject that already exists" do
+      theirs_project = create_copy_of_project(base_project.path, "theirs")
+
+      subproject = add_new_subproject_to_project(theirs_project, "foo", "foo")
+
+      ours_project = create_copy_of_project(base_project.path, "ours")
+      add_existing_subproject_to_project(ours_project, subproject, "foo")
+
+      changes_to_apply = get_diff(theirs_project, base_project)
+
+      described_class.apply_change_to_project(ours_project, changes_to_apply)
+
+      expect(ours_project.root_object.project_references[0][:project_ref].uuid)
+        .not_to equal(ours_project.root_object.project_references[1][:project_ref].uuid)
+      expect(ours_project.root_object.project_references[0][:project_ref].proxy_containers).not_to be_empty
+      expect(ours_project.root_object.project_references[1][:project_ref].proxy_containers).not_to be_empty
+    end
+  end
+
   def create_copy_of_project(project_path, new_project_prefix)
     copied_project_path = make_temp_directory(new_project_prefix, ".xcodeproj")
     FileUtils.cp(File.join(project_path, "project.pbxproj"), copied_project_path)