kintone 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b117f1c781845b8712805c6ede66ed44d8b44382
-  data.tar.gz: 2f3151d4228579e118fec2564f55f93b1eef955b
+  metadata.gz: 8d0188da83c5ab9e8038ede9d675404c468e1c3c
+  data.tar.gz: 4f2f6299034a38c502b3e50274e04569de423072
 SHA512:
-  metadata.gz: dd4fb7e33d330c4922c26b16449cd4ea5ef3998c2eda3376f127fafffcefb5193604f9cce5c381f0e86b239b859f1fe23979827c053edcf1f70cdeda8144f232
-  data.tar.gz: 34b39834c77beddbd95b4ebeff58483663210185a781f1c5e72a2a7213ddb9b67fe66e6a43dd047405f4eb2b23563c7f0a145e33bac209b63cf56ad4c54dd865
+  metadata.gz: 84285d30be1e24bf33c3eed5e893d172d9b201d0b0beb8608c519d0fc28468bb5a7225804d6ea50ebac7ebbaf9aa76cc268222bb1777b42b4dcfe9d9cbfc2fda
+  data.tar.gz: e29743feaeb25c857a55eb568bd21f0e3161ee9a19abc61a5bbc4d0c1e9d02c23cb49fc9df9bc7db553c17e3cbf410e55a5b2036fd1e8568a0bed0508b9f570b

data/.coveralls.yml

@@ -0,0 +1 @@
+repo_token: zDaEBy037OST98voxtIsbOPpyrTkqUXxi

data/.rubocop.yml

@@ -17,7 +17,7 @@ Style/Documentation:
   Enabled: false
 
 # Configuration parameters: AllowURI.
-Style/LineLength:
+Metrics/LineLength:
   Max: 1_00
 
 # Cop supports --auto-correct.
@@ -34,3 +34,13 @@ Style/AsciiComments:
 
 CyclomaticComplexity:
   Max: 10
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/SymbolProc:
+  Exclude:
+    - 'lib/kintone/query.rb'
+
+Style/SignalException:
+  EnforcedStyle: only_raise

data/.travis.yml

@@ -8,7 +8,21 @@ rvm:
   - 2.1.4
   - 2.1.5
   - 2.1.6
+  - 2.1.7
+  - 2.1.8
+  - 2.1.9
+  - 2.1.10
   - 2.2.0
   - 2.2.1
   - 2.2.2
-  - 2.3.0
+  - 2.2.3
+  - 2.2.4
+  - 2.2.5
+  - 2.2.6
+  - 2.3.0
+  - 2.3.1
+  - 2.3.2
+  - 2.3.3
+  - 2.4.0
+before_install:
+  - gem install rainbow

data/Guardfile

@@ -1,10 +1,10 @@
-guard :rspec, all_after_pass: false, all_on_start: false, cmd: 'bundle exec rspec' do
+guard :rspec, all_after_pass: false, all_on_start: false, cmd: 'rspec' do
   watch(%r{spec/.+_spec\.rb$})
   watch(%r{lib/(.+)\.rb$}) {|m| "spec/#{m[1]}_spec.rb"}
   watch(%r{lib/(.+)/.+\.rb$}) {|m| "spec/#{m[1]}_spec.rb"}
 end
 
-guard :rubocop, all_on_start: false, cmd: 'bundle exec rubocop' do
+guard :rubocop, all_on_start: false, cmd: 'rubocop' do
   watch(%r{.+\.rb$})
   watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
 end

data/README.md

@@ -1,6 +1,10 @@
 # kintone
 
 [![Build Status](https://travis-ci.org/jue58/kintone.svg?branch=master)](https://travis-ci.org/jue58/kintone)
+[![codebeat badge](https://codebeat.co/badges/7f66de05-57a4-4712-9706-0f33169f530b)](https://codebeat.co/projects/github-com-jue58-kintone)
+[![Coverage Status](https://coveralls.io/repos/github/jue58/kintone/badge.svg?branch=add-coveralls-settings)](https://coveralls.io/github/jue58/kintone?branch=add-coveralls-settings)
+[![Inline docs](http://inch-ci.org/github/jue58/kintone.svg?branch=master&style=shields)](http://inch-ci.org/github/jue58/kintone)
+[![Gem Version](https://badge.fury.io/rb/kintone.svg)](https://badge.fury.io/rb/kintone)
 
 A Ruby gem for communicating with the [kintone](https://kintone.cybozu.com/us/) REST API
 

data/kintone.gemspec

@@ -1,5 +1,4 @@
 # coding: utf-8
-# rubocop:disable Style/RegexpLiteral
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'kintone/version'
@@ -24,10 +23,9 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 1.5'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec', '~> 3.0.0'
-  spec.add_development_dependency 'rubocop', '~> 0.24.1'
+  spec.add_development_dependency 'rspec', '~> 3'
+  spec.add_development_dependency 'rubocop', '~> 0.44.1'
   spec.add_development_dependency 'webmock', '~> 1.18'
-  spec.add_development_dependency 'guard-rspec'
-  spec.add_development_dependency 'guard-rubocop'
   spec.add_development_dependency 'rspec-parameterized', '~> 0.1.2'
+  spec.add_development_dependency 'coveralls'
 end

data/lib/kintone/api.rb

@@ -5,29 +5,16 @@ require 'json'
 require 'kintone/command/accessor'
 require 'kintone/api/guest'
 require 'kintone/query'
+require 'kintone/kintone_error'
 
 class Kintone::Api
-  BASE_PATH = '/k/v1/'
-  COMMAND = '%s.json'
+  BASE_PATH = '/k/v1/'.freeze
+  COMMAND = '%s.json'.freeze
   ACCESSIBLE_COMMAND = [
-    :record,
-    :records,
-    :form,
-    :app_acl,
-    :record_acl,
-    :field_acl,
-    :template_space,
-    :space,
-    :space_body,
-    :space_thread,
-    :space_members,
-    :guests,
-    :app,
-    :apps,
-    :apis,
-    :bulk_request,
-    :bulk,
-    :file
+    :record, :records, :form, :app_acl, :record_acl,
+    :field_acl, :template_space, :space, :space_body, :space_thread,
+    :space_members, :guests, :app, :apps, :apis,
+    :bulk_request, :bulk, :file
   ].freeze
 
   def initialize(domain, user, password = nil)
@@ -54,6 +41,7 @@ class Kintone::Api
         request.url url
         request.params = params
       end
+    raise Kintone::KintoneError.new(response.body, response.status) if response.status != 200
     response.body
   end
 
@@ -64,6 +52,7 @@ class Kintone::Api
         request.headers['Content-Type'] = 'application/json'
         request.body = body.to_json
       end
+    raise Kintone::KintoneError.new(response.body, response.status) if response.status != 200
     response.body
   end
 
@@ -74,6 +63,7 @@ class Kintone::Api
         request.headers['Content-Type'] = 'application/json'
         request.body = body.to_json
       end
+    raise Kintone::KintoneError.new(response.body, response.status) if response.status != 200
     response.body
   end
 
@@ -84,6 +74,7 @@ class Kintone::Api
         request.headers['Content-Type'] = 'application/json'
         request.body = body.to_json
       end
+    raise Kintone::KintoneError.new(response.body, response.status) if response.status != 200
     response.body
   end
 
@@ -92,10 +83,9 @@ class Kintone::Api
       @connection.post do |request|
         request.url url
         request.headers['Content-Type'] = 'multipart/form-data'
-        request.body = { file: Faraday::UploadIO.new(
-          path, content_type, original_filename,
-          'Content-Disposition' => 'form-data') }
+        request.body = { file: Faraday::UploadIO.new(path, content_type, original_filename) }
       end
+    raise Kintone::KintoneError.new(response.body, response.status) if response.status != 200
     response.body['fileKey']
   end
 
@@ -103,10 +93,14 @@ class Kintone::Api
     if ACCESSIBLE_COMMAND.include?(name)
       CommandAccessor.send(name, self)
     else
-      super(name, *args)
+      super
     end
   end
 
+  def respond_to_missing?(name, *args)
+    ACCESSIBLE_COMMAND.include?(name) || super
+  end
+
   class CommandAccessor
     extend Kintone::Command::Accessor
   end

data/lib/kintone/api/guest.rb

@@ -6,7 +6,7 @@ class Kintone::Api
   class Guest
     extend Forwardable
 
-    GUEST_PATH = '/k/guest/%s/v1/'
+    GUEST_PATH = '/k/guest/%s/v1/'.freeze
     ACCESSIBLE_COMMAND = [
       :record,
       :records,
@@ -41,10 +41,14 @@ class Kintone::Api
       if ACCESSIBLE_COMMAND.include?(name)
         CommandAccessor.send(name, self)
       else
-        super(name, *args)
+        super
       end
     end
 
+    def respond_to_missing?(name, *args)
+      ACCESSIBLE_COMMAND.include?(name) || super
+    end
+
     class CommandAccessor
       extend Kintone::Command::Accessor
     end

data/lib/kintone/command/accessor.rb

@@ -99,6 +99,6 @@ class Kintone::Command
       SpaceGuests.new(api)
     end
 
-    alias_method :bulk, :bulk_request
+    alias bulk bulk_request
   end
 end

data/lib/kintone/command/guests.rb

@@ -13,5 +13,5 @@ class Kintone::Command::Guests < Kintone::Command
     @api.delete(@url, guests: guests)
   end
 
-  alias_method :create, :register
+  alias create register
 end

data/lib/kintone/command/record.rb

@@ -19,5 +19,5 @@ class Kintone::Command::Record < Kintone::Command
     @api.put(@url, body)
   end
 
-  alias_method :create, :register
+  alias create register
 end

data/lib/kintone/command/records.rb

@@ -5,8 +5,9 @@ class Kintone::Command::Records < Kintone::Command
     'records'
   end
 
-  def get(app, query, fields)
+  def get(app, query, fields, total_count: nil)
     params = { app: app, query: query.to_s }
+    params[:totalCount] = total_count if total_count
     fields.each_with_index { |v, i| params["fields[#{i}]"] = v }
     @api.get(@url, params)
   end
@@ -25,5 +26,5 @@ class Kintone::Command::Records < Kintone::Command
     @api.delete(@url, params)
   end
 
-  alias_method :create, :register
+  alias create register
 end

data/lib/kintone/kintone_error.rb

@@ -0,0 +1,11 @@
+class Kintone::KintoneError < StandardError
+  attr_reader :message_text, :id, :code, :http_status
+
+  def initialize(messages, http_status)
+    @message_text = messages['message']
+    @id = messages['id']
+    @code = messages['code']
+    @http_status = http_status
+    super(format('%s [%s] %s(%s)', @http_status, @code, @message_text, @id))
+  end
+end

data/lib/kintone/query.rb

@@ -68,7 +68,7 @@ class Kintone::Query
     to_s
   end
 
-  alias_method :f, :field
+  alias f field
 
   private
 

data/lib/kintone/version.rb

@@ -1,3 +1,3 @@
 module Kintone
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'.freeze
 end

data/spec/kintone/api/guest_spec.rb

@@ -25,8 +25,11 @@ describe Kintone::Api::Guest do
           headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' },
           query: params
         )
-        .to_return(body: "{\"abc\":\"def\"}", status: 200,
-                   headers: { 'Content-type' => 'application/json' })
+        .to_return(
+          body: '{"abc":"def"}',
+          status: 200,
+          headers: { 'Content-type' => 'application/json' }
+        )
     end
 
     subject { target.get(path, params) }
@@ -35,6 +38,25 @@ describe Kintone::Api::Guest do
     let(:params) { { p1: 'abc', p2: 'def' } }
 
     it { expect(subject).to eq 'abc' => 'def' }
+
+    context 'fail to request' do
+      before(:each) do
+        stub_request(
+          :get,
+          'https://example.cybozu.com/k/guest/1/v1/path.json'
+        )
+          .with(
+            headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' },
+            query: params
+          )
+          .to_return(
+            body: '{"message":"不正なJSON文字列です。","id":"1505999166-897850006","code":"CB_IJ01"}',
+            status: 500
+          )
+      end
+
+      it { expect { subject }.to raise_error Kintone::KintoneError }
+    end
   end
 
   describe '#post' do
@@ -45,10 +67,13 @@ describe Kintone::Api::Guest do
       )
         .with(
           headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' },
-          body: "{\"p1\":\"abc\",\"p2\":\"def\"}"
+          body: '{"p1":"abc","p2":"def"}'
+        )
+        .to_return(
+          body: '{"abc":"def"}',
+          status: 200,
+          headers: { 'Content-type' => 'application/json' }
         )
-        .to_return(body: "{\"abc\":\"def\"}", status: 200,
-                   headers: { 'Content-type' => 'application/json' })
     end
 
     subject { target.post(path, body) }
@@ -57,6 +82,25 @@ describe Kintone::Api::Guest do
     let(:body) { { 'p1' => 'abc', 'p2' => 'def' } }
 
     it { expect(subject).to eq 'abc' => 'def' }
+
+    context 'fail to request' do
+      before(:each) do
+        stub_request(
+          :post,
+          'https://example.cybozu.com/k/guest/1/v1/path.json'
+        )
+          .with(
+            headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' },
+            body: '{"p1":"abc","p2":"def"}'
+          )
+          .to_return(
+            body: '{"message":"不正なJSON文字列です。","id":"1505999166-897850006","code":"CB_IJ01"}',
+            status: 500
+          )
+      end
+
+      it { expect { subject }.to raise_error Kintone::KintoneError }
+    end
   end
 
   describe '#put' do
@@ -67,10 +111,13 @@ describe Kintone::Api::Guest do
       )
         .with(
           headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' },
-          body: "{\"p1\":\"abc\",\"p2\":\"def\"}"
+          body: '{"p1":"abc","p2":"def"}'
+        )
+        .to_return(
+          body: '{"abc":"def"}',
+          status: 200,
+          headers: { 'Content-type' => 'application/json' }
         )
-        .to_return(body: "{\"abc\":\"def\"}", status: 200,
-                   headers: { 'Content-type' => 'application/json' })
     end
 
     subject { target.put(path, body) }
@@ -79,6 +126,25 @@ describe Kintone::Api::Guest do
     let(:body) { { 'p1' => 'abc', 'p2' => 'def' } }
 
     it { expect(subject).to eq 'abc' => 'def' }
+
+    context 'fail to request' do
+      before(:each) do
+        stub_request(
+          :put,
+          'https://example.cybozu.com/k/guest/1/v1/path.json'
+        )
+          .with(
+            headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' },
+            body: '{"p1":"abc","p2":"def"}'
+          )
+          .to_return(
+            body: '{"message":"不正なJSON文字列です。","id":"1505999166-897850006","code":"CB_IJ01"}',
+            status: 500
+          )
+      end
+
+      it { expect { subject }.to raise_error Kintone::KintoneError }
+    end
   end
 
   describe '#delete' do
@@ -91,8 +157,11 @@ describe Kintone::Api::Guest do
           body: { 'p1' => 'abc', 'p2' => 'def' }.to_json,
           headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' }
         )
-        .to_return(body: "{\"abc\":\"def\"}", status: 200,
-                   headers: { 'Content-type' => 'application/json' })
+        .to_return(
+          body: '{"abc":"def"}',
+          status: 200,
+          headers: { 'Content-type' => 'application/json' }
+        )
     end
 
     subject { target.delete(path, params) }
@@ -101,6 +170,25 @@ describe Kintone::Api::Guest do
     let(:params) { { 'p1' => 'abc', 'p2' => 'def' } }
 
     it { expect(subject).to eq 'abc' => 'def' }
+
+    context 'fail to request' do
+      before(:each) do
+        stub_request(
+          :delete,
+          'https://example.cybozu.com/k/guest/1/v1/path.json'
+        )
+          .with(
+            body: { 'p1' => 'abc', 'p2' => 'def' }.to_json,
+            headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' }
+          )
+          .to_return(
+            body: '{"message":"不正なJSON文字列です。","id":"1505999166-897850006","code":"CB_IJ01"}',
+            status: 500
+          )
+      end
+
+      it { expect { subject }.to raise_error Kintone::KintoneError }
+    end
   end
 
   describe '#record' do