kingsly_certbot 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f918cc872b94fb857145acf72d39d5d832afcdc9e245df04da9162b98282d80f
-  data.tar.gz: efb37de505cc61020707ab4c3ed3ada16e5bedc110bedd0ac8806237f04d0754
+  metadata.gz: 5e525264e27c4abb5e41f87fc23c4111333f8672c64dffb56f69aca385c69120
+  data.tar.gz: b3b3cea79f1747964f44000f4883beac210cb857c3604d1cace166ea4cfd3940
 SHA512:
-  metadata.gz: a65a4a465a7cdabe2dabdd6267f1d05da358b58c067169972e4c3ae58bf845c280f99d403c4adda0c5eaeba4a9bfa103c48ead02c5800dc804ce83526d3ae5cf
-  data.tar.gz: bea614d762a02c1b459abcb051031ee1f05356294c616e0650e615fb38a00586a3f3656173e1bf1eabf4c19127ca51ec60ac2d724385fa2b1b362557fb050786
+  metadata.gz: ac47f45190d97fc9d440d683a0c9a689a77c31a624d88d365f2ee5654bcd191eed14a2b0f910277bf584b39dc1135e7bb1ab8a8b5cb6e85e90cbf859dbc8b2a4
+  data.tar.gz: 2819638266478f99cbaa4681c837b41963a8a71d5ea41b1bfe4ca75fbabc5e2b3816934cc81b832af0e39ca2882e2a7196ac533b1583c5eb69011155c42b6236

data/.rubocop.yml

@@ -14,6 +14,7 @@ Style/CommandLiteral:
 Metrics/BlockLength:
   Exclude:
     - 'spec/*'
+    - 'kingsly_certbot.gemspec'
 
 Metrics/PerceivedComplexity:
   Max: 8
@@ -29,4 +30,8 @@ Metrics/AbcSize:
 
 Metrics/ParameterLists:
   Exclude:
-    - 'lib/kingsly_certbot/kingsly_client.rb'
+    - 'lib/kingsly_certbot/kingsly_client.rb'
+
+Style/GlobalVars:
+  AllowedVariables:
+    - '$logger'

data/.ruby-version

@@ -1 +1 @@
-2.5.1
+2.5.3

data/Gemfile.lock

@@ -2,7 +2,7 @@ PATH
   remote: .
   specs:
     kingsly_certbot (0.1.0)
-      sentry-raven (~> 2.9.0)
+      sentry-raven (~> 2.9, >= 2.9.0)
 
 GEM
   remote: https://rubygems.org/
@@ -60,12 +60,12 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 2.0.1)
+  bundler (~> 2.0, >= 2.0.1)
   kingsly_certbot!
-  rake (~> 10.5.0)
-  rspec (~> 3.8.0)
+  rake (~> 10.5, >= 10.5.0)
+  rspec (~> 3.8, >= 3.8.0)
   rubocop (~> 0.63.1)
-  webmock (~> 3.5.1)
+  webmock (~> 3.5, >= 3.5.1)
 
 BUNDLED WITH
    2.0.1

data/README.md

@@ -16,6 +16,14 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+#### Running Test suite
+
+```
+$ mkdir /etc/ipsec.d
+$ sudo chown -R $USER:staff /etc/ipsec.d
+$ bundle exec rake
+```
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/gojekfarm/kingsly-certbot

data/bin/kingsly-certbot

@@ -4,18 +4,13 @@
 require 'kingsly_certbot'
 
 # kingsly-certbot --config /opt/kingsly-certbot/kingsly-certbot.conf
-log_dir = ENV['LOG_DIR'] || '/var/log'
-$logger = if Dir.exists?(log_dir)
-            Logger.new("#{log_dir}/kingsly-certbot.log", level: ENV['LOG_LEVEL'] || 'info')
-          else
-            Logger.new(STDOUT)
-          end
+$logger = Logger.new(STDOUT)
 certbot = begin
   KingslyCertbot::Runner.new(ARGV)
-rescue StandardError => e
-  $logger.fatal(e)
-  $logger.fatal(e.backtrace.join("\n"))
-  return 1
+          rescue StandardError => e
+            $logger.fatal(e)
+            $logger.fatal(e.backtrace.join("\n"))
+            return 1
 end
 
 certbot.configure.execute

data/kingsly-config.yaml.sample

@@ -1,8 +1,8 @@
 SENTRY_DSN:
 ENVIRONMENT: 'development'
-TOP_LEVEL_DOMAIN: 'go-life.co.id'
-SUB_DOMAIN: 'delete-thirty-one'
-KINGSLY_SERVER_HOST: 'integration-kingsly.golabs.io'
+TOP_LEVEL_DOMAIN: 'example.com'
+SUB_DOMAIN: 'subdomain'
+KINGSLY_SERVER_HOST: 'kingsly.example.com'
 KINGSLY_SERVER_USER: '****'
 KINGSLY_SERVER_PASSWORD: '****'
 SERVER_TYPE: 'ipsec'

data/lib/kingsly_certbot/configuration.rb

@@ -2,9 +2,9 @@
 
 module KingslyCertbot
   class Configuration
-    VARS = [:kingsly_server_host, :kingsly_server_user, :kingsly_server_password, :top_level_domain, :sub_domain,
-        :kingsly_http_read_timeout, :kingsly_http_open_timeout, :sentry_dsn, :environment, :server_type, :ipsec_root]
-    attr_accessor *VARS
+    VARS = %i[kingsly_server_host kingsly_server_user kingsly_server_password top_level_domain sub_domain
+              kingsly_http_read_timeout kingsly_http_open_timeout sentry_dsn environment server_type ipsec_root].freeze
+    attr_accessor(*VARS)
 
     def initialize(params = {})
       @kingsly_http_read_timeout = 120
@@ -32,9 +32,9 @@ module KingslyCertbot
     def to_s
       str = ''
       VARS.each do |key|
-        value = self.send(key)
-        value = "****" if key == :kingsly_server_password
-        str+="#{key.to_s}: '#{value}'\n"
+        value = send(key)
+        value = '****' if key == :kingsly_server_password
+        str += "#{key}: '#{value}'\n"
       end
       str
     end

data/lib/kingsly_certbot/ip_sec_cert_adapter.rb

@@ -48,12 +48,9 @@ module KingslyCertbot
     end
 
     def restart_service
-      result = %x(ipsec restart)
-      $logger.error("ipsec restart command failed with exitstatus: '#{result.exitstatus}'") unless result.success?
-      result.success?
-    rescue StandardError => e
-      $logger.fatal("ipsec restart command failed with error message: '#{e.message}'")
-      raise e
+      result = Kernel.system('ipsec restart')
+      $logger.error('ipsec restart command failed') unless result
+      result
     end
   end
 end

data/lib/kingsly_certbot/kingsly_client.rb

@@ -18,9 +18,10 @@ module KingslyCertbot
         'top_level_domain' => top_level_domain,
         'sub_domain' => sub_domain
       }
-      uri = URI.parse("http://#{kingsly_server_host}/v1/cert_bundles")
+      uri = URI.parse("https://#{kingsly_server_host}/v1/cert_bundles")
 
-      http = Net::HTTP.new(uri.host, '80')
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.use_ssl = true
 
       http.read_timeout = kingsly_http_read_timeout
       http.open_timeout = kingsly_http_open_timeout

data/lib/kingsly_certbot/runner.rb

@@ -6,7 +6,7 @@ module KingslyCertbot
 
     def initialize(args)
       raise 'Argument passed is not of type Array' if args.class != Array
-      raise '--config argument missing' if args[0] == nil || args[0].strip == ''
+      raise '--config argument missing' if args[0].nil? || args[0].strip == ''
       raise "Unknown argument '#{args[0]}'" if args[0] != '--config'
       raise "Config file does not exist at '#{args[1]}'" unless File.exist?(args[1])
 
@@ -22,7 +22,7 @@ module KingslyCertbot
       end
 
       @configuration = KingslyCertbot::Configuration.new(local_config)
-      $logger.info("Loaded configuration: #{@configuration.to_s}")
+      $logger.info("Loaded configuration: #{@configuration}")
       Raven.configure do |config|
         config.dsn = @configuration.sentry_dsn
         config.encoding = 'json'

data/lib/kingsly_certbot/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KingslyCertbot
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kingsly_certbot
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - FOSS at GO-JEK
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-31 00:00:00.000000000 Z
+date: 2019-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler