kinetic_cafe_error 1.9 → 1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fec4aacd3216e7dd65b34bc85e3c6f6a388de85d
-  data.tar.gz: b7456d64b7ad2bf4b8c0260d70543e552506de13
+  metadata.gz: ed2b06cb85a613bdd8ac56aa6e8216188f257395
+  data.tar.gz: 7077a564338ef9bb8f885c51e86c36033b975671
 SHA512:
-  metadata.gz: 777e6024ab58cc36d601b584dec51eb5ed0e9e2cc58b37741f75c71232568e5ada44653c283ea59c5aadcafb27b8675d363cec706a5b413ba202c8d84b963064
-  data.tar.gz: 85348156230d8e3ed1ef759b99202e06e1f0d24e8cc600fb032b0543fceae617f0041659bd9fe09540ab6b25f5648de866055f90d4d955c5e93dc59795f6058d
+  metadata.gz: 94f9b44dbd23fe6ac116dae799503402231d89d7ceb76fdec18cd781c6933d09e7ad471626bc515cfdd324275b25d11cd05981f6a1edb71dde6f530e8ab3840b
+  data.tar.gz: c0c6d9491699c4b9f184774552688b35c8fe0b21514e865d26811a4e488b7c5239329335850ab4fc6c4b42b3ddc26ac8ec1874e4f21ececbf9c0d2489c3b59b2

data/.travis.yml

@@ -1,19 +1,24 @@
 ---
 language: ruby
 rvm:
-  - 2.2.2
-  - 2.1.6
-  - jruby-9.0.0.0
+  - 2.3.0
+  - 2.2.4
+  - 2.1
+  - jruby-9.0.4.0
   - jruby-head
   - ruby-head
   - rbx-2
 matrix:
+  exclude:
+    - rvm: 2.1
+      gemfile: gemfiles/rack_2.gemfile
   allow_failures:
     - rvm: rbx-2
     - rvm: jruby-head
     - rvm: ruby-head
 gemfile:
-  - Gemfile
+  - gemfiles/rack_1.6.gemfile
+  - gemfiles/rack_2.gemfile
 before_script:
   - |
     case "${TRAVIS_RUBY_VERSION}" in

data/Appraisals

@@ -0,0 +1,7 @@
+appraise 'rack-1.6' do
+  gem 'rack', '~> 1.6'
+end
+
+appraise 'rack-2' do
+  gem 'rack', '~> 2.0.alpha'
+end

data/History.rdoc

@@ -1,3 +1,13 @@
+=== 1.10 / 2016-03-25
+
+* 1 bug fix:
+
+  * Protect against names with punctuation in them.
+
+* 1 testing change:
+
+  * Add Appraisals to test against both Rack 1.6 and Rack 2.0.
+
 === 1.9 / 2015-11-30
 
 * 2 bug fixes:

data/Manifest.txt

@@ -2,6 +2,7 @@
 .gemtest
 .rubocop.yml
 .travis.yml
+Appraisals
 Contributing.rdoc
 Gemfile
 History.rdoc
@@ -23,6 +24,8 @@ config/locales/kinetic_cafe_error.en-US.yml
 config/locales/kinetic_cafe_error.en.yml
 config/locales/kinetic_cafe_error.fr-CA.yml
 config/locales/kinetic_cafe_error.fr.yml
+gemfiles/rack_1.6.gemfile
+gemfiles/rack_2.gemfile
 lib/kinetic_cafe/error.rb
 lib/kinetic_cafe/error/minitest.rb
 lib/kinetic_cafe/error_dsl.rb

data/Rakefile

@@ -23,6 +23,7 @@ spec = Hoe.spec 'kinetic_cafe_error' do
 
   license 'MIT'
 
+  extra_dev_deps << ['appraisal', '~> 2.1']
   extra_dev_deps << ['hoe-doofus', '~> 1.0']
   extra_dev_deps << ['hoe-gemspec2', '~> 1.1']
   extra_dev_deps << ['hoe-git', '~> 1.6']

data/gemfiles/rack_1.6.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org/"
+
+gem "rack", "~> 1.6"
+
+gemspec :path => "../"

data/gemfiles/rack_2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org/"
+
+gem "rack", "~> 2.0.alpha"
+
+gemspec :path => "../"

data/lib/kinetic_cafe/error.rb

@@ -25,7 +25,7 @@ module KineticCafe # :nodoc:
   # rescue clause and handled there, as is shown in the included
   # KineticCafe::ErrorHandler controller concern for Rails.
   class Error < ::StandardError
-    VERSION = '1.9' # :nodoc:
+    VERSION = '1.10' # :nodoc:
 
     # Get the KineticCafe::Error functionality.
     include KineticCafe::ErrorModule

data/lib/kinetic_cafe/error_dsl.rb

@@ -103,6 +103,7 @@ module KineticCafe
       end
 
       key.tap do |k|
+        k.gsub!(/[^[:word:]]/, '_')
         k.squeeze!('_')
         k.gsub!(/^_+/, '')
         k.gsub!(/_+$/, '')
@@ -177,6 +178,8 @@ module KineticCafe
 
       if defined?(Rack::Utils) && rack_status
         Rack::Utils::SYMBOL_TO_STATUS_CODE.each_key do |name|
+          # Make the Rack names safe to use
+          name = name.to_s.gsub(/[^[:word:]]/, '_').squeeze('_').to_sym
           if rack_status.fetch(:methods, true)
             base.singleton_class.send :define_method, name do |options = {}|
               define_error(options.merge(status: name))

data/test/test_helper.rb

@@ -9,6 +9,8 @@ require 'minitest-bonus-assertions'
 require 'rack/test'
 require 'kinetic_cafe_error'
 
+puts "Testing with Rack.release #{Rack.release}"
+
 unless defined? I18n.translate
   module I18n
     def self.translate(*)

data/test/test_kinetic_cafe_error_dsl.rb

@@ -104,6 +104,12 @@ describe KineticCafe::ErrorDSL do
           refute base.private_instance_methods.include?(:default_severity)
           assert_equal :error, instance.send(:default_severity)
         end
+
+        it 'strips non-word characters from a key' do
+          child = base.define_error key: :"child(ren)"
+          instance = child.new
+          assert_equal 'child_ren', instance.name
+        end
       end
 
       describe 'class-based definition' do
@@ -184,6 +190,11 @@ describe KineticCafe::ErrorDSL do
             refute base.private_instance_methods.include?(:default_status)
             assert_equal :not_found, instance.send(:default_status)
           end
+
+          it 'strips non-word characters from a key' do
+            base.define_error class: :"child(ren)", status: :not_found
+            assert base.const_defined?(:ChildRenNotFound)
+          end
         end
 
         describe 'with numeric status' do
@@ -279,6 +290,20 @@ describe KineticCafe::ErrorDSL do
       assert base.respond_to?(:not_found)
       refute base.const_defined?(:NotFound)
     end
+
+    it 'protects against badly named Rack status symbols' do
+      begin
+        Rack::Utils::SYMBOL_TO_STATUS_CODE[:"another_(silly)_love_song"] = 999
+        base = Class.new(StandardError) do
+          extend KineticCafe::ErrorDSL
+        end
+        assert base.respond_to?(:another_silly_love_song)
+        assert base.const_defined?(:AnotherSillyLoveSong)
+      ensure
+        Rack::Utils::SYMBOL_TO_STATUS_CODE.delete(:"another_(silly)_love_song")
+        $debugme = false
+      end
+    end
   end
 
   describe 'when Rack::Utils is not defined' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kinetic_cafe_error
 version: !ruby/object:Gem::Version
-  version: '1.9'
+  version: '1.10'
 platform: ruby
 authors:
 - Austin Ziegler
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-30 00:00:00.000000000 Z
+date: 2016-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -39,6 +39,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: hoe-doofus
   requirement: !ruby/object:Gem::Requirement
@@ -317,6 +331,7 @@ files:
 - ".gemtest"
 - ".rubocop.yml"
 - ".travis.yml"
+- Appraisals
 - Contributing.rdoc
 - Gemfile
 - History.rdoc
@@ -338,6 +353,8 @@ files:
 - config/locales/kinetic_cafe_error.en.yml
 - config/locales/kinetic_cafe_error.fr-CA.yml
 - config/locales/kinetic_cafe_error.fr.yml
+- gemfiles/rack_1.6.gemfile
+- gemfiles/rack_2.gemfile
 - lib/kinetic_cafe/error.rb
 - lib/kinetic_cafe/error/minitest.rb
 - lib/kinetic_cafe/error_dsl.rb
@@ -373,7 +390,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: kinetic_cafe_error provides an API-smart error base class and a DSL for defining