kinetic_cafe_error 1.8.1 → 1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dc17826f6f7567f2438621fac02064e64fae64ba
-  data.tar.gz: 8ee581bf23ad9bbedcb42638e01d159773f02c35
+  metadata.gz: fec4aacd3216e7dd65b34bc85e3c6f6a388de85d
+  data.tar.gz: b7456d64b7ad2bf4b8c0260d70543e552506de13
 SHA512:
-  metadata.gz: 3398f8cefdabc226f3851a6b4ecf7e9a3dc0db0c135a66699341e71367ab53852745b09cf8856043ba79223a9e096c13ba83ff2405c008effe35979ae494e038
-  data.tar.gz: da175a041e62246c34e837723e0f631b9150f96891aec8271396464aaa3c09dcd456381aa689019bf9b17f04aa3b9b8110fe99874e21c9c143947fc60e1029f7
+  metadata.gz: 777e6024ab58cc36d601b584dec51eb5ed0e9e2cc58b37741f75c71232568e5ada44653c283ea59c5aadcafb27b8675d363cec706a5b413ba202c8d84b963064
+  data.tar.gz: 85348156230d8e3ed1ef759b99202e06e1f0d24e8cc600fb032b0543fceae617f0041659bd9fe09540ab6b25f5648de866055f90d4d955c5e93dc59795f6058d

data/.travis.yml

@@ -3,9 +3,6 @@ language: ruby
 rvm:
   - 2.2.2
   - 2.1.6
-  - 2.0.0
-  - 1.9.3
-  - jruby-1.7
   - jruby-9.0.0.0
   - jruby-head
   - ruby-head
@@ -28,10 +25,4 @@ before_script:
 script: rake travis
 after_script:
   - rake travis:after -t
-notifications:
-  email:
-    recipients:
-      - FIX@example.com
-    on_success: change
-    on_failure: always
 sudo: false

data/History.rdoc

@@ -1,3 +1,15 @@
+=== 1.9 / 2015-11-30
+
+* 2 bug fixes:
+
+  * The #stringify method needed to be moved to KineticCafe::ErrorModule so
+    that hierarchies *not* built from KineticCafe::Error can properly use query
+    parameter parsing.
+
+  * kinetic_cafe_error has required Ruby 2.1 or higher since version 1.5
+    because of the inclusion of i18n-tasks as a dependency. This is now
+    reflected in the dependencies.
+
 === 1.8.1 / 2015-10-26
 
 * Re-release because 1.8 was yanked

data/Rakefile

@@ -15,7 +15,7 @@ spec = Hoe.spec 'kinetic_cafe_error' do
   developer('Austin Ziegler', 'aziegler@kineticcafe.com')
   developer('Jero Sutlovic', 'jsutlovic@kineticcafe.com')
 
-  require_ruby_version '>= 1.9.2'
+  require_ruby_version '>= 2.1'
 
   self.history_file = 'History.rdoc'
   self.readme_file = 'README.rdoc'

data/lib/kinetic_cafe/error.rb

@@ -25,7 +25,7 @@ module KineticCafe # :nodoc:
   # rescue clause and handled there, as is shown in the included
   # KineticCafe::ErrorHandler controller concern for Rails.
   class Error < ::StandardError
-    VERSION = '1.8.1' # :nodoc:
+    VERSION = '1.9' # :nodoc:
 
     # Get the KineticCafe::Error functionality.
     include KineticCafe::ErrorModule
@@ -169,55 +169,6 @@ module KineticCafe # :nodoc:
         base.singleton_class.send :undef_method, :__rack_status
       end
     end
-
-    private
-
-    def default_status
-      defined?(Rack::Utils) && :bad_request || 400
-    end
-
-    def default_severity
-      :error
-    end
-
-    def stringify(object, namespace = nil)
-      case object
-      when Hash
-        stringify_hash(object, namespace).compact.sort.join('; ')
-      when Array
-        stringify_array(object, namespace)
-      else
-        stringify_value(namespace, object)
-      end
-    end
-
-    def stringify_hash(hash, namespace)
-      hash.collect do |key, value|
-        key = namespace ? "#{namespace}[#{key}]" : key
-        case value
-        when Hash
-          next if value.nil?
-          stringify(value, key)
-        when Array
-          stringify_array(key, value)
-        else
-          stringify_value(key, value)
-        end
-      end
-    end
-
-    def stringify_array(key, array)
-      key = "#{key}[]"
-      if array.empty?
-        stringify_value(key, [])
-      else
-        array.collect { |value| stringify(value, key) }.join(', ')
-      end
-    end
-
-    def stringify_value(key, value)
-      "#{key}: #{value}"
-    end
   end
 end
 

data/lib/kinetic_cafe/error_module.rb

@@ -200,6 +200,53 @@ module KineticCafe # :nodoc:
       @i18n_params.update(cause: @cause.message)
     end
 
+    def stringify(object, namespace = nil)
+      case object
+      when Hash
+        stringify_hash(object, namespace).compact.sort.join('; ')
+      when Array
+        stringify_array(object, namespace)
+      else
+        stringify_value(namespace, object)
+      end
+    end
+
+    def stringify_hash(hash, namespace)
+      hash.collect do |key, value|
+        key = namespace ? "#{namespace}[#{key}]" : key
+        case value
+        when Hash
+          next if value.nil?
+          stringify(value, key)
+        when Array
+          stringify_array(key, value)
+        else
+          stringify_value(key, value)
+        end
+      end
+    end
+
+    def stringify_array(key, array)
+      key = "#{key}[]"
+      if array.empty?
+        stringify_value(key, [])
+      else
+        array.collect { |value| stringify(value, key) }.join(', ')
+      end
+    end
+
+    def stringify_value(key, value)
+      "#{key}: #{value}"
+    end
+
+    def default_status
+      defined?(Rack::Utils) && :bad_request || 400
+    end
+
+    def default_severity
+      :error
+    end
+
     class << self
       ##
       # The base for I18n key resolution. Defaults to 'kcerrors'.

data/test/test_kinetic_cafe_error_hierarchy.rb

@@ -91,6 +91,12 @@ describe KineticCafe::Error, '.hierarchy' do
         assert My < KineticCafe::ErrorModule
       end
 
+      it 'can handle a query parameter (issue #9)' do
+        expected = { query: "id: 1" }
+        actual = My.new(query: { id: 1 }).instance_variable_get(:@i18n_params)
+        assert_equal expected, actual
+      end
+
       it 'cannot be extended a second time' do
         ex = assert_raises do
           KineticCafe::Error.hierarchy(class: :My)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kinetic_cafe_error
 version: !ruby/object:Gem::Version
-  version: 1.8.1
+  version: '1.9'
 platform: ruby
 authors:
 - Austin Ziegler
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-26 00:00:00.000000000 Z
+date: 2015-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -283,14 +283,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: '3.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: '3.14'
 description: |-
   kinetic_cafe_error provides an API-smart error base class and a DSL for
   defining errors. Under Rails, it also provides a controller concern
@@ -365,7 +365,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.2
+      version: '2.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="