killbill-paypal-express 4.1.5 → 4.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8dc36b7724efd4b473e338fcceee7e3ea0d5bbaa
-  data.tar.gz: e7bbff378a81f45c74e1d289d9d573ec6d9e87f2
+  metadata.gz: 0c56b36f1fd04db5756bbadd3a64ea7eac06e111
+  data.tar.gz: 2e42e9a3231f927b3450ccfe30c0477f094be7d2
 SHA512:
-  metadata.gz: 2a9e587a52da1a8d0a752fb47934649f9be28f7a532a9a1ecc9925c90f0a85e006547ce345d058ec250c4a055c092bae3428521ef3aa38b038baf3eac2797b56
-  data.tar.gz: 641a6f9b88cbee002bd99c4b9b5872b789395ef4a86e1a464ab3d904268d3d1ba1806e461c012790ce12bf5ab50022638a78ee842d623cadc0cd2803b7c16fd0
+  metadata.gz: 2cc2e615c35a73c63b86ede5736b25fe0894f3d4853673f68daa9e79c8a7e6af3ad0fffb86c9ffb400ef46baf0eb8a50674c15fab193038d7d7193ea04147241
+  data.tar.gz: 8df90f1dfd4fcc4dbe0c6ee9ea6ed64668993a25f2e75c39e049aa9f167a64a58539122883e523cbe873741ec886efff6d73b8659fa02964ec6de108c3d6ca44

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    killbill-paypal-express (4.1.5)
+    killbill-paypal-express (4.1.6)
       actionpack (~> 4.1.0)
       actionview (~> 4.1.0)
       activemerchant (~> 1.53.0)

data/NEWS

@@ -1,3 +1,6 @@
+4.1.6
+    Add invoice_id in refund call
+
 4.1.5
     Add more options to the build_form_descriptor call
 

data/VERSION

@@ -1 +1 @@
-4.1.5
+4.1.6

data/lib/paypal_express/ext/active_merchant/active_merchant.rb

@@ -13,6 +13,26 @@ module ActiveMerchant #:nodoc:
       def successful?(response)
         response[:error_codes] == DUPLICATE_REQUEST_CODE ? false : original_successful?(response)
       end
+
+      # Note: ActiveMerchant is missing InvoiceID in RefundTransactionReq.
+      # See https://github.com/activemerchant/active_merchant/blob/v1.48.0/lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb#L314
+      def build_refund_request(money, identification, options)
+        xml = Builder::XmlMarkup.new
+
+        xml.tag! 'RefundTransactionReq', 'xmlns' => PAYPAL_NAMESPACE do
+          xml.tag! 'RefundTransactionRequest', 'xmlns:n2' => EBAY_NAMESPACE do
+            xml.tag! 'n2:Version', API_VERSION
+            xml.tag! 'TransactionID', identification
+            xml.tag! 'Amount', amount(money), 'currencyID' => (options[:currency] || currency(money)) if money.present?
+            xml.tag! 'RefundType', (options[:refund_type] || (money.present? ? 'Partial' : 'Full'))
+            xml.tag! 'Memo', options[:note] unless options[:note].blank?
+            xml.tag! 'InvoiceID', (options[:order_id] || options[:invoice_id]) unless (options[:order_id] || options[:invoice_id]).blank?
+          end
+        end
+
+        xml.target!
+      end
+
     end
   end
 end

data/pom.xml

@@ -26,7 +26,7 @@
     <groupId>org.kill-bill.billing.plugin.ruby</groupId>
     <artifactId>paypal-express-plugin</artifactId>
     <packaging>pom</packaging>
-    <version>4.1.5</version>
+    <version>4.1.6</version>
     <name>paypal-express-plugin</name>
     <url>http://github.com/killbill/killbill-paypal-express-plugin</url>
     <description>Plugin for accessing Paypal Express Checkout as a payment gateway</description>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: killbill-paypal-express
 version: !ruby/object:Gem::Version
-  version: 4.1.5
+  version: 4.1.6
 platform: ruby
 authors:
 - Kill Bill core team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-06-14 00:00:00.000000000 Z
+date: 2016-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: killbill