killbill-paypal-express 4.1.2 → 4.1.3

data/spec/paypal_express/remote/hpp_spec_helpers.rb

@@ -0,0 +1,364 @@
+require_relative 'browser_helpers'
+
+module Killbill
+  module PaypalExpress
+    module HppSpecHelpers
+
+      include ::Killbill::PaypalExpress::BrowserHelpers
+
+      def hpp_setup
+        @call_context = build_call_context
+        @amount = BigDecimal.new('100')
+        @currency = 'USD'
+        @form_fields = @plugin.hash_to_properties(
+            :order_id => '1234',
+            :amount => @amount,
+            :currency => @currency
+        )
+        kb_account_id = SecureRandom.uuid
+        create_kb_account(kb_account_id, @plugin.kb_apis.proxied_services[:account_user_api])
+        @pm = create_payment_method(::Killbill::PaypalExpress::PaypalExpressPaymentMethod, kb_account_id, @call_context.tenant_id)
+        verify_payment_method kb_account_id
+      end
+
+      def validate_form(form)
+        form.kb_account_id.should == @pm.kb_account_id
+        form.form_url.should start_with('https://www.sandbox.paypal.com/cgi-bin/webscr')
+        form.form_method.should == 'GET'
+      end
+
+      def validate_nil_form_property(form, key)
+        key_properties = form.properties.select { |prop| prop.key == key }
+        key_properties.size.should == 0
+      end
+
+      def validate_form_property(form, key, value=nil)
+        key_properties = form.properties.select { |prop| prop.key == key }
+        key_properties.size.should == 1
+        key = key_properties.first.value
+        value.nil? ? key.should_not(be_nil) : key.should == value
+        key
+      end
+
+      def validate_token(form)
+        login_and_confirm form.form_url
+      end
+
+      def purchase_and_refund(kb_payment_id, purchase_payment_external_key, purchase_properties)
+        # Trigger the purchase
+        payment_response = @plugin.purchase_payment(@pm.kb_account_id, kb_payment_id, purchase_payment_external_key, @pm.kb_payment_method_id, @amount, @currency, purchase_properties, @call_context)
+        payment_response.status.should eq(:PROCESSED), payment_response.gateway_error
+        payment_response.amount.should == @amount
+        payment_response.transaction_type.should == :PURCHASE
+
+        # Verify GET API
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, [], @call_context)
+        payment_infos.size.should == 1
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :PURCHASE
+        payment_infos[0].amount.should == @amount
+        payment_infos[0].currency.should == @currency
+        payment_infos[0].status.should == :PROCESSED
+        payment_infos[0].gateway_error.should == 'Success'
+        payment_infos[0].gateway_error_code.should be_nil
+
+        # Try a full refund
+        refund_response = @plugin.refund_payment(@pm.kb_account_id, kb_payment_id, SecureRandom.uuid, @pm.kb_payment_method_id, @amount, @currency, [], @call_context)
+        refund_response.status.should eq(:PROCESSED), refund_response.gateway_error
+        refund_response.amount.should == @amount
+        refund_response.transaction_type.should == :REFUND
+
+        # Verify GET API
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, [], @call_context)
+        payment_infos.size.should == 2
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :PURCHASE
+        payment_infos[0].amount.should == @amount
+        payment_infos[0].currency.should == @currency
+        payment_infos[0].status.should == :PROCESSED
+        payment_infos[0].gateway_error.should == 'Success'
+        payment_infos[0].gateway_error_code.should be_nil
+        payment_infos[1].kb_payment_id.should.should == kb_payment_id
+        payment_infos[1].transaction_type.should == :REFUND
+        payment_infos[1].amount.should == @amount
+        payment_infos[1].currency.should == @currency
+        payment_infos[1].status.should == :PROCESSED
+        payment_infos[1].gateway_error.should == 'Success'
+        payment_infos[1].gateway_error_code.should be_nil
+      end
+
+      def authorize_capture_and_refund(kb_payment_id, payment_external_key, properties, payment_processor_account_id)
+        # Trigger the authorize
+        payment_response = @plugin.authorize_payment(@pm.kb_account_id, kb_payment_id, payment_external_key, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+        payment_response.status.should eq(:PROCESSED), payment_response.gateway_error
+        payment_response.amount.should == @amount
+        payment_response.transaction_type.should == :AUTHORIZE
+
+        # Verify GET AUTHORIZED PAYMENT
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, properties, @call_context)
+        payment_infos.size.should == 1
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :AUTHORIZE
+        payment_infos[0].amount.should == @amount
+        payment_infos[0].currency.should == @currency
+        payment_infos[0].status.should == :PROCESSED
+        payment_infos[0].gateway_error.should == 'Success'
+        payment_infos[0].gateway_error_code.should be_nil
+        find_value_from_properties(payment_infos[0].properties, 'paymentInfoPaymentStatus').should == 'Pending'
+        find_value_from_properties(payment_infos[0].properties, 'paymentInfoPendingReason').should == 'authorization'
+        find_value_from_properties(payment_infos[0].properties, 'payment_processor_account_id').should == payment_processor_account_id
+
+        # Trigger the capture
+        payment_response = @plugin.capture_payment(@pm.kb_account_id, kb_payment_id, payment_external_key, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+        payment_response.status.should eq(:PROCESSED), payment_response.gateway_error
+        payment_response.amount.should == @amount
+        payment_response.transaction_type.should == :CAPTURE
+
+        # Verify GET CAPTURED PAYMENT
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, properties, @call_context)
+        # Two expected transactions: one auth and one capture
+        payment_infos.size.should == 2
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :AUTHORIZE
+        payment_infos[0].amount.should == @amount
+        payment_infos[0].currency.should == @currency
+        payment_infos[0].status.should == :PROCESSED
+        payment_infos[0].gateway_error.should == 'Success'
+        payment_infos[0].gateway_error_code.should be_nil
+        find_value_from_properties(payment_infos[0].properties, 'payment_processor_account_id').should == payment_processor_account_id
+        payment_infos[1].kb_payment_id.should == kb_payment_id
+        payment_infos[1].transaction_type.should == :CAPTURE
+        payment_infos[1].amount.should == @amount
+        payment_infos[1].currency.should == @currency
+        payment_infos[1].status.should == :PROCESSED
+        payment_infos[1].gateway_error.should == 'Success'
+        payment_infos[1].gateway_error_code.should be_nil
+        find_value_from_properties(payment_infos[1].properties, 'paymentInfoPaymentStatus').should == 'Completed'
+        find_value_from_properties(payment_infos[1].properties, 'payment_processor_account_id').should == payment_processor_account_id
+
+        # Try a full refund
+        refund_response = @plugin.refund_payment(@pm.kb_account_id, kb_payment_id, SecureRandom.uuid, @pm.kb_payment_method_id, @amount, @currency, [], @call_context)
+        refund_response.status.should eq(:PROCESSED), refund_response.gateway_error
+        refund_response.amount.should == @amount
+        refund_response.transaction_type.should == :REFUND
+
+        # Verify GET API
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, properties, @call_context)
+        payment_infos.size.should == 3
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :AUTHORIZE
+        payment_infos[0].amount.should == @amount
+        payment_infos[0].currency.should == @currency
+        payment_infos[0].status.should == :PROCESSED
+        payment_infos[0].gateway_error.should == 'Success'
+        payment_infos[0].gateway_error_code.should be_nil
+        find_value_from_properties(payment_infos[0].properties, 'payment_processor_account_id').should == payment_processor_account_id
+        payment_infos[1].kb_payment_id.should == kb_payment_id
+        payment_infos[1].transaction_type.should == :CAPTURE
+        payment_infos[1].amount.should == @amount
+        payment_infos[1].currency.should == @currency
+        payment_infos[1].status.should == :PROCESSED
+        payment_infos[1].gateway_error.should == 'Success'
+        payment_infos[1].gateway_error_code.should be_nil
+        find_value_from_properties(payment_infos[1].properties, 'payment_processor_account_id').should == payment_processor_account_id
+        payment_infos[2].kb_payment_id.should.should == kb_payment_id
+        payment_infos[2].transaction_type.should == :REFUND
+        payment_infos[2].amount.should == @amount
+        payment_infos[2].currency.should == @currency
+        payment_infos[2].status.should == :PROCESSED
+        payment_infos[2].gateway_error.should == 'Success'
+        payment_infos[2].gateway_error_code.should be_nil
+        find_value_from_properties(payment_infos[2].properties, 'payment_processor_account_id').should == payment_processor_account_id
+      end
+
+      def authorize_and_double_capture(kb_payment_id, payment_external_key, properties)
+        # Trigger the authorize
+        payment_response = @plugin.authorize_payment(@pm.kb_account_id, kb_payment_id, payment_external_key, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+        payment_response.status.should eq(:PROCESSED), payment_response.gateway_error
+        payment_response.amount.should == @amount
+        payment_response.transaction_type.should == :AUTHORIZE
+
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, properties, @call_context)
+        payment_infos.size.should == 1
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :AUTHORIZE
+        payment_infos[0].amount.should == @amount
+        payment_infos[0].currency.should == @currency
+        payment_infos[0].status.should == :PROCESSED
+        payment_infos[0].gateway_error.should == 'Success'
+        payment_infos[0].gateway_error_code.should be_nil
+
+        # Trigger the capture
+        payment_response = @plugin.capture_payment(@pm.kb_account_id, kb_payment_id, payment_external_key, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+        payment_response.status.should eq(:PROCESSED), payment_response.gateway_error
+        payment_response.amount.should == @amount
+        payment_response.transaction_type.should == :CAPTURE
+
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, properties, @call_context)
+        payment_infos.size.should == 2
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :AUTHORIZE
+        payment_infos[0].amount.should == @amount
+        payment_infos[0].currency.should == @currency
+        payment_infos[0].status.should == :PROCESSED
+        payment_infos[0].gateway_error.should == 'Success'
+        payment_infos[0].gateway_error_code.should be_nil
+        payment_infos[1].kb_payment_id.should == kb_payment_id
+        payment_infos[1].transaction_type.should == :CAPTURE
+        payment_infos[1].amount.should == @amount
+        payment_infos[1].currency.should == @currency
+        payment_infos[1].status.should == :PROCESSED
+        payment_infos[1].gateway_error.should == 'Success'
+        payment_infos[1].gateway_error_code.should be_nil
+
+        # Trigger a capture again with full amount
+        payment_response = @plugin.capture_payment(@pm.kb_account_id, kb_payment_id, payment_external_key, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+        payment_response.status.should eq(:ERROR), payment_response.gateway_error
+        payment_response.amount.should == nil
+        payment_response.transaction_type.should == :CAPTURE
+
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, properties, @call_context)
+        payment_infos.size.should == 3
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :AUTHORIZE
+        payment_infos[0].amount.should == @amount
+        payment_infos[0].currency.should == @currency
+        payment_infos[0].status.should == :PROCESSED
+        payment_infos[0].gateway_error.should == 'Success'
+        payment_infos[0].gateway_error_code.should be_nil
+        payment_infos[1].kb_payment_id.should == kb_payment_id
+        payment_infos[1].transaction_type.should == :CAPTURE
+        payment_infos[1].amount.should == @amount
+        payment_infos[1].currency.should == @currency
+        payment_infos[1].status.should == :PROCESSED
+        payment_infos[1].gateway_error.should == 'Success'
+        payment_infos[1].gateway_error_code.should be_nil
+        payment_infos[2].kb_payment_id.should.should == kb_payment_id
+        payment_infos[2].transaction_type.should == :CAPTURE
+        payment_infos[2].amount.should be_nil
+        payment_infos[2].currency.should be_nil
+        payment_infos[2].status.should == :ERROR
+        payment_infos[2].gateway_error.should == 'Authorization has already been completed.'
+        payment_infos[2].gateway_error_code.should be_nil
+      end
+
+      def authorize_and_void(kb_payment_id, payment_external_key, properties, payment_processor_account_id)
+        # Trigger the authorize
+        payment_response = @plugin.authorize_payment(@pm.kb_account_id, kb_payment_id, payment_external_key, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+        payment_response.status.should eq(:PROCESSED), payment_response.gateway_error
+        payment_response.amount.should == @amount
+        payment_response.transaction_type.should == :AUTHORIZE
+
+        # Verify get_payment_info
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, properties, @call_context)
+        payment_infos.size.should == 1
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :AUTHORIZE
+        payment_infos[0].amount.should == @amount
+        payment_infos[0].currency.should == @currency
+        payment_infos[0].status.should == :PROCESSED
+        payment_infos[0].gateway_error.should == 'Success'
+        payment_infos[0].gateway_error_code.should be_nil
+        find_value_from_properties(payment_infos[0].properties, 'payment_processor_account_id').should == payment_processor_account_id
+
+        # Trigger the void
+        payment_response = @plugin.void_payment(@pm.kb_account_id, kb_payment_id, payment_external_key, @pm.kb_payment_method_id, properties, @call_context)
+        payment_response.status.should eq(:PROCESSED), payment_response.gateway_error
+        payment_response.transaction_type.should == :VOID
+
+        # Verify get_payment_info
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, properties, @call_context)
+        # Two expected transactions: one auth and one capture
+        payment_infos.size.should == 2
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :AUTHORIZE
+        payment_infos[0].amount.should == @amount
+        payment_infos[0].currency.should == @currency
+        payment_infos[0].status.should == :PROCESSED
+        payment_infos[0].gateway_error.should == 'Success'
+        payment_infos[0].gateway_error_code.should be_nil
+        find_value_from_properties(payment_infos[0].properties, 'payment_processor_account_id').should == payment_processor_account_id
+        payment_infos[1].kb_payment_id.should == kb_payment_id
+        payment_infos[1].transaction_type.should == :VOID
+        payment_infos[1].status.should == :PROCESSED
+        payment_infos[1].gateway_error.should == 'Success'
+        payment_infos[1].gateway_error_code.should be_nil
+        find_value_from_properties(payment_infos[1].properties, 'payment_processor_account_id').should == payment_processor_account_id
+      end
+
+      def purchase_with_missing_token
+        failed_purchase([], :CANCELED, 'Could not find the payer_id: the token is missing', 'RuntimeError')
+      end
+
+      def authorize_with_missing_token
+        failed_authorize([], :CANCELED, 'Could not find the payer_id: the token is missing', 'RuntimeError')
+      end
+
+      def purchase_with_invalid_token(purchase_properties)
+        failed_purchase(purchase_properties, :CANCELED, "Could not find the payer_id for token #{properties_to_hash(purchase_properties)[:token]}", 'RuntimeError')
+      end
+
+      def authorize_with_invalid_token(authorize_properties)
+        failed_authorize(authorize_properties, :CANCELED, "Could not find the payer_id for token #{properties_to_hash(authorize_properties)[:token]}", 'RuntimeError')
+      end
+
+      def subsequent_purchase(purchase_properties)
+        failed_purchase(purchase_properties, :ERROR, 'A successful transaction has already been completed for this token.')
+      end
+
+      def failed_authorize(authorize_properties, status, msg, gateway_error_code=nil)
+        kb_payment_id = SecureRandom.uuid
+
+        payment_response = @plugin.authorize_payment(@pm.kb_account_id, kb_payment_id, SecureRandom.uuid, @pm.kb_payment_method_id, @amount, @currency, authorize_properties, @call_context)
+        payment_response.status.should eq(status), payment_response.gateway_error
+        payment_response.amount.should be_nil
+        payment_response.transaction_type.should == :AUTHORIZE
+
+        # Verify GET API
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, [], @call_context)
+        payment_infos.size.should == 1
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :AUTHORIZE
+        payment_infos[0].amount.should be_nil
+        payment_infos[0].currency.should be_nil
+        payment_infos[0].status.should == status
+        payment_infos[0].gateway_error.should == msg
+        payment_infos[0].gateway_error_code.should == gateway_error_code
+      end
+
+      def failed_purchase(purchase_properties, status, msg, gateway_error_code=nil)
+        kb_payment_id = SecureRandom.uuid
+
+        payment_response = @plugin.purchase_payment(@pm.kb_account_id, kb_payment_id, SecureRandom.uuid, @pm.kb_payment_method_id, @amount, @currency, purchase_properties, @call_context)
+        payment_response.status.should eq(status), payment_response.gateway_error
+        payment_response.amount.should be_nil
+        payment_response.transaction_type.should == :PURCHASE
+
+        # Verify GET API
+        payment_infos = @plugin.get_payment_info(@pm.kb_account_id, kb_payment_id, [], @call_context)
+        payment_infos.size.should == 1
+        payment_infos[0].kb_payment_id.should == kb_payment_id
+        payment_infos[0].transaction_type.should == :PURCHASE
+        payment_infos[0].amount.should be_nil
+        payment_infos[0].currency.should be_nil
+        payment_infos[0].status.should == status
+        payment_infos[0].gateway_error.should == msg
+        payment_infos[0].gateway_error_code.should == gateway_error_code
+      end
+
+      private
+
+      def verify_payment_method(kb_account_id = nil)
+        # Verify our table directly
+        kb_account_id = @pm.kb_account_id if kb_account_id.nil?
+        payment_methods = ::Killbill::PaypalExpress::PaypalExpressPaymentMethod.from_kb_account_id(kb_account_id, @call_context.tenant_id)
+        payment_methods.size.should == 1
+        payment_method = payment_methods.first
+        payment_method.should_not be_nil
+        payment_method.paypal_express_payer_id.should be_nil
+        payment_method.token.should be_nil
+        payment_method.kb_payment_method_id.should == @pm.kb_payment_method_id
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -18,7 +18,7 @@ ActiveRecord::Base.establish_connection(
     :database => 'test.db'
 )
 # For debugging
-#ActiveRecord::Base.logger = Logger.new(STDOUT)
+# ActiveRecord::Base.logger = Logger.new(STDOUT)
 # Create the schema
 require File.expand_path(File.dirname(__FILE__) + '../../db/schema.rb')
 
@@ -41,4 +41,17 @@ class PaypalExpressJavaPaymentApi < ::Killbill::Plugin::ActiveMerchant::RSpec::F
 
     kb_payment
   end
+
+  def create_authorization(kb_account, kb_payment_method_id, kb_payment_id, amount, currency, payment_external_key, payment_transaction_external_key, properties, context)
+    kb_payment = add_payment(kb_payment_id || SecureRandom.uuid, SecureRandom.uuid, payment_transaction_external_key, :AUTHORIZE)
+
+    rcontext = context.to_ruby(context)
+    @plugin.authorize_payment(kb_account.id, kb_payment.id, kb_payment.transactions.last.id, kb_payment_method_id, amount, currency, properties, rcontext)
+
+    kb_payment
+  end
+
+  def delete_all_payments
+    @payments = []
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: killbill-paypal-express
 version: !ruby/object:Gem::Version
-  version: 4.1.2
+  version: 4.1.3
 platform: ruby
 authors:
 - Kill Bill core team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-04-11 00:00:00.000000000 Z
+date: 2016-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: killbill
@@ -240,6 +240,20 @@ dependencies:
         version: 2.12.0
   prerelease: false
   type: :development
+- !ruby/object:Gem::Dependency
+  name: selenium-webdriver
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.53.0
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.53.0
+  prerelease: false
+  type: :development
 - !ruby/object:Gem::Dependency
   name: jdbc-sqlite3
   version_requirements: !ruby/object:Gem::Requirement
@@ -320,7 +334,11 @@ files:
 - release.sh
 - spec/paypal_express/base_plugin_spec.rb
 - spec/paypal_express/remote/baid_spec.rb
+- spec/paypal_express/remote/baid_spec_helpers.rb
+- spec/paypal_express/remote/browser_helpers.rb
+- spec/paypal_express/remote/build_plugin_helpers.rb
 - spec/paypal_express/remote/hpp_spec.rb
+- spec/paypal_express/remote/hpp_spec_helpers.rb
 - spec/spec_helper.rb
 homepage: http://killbill.io
 licenses: