killbill-paypal-express 1.5.4 → 1.6.0

data/.travis.yml

@@ -2,21 +2,18 @@ language: ruby
 
 notifications:
   email:
-    - killbilling-dev@googlegroups.com
+    - kill-bill-commits@googlegroups.com
 
 rvm:
-  - 1.9.2
-  - 1.9.3
-  - ruby-head
   - jruby-19mode
+  - jruby-20mode
   - jruby-head
 
 jdk:
+  - openjdk6
   - openjdk7
   - oraclejdk7
-  - openjdk6
 
 matrix:
   allow_failures:
-    - rvm: ruby-head
     - rvm: jruby-head

data/Jarfile

@@ -1,5 +1,5 @@
-jar 'com.ning.billing:killbill-api', '0.6.0'
-jar 'com.ning.billing.plugin:killbill-plugin-api-notification', '0.4.0'
-jar 'com.ning.billing.plugin:killbill-plugin-api-payment', '0.4.0'
-jar 'com.ning.billing:killbill-util:tests', '0.6.0'
+jar 'com.ning.billing:killbill-api', '0.7.1'
+jar 'com.ning.billing.plugin:killbill-plugin-api-notification', '0.5.0'
+jar 'com.ning.billing.plugin:killbill-plugin-api-payment', '0.5.0'
+jar 'com.ning.billing:killbill-util:tests', '0.6.17'
 jar 'javax.servlet:javax.servlet-api', '3.0.1'

data/NEWS

@@ -1,3 +1,8 @@
+1.6.0
+    Add pagination support for search
+    Improve search algorithm
+    Allow setting of default payment description in configuration file
+
 1.5.4
     Fix issue #1
 

data/VERSION

@@ -1 +1 @@
-1.5.4
+1.6.0

data/db/ddl.sql

@@ -82,6 +82,6 @@ CREATE TABLE `paypal_express_responses` (
   `success` tinyint(1) DEFAULT NULL,
   `created_at` datetime NOT NULL,
   `updated_at` datetime NOT NULL,
-  PRIMARY KEY (`id`)
+  PRIMARY KEY (`id`),
   KEY `index_paypal_express_responses_on_token_and_api_call` (`token`, `api_call`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;

data/killbill-paypal-express.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |s|
 
   s.rdoc_options << '--exclude' << '.'
 
-  s.add_dependency 'killbill', '~> 1.6.0'
+  s.add_dependency 'killbill', '~> 1.7.1'
   s.add_dependency 'activemerchant', '~> 1.36.0'
   s.add_dependency 'activerecord', '~> 3.2.1'
   s.add_dependency 'sinatra', '~> 1.3.4'

data/lib/paypal_express/api.rb

@@ -26,7 +26,7 @@ module Killbill::PaypalExpress
       options[:currency] ||= currency.to_s
       options[:payment_type] ||= 'Any'
       options[:invoice_id] ||= kb_payment_id
-      options[:description] ||= "Kill Bill payment for #{kb_payment_id}"
+      options[:description] ||= Killbill::PaypalExpress.paypal_payment_description || "Kill Bill payment for #{kb_payment_id}"
       options[:ip] ||= @ip
 
       if options[:reference_id].blank?
@@ -166,8 +166,8 @@ module Killbill::PaypalExpress
       end
     end
 
-    def search_payment_methods(search_key, call_context = nil, options = {})
-      PaypalExpressPaymentMethod.search(search_key).map(&:to_payment_method_response)
+    def search_payment_methods(search_key, offset = 0, limit = 100, call_context = nil, options = {})
+      PaypalExpressPaymentMethod.search(search_key, offset, limit)
     end
 
     private

data/lib/paypal_express/config/configuration.rb

@@ -6,6 +6,7 @@ module Killbill::PaypalExpress
   mattr_reader :gateway
   mattr_reader :paypal_sandbox_url
   mattr_reader :paypal_production_url
+  mattr_reader :paypal_payment_description
   mattr_reader :initialized
   mattr_reader :test
 
@@ -16,9 +17,12 @@ module Killbill::PaypalExpress
     @@config = Properties.new(config_file)
     @@config.parse!
 
+    @@logger.log_level = Logger::DEBUG if (@@config[:logger] || {})[:debug]
+
     @@paypal_sandbox_url = @@config[:paypal][:sandbox_url] || 'https://www.sandbox.paypal.com/cgi-bin/webscr'
     @@paypal_production_url = @@config[:paypal][:production_url] || 'https://www.paypal.com/cgi-bin/webscr'
     @@test = @@config[:paypal][:test]
+    @@paypal_payment_description = @@config[:paypal][:payment_description]
 
     @@gateway = Killbill::PaypalExpress::Gateway.instance
     @@gateway.configure(@@config[:paypal])
@@ -30,7 +34,8 @@ module Killbill::PaypalExpress
     end
 
     ActiveRecord::Base.establish_connection(@@config[:database])
+    ActiveRecord::Base.logger = @@logger
 
     @@initialized = true
   end
-end
+end

data/lib/paypal_express/models/paypal_express_payment_method.rb

@@ -33,14 +33,52 @@ module Killbill::PaypalExpress
       payment_method.save!
     end
 
-    def self.search(search_key)
-      search_columns = [
-                         :paypal_express_payer_id,
-                         :paypal_express_baid,
-                         :paypal_express_token
-                       ]
-      query = search_columns.map(&:to_s).join(' like ? or ') + ' like ?'
-      where(query, *search_columns.map { |e| "%#{search_key}%" })
+    # VisibleForTesting
+    def self.search_query(search_key, offset = nil, limit = nil)
+      t = self.arel_table
+      tr = PaypalExpressResponse.arel_table
+
+      # Note 1: Exact match for ids and email, partial match for name
+      # Note 2: Creating a payment method is a two-step process. We first create a placeholder during the SetExpressCheckout call, which
+      # doesn't have a kb_payment_method_id (nor a paypal_express_payer_id). During the CreateBillingAgreement call, both attributes
+      # will be populated, as well as the baid. If the second step is never completed, the payment method placeholder is garbage and
+      # we want to ignore it.
+      query = t.join(tr, Arel::Nodes::OuterJoin).on(     tr[:api_call].eq('details_for')
+                                                    .and(tr[:success].eq(true))
+                                                    .and(tr[:token].eq(t[:paypal_express_token])))
+               .where(    t[:paypal_express_payer_id].eq(search_key)
+                      .or(t[:paypal_express_baid].eq(search_key))
+                      .or(t[:paypal_express_token].eq(search_key))
+                      .or(tr[:payer_email].eq(search_key))
+                      .or(tr[:payer_name].matches("%#{search_key}%")))
+               .where(t[:kb_payment_method_id].not_eq(nil))
+               .order(t[:id])
+      if offset.blank? and limit.blank?
+        # true is for count distinct
+        query.project(t[:id].count(true))
+      else
+        query.skip(offset) unless offset.blank?
+        query.take(limit) unless limit.blank?
+        query.project(t[Arel.star])
+        # Not chainable
+        query.distinct
+      end
+      query
+    end
+
+    def self.search(search_key, offset = 0, limit = 100)
+      pagination = Killbill::Plugin::Model::Pagination.new
+      pagination.current_offset = offset
+      pagination.total_nb_records = self.count_by_sql(self.search_query(search_key))
+      pagination.max_nb_records = self.where('kb_payment_method_id is not NULL').count
+      pagination.next_offset = (!pagination.total_nb_records.nil? && offset + limit >= pagination.total_nb_records) ? nil : offset + limit
+      # Reduce the limit if the specified value is larger than the number of records
+      actual_limit = [pagination.max_nb_records, limit].min
+      pagination.iterator = StreamyResultSet.new(actual_limit) do |offset,limit|
+        self.find_by_sql(self.search_query(search_key, offset, limit))
+            .map(&:to_payment_method_response)
+      end
+      pagination
     end
 
     def to_payment_method_response

data/lib/paypal_express/paypal_express_utils.rb

@@ -14,4 +14,30 @@ module Killbill::PaypalExpress
       @@first_public_ipv4 ||= Socket.ip_address_list.detect{ |intf| intf.ipv4? and !intf.ipv4_loopback? and !intf.ipv4_multicast? and !intf.ipv4_private? }
     end
   end
-end
+
+  # Closest from a streaming API as we can get with ActiveRecord
+  class StreamyResultSet
+    include Enumerable
+
+    def initialize(limit, batch_size = 100, &delegate)
+      @limit = limit
+      @batch = [batch_size, limit].min
+      @delegate = delegate
+    end
+
+    def each(&block)
+      (0..(@limit - @batch)).step(@batch) do |i|
+        result = @delegate.call(i, @batch)
+        block.call(result)
+        # Optimization: bail out if no more results
+        break if result.nil? || result.empty?
+      end if @batch > 0
+      # Make sure to return DB connections to the Pool
+      ActiveRecord::Base.connection.close
+    end
+
+    def to_a
+      super.to_a.flatten
+    end
+  end
+end

data/pom.xml

@@ -25,7 +25,7 @@
     <groupId>com.ning.killbill.ruby</groupId>
     <artifactId>paypal-express-plugin</artifactId>
     <packaging>pom</packaging>
-    <version>1.5.4</version>
+    <version>1.6.0</version>
     <name>paypal-express-plugin</name>
     <url>http://github.com/killbill/killbill-paypal-express-plugin</url>
     <description>Plugin for accessing paypal as a payment gateway</description>

data/spec/paypal_express/base_plugin_spec.rb

@@ -18,6 +18,7 @@ describe Killbill::PaypalExpress::PaymentPlugin do
 
       @plugin = Killbill::PaypalExpress::PaymentPlugin.new
       @plugin.logger = Logger.new(STDOUT)
+      @plugin.logger.level = Logger::INFO
       @plugin.conf_dir = File.dirname(file)
 
       # Start the plugin here - since the config file will be deleted

data/spec/paypal_express/paypal_express_payment_method_spec.rb

@@ -1,8 +1,37 @@
 require 'spec_helper'
 
 describe Killbill::PaypalExpress::PaypalExpressPaymentMethod do
+  before :all do
+    Killbill::PaypalExpress::PaypalExpressPaymentMethod.delete_all
+  end
+
+  it 'should ignore in search results payment methods without a kb payment method id' do
+    kb_account_id = SecureRandom.uuid
+    token = SecureRandom.uuid
+    pm1 = Killbill::PaypalExpress::PaypalExpressPaymentMethod.create :kb_account_id => kb_account_id,
+                                                                     :kb_payment_method_id => SecureRandom.uuid,
+                                                                     :paypal_express_payer_id => SecureRandom.uuid,
+                                                                     :paypal_express_baid => SecureRandom.uuid,
+                                                                     :paypal_express_token => token
+    # Token, but not baid/kb payment method id
+    pm2 = Killbill::PaypalExpress::PaypalExpressPaymentMethod.create :kb_account_id => kb_account_id,
+                                                                     :paypal_express_token => token
+
+    do_search(token).size.should == 1
+  end
+
+  it 'should generate the right SQL query' do
+    # Check count query
+    expected_query = "SELECT COUNT(DISTINCT \"paypal_express_payment_methods\".\"id\") FROM \"paypal_express_payment_methods\" LEFT OUTER JOIN \"paypal_express_responses\" ON \"paypal_express_responses\".\"api_call\" = 'details_for' AND \"paypal_express_responses\".\"success\" = 't' AND \"paypal_express_responses\".\"token\" = \"paypal_express_payment_methods\".\"paypal_express_token\" WHERE ((((\"paypal_express_payment_methods\".\"paypal_express_payer_id\" = 'XXX' OR \"paypal_express_payment_methods\".\"paypal_express_baid\" = 'XXX') OR \"paypal_express_payment_methods\".\"paypal_express_token\" = 'XXX') OR \"paypal_express_responses\".\"payer_email\" = 'XXX') OR \"paypal_express_responses\".\"payer_name\" LIKE '%XXX%') AND \"paypal_express_payment_methods\".\"kb_payment_method_id\" IS NOT NULL ORDER BY \"paypal_express_payment_methods\".\"id\""
+    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search_query('XXX').to_sql.should == expected_query
+
+    # Check query with results
+    expected_query = "SELECT  DISTINCT \"paypal_express_payment_methods\".* FROM \"paypal_express_payment_methods\" LEFT OUTER JOIN \"paypal_express_responses\" ON \"paypal_express_responses\".\"api_call\" = 'details_for' AND \"paypal_express_responses\".\"success\" = 't' AND \"paypal_express_responses\".\"token\" = \"paypal_express_payment_methods\".\"paypal_express_token\" WHERE ((((\"paypal_express_payment_methods\".\"paypal_express_payer_id\" = 'XXX' OR \"paypal_express_payment_methods\".\"paypal_express_baid\" = 'XXX') OR \"paypal_express_payment_methods\".\"paypal_express_token\" = 'XXX') OR \"paypal_express_responses\".\"payer_email\" = 'XXX') OR \"paypal_express_responses\".\"payer_name\" LIKE '%XXX%') AND \"paypal_express_payment_methods\".\"kb_payment_method_id\" IS NOT NULL ORDER BY \"paypal_express_payment_methods\".\"id\" LIMIT 10 OFFSET 0"
+    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search_query('XXX', 0, 10).to_sql.should == expected_query
+  end
+
   it 'should search all fields' do
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search('foo').size.should == 0
+    do_search('foo').size.should == 0
 
     pm = Killbill::PaypalExpress::PaypalExpressPaymentMethod.create :kb_account_id => '11-22-33-44',
                                                                     :kb_payment_method_id => '55-66-77-88',
@@ -10,11 +39,12 @@ describe Killbill::PaypalExpress::PaypalExpressPaymentMethod do
                                                                     :paypal_express_baid => 'baid',
                                                                     :paypal_express_token => 'token'
 
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search('foo').size.should == 0
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search(pm.paypal_express_payer_id).size.should == 1
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search('baid').size.should == 1
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search('token').size.should == 1
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search(2343).size.should == 1
+    do_search('foo').size.should == 0
+    do_search(pm.paypal_express_payer_id).size.should == 1
+    do_search('baid').size.should == 1
+    do_search('token').size.should == 1
+    # No partial match for payer id
+    do_search(2343).size.should == 0
 
     pm2 = Killbill::PaypalExpress::PaypalExpressPaymentMethod.create :kb_account_id => '22-33-44-55',
                                                                      :kb_payment_method_id => '66-77-88-99',
@@ -22,11 +52,79 @@ describe Killbill::PaypalExpress::PaypalExpressPaymentMethod do
                                                                      :paypal_express_baid => 'baid',
                                                                      :paypal_express_token => 'token'
 
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search('foo').size.should == 0
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search(pm.paypal_express_payer_id).size.should == 1
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search(pm2.paypal_express_payer_id).size.should == 1
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search('baid').size.should == 2
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search('token').size.should == 2
-    Killbill::PaypalExpress::PaypalExpressPaymentMethod.search(2343).size.should == 1
+    do_search('foo').size.should == 0
+    do_search(pm.paypal_express_payer_id).size.should == 1
+    do_search(pm2.paypal_express_payer_id).size.should == 1
+    do_search('baid').size.should == 2
+    do_search('token').size.should == 2
+    # No partial match for payer id
+    do_search(2343).size.should == 0
+
+    # New pm with new token
+    pm3 = Killbill::PaypalExpress::PaypalExpressPaymentMethod.create :kb_account_id => '66-77-88-99',
+                                                                     :kb_payment_method_id => '08-09-10-11',
+                                                                     :paypal_express_payer_id => 9938420,
+                                                                     :paypal_express_baid => 'baid2',
+                                                                     :paypal_express_token => 'token2'
+    # Check search by name
+    do_search('good').size.should == 0
+    do_search('bad').size.should == 0
+    # Check partial search
+    do_search('goo').size.should == 0
+    do_search('ba').size.should == 0
+    # Check search by email
+    do_search('visible@visible.com').size.should == 0
+    do_search('hidden@visible.com').size.should == 0
+
+    # Good response
+    Killbill::PaypalExpress::PaypalExpressResponse.create :api_call => 'details_for',
+                                                          :token => 'token2',
+                                                          :success => true,
+                                                          :payer_name => 'good',
+                                                          :payer_email => 'visible@visible.com'
+    # Create a dup, to make sure we see it only once
+    Killbill::PaypalExpress::PaypalExpressResponse.create :api_call => 'details_for',
+                                                          :token => 'token2',
+                                                          :success => true,
+                                                          :payer_name => 'good',
+                                                          :payer_email => 'visible@visible.com'
+    # Bad response: wrong api call
+    Killbill::PaypalExpress::PaypalExpressResponse.create :api_call => 'something',
+                                                          :token => 'token2',
+                                                          :success => true,
+                                                          :payer_name => 'bad',
+                                                          :payer_email => 'hidden@hidden.com'
+    # Bad response: wrong token
+    Killbill::PaypalExpress::PaypalExpressResponse.create :api_call => 'details_for',
+                                                          :token => 'something',
+                                                          :success => true,
+                                                          :payer_name => 'bad',
+                                                          :payer_email => 'hidden@hidden.com'
+    # Bad response: not successful
+    Killbill::PaypalExpress::PaypalExpressResponse.create :api_call => 'details_for',
+                                                          :token => 'token2',
+                                                          :success => false,
+                                                          :payer_name => 'bad',
+                                                          :payer_email => 'hidden@hidden.com'
+
+    # Check search by name
+    do_search('good').size.should == 1
+    do_search('bad').size.should == 0
+    # Check partial search
+    do_search('goo').size.should == 1
+    do_search('ba').size.should == 0
+    # Check search by email
+    do_search('visible@visible.com').size.should == 1
+    do_search('hidden@visible.com').size.should == 0
+  end
+
+  private
+
+  def do_search(search_key)
+    pagination = Killbill::PaypalExpress::PaypalExpressPaymentMethod.search(search_key)
+    pagination.current_offset.should == 0
+    results = pagination.iterator.to_a
+    pagination.total_nb_records.should == results.size
+    results
   end
 end

data/spec/paypal_express/remote/integration_spec.rb

@@ -9,7 +9,7 @@ describe Killbill::PaypalExpress::PaymentPlugin do
     @plugin.conf_dir = File.expand_path(File.dirname(__FILE__) + '../../../../')
 
     logger = Logger.new(STDOUT)
-    logger.level = Logger::DEBUG
+    logger.level = Logger::INFO
     @plugin.logger = logger
 
     @plugin.start_plugin
@@ -112,6 +112,7 @@ describe Killbill::PaypalExpress::PaymentPlugin do
     pm_details.external_payment_method_id.should == @pm.paypal_express_baid
 
     pms_found = @plugin.search_payment_methods @pm.paypal_express_baid
+    pms_found = pms_found.iterator.to_a
     pms_found.size.should == 1
     pms_found.first.external_payment_method_id.should == pm_details.external_payment_method_id
 

data/spec/paypal_express/streamy_result_set_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe Killbill::PaypalExpress::StreamyResultSet do
+  before :all do
+    Killbill::PaypalExpress::PaypalExpressPaymentMethod.delete_all
+  end
+
+  it 'should stream results per batch' do
+    1.upto(35) do
+      Killbill::PaypalExpress::PaypalExpressPaymentMethod.create :kb_account_id => SecureRandom.uuid,
+                                                                 :kb_payment_method_id => SecureRandom.uuid,
+                                                                 :paypal_express_payer_id => SecureRandom.uuid,
+                                                                 :paypal_express_baid => SecureRandom.uuid,
+                                                                 :paypal_express_token => SecureRandom.uuid
+    end
+    Killbill::PaypalExpress::PaypalExpressPaymentMethod.count.should == 35
+
+    enum = Killbill::PaypalExpress::StreamyResultSet.new(40, 10) do |offset,limit|
+      Killbill::PaypalExpress::PaypalExpressPaymentMethod.where('kb_payment_method_id is not NULL')
+                                                         .order("id ASC")
+                                                         .offset(offset)
+                                                         .limit(limit)
+    end
+
+    i = 0
+    enum.each do |results|
+      if i < 3
+        results.size.should == 10
+      elsif i == 3
+        results.size.should == 5
+      else
+        fail 'Too many results'
+      end
+      i += 1
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -16,6 +16,8 @@ ActiveRecord::Base.establish_connection(
     :adapter => 'sqlite3',
     :database => 'test.db'
 )
+# For debugging
+#ActiveRecord::Base.logger = Logger.new(STDOUT)
 # Create the schema
 require File.expand_path(File.dirname(__FILE__) + '../../db/schema.rb')
 

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: killbill-paypal-express
 version: !ruby/object:Gem::Version
+  version: 1.6.0
   prerelease:
-  version: 1.5.4
 platform: ruby
 authors:
 - Kill Bill core team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2013-10-16 00:00:00.000000000 Z
+date: 2013-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: killbill
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: 1.7.1
     none: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: 1.7.1
     none: false
   prerelease: false
   type: :runtime
@@ -31,13 +31,13 @@ dependencies:
   name: activemerchant
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.36.0
     none: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.36.0
     none: false
@@ -47,13 +47,13 @@ dependencies:
   name: activerecord
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 3.2.1
     none: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 3.2.1
     none: false
@@ -63,13 +63,13 @@ dependencies:
   name: sinatra
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.3.4
     none: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.3.4
     none: false
@@ -79,13 +79,13 @@ dependencies:
   name: activerecord-jdbcmysql-adapter
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.2.9
     none: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.2.9
     none: false
@@ -95,13 +95,13 @@ dependencies:
   name: jbundler
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.4.1
     none: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.4.1
     none: false
@@ -111,13 +111,13 @@ dependencies:
   name: rake
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 10.0.0
     none: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 10.0.0
     none: false
@@ -127,13 +127,13 @@ dependencies:
   name: rspec
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.12.0
     none: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.12.0
     none: false
@@ -143,13 +143,13 @@ dependencies:
   name: activerecord-jdbcsqlite3-adapter
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.2.6
     none: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.2.6
     none: false
@@ -161,8 +161,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".travis.yml"
+- .gitignore
+- .travis.yml
 - Gemfile
 - Jarfile
 - NEWS
@@ -190,31 +190,31 @@ files:
 - spec/paypal_express/base_plugin_spec.rb
 - spec/paypal_express/paypal_express_payment_method_spec.rb
 - spec/paypal_express/remote/integration_spec.rb
+- spec/paypal_express/streamy_result_set_spec.rb
 - spec/spec_helper.rb
 homepage: http://kill-bill.org
 licenses:
 - Apache License (2.0)
 post_install_message:
 rdoc_options:
-- "--exclude"
-- "."
+- --exclude
+- .
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.3
   none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       segments:
       - 0
+      version: '0'
       hash: 2
-      version: !binary |-
-        MA==
   none: false
 requirements: []
 rubyforge_project:
@@ -226,4 +226,5 @@ test_files:
 - spec/paypal_express/base_plugin_spec.rb
 - spec/paypal_express/paypal_express_payment_method_spec.rb
 - spec/paypal_express/remote/integration_spec.rb
+- spec/paypal_express/streamy_result_set_spec.rb
 - spec/spec_helper.rb