killbill-paypal-express 1.5.0 → 1.5.1

data/NEWS

@@ -1,3 +1,6 @@
+1.5.1
+    Fix bug in get_payment_info and get_refund_info
+
 1.5.0
     Update to latest killbill 1.6.0 (new entitlement apis)
 

data/VERSION

@@ -1 +1 @@
-1.5.0
+1.5.1

data/lib/paypal_express/api.rb

@@ -44,14 +44,9 @@ module Killbill::PaypalExpress
     def get_payment_info(kb_account_id, kb_payment_id, tenant_context = nil, options = {})
       paypal_express_transaction = PaypalExpressTransaction.from_kb_payment_id(kb_payment_id)
 
-      begin
-        transaction_id = paypal_express_transaction.paypal_express_txn_id
-        response = @gateway.transaction_details transaction_id
-        PaypalExpressResponse.from_response(:transaction_details, kb_payment_id, response).to_payment_response
-      rescue => e
-        @logger.warn("Exception while retrieving Paypal Express transaction detail for payment #{kb_payment_id}, defaulting to cached response: #{e}")
-        paypal_express_transaction.paypal_express_response.to_payment_response
-      end
+      # We could also re-fetch it via: @gateway.transaction_details(transaction_id)
+      # but we would need to reconstruct the payment_info object
+      paypal_express_transaction.paypal_express_response.to_payment_response
     end
 
     def process_refund(kb_account_id, kb_payment_id, amount, currency, call_context = nil, options = {})
@@ -74,14 +69,9 @@ module Killbill::PaypalExpress
     def get_refund_info(kb_account_id, kb_payment_id, tenant_context = nil, options = {})
       paypal_express_transaction = PaypalExpressTransaction.refund_from_kb_payment_id(kb_payment_id)
 
-      begin
-        transaction_id = paypal_express_transaction.paypal_express_txn_id
-        response = @gateway.transaction_details transaction_id
-        PaypalExpressResponse.from_response(:transaction_details, kb_payment_id, response).to_refund_response
-      rescue => e
-        @logger.warn("Exception while retrieving Paypal Express transaction detail for payment #{kb_payment_id}, defaulting to cached response: #{e}")
-        paypal_express_transaction.paypal_express_response.to_refund_response
-      end
+      # We could also re-fetch it via: @gateway.transaction_details(transaction_id)
+      # but we would need to reconstruct the refund_info object
+      paypal_express_transaction.paypal_express_response.to_refund_response
     end
 
     def add_payment_method(kb_account_id, kb_payment_method_id, payment_method_props, set_default = false, call_context = nil, options = {})

data/pom.xml

@@ -25,7 +25,7 @@
     <groupId>com.ning.killbill.ruby</groupId>
     <artifactId>paypal-express-plugin</artifactId>
     <packaging>pom</packaging>
-    <version>1.5.0</version>
+    <version>1.5.1</version>
     <name>paypal-express-plugin</name>
     <url>http://github.com/killbill/killbill-paypal-express-plugin</url>
     <description>Plugin for accessing paypal as a payment gateway</description>

data/spec/paypal_express/remote/integration_spec.rb

@@ -22,7 +22,7 @@ describe Killbill::PaypalExpress::PaymentPlugin do
   end
 
   it 'should be able to charge and refund' do
-    amount = 100
+    amount = BigDecimal.new("100")
     currency = 'USD'
     kb_payment_id = SecureRandom.uuid
 
@@ -38,6 +38,7 @@ describe Killbill::PaypalExpress::PaymentPlugin do
 
     # Check we can retrieve the payment
     payment_response = @plugin.get_payment_info @pm.kb_account_id, kb_payment_id
+    payment_response.first_payment_reference_id.should_not be_nil
     payment_response.amount.should == amount
     payment_response.status.should == :PROCESSED
 
@@ -55,11 +56,11 @@ describe Killbill::PaypalExpress::PaymentPlugin do
 
     # Check we can retrieve the refund
     refund_response = @plugin.get_refund_info @pm.kb_account_id, kb_payment_id
-    refund_response.amount.should == (-1 * amount)
+    refund_response.amount.should == amount
     refund_response.status.should == :PROCESSED
 
     # Try another payment to verify the BAID
-    second_amount = 94.23
+    second_amount = BigDecimal.new("94.23")
     second_kb_payment_id = SecureRandom.uuid
     payment_response = @plugin.process_payment @pm.kb_account_id, second_kb_payment_id, @pm.kb_payment_method_id, second_amount, currency
     payment_response.amount.should == second_amount

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: killbill-paypal-express
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
   prerelease:
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2013-08-21 00:00:00.000000000 Z
+date: 2013-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: killbill