killbill-cybersource 4.0.8 → 4.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e5e9dc0988edff5c4623bbe0b78fff943f7deeca
-  data.tar.gz: 8021eb5f7e6a7ad4c8132ecf7f7d7a2f96fc4523
+  metadata.gz: 7f29b96955182c07ea9f8c6c0b2664828c9b385d
+  data.tar.gz: 43392e1684880a50f286cdaaae67b8c8666e2d91
 SHA512:
-  metadata.gz: 8c8240aff2da9f916e0dad419b4ca2a335a38850ec4628046819d858dc5fead9fbccda182e22cee2340f655a54a5d21449e440e9b5a2cbc9c6985239ca1d6b50
-  data.tar.gz: 25bf63b13df3da99c28903e0534398dedd6e24ae3c80b4e6799f6d0e62e78d4aa8b236fa3a713ee0373d33cdeed5b5c7fc12b5bf16ff021b5481b75c34919847
+  metadata.gz: 6ccc1ae57b5fef06cf6e45f2518704aaebaaf3f0b195a8356f4a9eae084cdb748e245e6e04d1f67d42580c5c8d981eec90276df47826c6bbdd50e2dfd190d292
+  data.tar.gz: 2da7bfe0ff896e517ea1ec8be1450cf850633274b629afad4cac5997947a2ac1fd16b62aa1560f3cec2c4f98f2aeef58bb879050432432835334f6a622ee1ba9

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    killbill-cybersource (4.0.8)
+    killbill-cybersource (4.0.9)
       actionpack (~> 4.1.0)
       actionview (~> 4.1.0)
       activemerchant (~> 1.48.0)

data/NEWS

@@ -1,3 +1,7 @@
+4.0.9
+    Android Pay bugfix
+    Cancel UNDEFINED payments after 24 hours by default
+
 4.0.8
     Add Android Pay support
     Add support for merchant descriptors

data/VERSION

@@ -1 +1 @@
-4.0.8
+4.0.9

data/lib/cybersource/api.rb

@@ -2,7 +2,7 @@ module Killbill #:nodoc:
   module Cybersource #:nodoc:
     class PaymentPlugin < ::Killbill::Plugin::ActiveMerchant::PaymentPlugin
 
-      SEVEN_DAYS_AGO = (7 * 86400)
+      ONE_DAY_AGO = (1 * 86400)
       SIXTY_DAYS_AGO = (60 * 86400)
 
       def initialize
@@ -152,7 +152,7 @@ module Killbill #:nodoc:
           # Report API not configured, connection problem or skip_gw=true
           next if report.nil?
 
-          threshold = (Killbill::Plugin::ActiveMerchant::Utils.normalized(options, :cancel_threshold) || SEVEN_DAYS_AGO).to_i
+          threshold = (Killbill::Plugin::ActiveMerchant::Utils.normalized(options, :cancel_threshold) || ONE_DAY_AGO).to_i
           should_cancel_payment = (now - report_date) >= threshold
           if report.empty? && !should_cancel_payment
             # We'll retry later

data/lib/cybersource/ext/active_merchant/active_merchant.rb

@@ -64,7 +64,9 @@ module ActiveMerchant
             xml.tag! 'ccAuthService', {'run' => 'true'} do
               xml.tag!("cavv", Base64.encode64(cryptogram[0...20]))
               xml.tag!("commerceIndicator", options[:commerce_indicator] || "aesk")
-              xml.tag!("xid", Base64.encode64(cryptogram[20...40]))
+              if cryptogram.size == 40
+                xml.tag!("xid", Base64.encode64(cryptogram[20...40]))
+              end
             end
         end
       end

data/pom.xml

@@ -25,7 +25,7 @@
     <groupId>org.kill-bill.billing.plugin.ruby</groupId>
     <artifactId>cybersource-plugin</artifactId>
     <packaging>pom</packaging>
-    <version>4.0.8</version>
+    <version>4.0.9</version>
     <name>cybersource-plugin</name>
     <url>http://github.com/killbill/killbill-cybersource-plugin</url>
     <description>Plugin for accessing Cybersource as a payment gateway</description>

data/spec/cybersource/remote/integration_spec.rb

@@ -182,6 +182,18 @@ describe Killbill::Cybersource::PaymentPlugin do
     kb_payment = setup_kb_payment
     payment_response = @plugin.purchase_payment(@pm.kb_account_id, kb_payment.id, kb_payment.transactions[0].id, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
     check_response(payment_response, @amount, :PURCHASE, :PROCESSED, 'Successful transaction', '100')
+
+    properties = build_pm_properties(nil,
+                                     {
+                                         :cc_number => 378282246310005,
+                                         :cc_type => 'american_express',
+                                         :payment_cryptogram => 'AAAAAAAAAAAAAAAAAABBBBBBBBB=',
+                                         :ignore_avs => true,
+                                         :ignore_cvv => true
+                                     })
+    kb_payment = setup_kb_payment
+    payment_response = @plugin.purchase_payment(@pm.kb_account_id, kb_payment.id, kb_payment.transactions[0].id, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+    check_response(payment_response, @amount, :PURCHASE, :PROCESSED, 'Successful transaction', '100')
   end
 
   it 'should be able to pay with Android Pay' do
@@ -196,8 +208,50 @@ describe Killbill::Cybersource::PaymentPlugin do
     properties << build_property('source', 'androidpay')
 
     kb_payment = setup_kb_payment
-    payment_response = @plugin.authorize_payment(@pm.kb_account_id, kb_payment.id, kb_payment.transactions[0].id, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
-    check_response(payment_response, @amount, :AUTHORIZE, :PROCESSED, 'Successful transaction', '100')
+    payment_response = @plugin.purchase_payment(@pm.kb_account_id, kb_payment.id, kb_payment.transactions[0].id, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+    check_response(payment_response, @amount, :PURCHASE, :PROCESSED, 'Successful transaction', '100')
+
+    properties = build_pm_properties(nil,
+                                     {
+                                         :cc_number => 5555555555554444,
+                                         :cc_type => 'master',
+                                         :payment_cryptogram => 'EHuWW9PiBkWvqE5juRwDzAUFBAk=',
+                                         :ignore_avs => true,
+                                         :ignore_cvv => true
+                                     })
+    properties << build_property('source', 'androidpay')
+
+    kb_payment = setup_kb_payment
+    payment_response = @plugin.purchase_payment(@pm.kb_account_id, kb_payment.id, kb_payment.transactions[0].id, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+    check_response(payment_response, @amount, :PURCHASE, :PROCESSED, 'Successful transaction', '100')
+
+    properties = build_pm_properties(nil,
+                                     {
+                                         :cc_number => 378282246310005,
+                                         :cc_type => 'american_express',
+                                         :payment_cryptogram => 'AAAAAAAAAAAAAAAAAAAAAAAAAAABBBBBBBBBBBBBBBBBBBBBBBBBBB==',
+                                         :ignore_avs => true,
+                                         :ignore_cvv => true
+                                     })
+    properties << build_property('source', 'androidpay')
+
+    kb_payment = setup_kb_payment
+    payment_response = @plugin.purchase_payment(@pm.kb_account_id, kb_payment.id, kb_payment.transactions[0].id, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+    check_response(payment_response, @amount, :PURCHASE, :PROCESSED, 'Successful transaction', '100')
+
+    properties = build_pm_properties(nil,
+                                     {
+                                         :cc_number => 378282246310005,
+                                         :cc_type => 'american_express',
+                                         :payment_cryptogram => 'AAAAAAAAAAAAAAAAAABBBBBBBBB=',
+                                         :ignore_avs => true,
+                                         :ignore_cvv => true
+                                     })
+    properties << build_property('source', 'androidpay')
+
+    kb_payment = setup_kb_payment
+    payment_response = @plugin.purchase_payment(@pm.kb_account_id, kb_payment.id, kb_payment.transactions[0].id, @pm.kb_payment_method_id, @amount, @currency, properties, @call_context)
+    check_response(payment_response, @amount, :PURCHASE, :PROCESSED, 'Successful transaction', '100')
   end
 
   it 'should be able to fix UNDEFINED payments' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: killbill-cybersource
 version: !ruby/object:Gem::Version
-  version: 4.0.8
+  version: 4.0.9
 platform: ruby
 authors:
 - Kill Bill core team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-08-15 00:00:00.000000000 Z
+date: 2016-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: killbill