kicks 3.1.0 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b553911947a5b50df9d2576610c02c448873a359bf8641116c3bdaeb10539fd4
-  data.tar.gz: 8fd78e33555ba42a001781c204ca22e9e875a22d96eb53374dcc1a3d0af2ac06
+  metadata.gz: 7899bb171d5e5399547c0b02c33753e23bc8cfaec63e614baa84cd473448a45d
+  data.tar.gz: 3b5b708557aae6c815a2ad23cf86115e5d39ad397cd1e52099ed2e621b26848a
 SHA512:
-  metadata.gz: cf96bb1a274d3ad4da6f904c6395156541b750a78d20130226e3404f00f97853a71a0327db11b96193affe54a94217b909600ffb9c9e8527c3bcb5b88e51590b
-  data.tar.gz: 0244cdda5904875397992237239b67649c6c4ef2affb0962a040d8f06849549b816a371280ef870fb04e16db9c768b948c8b96196e75337c3303131b5c333122
+  metadata.gz: 57565fbb9e74e4b990f62e482293ff41cdffebb0b75875b4c654a34e4bb6ed037e2cc9305f15c1c6920e789749a484403badbc2f7aad58b811d614b0d2e51080
+  data.tar.gz: e6516ab5c10e167a1e94b0a80f82b68dbe330be53603d4cc7132104e0827f013c3cc930b1f3fe2ecc5f2f65a6cbf140707ccd3bd709fbae5ae0eae0747e2b8d7

data/ChangeLog.md

@@ -1,8 +1,29 @@
 # Change Log
 
-## Changes Between 3.1.0 and 3.2.0 (in development)
+## Changes Between 3.2.0 and 3.3.0 (in development)
 
-No changes yet.
+No (documented) changes yet.
+
+
+## Changes Between 3.1.0 and 3.2.0 (Jan 26, 2025)
+
+### Improved Support for Bring-Your-Own-Connection (BYOC)
+
+Kicks now supports a callable (e.g. a proc) to be passed for an externally-initialized
+and managed Bunny connection. In this case, it is entirely up to the caller
+to configure the connection and call `Bunny::Session#start` on it
+at the right moment.
+
+Contributed by @tie.
+
+GitHub issue: [#29](https://github.com/ruby-amqp/kicks/pull/29)
+
+
+### ActiveJob Adapter Compatibility with Ruby on Rails Older Than 7.2
+
+Contributed by @dixpac.
+
+GitHub issues: [#19](https://github.com/ruby-amqp/kicks/pull/19), [#28](https://github.com/ruby-amqp/kicks/pull/28)
 
 
 ## Changes Between 3.0.0 and 3.1.0 (Oct 20, 2024)

data/README.md

@@ -212,5 +212,6 @@ See [LICENSE](LICENSE.txt) for further details.
 
 ## Copyright
 
-Copyright (c) 2023-2024 Kicks contributors
+Copyright (c) 2023-2024 Kicks contributors.
+
 Copyright (c) 2015-2023 [Dotan Nahum](http://gplus.to/dotan) [@jondot](http://twitter.com/jondot).

data/kicks.gemspec

@@ -31,8 +31,8 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'rake', '>= 12.3', '< 14.0'
 
   # for integration environment (see .travis.yml and integration_spec)
-  gem.add_development_dependency 'activejob', '>= 7.1'
-  gem.add_development_dependency 'activesupport', '>= 7.1'
+  gem.add_development_dependency 'activejob', '>= 7.2'
+  gem.add_development_dependency 'activesupport', '>= 7.2'
   gem.add_development_dependency 'rabbitmq_http_api_client'
   gem.add_development_dependency 'redis'
 

data/lib/active_job/queue_adapters/sneakers_adapter.rb

@@ -1,14 +1,14 @@
 module ActiveJob
   module QueueAdapters
-    # Explicitly remove the implementation existing in older rails'.
-    remove_const(:SneakersAdapter) if defined?(:SneakersAdapter)
+    # Explicitly remove the implementation existing in older Rails versions'.
+    remove_const(:SneakersAdapter) if const_defined?(:SneakersAdapter)
 
     # = Sneakers adapter for Active Job
     #
     # To use Sneakers set the queue_adapter config to +:sneakers+.
     #
     #   Rails.application.config.active_job.queue_adapter = :sneakers
-    class SneakersAdapter < ::ActiveJob::QueueAdapters::AbstractAdapter
+    class SneakersAdapter
       def initialize
         @monitor = Monitor.new
       end

data/lib/sneakers/configuration.rb

@@ -5,7 +5,7 @@ module Sneakers
   class Configuration
 
     extend Forwardable
-    def_delegators :@hash, :to_hash, :[], :[]=, :==, :fetch, :delete, :has_key?
+    def_delegators :@hash, :to_hash, :[], :[]=, :==, :fetch, :delete, :has_key?, :dig
 
     EXCHANGE_OPTION_DEFAULTS = {
       :type               => :direct,

data/lib/sneakers/handlers/maxretry.rb

@@ -84,8 +84,12 @@ module Sneakers
 
       def self.configure_queue(name, opts)
         retry_name = opts.fetch(:retry_exchange, "#{name}-retry")
-        opt_args = opts[:queue_options][:arguments] ? opts[:queue_options][:arguments].inject({}){|memo,(k,v)| memo[k.to_sym] = v; memo} : {}
-        opts[:queue_options][:arguments] = { :'x-dead-letter-exchange' => retry_name }.merge(opt_args)
+        opt_args = if opts.dig(:queue_options, :arguments).blank?
+                    {}
+                   else
+                    opts.dig(:queue_options, :arguments).transform_keys(&:to_sym)
+                   end
+        opts[:queue_options][:arguments] = { :'x-dead-letter-exchange' => retry_name }.merge!(opt_args)
         opts[:queue_options]
       end
 

data/lib/sneakers/publisher.rb

@@ -6,9 +6,6 @@ module Sneakers
     def initialize(opts = {})
       @mutex = Mutex.new
       @opts = Sneakers::CONFIG.merge(opts)
-      # If we've already got a bunny object, use it.  This allows people to
-      # specify all kinds of options we don't need to know about (e.g. for ssl).
-      @bunny = @opts[:connection]
     end
 
     def publish(msg, options = {})
@@ -29,8 +26,15 @@ module Sneakers
 
   private
     def connect!
-      @bunny ||= create_bunny_connection
-      @bunny.start
+      # If we've already got a bunny object, use it.  This allows people to
+      # specify all kinds of options we don't need to know about (e.g. for ssl).
+      @bunny = @opts[:connection]
+      if @bunny.respond_to?(:call)
+        @bunny = @bunny.call
+      else
+        @bunny ||= create_bunny_connection
+        @bunny.start
+      end
       @channel = @bunny.create_channel
       @exchange = @channel.exchange(@opts[:exchange], **@opts[:exchange_options])
     end

data/lib/sneakers/queue.rb

@@ -19,8 +19,12 @@ class Sneakers::Queue
     # If we've already got a bunny object, use it.  This allows people to
     # specify all kinds of options we don't need to know about (e.g. for ssl).
     @bunny = @opts[:connection]
-    @bunny ||= create_bunny_connection
-    @bunny.start
+    if @bunny.respond_to?(:call)
+      @bunny = @bunny.call
+    else
+      @bunny ||= create_bunny_connection
+      @bunny.start
+    end
 
     @channel = @bunny.create_channel
     @channel.prefetch(@opts[:prefetch])

data/lib/sneakers/version.rb

@@ -1,3 +1,3 @@
 module Sneakers
-  VERSION = "3.1.0"
+  VERSION = "3.2.0"
 end

data/spec/sneakers/publisher_spec.rb

@@ -122,19 +122,44 @@ describe Sneakers::Publisher do
           durable: false
         )
         @existing_session = existing_session
+        @exchange = exchange
+        @channel = channel
       end
 
-      it 'can handle an existing connection that is offline' do
+      it 'can handle an existing connection object' do
         p = Sneakers::Publisher.new
         p.publish('test msg', my_vars)
         _(p.instance_variable_get(:@bunny)).must_equal @existing_session
       end
 
+      it 'can handle an existing connection function' do
+        @existing_session.start
+        p = Sneakers::Publisher.new(connection: ->() { @existing_session })
+        p.publish('test msg', my_vars)
+        _(p.instance_variable_get(:@bunny)).must_equal @existing_session
+      end
+
       it 'can handle an existing connection that is online' do
+        p = Sneakers::Publisher.new
+        p.publish('test msg', my_vars)
+        _(p.instance_variable_get(:@bunny)).must_equal @existing_session
         mock(@existing_session).connected? { true }
+        mock(@exchange).publish('test msg 2', my_vars)
+        p.publish('test msg 2', my_vars)
+      end
+
+      it 'can handle an existing connection that goes offline' do
         p = Sneakers::Publisher.new
         p.publish('test msg', my_vars)
         _(p.instance_variable_get(:@bunny)).must_equal @existing_session
+        mock(@existing_session).connected? { false }
+        mock(@existing_session).start
+        mock(@existing_session).create_channel { @channel }
+        mock(@channel).exchange('another_exchange', type: :topic, durable: false, :auto_delete => false, arguments: { 'x-arg' => 'value' }) do
+          @exchange
+        end
+        mock(@exchange).publish('test msg 2', my_vars)
+        p.publish('test msg 2', my_vars)
       end
     end
 

data/spec/sneakers/queue_spec.rb

@@ -150,19 +150,24 @@ describe Sneakers::Queue do
                                :type => :direct,
                                :durable => true,
                                :arguments => { 'x-arg' => 'value' }){ @mkex }
-
-        queue_name = 'foo'
-        mock(@mkchan).queue(queue_name, :durable => true) { @mkqueue }
-        mock(@mkqueue).bind(@mkex, :routing_key => queue_name)
+        mock(@mkchan).queue('foo', :durable => true) { @mkqueue }
+        mock(@mkqueue).bind(@mkex, :routing_key => 'foo')
         mock(@mkqueue).subscribe(:block => false, :manual_ack => true)
-
-        my_vars = queue_vars.merge(:connection => @external_connection)
-        @q = Sneakers::Queue.new(queue_name, my_vars)
       end
 
       it 'uses that object' do
-        @q.subscribe(@mkworker)
-        _(@q.instance_variable_get(:@bunny)).must_equal @external_connection
+        q = Sneakers::Queue.new('foo',
+                                queue_vars.merge(:connection => @external_connection))
+        q.subscribe(@mkworker)
+        _(q.instance_variable_get(:@bunny)).must_equal @external_connection
+      end
+
+      it 'uses that function' do
+        @external_connection.start
+        q = Sneakers::Queue.new('foo',
+                                queue_vars.merge(:connection => ->() { @external_connection }))
+        q.subscribe(@mkworker)
+        _(q.instance_variable_get(:@bunny)).must_equal @external_connection
       end
     end
   end

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kicks
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.2.0
 platform: ruby
 authors:
 - Dotan Nahum
 - Michael Klishin
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-21 00:00:00.000000000 Z
+date: 2025-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: serverengine
@@ -93,28 +92,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
 - !ruby/object:Gem::Dependency
   name: rabbitmq_http_api_client
   requirement: !ruby/object:Gem::Requirement
@@ -343,7 +342,6 @@ licenses:
 - MIT
 metadata:
   source_code_uri: https://github.com/ruby-amqp/kicks
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -358,8 +356,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Fast background processing framework for Ruby and RabbitMQ
 test_files: