khipu 1.3.0 → 1.3.3

data/.gitignore

@@ -16,3 +16,4 @@ test/tmp
 test/version_tmp
 tmp
 .idea/*
+.ruby-version

data/README.md

@@ -4,8 +4,6 @@
 
 Gema Ruby para utilizar los servicios de Khipu.com
 
-Versión Biblioteca: 1.3.0
-
 Versión API Khipu: 1.3
 Versión API de notificación: 1.2
 
@@ -226,4 +224,4 @@ saldar este pago:
         puts error.type
         puts error.message
     end
-```
+```

data/khipu.gemspec

@@ -23,4 +23,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "webmock"
 end

data/lib/khipu.rb

@@ -8,6 +8,7 @@ require 'khipu/const'
 module Khipu
 
   API_URL = 'https://khipu.com/api/1.3/'
+  INTEGRATOR_API_URL = 'https://khipu.com/integratorApi/1.3/'
   DEBUG = ENV['KHIPU_DEBUG'] || false
   FORM_BUTTONS = {
       '50x25'       => '50x25.png',
@@ -25,7 +26,7 @@ module Khipu
       '200x50white' => '200x50-w.png',
       '200x75'      => '200x75.png',
       '200x75white' => '200x75-w.png',
-  }.inject({}) { |h, (k, v)| h[k] = 'htps://s3.amazonaws.com/static.khipu.com/buttons/' + v; h }
+  }.inject({}) { |h, (k, v)| h[k] = 'https://s3.amazonaws.com/static.khipu.com/buttons/' + v; h }
 
   def self.create_khipu_api(receiver_id, secret = '')
     KhipuApiEndpoint.new(receiver_id, secret)

data/lib/khipu/khipu_api_endpoint.rb

@@ -7,12 +7,12 @@ module Khipu
       super(receiver_id, secret)
     end
 
-    def execute(endpoint, params, add_hash = true, json_response = true)
+    def execute(endpoint, params, add_hash = true, json_response = true, base_url = Khipu::API_URL)
       post_params = params.clone
       if add_hash
         post_params['hash'] = hmac_sha256(@secret, concatenated(params))
       end
-      post(endpoint, post_params, json_response)
+      post(endpoint, post_params, json_response, base_url)
     end
 
     def payment_status(args)
@@ -178,7 +178,29 @@ module Khipu
       verify_signature(params, args[:notification_signature])
     end
 
+    # Integrator API
 
+    def create_receiver(args)
+      endpoint = 'createReceiver'
+      check_arguments(args, [:email, :first_name, :last_name, :notify_url, :identifier, :bussiness_category, :bussiness_name,
+                             :phone, :address_line_1, :address_line_2, :address_line_3, :country_code])
+      params = {
+          receiver_id: @receiver_id,
+          email: args[:email],
+          first_name: args[:first_name],
+          last_name: args[:last_name],
+          notify_url: args[:notify_url],
+          identifier: args[:identifier],
+          bussiness_category: args[:bussiness_category],
+          bussiness_name: args[:bussiness_name],
+          phone: args[:phone],
+          address_line_1: args[:address_line_1],
+          address_line_2: args[:address_line_2],
+          address_line_3: args[:address_line_3],
+          country_code: args[:country_code]
+      }
+      execute(endpoint, params, true, true, Khipu::INTEGRATOR_API_URL)
+    end
 
   end
 end

data/lib/khipu/khipu_service.rb

@@ -12,8 +12,8 @@ module Khipu
       @secret = secret
     end
 
-    def post(endpoint, params, json_response = true)
-      uri = URI(Khipu::API_URL + endpoint)
+    def post(endpoint, params, json_response = true, base_url = Khipu::API_URL)
+      uri = URI(base_url + endpoint)
       http = Net::HTTP.new(uri.host, uri.port)
       http.use_ssl = true
       if Khipu::DEBUG
@@ -58,7 +58,7 @@ module Khipu
     end
 
     def hmac_sha256(secret, data)
-      OpenSSL::HMAC.digest(OpenSSL::Digest::Digest.new('sha256'), secret, data).unpack('H*').first
+      OpenSSL::HMAC.digest(OpenSSL::Digest.new('sha256'), secret, data).unpack('H*').first
     end
 
     def concatenated(params)
@@ -73,4 +73,4 @@ module Khipu
     end
 
   end
-end
+end

data/lib/khipu/version.rb

@@ -1,3 +1,3 @@
 module Khipu
-    VERSION = "1.3.0"
+    VERSION = "1.3.3"
 end

data/spec/khipu_api_endpoint_spec.rb

@@ -0,0 +1,42 @@
+require "spec_helper"
+
+describe Khipu::KhipuApiEndpoint do
+  let(:api) { Khipu.create_khipu_api(1234, '1234') }
+
+  describe ".create_receiver" do
+    let(:receiver_params) do
+      {
+        first_name: 'First Name',
+        last_name: 'Last Name',
+        email: 'email@domain.com',
+        notify_url: 'https://example.com/notify_url',
+        identifier: '12345678-5',
+        bussiness_category: 'Business Category',
+        bussiness_name: 'Business Name',
+        phone: '56221234567',
+        address_line_1: 'Address Line 1',
+        address_line_2: 'Address Line 2',
+        address_line_3: 'Address Line 3',
+        country_code: 'cl'
+      }
+    end
+    let(:return_params) do
+      {
+        receiver_id: 1369,
+        secret: "392d15ea0a92b83b1b54ddda165efd146ff81804"
+      }
+    end
+
+    subject { api.create_receiver(receiver_params) }
+
+    before do
+      stub_request(:post, "https://khipu.com/integratorApi/1.3/createReceiver")
+      .to_return(body: return_params.to_json)
+    end
+
+    it { should include('receiver_id') }
+    it { should include('secret') }
+    it { expect(subject['receiver_id']).to eq 1369 }
+    it { expect(subject['secret']).to eq "392d15ea0a92b83b1b54ddda165efd146ff81804" }
+  end
+end

data/spec/khipu_service_spec.rb

@@ -1,17 +1,57 @@
 require "spec_helper"
 
-describe 'KhipuService' do
+describe Khipu::KhipuService do
+  let(:service) { Khipu::KhipuService.new(1234, '1234') }
 
   it 'should calculate hmac' do
-    service = Khipu::KhipuService.new(1234, '1234')
     hex_hmac = service.hmac_sha256('abcd', '1234')
     expect(hex_hmac).to eq('d219a3dd877f943be0ee65ef6a34129778d2fd0568ce2d9a8f37fea9d7fcaca3')
   end
 
   it 'should concatenate parameters' do
-    service = Khipu::KhipuService.new(1234, '1234')
     params = service.concatenated(a: 1, b: 'foo', c: nil)
     expect(params).to eq('a=1&b=foo&c=')
   end
 
-end
+  describe '.post' do
+    it 'should return body if response is not json' do
+      stub_request(:post, 'https://khipu.com/api/1.3/endpoint').
+        to_return(status: 200, body: 'Hello World')
+      expect(service.post('endpoint', {}, false)).to eq('Hello World')
+    end
+
+    it 'should return json if response is json' do
+      stub_request(:post, 'https://khipu.com/api/1.3/endpoint').
+        to_return(status: 200, body: {text: 'Hello World'}.to_json)
+      expect(service.post('endpoint', {})).to eq({'text' => 'Hello World'})
+    end
+
+    it 'should raise error with invalid json response' do
+      stub_request(:post, 'https://khipu.com/api/1.3/endpoint').
+        to_return(status: 200, body: '{"text":}')
+      expect{service.post('endpoint', {})}.to raise_error /invalid response from endpoint/i
+    end
+
+    it 'should raise error with status code different from 200 and 400' do
+      stub_request(:post, 'https://khipu.com/api/1.3/endpoint').
+        to_return(status: 500)
+      expect{service.post('endpoint', {})}.to raise_error /invalid response code/i
+    end
+
+    it 'should raise error with status code 400 and invalid json' do
+      stub_request(:post, 'https://khipu.com/api/1.3/endpoint').
+        to_return(status: 400, body: '{"error":}')
+      expect{service.post('endpoint', {})}.to raise_error /invalid response from endpoint/i
+    end
+
+    it 'should raise Khipu::ApiError with status code 400' do
+      stub_request(:post, 'https://khipu.com/api/1.3/endpoint').
+        to_return(status: 400, body: {error: {type:'Type', message: 'Message'}}.to_json)
+      expect{service.post('endpoint', {})}.to raise_error do |error|
+        expect(error).to be_a(Khipu::ApiError)
+        expect(error.type).to eq('Type')
+        expect(error.message).to eq('Message')
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1 +1,2 @@
-require "khipu"
+require "khipu"
+require "webmock/rspec"

metadata

@@ -1,18 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: khipu
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.3
+  prerelease: 
 platform: ruby
 authors:
 - Alex Lorca
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-29 00:00:00.000000000 Z
+date: 2014-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -20,6 +22,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -27,29 +30,49 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: A wrapper for khipu's web API
@@ -72,32 +95,35 @@ files:
 - lib/khipu/khipu_api_endpoint.rb
 - lib/khipu/khipu_service.rb
 - lib/khipu/version.rb
+- spec/khipu_api_endpoint_spec.rb
 - spec/khipu_service_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/khipu/lib-ruby
 licenses:
 - BSD
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '1.9'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.7
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: A wrapper for khipu's web API
 test_files:
+- spec/khipu_api_endpoint_spec.rb
 - spec/khipu_service_spec.rb
 - spec/spec_helper.rb

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: bbdd3f10aea423ebab6c1e4801ae8cd3dd0da2f1
-  data.tar.gz: ee8f254750eef7c4e1beb041adc251a872bbd0c2
-SHA512:
-  metadata.gz: d4da9dff3275f4eca53ff9d835d166b26672a0dc65b5f7f71b1b35c2cf50e0774b1ea905d3c494e57dd7d2733d40a3eb71207f16f71438f060f1c801ca8a3f21
-  data.tar.gz: e8aeca81768df4f5519c30f466349ba3cd25d4d97dd0b084754ab6bf372712eb4b58ebe08c55f2b1ff050f55db033a0a23e77f1143fbfdf50ae11a53d567c6da