khalti 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 309f5628dd3b199d9eca368e1bc05b27ae09ee77e507588256a6985ffa698283
-  data.tar.gz: 68580e107ed53666784aebb19da5be2a98d8f08ad74ace6c8e366b7b04b4c1a9
+  metadata.gz: b20511cc14806c470c53f8ec138616c0863f6b57e5db496ce314f4506ee51184
+  data.tar.gz: 5acfb0d08b2201176fba040081eaac1b03e1077a47d1dd85826ea708b8915cb8
 SHA512:
-  metadata.gz: 58f20eebbd9a41e48a8bced44bdbb5d608dc75e53658d366545d3b841107432cbd1d366d221028c893ce649549e9b3c084fa05fd0b0158b9149feaa9387affef
-  data.tar.gz: c6494c81d7d5ed477ad241fb2ff804471b6493b7e6bf9b0227502a616d3fdfaf37dd3e9e6c04172a8d8fb742923160bab7976633ad0e31ba5e43291d05ea9d15
+  metadata.gz: ffa68561315dff3dba7c81e1e1449fed9f7036f3fe8c639549237dcd84d66c642b8d9d27947f500f092b2ede9a7334f2bb53f3c6553ed02423b0f33cffa99896
+  data.tar.gz: 825340bb128d07112998e87120a4dadfefdff52db263bc3a91ade2da2ad93e8b69a86290532b31209d2e0299899d686b9068e7036ec91d4fe35cf6a2d24ea273

data/.travis.yml

@@ -4,4 +4,5 @@ rvm:
   - 2.5.0
 before_install: gem install bundler -v 1.16.1
 script:
+  - export KHALTI_SECRET_KEY=your_secret_key
   - bundle exec rspec spec

data/Gemfile.lock

@@ -1,17 +1,23 @@
 PATH
   remote: .
   specs:
-    khalti (0.1.3)
+    khalti (0.1.5)
 
 GEM
   remote: https://rubygems.org/
   specs:
     addressable (2.5.2)
       public_suffix (>= 2.0.2, < 4.0)
+    codecov (0.1.10)
+      json
+      simplecov
+      url
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
+    docile (1.3.0)
     hashdiff (0.3.7)
+    json (2.1.0)
     public_suffix (3.0.2)
     rake (10.5.0)
     rspec (3.7.0)
@@ -28,6 +34,12 @@ GEM
       rspec-support (~> 3.7.0)
     rspec-support (3.7.1)
     safe_yaml (1.0.4)
+    simplecov (0.16.1)
+      docile (~> 1.1)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.2)
+    url (0.3.2)
     webmock (3.3.0)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
@@ -38,6 +50,7 @@ PLATFORMS
 
 DEPENDENCIES
   bundler (~> 1.16)
+  codecov (~> 0.1)
   khalti!
   rake (~> 10.0)
   rspec (~> 3.0)

data/README.md

@@ -1,4 +1,4 @@
-[![Build Status](https://travis-ci.org/degendra/khalti-ruby.png)](https://travis-ci.org/degendra/khalti-ruby)
+[![Build Status](https://travis-ci.org/degendra/khalti-ruby.png)](https://travis-ci.org/degendra/khalti-ruby) [![codecov](https://codecov.io/gh/degendra/khalti-ruby/branch/master/graph/badge.svg)](https://codecov.io/gh/degendra/khalti-ruby) [![Gem Version](https://badge.fury.io/rb/khalti.svg)](https://badge.fury.io/rb/khalti) [![Open Source Love](https://badges.frapsoft.com/os/v2/open-source.png?v=103)](https://github.com/ellerbrock/open-source-badges/) [![MIT Licence](https://badges.frapsoft.com/os/mit/mit.svg?v=103)](https://opensource.org/licenses/mit-license.php)
 
 # Khalti
 

data/khalti.gemspec

@@ -34,4 +34,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "webmock", "~> 3.3"
+  spec.add_development_dependency "codecov", "~> 0.1"
 end

data/lib/khalti/errors.rb

@@ -0,0 +1,23 @@
+module Khalti
+  module Errors
+    class KhaltiError < RuntimeError
+      attr_reader :data
+      def initialize(data)
+        @data = data
+        super
+      end
+    end
+
+    class BlankError < RuntimeError
+    end
+
+    class InvalidAmountError < RuntimeError
+    end
+
+    class InvalidTokenError < RuntimeError
+    end
+
+    class InvalidResponseError < RuntimeError
+    end
+  end
+end

data/lib/khalti/request_helper.rb

@@ -0,0 +1,48 @@
+module Khalti
+  module RequestHelper
+    SECRET_KEY = ENV['KHALTI_SECRET_KEY']
+    def self.get(path)
+      self.validate_secret_key
+      uri = URI.parse(path)
+      req = Net::HTTP::Get.new(uri)
+      req['authorization'] = "Key #{SECRET_KEY}"
+      res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) {|http|
+        http.request(req)
+      }
+      case res
+        when Net::HTTPSuccess
+          self.validate_content_type(res['content-type'])
+          JSON.parse res.body
+        else
+          raise Errors::KhaltiError.new(res.message)
+      end
+    end
+
+    def self.post(path, params)
+      self.validate_secret_key
+      uri = URI.parse(path)
+      req = Net::HTTP::Post.new(uri)
+      req['authorization'] = "Key #{SECRET_KEY}"
+      req.set_form_data(params)
+      res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) {|http|
+        http.request(req)
+      }
+      case res
+        when Net::HTTPSuccess
+          self.validate_content_type(res['content-type'])
+          JSON.parse res.body
+        else
+          raise Errors::KhaltiError.new(res.message)
+      end
+    end
+
+    private
+    def self.validate_secret_key
+      raise Errors::BlankError.new('Ensure KHALTI_SECRET_KEY is not blank.') if SECRET_KEY.nil? || SECRET_KEY.strip.empty?
+    end
+
+    def self.validate_content_type(content_type)
+      Errors::InvalidResponseError.new('Content-type is not application/json.') unless content_type ==='application/json'
+    end
+  end
+end

data/lib/khalti/transaction.rb

@@ -2,37 +2,16 @@ require 'uri'
 require 'net/http'
 require 'json'
 
-API_URL = 'https://khalti.com/api/merchant-transaction'
-
 module Khalti
   class Transaction
+    API_URL = 'https://khalti.com/api/merchant-transaction'
     def self.find(idx)
-      secret_key = ENV['KHALTI_SECRET_KEY'] #test_secret_key_f59e8b7d18b4499ca40f68195a846e9b
-      headers = {
-        Authorization: "Key #{secret_key}"
-      }
-      uri = URI.parse("#{API_URL}/#{idx}/")
-      puts uri
-      https = Net::HTTP.new(uri.host, uri.port)
-      https.use_ssl = true
-      request = Net::HTTP::Get.new(uri.request_uri, headers)
-      response = https.request(request)
-
-      JSON.parse(response.body) || {}
+      raise Errors::BlankError.new('Ensure idx is not blank.') if idx.nil? || idx.strip.empty?
+      RequestHelper.get("#{API_URL}/#{idx}/")
     end
 
     def self.all
-      secret_key = ENV['KHALTI_SECRET_KEY'] #test_secret_key_f59e8b7d18b4499ca40f68195a846e9b
-      headers = {
-        Authorization: "Key #{secret_key}"
-      }
-      uri = URI.parse("#{API_URL}/")
-      https = Net::HTTP.new(uri.host, uri.port)
-      https.use_ssl = true
-      request = Net::HTTP::Get.new(uri.request_uri, headers)
-      response = https.request(request)
-
-      JSON.parse(response.body) || {}
+      RequestHelper.get("#{API_URL}/")
     end
   end
 end

data/lib/khalti/verification.rb

@@ -4,20 +4,14 @@ require 'json'
 
 module Khalti
   class Verification
+    API_URL = "https://khalti.com/api/payment/verify/"
+    SECRET_KEY = ENV['KHALTI_SECRET_KEY']
     def self.verify(token, amount)
-      api_url = "https://khalti.com/api/payment/verify/"
-      secret_key = ENV['KHALTI_SECRET_KEY']
-      headers = {
-        Authorization: "Key #{secret_key}"
-      }
-      uri = URI.parse("#{api_url}")
-      https = Net::HTTP.new(uri.host, uri.port)
-      https.use_ssl = true
-      request = Net::HTTP::Post.new(uri.request_uri, headers)
-      request.set_form_data('token' => "#{token}", 'amount' => "#{amount}")
-      response = https.request(request)
-
-      JSON.parse(response.body) || {}
+      raise Errors::BlankError.new('Ensure token is not blank.') if token.nil? || token.strip.empty?
+      raise Errors::InvalidTokenError.new('Ensure token has at least 22 characters.') if token.strip.size < 22
+      raise Errors::InvalidAmountError.new('Ensure amount is greate than 0 paisa.') if Integer(amount) < 0
+      params = {'token': token, 'amount': Integer(amount)}
+      RequestHelper.post(API_URL, params)
     end
   end
 end

data/lib/khalti/version.rb

@@ -1,3 +1,3 @@
 module Khalti
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

data/lib/khalti.rb

@@ -1,6 +1,8 @@
 require_relative "khalti/version"
 require_relative "khalti/verification"
 require_relative "khalti/transaction"
+require_relative "khalti/request_helper"
+require_relative "khalti/errors"
 
 module Khalti
   # Your code goes here...

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: khalti
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Degendra Sivakoti
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-03-31 00:00:00.000000000 Z
+date: 2018-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.3'
+- !ruby/object:Gem::Dependency
+  name: codecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
 description: Welcome to the khalti ruby gem. It is an API wrapper for Khalti payment
   gateway. For more info visit Khalti Gateway Docs.
 email:
@@ -87,6 +101,8 @@ files:
 - bin/setup
 - khalti.gemspec
 - lib/khalti.rb
+- lib/khalti/errors.rb
+- lib/khalti/request_helper.rb
 - lib/khalti/transaction.rb
 - lib/khalti/verification.rb
 - lib/khalti/version.rb