keystone_ui 0.38.0 → 0.39.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba03a37368cf5e1f7e0b18721a1eca9a04aae5dea7a5b3d8887e3db9956f9e8f
-  data.tar.gz: 6c0eb35d049ec308a68984f32cd787d8fa1c183057a975322844187f294c31fc
+  metadata.gz: b11fa4104f5668547e8efeff23c90f69f4c3d1b7374103c33d7dc2c208363acb
+  data.tar.gz: 719716203afcd39869e402674d72a6bf8f1e5f4e7fce163a76c3429ae2bc77e2
 SHA512:
-  metadata.gz: 36f95ca64410c3d39cae7355a0f1f7673a66e963ecf78a67d82a5559c74eef5ea02de3dc4668aef26fdab81b7b330d8d30dbb1a0aea658f13a188fdfdf296e27
-  data.tar.gz: 41c5aff5beccf97a8fac694a8cb6e4250e9b6c4456efb78dc1335df8c5a3be086bacae0b5a28292520666bfae44f7df5b8d6cc9c2fbe36f88f619c0a61e33cc1
+  metadata.gz: b4849b26d1df9c8a45c7721fa966569e6d0f556780b5139a479a73e08c0602ce1db0eab5d4f8bfedcf5a30301cc4d1bba3cffdb0bf82e91a65a3d87c9fdb575c
+  data.tar.gz: 8fdb709bfbf187d4792a76c5057ebec69651fb5d4ba2e5b7a6b527b5e0ae68f437689896a492ec390f46ddc7d330fd3e00e2946588f41932d85bf82e790104e3

data/app/components/keystone/ui/navigation_component.html.erb

@@ -6,11 +6,11 @@
     <% if logo? %>
       <div><%= logo %></div>
     <% end %>
-    <% groups.each do |group, tabs| %>
+    <% groups.each do |group| %>
       <div class="<%= SIDEBAR_GROUP_CLASSES %>">
-        <p class="<%= sidebar_group_label_classes(tabs) %>"><%= group.label %></p>
-        <% tabs.each do |tab| %>
-          <a class="<%= sidebar_tab_classes(tab) %>" href="<%= tab.href_for(helpers) %>"><%= tab.label %></a>
+        <p class="<%= sidebar_group_label_classes(group) %>"><%= group.label %></p>
+        <% group.tabs.each do |tab| %>
+          <a class="<%= sidebar_tab_classes(tab) %>" href="<%= tab.href %>"><%= tab.label %></a>
         <% end %>
       </div>
     <% end %>
@@ -31,10 +31,10 @@
     <% navbar.with_logo do %><%= logo %><% end %>
   <% end %>
   <% navbar.with_desktop_links do %>
-    <% groups.each do |group, tabs| %>
-      <%= render Keystone::Ui::NavDropdownComponent.new(title: group.label, area: group.label, active: holds_current?(tabs)) do %>
-        <% tabs.each do |tab| %>
-          <%= render Keystone::Ui::NavItemComponent.new(label: tab.label, href: tab.href_for(helpers), active: current?(tab)) %>
+    <% groups.each do |group| %>
+      <%= render Keystone::Ui::NavDropdownComponent.new(title: group.label, area: group.label, active: group.active) do %>
+        <% group.tabs.each do |tab| %>
+          <%= render Keystone::Ui::NavItemComponent.new(label: tab.label, href: tab.href, active: tab.active) %>
         <% end %>
       <% end %>
     <% end %>

data/app/components/keystone/ui/navigation_component.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "keystone_ui/navigation_order"
+require "keystone_ui/visible_navigation"
 
 module Keystone
   module Ui
@@ -22,27 +22,20 @@ module Keystone
       attr_reader :groups
 
       def before_render
-        permitted = KeystoneUi.configuration.navigation_groups
-          .map { |group| [ group, group.tabs_permitted_for(helpers) ] }
-          .reject { |_group, tabs| tabs.empty? }
-        @groups = KeystoneUi::NavigationOrder.new(saved_navigation["order"] || []).arrange(permitted)
-        @current_tab = KeystoneUi.configuration.supplied_current_tab(helpers)
+        @groups = KeystoneUi::VisibleNavigation.new(
+          KeystoneUi.configuration.navigation_groups,
+          view: helpers,
+          saved_order: saved_navigation["order"] || [],
+          current_tab: KeystoneUi.configuration.supplied_current_tab(helpers)
+        ).groups
       end
 
-      def current?(tab)
-        tab.key == @current_tab
-      end
-
-      def holds_current?(tabs)
-        tabs.any? { |tab| current?(tab) }
-      end
-
-      def sidebar_group_label_classes(tabs)
-        [ SIDEBAR_GROUP_LABEL_CLASSES, (ACTIVE_CLASS if holds_current?(tabs)) ].compact.join(" ")
+      def sidebar_group_label_classes(group)
+        [ SIDEBAR_GROUP_LABEL_CLASSES, (ACTIVE_CLASS if group.active) ].compact.join(" ")
       end
 
       def sidebar_tab_classes(tab)
-        [ SIDEBAR_TAB_CLASSES, (ACTIVE_CLASS if current?(tab)) ].compact.join(" ")
+        [ SIDEBAR_TAB_CLASSES, (ACTIVE_CLASS if tab.active) ].compact.join(" ")
       end
 
       def anything_to_show?

data/lib/keystone_ui/engine.rb

@@ -3,6 +3,7 @@
 require "keystone_ui/source_css"
 require "keystone_ui/leftover_stylesheet"
 require "keystone_ui/look_check"
+require "keystone_ui/navigation_check"
 
 module KeystoneUi
   class Engine < ::Rails::Engine
@@ -32,8 +33,13 @@ module KeystoneUi
       KeystoneUi::LookCheck.new(looks: config.looks, default: config.default_look).call
     end
 
+    def self.check_navigation
+      KeystoneUi::NavigationCheck.new(groups: KeystoneUi.configuration.navigation_groups).call
+    end
+
     config.after_initialize do
       KeystoneUi::Engine.check_looks
+      KeystoneUi::Engine.check_navigation
 
       tailwind_dir = Rails.root.join("app/assets/tailwind")
       css_path = tailwind_dir.join("application.css")

data/lib/keystone_ui/navigation_check.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module KeystoneUi
+  class NavigationCheck
+    class Error < StandardError; end
+
+    def initialize(groups:)
+      @groups = groups
+    end
+
+    def call
+      @groups.each do |group|
+        raise Error, "The #{group.label} navigation group has no tabs." if group.tabs.empty?
+      end
+      tabs.each do |tab|
+        raise Error, "The #{tab.key} tab has no label." if blank?(tab.label)
+        raise Error, "The #{tab.key} tab has no link." if blank?(tab.href)
+      end
+      raise Error, "More than one navigation tab has the key #{shared_key}." if shared_key
+      nil
+    end
+
+    private
+
+    def tabs
+      @groups.flat_map(&:tabs)
+    end
+
+    def shared_key
+      tabs.map(&:key).tally.find { |_key, count| count > 1 }&.first
+    end
+
+    def blank?(value)
+      value.nil? || value.to_s.strip.empty?
+    end
+  end
+end

data/lib/keystone_ui/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KeystoneUi
-  VERSION = "0.38.0"
+  VERSION = "0.39.0"
 end

data/lib/keystone_ui/visible_navigation.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require "keystone_ui/navigation_order"
+
+module KeystoneUi
+  class VisibleNavigation
+    Group = Struct.new(:label, :tabs, :active, keyword_init: true)
+    Tab = Struct.new(:label, :href, :active, keyword_init: true)
+
+    def initialize(declared_groups, view:, saved_order:, current_tab:)
+      @declared_groups = declared_groups
+      @view = view
+      @saved_order = saved_order
+      @current_tab = current_tab
+    end
+
+    def groups
+      NavigationOrder.new(@saved_order).arrange(permitted).map { |group, tabs| visible_group(group, tabs) }
+    end
+
+    private
+
+    def permitted
+      @declared_groups
+        .map { |group| [ group, group.tabs_permitted_for(@view) ] }
+        .reject { |_group, tabs| tabs.empty? }
+    end
+
+    def visible_group(group, tabs)
+      visible_tabs = tabs.map { |tab| visible_tab(tab) }
+      Group.new(label: group.label, tabs: visible_tabs, active: visible_tabs.any?(&:active))
+    end
+
+    def visible_tab(tab)
+      Tab.new(label: tab.label, href: tab.href_for(@view), active: tab.key == @current_tab)
+    end
+  end
+end