keystone_ui-pages 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52e6e9b60483ae6bcec206e22e688d5b246fb3c30bac941df3658c26c8c386db
-  data.tar.gz: ae992048e518aae337f6df23ec7a9c4ffd04f7d76e98f0a8c1a389636d99f78d
+  metadata.gz: ebfd45f732eefa22bd08b4a5abd3c13ff88a2fa65c55a5309c89c8b21468c69c
+  data.tar.gz: bb309abcbff6e6d5a12aa1096db65c1a3d298ca1db781ed4c3110a5b4e6334a3
 SHA512:
-  metadata.gz: 7f7dcf0832adca48663675600fa5a2d05aa5f6a6b1e4e4d8c133cf4f9c9cf7bd951fb9244e4fc1824819711733bbd1dfdc03962f239cc60479407ae9ca2754c1
-  data.tar.gz: bb06bbe0e3e0c2cc7a9876343ab7458ccec329019218c9669f266d06eb2438bff3d8b8ecc95199ff1961775718c8b4178ad5aa47c64966d19bb9843f067eaafc
+  metadata.gz: 845983515d8a34e9d1c4ef3faff043e2ec832461b4fbf9be78b246d9fc9aba12c9823b69f3b573879df2755dd30e7041a7b1865939cab16d53ee1dad64f6a94e
+  data.tar.gz: dc35e48a37f83ed5b6e61d0d41b22e92139017c8b0fa9cb1cabb458e33bb61a69b38d625800a6f7f7113fe5f3ae80689691f5c2b4a2eafbef3f2db8753b3c4cf

data/app/controllers/keystone_ui/pages/manage/pages_controller.rb

@@ -16,6 +16,7 @@ module KeystoneUi
 
         def new
           @place = chosen_place
+          @default_name = Page.new(place: @place, owner: page_owner).default_name
         end
 
         def create

data/app/models/keystone_ui/pages/page.rb

@@ -89,7 +89,7 @@ module KeystoneUi
       end
 
       def default_name
-        word = KeystoneUi::Pages.default_names.fetch(place, "Page")
+        word = KeystoneUi::Pages.place_settings.dig(place, :default_name) || "Page"
         used = Page.where(owner: owner, place: place).pluck(:name).filter_map { |taken| taken[/\A#{Regexp.escape(word)} (\d+)\z/, 1]&.to_i }
         "#{word} #{(used.max || 0) + 1}"
       end

data/app/views/keystone_ui/pages/manage/pages/edit.html.erb

@@ -9,7 +9,7 @@
     <label class="ks-label mb-1">Name</label>
     <%= ui_input(name: "page[name]", value: @page.name) %>
 
-    <label class="ks-label mb-1">Address</label>
+    <label class="ks-label mb-1">URL slug</label>
     <%= ui_input(name: "page[slug]", value: @page.slug) %>
 
     <% if KeystoneUi::Pages.places.any? %>

data/app/views/keystone_ui/pages/manage/pages/new.html.erb

@@ -5,16 +5,16 @@
     <%= hidden_field_tag "page[place]", @place if @place %>
 
     <label class="ks-label mb-1">Name</label>
-    <%= ui_input(name: "page[name]", placeholder: "e.g. Pricing") %>
+    <%= ui_input(name: "page[name]", placeholder: @default_name) %>
 
-    <% unless @place %>
-      <label class="ks-label mb-1">Address</label>
+    <% if KeystoneUi::Pages.slugged?(@place) %>
+      <label class="ks-label mb-1">URL slug</label>
       <%= ui_input(name: "page[slug]", placeholder: "e.g. pricing") %>
+    <% end %>
 
-      <% if KeystoneUi::Pages.places.any? %>
-        <label class="ks-label mb-1">Place</label>
-        <%= ui_select(name: "page[place]", options: KeystoneUi::Pages.places.invert.to_a) %>
-      <% end %>
+    <% if !@place && KeystoneUi::Pages.places.any? %>
+      <label class="ks-label mb-1">Place</label>
+      <%= ui_select(name: "page[place]", options: KeystoneUi::Pages.places.invert.to_a) %>
     <% end %>
 
     <%= ui_button(label: "Create", type: :submit) %>

data/lib/keystone_ui/pages/version.rb

@@ -2,6 +2,6 @@
 
 module KeystoneUi
   module Pages
-    VERSION = "0.7.0"
+    VERSION = "0.8.0"
   end
 end

data/lib/keystone_ui/pages.rb

@@ -9,7 +9,7 @@ require "keystone_ui/pages/engine"
 module KeystoneUi
   module Pages
     class << self
-      attr_writer :base_controller, :layout, :editor_layout, :pdf_stylesheet, :places, :access_exceptions, :default_names
+      attr_writer :base_controller, :layout, :editor_layout, :pdf_stylesheet, :access_exceptions
       attr_accessor :edit_check_method, :view_check_method, :values_method, :owner_method, :refusal_method, :chrome_path
 
       def base_controller
@@ -29,15 +29,28 @@ module KeystoneUi
       end
 
       def places
-        @places || {}
+        (@places || {}).merge(place_settings.transform_values { |settings| settings[:label] })
       end
 
-      def access_exceptions
-        @access_exceptions || {}
+      def places=(labels)
+        @places = labels
+        @place_settings = {}
+      end
+
+      def register_place(key, label:, default_name: "Page", slug: true)
+        place_settings[key.to_s] = { label: label, default_name: default_name, slug: slug }
+      end
+
+      def place_settings
+        @place_settings ||= {}
+      end
+
+      def slugged?(place)
+        place_settings.dig(place.to_s, :slug) != false
       end
 
-      def default_names
-        @default_names || {}
+      def access_exceptions
+        @access_exceptions || {}
       end
     end
 

data/the_local/agents/keystone_ui-pages-develop.md

@@ -51,11 +51,15 @@ inherit from the base controller, so define it there.
   When it is not empty, the New page form offers them, a page with a place not
   in it is refused, and the page list shows each page's place. The view check
   reads it as `page.place`. Unset, pages have no place.
-- `KeystoneUi::Pages.default_names = { "client_report" => "Report template" }`
-  — the word a page created with no name starts with, per place. The page is
-  named with the word and the next number among that owner's pages in that
-  place, so "Report template 1", then "Report template 2". A place with no word,
-  and a page with no place, use "Page".
+- `KeystoneUi::Pages.register_place("client_report", label: "Client report", default_name: "Report template", slug: false)`
+  — adds one place with its own settings, so each part of a host app registers
+  the place it uses and two registrations never replace each other. `label:` is
+  what editors see. `default_name:` is the word a page created with no name
+  starts with, followed by the next number among that owner's pages in that
+  place, so "Report template 1", then "Report template 2"; it defaults to
+  "Page". `slug:` says whether the place's pages have a URL slug; it defaults to
+  true. Registered places are offered alongside any set with `places =`, and
+  `places = nil` clears both.
 - `KeystoneUi::Pages.access_exceptions = { "public_preview" => "Public preview" }`
   — a hash of the exceptions an editor can set on a page, each stored value to
   its label. When it is not empty, the builder's top bar has an Access exception
@@ -324,11 +328,12 @@ The catalog offers these Keystone UI components by default: `button`,
   restoring go to that place's list, and so does the builder's Back link unless
   the host passed its own `return_to`.
 - **The New page form** at `/pages/manage/pages/new` saves a blank name from
-  `default_names` and a blank slug as eight random hex characters. A host
-  linking to it with `new_manage_page_path(place: "client_report")` creates the
-  page in that place, and the form then asks for a name only. A place the host
-  does not name in the link is ignored, and one posted to create is refused
-  with the form shown again.
+  the place's `default_name` and a blank slug as eight random hex characters,
+  and shows that name as the Name field's placeholder. A host linking to it
+  with `new_manage_page_path(place: "client_report")` creates the page in that
+  place and offers no place choice. The URL slug field shows unless the place
+  was registered with `slug: false`. A place the host does not name in the link
+  is ignored, and one posted to create is refused with the form shown again.
 - **A page's settings** at `/pages/manage/pages/:id/edit` change its name, slug
   and place after it is created. A slug another page of the same owner uses, or
   a place the host does not name, is refused with a message and changes nothing.

data/the_local/interface.yml

@@ -11,7 +11,7 @@ develop:
   - KeystoneUi::Pages.view_check_method
   - KeystoneUi::Pages.places
   - KeystoneUi::Pages.access_exceptions
-  - KeystoneUi::Pages.default_names
+  - KeystoneUi::Pages.register_place
   - KeystoneUi::Pages.values_method
   - KeystoneUi::Pages.edit_check_method
   - KeystoneUi::Pages.refusal_method

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: keystone_ui-pages
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Tyler Schneider