keymap 0.2.0 → 0.3.0

data/.gitignore

@@ -3,6 +3,7 @@
 .bundle
 .config
 .yardoc
+.idea
 Gemfile.lock
 InstalledFiles
 _yardoc
@@ -11,7 +12,10 @@ doc/
 lib/bundler/man
 pkg
 rdoc
+coverage
+doc
 spec/reports
 test/tmp
 test/version_tmp
 tmp
+debug.log

data/.travis.yml

@@ -10,3 +10,5 @@ notifications:
 branches:
   only:
     master
+services:
+  - redis-server

data/README.rdoc

@@ -1,21 +1,16 @@
 = Keymap
 
+{<img src="https://secure.travis-ci.org/rbuck/keymap.png?branch=master" alt="Continuous Integration Status" />}[http://travis-ci.org/rbuck/keymap]
+{<img src="https://gemnasium.com/rbuck/keymap.png?travis" alt="Dependency Status" />}[https://gemnasium.com/rbuck/keymap]
+{<img src="https://codeclimate.com/badge.png" alt="Code Climate" />}[https://codeclimate.com/github/rbuck/keymap]
+
 Helping Ruby developers and their companies, unlock their key-value store data,
 through associative and sequential based access, providing unprecedented support
 for map reduce behaviors, native to the Ruby language.
 
-A NoSQL database abstraction similar in design to ActiveRecord but solely
-focussed on NoSQL databases. These are the goals for this project:
-
-1. Provide a simple abstraction layer over NoSQL databases, allowing easy
-   migration from one to another without having to rewrite application code.
-
-2. Provide a natural Ruby integration with NoSQL database, allowing direct
-   use of Enumerable operations on returned values (implying returned values
-   are always lists or hashes, or are manipulated to be represented in these
-   forms).
-
-{<img src="https://secure.travis-ci.org/rbuck/keymap.png?branch=master" alt="Continuous Integration Status" />}[http://travis-ci.org/rbuck/keymap]
+Keymap provides a natural Ruby integration with NoSQL database, allowing direct
+use of Enumerable operations on returned values (implying returned values are
+always lists or hashes, or are manipulated to be represented in these forms).
 
 == Installation
 
@@ -33,7 +28,35 @@ Or install it yourself as:
 
 == Usage
 
-TBD
+Here is a simple example of how to use keymap:
+
+    Keymap::Base.establish_connection 'test'
+    connection = Keymap::Base.connection
+
+    list = connection.list :what
+    (0..10).each do |value|
+        list << value
+    end
+
+    sum = list.inject(0) do |result, item|
+        result + item.to_i
+    end
+
+The key observation here is this: no key-value store specific API, its plain ordinary Ruby.
+One more example on how to use keymap, this time with a hash:
+
+      accounting = @connection.hash :accounting
+      salaries = {
+          Bob: 82000,
+          Jim: 94000,
+          Billy: 58000
+      }
+      accounting.merge! salaries
+      total = 0
+      accounting.each_value do |value|
+        total = total + value.to_i
+      end
+      total => # 234000
 
 == Contributing
 
@@ -54,40 +77,33 @@ TBD
 
 == Configure databases
 
-Copy test/config.example.yml to test/config.yml and edit as needed. Or just run the tests for
-the first time, which will do the copy automatically and use the default (sqlite3).
+Copy spec/support/config.example.yml to spec/support/config.yml and edit as needed. Or just run the tests for
+the first time, which will do the copy automatically and use the default (redis).
 
-You can build postgres and mysql databases using the build_postgresql and build_mysql rake tasks.
+You can set up redis using the redis:start_server rake tasks.
 
 == Running the tests
 
 You can run a particular test file from the command line, e.g.
 
-  $ ruby -Itest test/cases/base_test.rb
+  $ ruby -Itest spec/functional/adapter_spec.rb
 
 To run a specific test:
 
-  $ ruby -Itest test/cases/base_test.rb -n test_something_works
+  $ ruby -Itest spec/functional/adapter_spec.rb -n test_something_works
 
-You can run with a database other than the default you set in test/config.yml, using the ARCONN
+You can run with a database other than the default you set in spec/support/config.yml, using the KEYCONN
 environment variable:
 
-  $ ARCONN=postgresql ruby -Itest test/cases/base_test.rb
+  $ KEYCONN=redis ruby -Itest spec/functional/adapter_spec.rb
 
 You can run all the tests for a given database via rake:
 
-  $ rake test_mysql
-
-The 'rake test' task will run all the tests for mysql, mysql2, sqlite3 and postgresql.
-
-== Identity Map
-
-By default the tests run with the Identity Map turned off. But all tests should pass whether or
-not the identity map is on or off. You can turn it on using the IM env variable:
+  $ rake test_redis
 
-  $ IM=true ruby -Itest test/case/base_test.rb
+The 'rake test' task will run all the tests for redis, couchdb, and riak,
 
 == Config file
 
-By default, the config file is expected to be at the path test/config.yml. You can specify a
-custom location with the ARCONFIG environment variable.
+By default, the config file is expected to be at the path spec/support/config.yml. You can specify a
+custom location with the KEYCONFIG environment variable.

data/Rakefile

@@ -21,6 +21,8 @@ Dir['tasks/**/*.rb'].each { |file| load file }
 GEM_NAME = "keymap"
 GEM_VERSION = Keymap::VERSION
 
+CLEAN.include('doc/ri')
+CLEAN.include('doc/site')
 CLEAN.include('pkg')
 
 task :default => :spec
@@ -48,7 +50,7 @@ desc "Release version #{Keymap::VERSION}"
 task :release => [:tag, :push]
 
 desc "Provides tasks for each adapter type, e.g. test_redis"
-%w(  ).each do |adapter|
+%w( redis ).each do |adapter|
   Rake::TestTask.new("test_#{adapter}") { |t|
     adapter_short = adapter[/^[a-z0-9]+/]
     t.libs << 'test'
@@ -108,3 +110,21 @@ task :lines do
 
   puts "Total: Lines #{total_lines}, LOC #{total_codelines}"
 end
+
+RDOC_FILES = FileList['README.rdoc', 'lib/**/*.rb']
+
+require 'rdoc/task'
+Rake::RDocTask.new do |rdoc|
+  rdoc.title = "#{GEM_NAME} #{GEM_VERSION}"
+  rdoc.main = 'README.rdoc'
+  rdoc.rdoc_dir = 'doc/site/api'
+  rdoc.options << "-a" << "-U" << "-D" << "-v"
+  rdoc.rdoc_files.include(RDOC_FILES)
+end
+
+Rake::RDocTask.new(:ri) do |rdoc|
+  rdoc.main = "README.rdoc"
+  rdoc.rdoc_dir = "doc/ri"
+  rdoc.options << "--ri-system"
+  rdoc.rdoc_files.include(RDOC_FILES)
+end

data/keymap.gemspec

@@ -8,21 +8,20 @@ Gem::Specification.new do |spec|
   spec.version       = Keymap::VERSION
   spec.authors       = ['Robert Buck']
   spec.email         = 'buck.robert.j@gmail.com'
-  spec.description   = %q{ActiveRecord like Key-Value Store API for Ruby}
-  spec.summary       = %q{Abstracts choosing a key-value store implementation, and provides a common API.}
+  spec.description   = 'Helping Ruby developers and their companies, unlock their key-value store data, through associative and sequential based access, providing unprecedented support for map reduce behaviors, native to the Ruby language'
+  spec.summary       = 'Abstracts choosing a key-value store implementation, and provides a natural enumerable-based Ruby API for hashed and sequential collections.'
   spec.homepage      = 'https://github.com/rbuck/keymap'
-  spec.date          = '2012-10-28'
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(tasks|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = %w(lib)
 
   spec.add_dependency "erubis", "~> 2.7.0"
   spec.add_dependency "redis", "~> 3.0.2"
   spec.add_dependency "activesupport", "~> 3.2.8"
 
-  %w(rake rdoc simplecov).each { |gem| spec.add_development_dependency gem }
+  %w(rake rdoc simplecov hanna-nouveau).each { |gem| spec.add_development_dependency gem }
   %w(ruby-prof).each { |gem| spec.add_development_dependency gem }
   %w(rspec rspec-core rspec-expectations rspec-mocks).each { |gem| spec.add_development_dependency gem, "~> 2.11.0" }
 end

data/lib/keymap/connection_adapters/abstract/connection_pool.rb

@@ -178,7 +178,7 @@ module Keymap
           ActiveSupport::Deprecation.warn(<<-eowarn) if conn.in_use?
 Database connections will not be closed automatically, please close your
 database connection at the end of the thread by calling `close` on your
-connection.  For example: ActiveRecord::Base.connection.close
+connection.  For example: Keymap::Base.connection.close
           eowarn
           checkin conn
           @reserved_connections.delete(key)
@@ -304,28 +304,11 @@ connection.  For example: ActiveRecord::Base.connection.close
     end
 
     # ConnectionHandler is a collection of ConnectionPool objects. It is used
-    # for keeping separate connection pools for Active Record models that connect
-    # to different databases.
-    #
-    # For example, suppose that you have 5 models, with the following hierarchy:
-    #
-    #  |
-    #  +-- Book
-    #  |    |
-    #  |    +-- ScaryBook
-    #  |    +-- GoodBook
-    #  +-- Author
-    #  +-- BankAccount
-    #
-    # Suppose that Book is to connect to a separate database (i.e. one other
-    # than the default database). Then Book, ScaryBook and GoodBook will all use
-    # the same connection pool. Likewise, Author and BankAccount will use the
-    # same connection pool. However, the connection pool used by Author/BankAccount
-    # is not the same as the one used by Book/ScaryBook/GoodBook.
+    # for keeping separate connection pools for Keymap objects stored in
+    # different databases.
     #
     # Normally there is only a single ConnectionHandler instance, accessible via
-    # ActiveRecord::Base.connection_handler. Active Record models use this to
-    # determine that connection pool that they should use.
+    # Keymap::Base.connection_handler.
     class ConnectionHandler
       attr_reader :connection_pools
 

data/lib/keymap/connection_adapters/abstract/connection_specification.rb

@@ -107,7 +107,7 @@ module Keymap
     class << self
       # Returns the connection currently associated with the class. This can
       # also be used to "borrow" the connection to do database work unrelated
-      # to any of the specific Active Records.
+      # to any of the specific Keymap collections.
       def connection
         retrieve_connection
       end

data/lib/keymap/connection_adapters/redis_adapter.rb

@@ -70,28 +70,108 @@ module Keymap
         raw_connection.discard
       end
 
-      def delete(key)
-        raw_connection.del(key) != 0
+      def delete(id)
+        raw_connection.del(id) != 0
+      end
+
+      def hash (id)
+        RedisHash.new(raw_connection, id)
       end
 
-      # todo idea: add an optional argument where we specify the data type for elements in the collection
-      def list (key)
-        List.new(raw_connection, key)
+      def list (id)
+        # todo idea: add an optional argument where we specify the data type for elements in the collection
+        RedisList.new(raw_connection, id)
       end
     end
 
     private
 
-    class List
+    class RedisHash
+
+      include Enumerable
+
+      attr_reader :connection, :id, :sentinel
+
+      # n.b. nil gets represented as an empty string by redis, so the two are
+      # in effect identical keys.
+      def initialize(connection, id, sentinel=nil)
+        @connection = connection
+        @id = id
+        @sentinel = sentinel
+        self[sentinel] = sentinel
+      end
+
+      def empty?
+        connection.hlen id == 1
+      end
+
+      def [](key)
+        connection.hget id, key
+      end
+
+      def []=(key, value)
+        connection.hset id, key, value
+      end
+
+      def each
+        if block_given?
+          hash_keys.each { |key| yield [key, self[key]] unless key == sentinel }
+        else
+          ::Enumerable::Enumerator.new(self, :each)
+        end
+      end
+
+      def each_pair
+        if block_given?
+          hash_keys.each { |key| yield key, self[key] unless key == sentinel }
+        else
+          ::Enumerable::Enumerator.new(self, :each_pair)
+        end
+      end
+
+      def each_value
+        if block_given?
+          hash_keys.each { |key| yield self[key] unless key == sentinel }
+        else
+          ::Enumerable::Enumerator.new(self, :each_value)
+        end
+      end
+
+      def delete(key)
+        value = self[key]
+        connection.hdel id, key
+        value
+      end
+
+      def merge!(hash)
+        hash.each do |key, value|
+          self[key] = value
+        end
+        self
+      end
+
+      alias merge merge!
+
+      private
+
+      def hash_keys
+        keys = connection.hkeys id
+        keys.delete sentinel
+        keys.delete ''
+        keys
+      end
+    end
+
+    class RedisList
 
       include Enumerable
 
-      attr_reader :connection, :key
+      attr_reader :connection, :id
 
-      def initialize(connection, key)
+      def initialize(connection, id, sentinel=nil)
         @connection = connection
-        @key = key
-        self << nil # sentinel to force creation of an "empty list"
+        @id = id
+        self << sentinel # sentinel to force creation of an "empty list"
       end
 
       def each
@@ -100,7 +180,7 @@ module Keymap
           (0..length % step_size).step(step_size) do |step|
             first = step_size * step
             last = first + step_size
-            list = connection.lrange key, first + 1, last
+            list = connection.lrange id, first + 1, last
             list.each do |item|
               yield item
             end
@@ -111,22 +191,29 @@ module Keymap
       end
 
       def <<(value)
-        connection.rpush key, value
+        connection.rpush id, value
         self
       end
 
       alias :push :<<
 
       def [](index)
-        connection.lindex key, index + 1
+        connection.lindex id, index + 1
       end
 
       def []=(index, value)
-        connection.lset key, index + 1, value
+        connection.lset id, index + 1, value
+      end
+
+      def concat array
+        array.each do |entry|
+          self << entry
+        end
+        self
       end
 
       def length
-        connection.llen(key) -1
+        connection.llen(id) -1
       end
 
       alias size length
@@ -136,18 +223,24 @@ module Keymap
       end
 
       def pop()
-        connection.rpop key unless length == 0
+        connection.rpop id unless length == 0
       end
 
       def delete(value)
-        value = connection.lrem(key, 0, value) == 0 ? nil : value
+        value = connection.lrem(id, 0, value) == 0 ? nil : value
         yield value if block_given?
         value
       end
 
-      def delete_if(&block)
-        # todo
-        self
+      def delete_if
+        if block_given?
+          each do |value|
+            delete(value) if yield(value)
+          end
+          self
+        else
+          nil
+        end
       end
     end
 

data/lib/keymap/version.rb

@@ -1,3 +1,3 @@
 module Keymap
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/spec/functional/hash_spec.rb

@@ -0,0 +1,140 @@
+require 'spec_helper'
+
+describe Keymap::Base do
+  before do
+    @connection = Keymap::Base.connection
+  end
+
+  context "a connection yields hashes" do
+
+    before(:each) do
+      @connection.delete :what
+    end
+
+    after(:each) do
+      @connection.delete :what
+    end
+
+    it "that are empty upon creation" do
+      hash = @connection.hash :what
+      hash.nil?.should be_false
+    end
+
+    it "that support an empty? operation" do
+      hash = @connection.hash :what
+      hash.respond_to?(:empty?).should be_true
+    end
+
+    it "that are empty upon creation" do
+      hash = @connection.hash :what
+      hash.empty?.should be_true
+    end
+
+    it "that if not yet allocated an attempt to delete them returns false" do
+      exists = @connection.delete :what
+      exists.should be_false
+    end
+
+    it "that if already allocated an attempt to delete them returns true" do
+      @connection.hash :what
+      exists = @connection.delete :what
+      exists.should be_true
+    end
+
+    it "that yield no value when accessing with an unknown key" do
+      hash = @connection.hash :what
+      hash[:id].should eq(nil)
+    end
+
+    it "that yield values for which an association exists" do
+      hash = @connection.hash :what
+      hash[:id] = 'value'
+      hash[:id].should eq('value')
+    end
+
+    it "that returns the value when deleting keys for which an association does exist" do
+      hash = @connection.hash :what
+      hash[:id] = 'value'
+      hash.delete(:id).should be_true
+    end
+
+    it "that returns nil when deleting keys for which an association does not exists and for which there is no default value" do
+      hash = @connection.hash :what
+      hash.delete(:id).should be_nil
+    end
+
+    it "that support merging key value pairs from other hashes" do
+      hash = @connection.hash :what
+      grades = {
+          Bob: 82,
+          Jim: 94,
+          Billy: 58
+      }
+      hash.merge! grades
+      hash[:Bob].should eq('82')
+    end
+
+    it "that implement enumerable" do
+      hash = @connection.hash :what
+      hash.respond_to?(:each).should be_true
+    end
+
+    it "that support each operations" do
+      hash = @connection.hash :what
+      grades = {
+          Bob: 82,
+          Jim: 94,
+          Billy: 58
+      }
+      hash.merge! grades
+      sum = 0
+      hash.each do |pair|
+        sum = sum + pair.last.to_i
+      end
+      sum.should eq(234)
+    end
+
+    it "that support each_pair operations" do
+      hash = @connection.hash :what
+      grades = {
+          Bob: 82,
+          Jim: 94,
+          Billy: 58
+      }
+      hash.merge! grades
+      sum = 0
+      hash.each_pair do |key, value|
+        key
+        sum = sum + value.to_i
+      end
+      sum.should eq(234)
+    end
+
+    it "that support each_value operations" do
+      hash = @connection.hash :what
+      grades = {
+          Bob: 82,
+          Jim: 94,
+          Billy: 58
+      }
+      hash.merge! grades
+      sum = 0
+      hash.each_value do |value|
+        sum = sum + value.to_i
+      end
+      sum.should eq(234)
+    end
+
+    it "that support merging key value pairs from other hashes" do
+      hash = @connection.hash :what
+      grades = {
+          Bob: 82,
+          Jim: 94,
+          Billy: 58
+      }
+      hash.merge! grades
+      hash[:Bob].should eq('82')
+    end
+
+  end
+end

data/spec/functional/list_spec.rb

@@ -52,6 +52,42 @@ describe Keymap::Base do
       list.pop.to_i.should eq(1)
     end
 
+    it "that supports replacing an entry by index" do
+      list = @connection.list :what
+      list << 'a' << 'b'
+      list[0] = 'c'
+      list[0].should eq('c')
+    end
+
+    it "that returns the value when deleting values that does exist" do
+      list = @connection.list :what
+      list << 'a'
+      list.delete('a').should eq('a')
+    end
+
+    it "that returns nil when deleting values that does not exist" do
+      list = @connection.list :what
+      list.delete('a').should be_nil
+    end
+
+    it "that supports concatenation" do
+      list = @connection.list :what
+      list << 'a'
+      list.concat %w(b)
+      list[0].should eq('a')
+      list[1].should eq('b')
+    end
+
+    it "that supports selectively deleting entries by a matching condition" do
+      list = @connection.list :what
+      list.concat [1, 2, 3, 4, 5, 6, 7, 8, 9]
+      list.delete_if { |value|
+        value.to_i % 2 > 0
+      }
+      list.length.should eq(4)
+      list[1].to_i.should eq(4)
+    end
+
     it "lists support append operators and inject" do
       list = @connection.list :what
       (0..10).each do |value|

data/spec/support/config.yml

@@ -5,4 +5,4 @@ connections:
     test:
       adapter:  redis
       host:     localhost
-      port:     4000
+      port:     6379

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: keymap
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-28 00:00:00.000000000 Z
+date: 2012-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: erubis
@@ -107,6 +107,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: hanna-nouveau
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: ruby-prof
   requirement: !ruby/object:Gem::Requirement
@@ -187,7 +203,9 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 2.11.0
-description: ActiveRecord like Key-Value Store API for Ruby
+description: Helping Ruby developers and their companies, unlock their key-value store
+  data, through associative and sequential based access, providing unprecedented support
+  for map reduce behaviors, native to the Ruby language
 email: buck.robert.j@gmail.com
 executables: []
 extensions: []
@@ -216,6 +234,7 @@ files:
 - spec/functional/abstract_adapter_spec.rb
 - spec/functional/adapter_spec.rb
 - spec/functional/adapters/redis/connection_spec.rb
+- spec/functional/hash_spec.rb
 - spec/functional/list_spec.rb
 - spec/rcov.opts
 - spec/spec.opts
@@ -224,7 +243,6 @@ files:
 - spec/support/config.yml
 - spec/support/connection.rb
 - spec/unit/.gitignore
-- spec/unit/test.rb
 - tasks/rspec.rb
 homepage: https://github.com/rbuck/keymap
 licenses: []
@@ -249,13 +267,14 @@ rubyforge_project:
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
-summary: Abstracts choosing a key-value store implementation, and provides a common
-  API.
+summary: Abstracts choosing a key-value store implementation, and provides a natural
+  enumerable-based Ruby API for hashed and sequential collections.
 test_files:
 - spec/data/.gitignore
 - spec/functional/abstract_adapter_spec.rb
 - spec/functional/adapter_spec.rb
 - spec/functional/adapters/redis/connection_spec.rb
+- spec/functional/hash_spec.rb
 - spec/functional/list_spec.rb
 - spec/rcov.opts
 - spec/spec.opts
@@ -264,5 +283,4 @@ test_files:
 - spec/support/config.yml
 - spec/support/connection.rb
 - spec/unit/.gitignore
-- spec/unit/test.rb
 - tasks/rspec.rb

data/spec/unit/test.rb

@@ -1,89 +0,0 @@
-require 'rubygems'
-require 'keymap'
-require 'yaml'
-require 'logger'
-
-Keymap::Base.configurations['redis'] = {
-    :adapter => 'redis',
-    :host => 'localhost'
-}
-
-class User < Keymap::Base
-
-  establish_connection 'redis'
-
-  def test
-    c = self.connection
-    puts 'hi'
-  end
-end
-
-user = User.new
-user.test
-
-#
-#config = {adapter: 'redis',
-#          host: 'localhost'
-#          #database: database,
-#          #username: user,
-#          #password: password,
-#}
-#Keymap::Base.establish_connection(config)
-#Keymap::Base.logger = Logger.new(STDERR)
-#
-#class User < Keymap::Base
-#end
-
-#puts User.count
-# SQL (0.000277)   SELECT count(*) AS count_all FROM users
-# 6
-
-
-#require 'redis'
-#require 'keymap/connection_adapters/redis_adapter'
-#require 'keymap/connection_adapters/abstract/connection_specification'
-#
-#Base.configurations["redis"] = {
-#    :adapter => 'redis',
-#    :host => 'localhost'
-#}
-#
-#Base.establish_connection(
-#    :adapter => "redis",
-#    :host => "localhost"
-#)
-#
-#
-##
-##class Table1 < ActiveRecord::Base
-##  establish_connection "db1"
-##end
-##
-##class Table2 < ActiveRecord::Base
-##  establish_connection "db2"
-##end
-#
-#
-#redis = ConnectionAdapters::RedisAdapter.new nil, nil, {host: "localhost"}
-#puts redis.active?
-#
-#redis.reconnect!
-#puts redis.active?
-#
-#redis.transaction do
-#  tokens = redis.hash 'tokens'
-#  tokens[:auth] = 'no way'
-#  puts tokens[:auth]
-#end
-#
-#redis.transaction do
-#  tokens = redis.hash 'tokens'
-#  tokens.each do |key, value|
-#    puts "#{key},#{value}"
-#  end
-#end
-#
-#redis.disconnect!
-#puts redis.active?
-#
-#