kevintyll-ofac 1.1.6 → 1.1.7

data/History.txt

@@ -38,4 +38,9 @@
 == 1.1.6 2009-06-29
 
 * 1 minor enhancement:
-  * Allow passing of first and last name seperately...to improve performance.
+  * Allow passing of first and last name seperately...to improve performance.
+
+== 1.1.7 2009-06-30
+
+* 1 bug fix:
+  * fixed error when passing a nil value into the new :first_name or :last_name hash values when initializing the Ofac object.

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :minor: 1
-:patch: 6
+:patch: 7
 :major: 1

data/lib/ofac/models/ofac.rb

@@ -112,13 +112,13 @@ class Ofac
 
       #you can pass in a full name, or specify the first and last name
       if @identity[:name].kind_of?(Hash)
-        name_array = [@identity[:name][:first_name],@identity[:name][:last_name]]
+        name_array = [@identity[:name][:first_name],@identity[:name][:last_name]].compact
       else
         partial_name = @identity[:name].gsub(/\W/,'|')
         name_array = partial_name.split('|')
       end
 
-      name_array.delete_if{|n| n.size < 2}
+      name_array.delete_if{|n| n.strip.size < 2}
       unless name_array.empty?
         sql_name_partial = name_array.collect {|partial_name| "name like '%#{partial_name}%'"}.join(' or ')
         sql_alt_name_partial = name_array.collect {|partial_name| "alternate_identity_name like '%#{partial_name}%'"}.join(' or ')

data/test/ofac_test.rb

@@ -12,6 +12,9 @@ class OfacTest < Test::Unit::TestCase
       assert_equal 0, Ofac.new({:address => '123 somewhere'}).score
       assert_equal 0, Ofac.new({:name => ''}).score
       assert_equal 0, Ofac.new({:name => ' '}).score
+      assert_equal 0, Ofac.new({:name => nil}).score
+      assert_equal 0, Ofac.new({:name => {:first_name => '',:last_name => ' '}}).score
+      assert_equal 0, Ofac.new({:name => {:first_name => '',:last_name => '  '}}).score
       assert_equal 0, Ofac.new({:name => 'P T'}).score
     end
 
@@ -33,6 +36,15 @@ class OfacTest < Test::Unit::TestCase
       assert_equal 30, Ofac.new({:name => {:first_name => 'Oscar', :last_name => 'de la Hernandez'}}).score
     end
 
+    should "handle first or last name not given" do
+      assert_equal 60, Ofac.new({:name => {:first_name => 'Oscar', :last_name => ''}}).score
+      assert_equal 60, Ofac.new({:name => {:first_name => 'Oscar', :last_name => nil}}).score
+      assert_equal 60, Ofac.new({:name => {:first_name => nil, :last_name => 'Oscar'}}).score
+      assert_equal 60, Ofac.new({:name => {:first_name => 'Oscar'}}).score
+      assert_equal 60, Ofac.new({:name => {:first_name => '', :last_name => 'Oscar'}}).score
+      assert_equal 60, Ofac.new({:name => {:last_name => 'Oscar'}}).score
+    end
+
     should "deduct scores for non matches on address and city if data is in the database" do
       #if there is data for address or city in the database, and that info is passed in, then 10%
       #of the weight will be deducted if there is not match or sounds like match

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: kevintyll-ofac
 version: !ruby/object:Gem::Version 
-  version: 1.1.6
+  version: 1.1.7
 platform: ruby
 authors: 
 - Kevin Tyll
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-29 00:00:00 -07:00
+date: 2009-06-30 00:00:00 -07:00
 default_executable: 
 dependencies: []