kevintyll-ofac 1.1.4 → 1.1.5

data/History.txt

@@ -28,4 +28,9 @@
 == 1.1.4 2009-06-02
 
 * 1 minor enhancement:
-  * Improved performance by ignoring initial in names when searching the database for possible hits.
+  * Improved performance by ignoring initial in names when searching the database for possible hits.
+
+== 1.1.5 2009-06-03
+
+* 1 bug fix:
+  * fixed a bug that threw an error if only single character initials are passed in for the name.

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :minor: 1
-:patch: 4
+:patch: 5
 :major: 1

data/lib/ofac/models/ofac.rb

@@ -103,22 +103,24 @@ class Ofac
       partial_name = @identity[:name].gsub(/\W/,'|')
       name_array = partial_name.split('|')
       name_array.delete_if{|n| n.size < 2}
-      sql_name_partial = name_array.collect {|partial_name| "name like '%#{partial_name}%'"}.join(' or ')
-      sql_alt_name_partial = name_array.collect {|partial_name| "alternate_identity_name like '%#{partial_name}%'"}.join(' or ')
-      possible_sdns = OfacSdn.connection.select_all("select name, alternate_identity_name, address, city
+      unless name_array.empty?
+        sql_name_partial = name_array.collect {|partial_name| "name like '%#{partial_name}%'"}.join(' or ')
+        sql_alt_name_partial = name_array.collect {|partial_name| "alternate_identity_name like '%#{partial_name}%'"}.join(' or ')
+        possible_sdns = OfacSdn.connection.select_all("select name, alternate_identity_name, address, city
                                 from ofac_sdns
                                 where name is not null
                                 and sdn_type = 'individual'
                                 and (#{sql_name_partial}
                                 or #{sql_alt_name_partial})")
-      possible_sdns = possible_sdns.collect {|sdn|{:name => "#{sdn['name']}|#{sdn['alternate_identity_name']}", :city => sdn['city'], :address => sdn['address']}}
+        possible_sdns = possible_sdns.collect {|sdn|{:name => "#{sdn['name']}|#{sdn['alternate_identity_name']}", :city => sdn['city'], :address => sdn['address']}}
      
-      match = OfacMatch.new({:name => {:weight => 60, :token => "#{@identity[:name]}"},
-          :address => {:weight => 10, :token => @identity[:address]},
-          :city => {:weight => 30, :token => @identity[:city]}})
+        match = OfacMatch.new({:name => {:weight => 60, :token => "#{@identity[:name]}"},
+            :address => {:weight => 10, :token => @identity[:address]},
+            :city => {:weight => 30, :token => @identity[:city]}})
 
-      score = match.score(possible_sdns)
-      @possible_hits = match.possible_hits
+        score = match.score(possible_sdns)
+        @possible_hits = match.possible_hits
+      end
     end
     @score = score || 0
     return @score

data/test/ofac_test.rb

@@ -12,6 +12,7 @@ class OfacTest < Test::Unit::TestCase
       assert_equal 0, Ofac.new({:address => '123 somewhere'}).score
       assert_equal 0, Ofac.new({:name => ''}).score
       assert_equal 0, Ofac.new({:name => ' '}).score
+      assert_equal 0, Ofac.new({:name => 'P T'}).score
     end
 
     should "give a score of 0 if there is no name match" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: kevintyll-ofac
 version: !ruby/object:Gem::Version 
-  version: 1.1.4
+  version: 1.1.5
 platform: ruby
 authors: 
 - Kevin Tyll
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-02 00:00:00 -07:00
+date: 2009-06-03 00:00:00 -07:00
 default_executable: 
 dependencies: []