kevinrutherford-reek 1.1.3.10 → 1.1.3.11

data/History.txt

@@ -6,18 +6,22 @@
 ** Output now reports on all files examined, even if they have no smells
 ** Smell warnings are indented in the report; file summary headers are not
 ** Reports for multiple sources are run together; no more blank lines
-** Reports in spec matcher failures are quiet
+** Reports in spec matcher failures are quiet (fixed #38)
 * The smells masked by *.reek config files can now be seen:
 ** The header for each source file now counts masked smells
 ** The --show-all (-a) option shows masked warnings in the report
+* The spec matchers are now accessed by requiring 'reek/adapters/spec'
 
 === Minor Changes
 * Reek's RDoc is now hosted at http://rdoc.info/projects/kevinrutherford/reek
+* If a dir is passed on the command-line all **/*.rb files below it are examined (fixed #41)
 * Several changes to the LongMethod counting algorithm:
 ** LongMethod now counts statements deeper into each method (fixed #25)
 ** LongMethod no longer counts control structures, only their contained stmts
 ** See http://wiki.github.com/kevinrutherford/reek/long-method for details
 * LargeClass is disabled when checking in-memory classes (fixed #28)
+* UtilityFunction no longer reports methods that call 'super' (fixed #39)
+* Duplication warnings now report the number of identical calls
 * Now reports an error for corrupt config files
 * Empty config files are ignored
 

data/bin/reek

@@ -6,21 +6,6 @@
 # Author: Kevin Rutherford
 #
 
-require 'reek/options'
+require 'reek/adapters/application'
 
-def reek(args)
-  begin
-    sniffer = Reek::Options.parse(args)
-    # SMELL:
-    # This should use the actual type of report selected by the user's options
-    puts sniffer.full_report
-    return sniffer.smelly? ? 2 : 0
-  rescue SystemExit => ex
-    return ex.status
-  rescue Exception => error
-    $stderr.puts "Error: #{error}"
-    return 1
-  end
-end
-
-exit reek(ARGV)
+exit Reek::Application.new(ARGV).execute

data/features/masking_smells.feature

@@ -11,8 +11,8 @@ Feature: Masking smells using config files
       """
       spec/samples/empty_config_file/dirty.rb -- 6 warnings:
         Dirty has the variable name '@s' (Uncommunicative Name)
-        Dirty#a calls @s.title multiple times (Duplication)
-        Dirty#a calls puts(@s.title) multiple times (Duplication)
+        Dirty#a calls @s.title twice (Duplication)
+        Dirty#a calls puts(@s.title) twice (Duplication)
         Dirty#a has the name 'a' (Uncommunicative Name)
         Dirty#a/block has the variable name 'x' (Uncommunicative Name)
         Dirty#a/block/block is nested (Nested Iterators)
@@ -35,8 +35,8 @@ Feature: Masking smells using config files
     And it reports:
       """
       spec/samples/masked/dirty.rb -- 3 warnings (+3 masked):
-        Dirty#a calls @s.title multiple times (Duplication)
-        Dirty#a calls puts(@s.title) multiple times (Duplication)
+        Dirty#a calls @s.title twice (Duplication)
+        Dirty#a calls puts(@s.title) twice (Duplication)
         Dirty#a/block/block is nested (Nested Iterators)
 
       """
@@ -48,8 +48,8 @@ Feature: Masking smells using config files
       """
       spec/samples/masked/dirty.rb -- 3 warnings (+3 masked):
         (masked) Dirty has the variable name '@s' (Uncommunicative Name)
-        Dirty#a calls @s.title multiple times (Duplication)
-        Dirty#a calls puts(@s.title) multiple times (Duplication)
+        Dirty#a calls @s.title twice (Duplication)
+        Dirty#a calls puts(@s.title) twice (Duplication)
         (masked) Dirty#a has the name 'a' (Uncommunicative Name)
         (masked) Dirty#a/block has the variable name 'x' (Uncommunicative Name)
         Dirty#a/block/block is nested (Nested Iterators)
@@ -62,8 +62,22 @@ Feature: Masking smells using config files
     And it reports:
       """
       spec/samples/masked/dirty.rb -- 3 warnings (+3 masked):
-        Dirty#a calls @s.title multiple times (Duplication)
-        Dirty#a calls puts(@s.title) multiple times (Duplication)
+        Dirty#a calls @s.title twice (Duplication)
+        Dirty#a calls puts(@s.title) twice (Duplication)
+        Dirty#a/block/block is nested (Nested Iterators)
+
+      """
+
+  Scenario: non-masked smells are only counted once
+    When I run reek spec/samples/not_quite_masked/dirty.rb
+    Then it fails with exit status 2
+    And it reports:
+      """
+      spec/samples/not_quite_masked/dirty.rb -- 5 warnings (+1 masked):
+        Dirty has the variable name '@s' (Uncommunicative Name)
+        Dirty#a calls @s.title twice (Duplication)
+        Dirty#a calls puts(@s.title) twice (Duplication)
+        Dirty#a has the name 'a' (Uncommunicative Name)
         Dirty#a/block/block is nested (Nested Iterators)
 
       """

data/features/options.feature

@@ -24,19 +24,26 @@ Feature: Reek can be controlled using command-line options
     Then it succeeds
     And it reports:
       """
-      Usage: reek [options] files...
+      Usage: reek [options] [files]
+
+      Examples:
+
+      reek lib/*.rb
+      reek -q -a lib
+      cat my_class.rb | reek
 
-      If no files are given, Reek reads source code from standard input.
       See http://wiki.github.com/kevinrutherford/reek for detailed help.
 
+      Common options:
+          -h, --help                       Show this message
+          -v, --version                    Show version
 
-      Options:
+
+      Report formatting:
           -a, --[no-]show-all              Show all smells, including those masked by config settings
           -q, --quiet                      Suppress headings for smell-free source files
-          -h, --help                       Show this message
           -f, --format FORMAT              Specify the format of smell warnings
           -c, --context-first              Sort by context; sets the format string to "%m%c %w (%s)"
           -s, --smell-first                Sort by smell; sets the format string to "%m[%s] %c %w"
-          -v, --version                    Show version
 
       """

data/features/reports.feature

@@ -4,30 +4,35 @@ Feature: Correctly formatted reports
   As a developer
   I want to be able to parse reek's output simply and consistently
 
-  Scenario: two reports run together with indented smells
-    When I run reek spec/samples/two_smelly_files/*.rb
+  Scenario Outline: two reports run together with indented smells
+    When I run reek <args>
     Then it fails with exit status 2
     And it reports:
       """
       spec/samples/two_smelly_files/dirty_one.rb -- 6 warnings:
         Dirty has the variable name '@s' (Uncommunicative Name)
-        Dirty#a calls @s.title multiple times (Duplication)
-        Dirty#a calls puts(@s.title) multiple times (Duplication)
+        Dirty#a calls @s.title twice (Duplication)
+        Dirty#a calls puts(@s.title) twice (Duplication)
         Dirty#a has the name 'a' (Uncommunicative Name)
         Dirty#a/block has the variable name 'x' (Uncommunicative Name)
         Dirty#a/block/block is nested (Nested Iterators)
       spec/samples/two_smelly_files/dirty_two.rb -- 6 warnings:
         Dirty has the variable name '@s' (Uncommunicative Name)
-        Dirty#a calls @s.title multiple times (Duplication)
-        Dirty#a calls puts(@s.title) multiple times (Duplication)
+        Dirty#a calls @s.title twice (Duplication)
+        Dirty#a calls puts(@s.title) twice (Duplication)
         Dirty#a has the name 'a' (Uncommunicative Name)
         Dirty#a/block has the variable name 'x' (Uncommunicative Name)
         Dirty#a/block/block is nested (Nested Iterators)
 
       """
 
-  Scenario: good files show headers consecutively
-    When I run reek spec/samples/three_clean_files/*.rb
+    Examples:
+      | args                               |
+      | spec/samples/two_smelly_files/*.rb |
+      | spec/samples/two_smelly_files      |
+
+  Scenario Outline: good files show headers consecutively
+    When I run reek <args>
     Then it succeeds
     And it reports:
       """
@@ -37,6 +42,11 @@ Feature: Correctly formatted reports
 
       """
 
+    Examples:
+      | args |
+      | spec/samples/three_clean_files/*.rb |
+      | spec/samples/three_clean_files      |
+
   Scenario Outline: --quiet turns off headers for fragrant files
     When I run reek <option> spec/samples/three_clean_files/*.rb
     Then it succeeds
@@ -59,15 +69,15 @@ Feature: Correctly formatted reports
       """
       spec/samples/clean_due_to_masking/dirty_one.rb -- 0 warnings (+6 masked):
         (masked) Dirty has the variable name '@s' (Uncommunicative Name)
-        (masked) Dirty#a calls @s.title multiple times (Duplication)
-        (masked) Dirty#a calls puts(@s.title) multiple times (Duplication)
+        (masked) Dirty#a calls @s.title twice (Duplication)
+        (masked) Dirty#a calls puts(@s.title) twice (Duplication)
         (masked) Dirty#a has the name 'a' (Uncommunicative Name)
         (masked) Dirty#a/block has the variable name 'x' (Uncommunicative Name)
         (masked) Dirty#a/block/block is nested (Nested Iterators)
       spec/samples/clean_due_to_masking/dirty_two.rb -- 0 warnings (+6 masked):
         (masked) Dirty has the variable name '@s' (Uncommunicative Name)
-        (masked) Dirty#a calls @s.title multiple times (Duplication)
-        (masked) Dirty#a calls puts(@s.title) multiple times (Duplication)
+        (masked) Dirty#a calls @s.title twice (Duplication)
+        (masked) Dirty#a calls puts(@s.title) twice (Duplication)
         (masked) Dirty#a has the name 'a' (Uncommunicative Name)
         (masked) Dirty#a/block has the variable name 'x' (Uncommunicative Name)
         (masked) Dirty#a/block/block is nested (Nested Iterators)

data/features/samples.feature

@@ -11,25 +11,25 @@ Feature: Basic smell detection
     """
     spec/samples/inline.rb -- 32 warnings:
       Inline::C has at least 13 instance variables (Large Class)
-      Inline::C#build calls ($? == 0) multiple times (Duplication)
-      Inline::C#build calls Inline.directory multiple times (Duplication)
-      Inline::C#build calls io.puts multiple times (Duplication)
-      Inline::C#build calls io.puts("#endif") multiple times (Duplication)
-      Inline::C#build calls io.puts("#ifdef __cplusplus") multiple times (Duplication)
-      Inline::C#build calls module_name multiple times (Duplication)
-      Inline::C#build calls warn("Output:\n#{result}") multiple times (Duplication)
+      Inline::C#build calls ($? == 0) twice (Duplication)
+      Inline::C#build calls Inline.directory 5 times (Duplication)
+      Inline::C#build calls io.puts 6 times (Duplication)
+      Inline::C#build calls io.puts("#endif") twice (Duplication)
+      Inline::C#build calls io.puts("#ifdef __cplusplus") twice (Duplication)
+      Inline::C#build calls module_name twice (Duplication)
+      Inline::C#build calls warn("Output:\n#{result}") twice (Duplication)
       Inline::C#build has approx 60 statements (Long Method)
       Inline::C#build has the variable name 't' (Uncommunicative Name)
       Inline::C#build/block/block has the variable name 'n' (Uncommunicative Name)
       Inline::C#build/block/block is nested (Nested Iterators)
       Inline::C#c has the name 'c' (Uncommunicative Name)
-      Inline::C#crap_for_windoze calls Config::CONFIG["libdir"] multiple times (Duplication)
-      Inline::C#generate calls result.sub!(/\A\n/, "") multiple times (Duplication)
-      Inline::C#generate calls signature["args"] multiple times (Duplication)
-      Inline::C#generate calls signature["args"].map multiple times (Duplication)
+      Inline::C#crap_for_windoze calls Config::CONFIG["libdir"] twice (Duplication)
+      Inline::C#generate calls result.sub!(/\A\n/, "") twice (Duplication)
+      Inline::C#generate calls signature["args"] twice (Duplication)
+      Inline::C#generate calls signature["args"].map twice (Duplication)
       Inline::C#generate has approx 32 statements (Long Method)
-      Inline::C#initialize calls stack.empty? multiple times (Duplication)
-      Inline::C#load calls so_name multiple times (Duplication)
+      Inline::C#initialize calls stack.empty? twice (Duplication)
+      Inline::C#load calls so_name twice (Duplication)
       Inline::C#module_name/block has the variable name 'm' (Uncommunicative Name)
       Inline::C#module_name/block has the variable name 'x' (Uncommunicative Name)
       Inline::C#parse_signature has approx 15 statements (Long Method)
@@ -37,9 +37,9 @@ Feature: Basic smell detection
       Inline::C#parse_signature/block has the variable name 'x' (Uncommunicative Name)
       Inline::C#strip_comments doesn't depend on instance state (Utility Function)
       Inline::C#strip_comments refers to src more than self (Feature Envy)
-      Inline::self.rootdir calls env.nil? multiple times (Duplication)
+      Inline::self.rootdir calls env.nil? twice (Duplication)
       Inline::self.rootdir has approx 8 statements (Long Method)
-      Module#inline calls Inline.const_get(lang) multiple times (Duplication)
+      Module#inline calls Inline.const_get(lang) twice (Duplication)
       Module#inline has approx 11 statements (Long Method)
       Module#inline is controlled by argument options (Control Couple)
 
@@ -53,8 +53,8 @@ Feature: Basic smell detection
     spec/samples/optparse.rb -- 117 warnings:
       OptionParser has at least 59 methods (Large Class)
       OptionParser#CompletingHash#match/block/block is nested (Nested Iterators)
-      OptionParser#Completion::complete calls candidates.size multiple times (Duplication)
-      OptionParser#Completion::complete calls k.id2name multiple times (Duplication)
+      OptionParser#Completion::complete calls candidates.size twice (Duplication)
+      OptionParser#Completion::complete calls k.id2name twice (Duplication)
       OptionParser#Completion::complete has approx 22 statements (Long Method)
       OptionParser#Completion::complete has the variable name 'k' (Uncommunicative Name)
       OptionParser#Completion::complete has the variable name 'v' (Uncommunicative Name)
@@ -80,23 +80,23 @@ Feature: Basic smell detection
       OptionParser#Switch#PlacedArgument#parse has approx 6 statements (Long Method)
       OptionParser#Switch#RequiredArgument#parse is controlled by argument arg (Control Couple)
       OptionParser#Switch#add_banner has the variable name 's' (Uncommunicative Name)
-      OptionParser#Switch#conv_arg calls conv multiple times (Duplication)
+      OptionParser#Switch#conv_arg calls conv twice (Duplication)
       OptionParser#Switch#initialize has 7 parameters (Long Parameter List)
-      OptionParser#Switch#parse_arg calls pattern multiple times (Duplication)
-      OptionParser#Switch#parse_arg calls s.length multiple times (Duplication)
+      OptionParser#Switch#parse_arg calls pattern twice (Duplication)
+      OptionParser#Switch#parse_arg calls s.length twice (Duplication)
       OptionParser#Switch#parse_arg has approx 11 statements (Long Method)
       OptionParser#Switch#parse_arg has the variable name 'm' (Uncommunicative Name)
       OptionParser#Switch#parse_arg has the variable name 's' (Uncommunicative Name)
       OptionParser#Switch#self.guess has the variable name 't' (Uncommunicative Name)
       OptionParser#Switch#self.incompatible_argument_styles has the variable name 't' (Uncommunicative Name)
-      OptionParser#Switch#summarize calls (indent + l) multiple times (Duplication)
-      OptionParser#Switch#summarize calls arg multiple times (Duplication)
-      OptionParser#Switch#summarize calls left.collect multiple times (Duplication)
-      OptionParser#Switch#summarize calls left.collect { |s| s.length }.max multiple times (Duplication)
-      OptionParser#Switch#summarize calls left.collect { |s| s.length }.max.to_i multiple times (Duplication)
-      OptionParser#Switch#summarize calls left.shift multiple times (Duplication)
-      OptionParser#Switch#summarize calls left[-1] multiple times (Duplication)
-      OptionParser#Switch#summarize calls s.length multiple times (Duplication)
+      OptionParser#Switch#summarize calls (indent + l) twice (Duplication)
+      OptionParser#Switch#summarize calls arg 4 times (Duplication)
+      OptionParser#Switch#summarize calls left.collect twice (Duplication)
+      OptionParser#Switch#summarize calls left.collect { |s| s.length }.max twice (Duplication)
+      OptionParser#Switch#summarize calls left.collect { |s| s.length }.max.to_i twice (Duplication)
+      OptionParser#Switch#summarize calls left.shift twice (Duplication)
+      OptionParser#Switch#summarize calls left[-1] 3 times (Duplication)
+      OptionParser#Switch#summarize calls s.length 3 times (Duplication)
       OptionParser#Switch#summarize has 5 parameters (Long Parameter List)
       OptionParser#Switch#summarize has approx 25 statements (Long Method)
       OptionParser#Switch#summarize has the variable name 'l' (Uncommunicative Name)
@@ -117,21 +117,21 @@ Feature: Basic smell detection
       OptionParser#block/block is nested (Nested Iterators)
       OptionParser#complete has 4 parameters (Long Parameter List)
       OptionParser#complete/block/block is nested (Nested Iterators)
-      OptionParser#getopts calls result[opt] = false multiple times (Duplication)
+      OptionParser#getopts calls result[opt] = false twice (Duplication)
       OptionParser#getopts has approx 17 statements (Long Method)
       OptionParser#getopts/block is controlled by argument val (Control Couple)
       OptionParser#load/block has the variable name 's' (Uncommunicative Name)
-      OptionParser#make_switch calls (long << o = q.downcase) multiple times (Duplication)
-      OptionParser#make_switch calls (sdesc << "-#{q}") multiple times (Duplication)
-      OptionParser#make_switch calls default_style.guess(arg = a) multiple times (Duplication)
-      OptionParser#make_switch calls notwice(NilClass, klass, "type") multiple times (Duplication)
-      OptionParser#make_switch calls notwice(a ? (Object) : (TrueClass), klass, "type") multiple times (Duplication)
-      OptionParser#make_switch calls pattern.method(:convert) multiple times (Duplication)
-      OptionParser#make_switch calls pattern.method(:convert).to_proc multiple times (Duplication)
-      OptionParser#make_switch calls pattern.respond_to?(:convert) multiple times (Duplication)
-      OptionParser#make_switch calls q.downcase multiple times (Duplication)
-      OptionParser#make_switch calls search(:atype, FalseClass) multiple times (Duplication)
-      OptionParser#make_switch calls search(:atype, o) multiple times (Duplication)
+      OptionParser#make_switch calls (long << o = q.downcase) twice (Duplication)
+      OptionParser#make_switch calls (sdesc << "-#{q}") twice (Duplication)
+      OptionParser#make_switch calls default_style.guess(arg = a) 4 times (Duplication)
+      OptionParser#make_switch calls notwice(NilClass, klass, "type") twice (Duplication)
+      OptionParser#make_switch calls notwice(a ? (Object) : (TrueClass), klass, "type") twice (Duplication)
+      OptionParser#make_switch calls pattern.method(:convert) twice (Duplication)
+      OptionParser#make_switch calls pattern.method(:convert).to_proc twice (Duplication)
+      OptionParser#make_switch calls pattern.respond_to?(:convert) twice (Duplication)
+      OptionParser#make_switch calls q.downcase 3 times (Duplication)
+      OptionParser#make_switch calls search(:atype, FalseClass) twice (Duplication)
+      OptionParser#make_switch calls search(:atype, o) 6 times (Duplication)
       OptionParser#make_switch has approx 68 statements (Long Method)
       OptionParser#make_switch has the variable name 'a' (Uncommunicative Name)
       OptionParser#make_switch has the variable name 'n' (Uncommunicative Name)
@@ -146,22 +146,22 @@ Feature: Basic smell detection
       OptionParser#make_switch/block/block has the variable name 'v' (Uncommunicative Name)
       OptionParser#make_switch/block/block is nested (Nested Iterators)
       OptionParser#make_switch/block/block/block is nested (Nested Iterators)
-      OptionParser#order calls argv[0] multiple times (Duplication)
+      OptionParser#order calls argv[0] twice (Duplication)
       OptionParser#order refers to argv more than self (Feature Envy)
-      OptionParser#parse calls argv[0] multiple times (Duplication)
+      OptionParser#parse calls argv[0] twice (Duplication)
       OptionParser#parse refers to argv more than self (Feature Envy)
-      OptionParser#parse_in_order calls $!.set_option(arg, true) multiple times (Duplication)
-      OptionParser#parse_in_order calls cb.call(val) multiple times (Duplication)
-      OptionParser#parse_in_order calls raise($!.set_option(arg, true)) multiple times (Duplication)
-      OptionParser#parse_in_order calls raise(*exc) multiple times (Duplication)
-      OptionParser#parse_in_order calls setter.call(sw.switch_name, val) multiple times (Duplication)
-      OptionParser#parse_in_order calls sw.block multiple times (Duplication)
-      OptionParser#parse_in_order calls sw.switch_name multiple times (Duplication)
+      OptionParser#parse_in_order calls $!.set_option(arg, true) twice (Duplication)
+      OptionParser#parse_in_order calls cb.call(val) twice (Duplication)
+      OptionParser#parse_in_order calls raise($!.set_option(arg, true)) twice (Duplication)
+      OptionParser#parse_in_order calls raise(*exc) twice (Duplication)
+      OptionParser#parse_in_order calls setter.call(sw.switch_name, val) twice (Duplication)
+      OptionParser#parse_in_order calls sw.block twice (Duplication)
+      OptionParser#parse_in_order calls sw.switch_name twice (Duplication)
       OptionParser#parse_in_order has approx 28 statements (Long Method)
       OptionParser#parse_in_order/block is controlled by argument setter (Control Couple)
       OptionParser#parse_in_order/block/block is nested (Nested Iterators)
       OptionParser#parse_in_order/block/block/block is nested (Nested Iterators)
-      OptionParser#permute calls argv[0] multiple times (Duplication)
+      OptionParser#permute calls argv[0] twice (Duplication)
       OptionParser#permute refers to argv more than self (Feature Envy)
       OptionParser#search/block has the variable name 'k' (Uncommunicative Name)
       OptionParser#summarize has 4 parameters (Long Parameter List)
@@ -185,12 +185,12 @@ Feature: Basic smell detection
       RedCloth#block_markdown_rule doesn't depend on instance state (Utility Function)
       RedCloth#block_markdown_rule refers to text more than self (Feature Envy)
       RedCloth#block_markdown_setext refers to text more than self (Feature Envy)
-      RedCloth#block_textile_lists calls (line_id - 1) multiple times (Duplication)
-      RedCloth#block_textile_lists calls depth.last multiple times (Duplication)
-      RedCloth#block_textile_lists calls depth.last.length multiple times (Duplication)
-      RedCloth#block_textile_lists calls depth[i] multiple times (Duplication)
-      RedCloth#block_textile_lists calls lines[(line_id - 1)] multiple times (Duplication)
-      RedCloth#block_textile_lists calls tl.length multiple times (Duplication)
+      RedCloth#block_textile_lists calls (line_id - 1) twice (Duplication)
+      RedCloth#block_textile_lists calls depth.last 5 times (Duplication)
+      RedCloth#block_textile_lists calls depth.last.length twice (Duplication)
+      RedCloth#block_textile_lists calls depth[i] twice (Duplication)
+      RedCloth#block_textile_lists calls lines[(line_id - 1)] twice (Duplication)
+      RedCloth#block_textile_lists calls tl.length 3 times (Duplication)
       RedCloth#block_textile_lists has approx 20 statements (Long Method)
       RedCloth#block_textile_lists refers to depth more than self (Feature Envy)
       RedCloth#block_textile_lists/block/block is nested (Nested Iterators)
@@ -205,7 +205,7 @@ Feature: Basic smell detection
       RedCloth#blocks/block is controlled by argument deep_code (Control Couple)
       RedCloth#blocks/block/block is nested (Nested Iterators)
       RedCloth#check_refs is controlled by argument text (Control Couple)
-      RedCloth#clean_html calls tags[tag] multiple times (Duplication)
+      RedCloth#clean_html calls tags[tag] twice (Duplication)
       RedCloth#clean_html doesn't depend on instance state (Utility Function)
       RedCloth#clean_html has approx 14 statements (Long Method)
       RedCloth#clean_html refers to raw more than self (Feature Envy)
@@ -243,7 +243,7 @@ Feature: Basic smell detection
       RedCloth#inline_textile_span/block/block is nested (Nested Iterators)
       RedCloth#no_textile doesn't depend on instance state (Utility Function)
       RedCloth#no_textile refers to text more than self (Feature Envy)
-      RedCloth#pba calls $1.length multiple times (Duplication)
+      RedCloth#pba calls $1.length twice (Duplication)
       RedCloth#pba has approx 21 statements (Long Method)
       RedCloth#pba is controlled by argument text_in (Control Couple)
       RedCloth#pba refers to style more than self (Feature Envy)
@@ -252,14 +252,14 @@ Feature: Basic smell detection
       RedCloth#refs_textile/block has the variable name 'm' (Uncommunicative Name)
       RedCloth#retrieve/block has the variable name 'i' (Uncommunicative Name)
       RedCloth#retrieve/block has the variable name 'r' (Uncommunicative Name)
-      RedCloth#rip_offtags calls ((codepre - used_offtags.length) > 0) multiple times (Duplication)
-      RedCloth#rip_offtags calls (@pre_list.last << line) multiple times (Duplication)
-      RedCloth#rip_offtags calls (codepre - used_offtags.length) multiple times (Duplication)
-      RedCloth#rip_offtags calls @pre_list.last multiple times (Duplication)
-      RedCloth#rip_offtags calls codepre.zero? multiple times (Duplication)
-      RedCloth#rip_offtags calls htmlesc(line, :NoQuotes) multiple times (Duplication)
-      RedCloth#rip_offtags calls used_offtags.length multiple times (Duplication)
-      RedCloth#rip_offtags calls used_offtags["notextile"] multiple times (Duplication)
+      RedCloth#rip_offtags calls ((codepre - used_offtags.length) > 0) twice (Duplication)
+      RedCloth#rip_offtags calls (@pre_list.last << line) twice (Duplication)
+      RedCloth#rip_offtags calls (codepre - used_offtags.length) twice (Duplication)
+      RedCloth#rip_offtags calls @pre_list.last twice (Duplication)
+      RedCloth#rip_offtags calls codepre.zero? twice (Duplication)
+      RedCloth#rip_offtags calls htmlesc(line, :NoQuotes) twice (Duplication)
+      RedCloth#rip_offtags calls used_offtags.length twice (Duplication)
+      RedCloth#rip_offtags calls used_offtags["notextile"] 3 times (Duplication)
       RedCloth#rip_offtags has approx 18 statements (Long Method)
       RedCloth#textile_bq has 4 parameters (Long Parameter List)
       RedCloth#textile_bq is controlled by argument atts (Control Couple)

data/lib/reek/adapters/application.rb

@@ -0,0 +1,47 @@
+require 'reek/command_line'
+require 'reek/adapters/source'
+require 'reek/adapters/core_extras'
+require 'reek/adapters/report'
+
+module Reek
+  #
+  # Represents an instance of a Reek application.
+  # This is the entry point for all invocations of Reek from the
+  # command line.
+  #
+  class Application
+    def initialize(argv)
+      @argv = argv
+    end
+
+    def examine_sources
+      # SMELL: Greedy Method
+      # Options.parse executes the -v and -h commands and throws a SystemExit
+      args = Options.new(@argv).parse
+      if args.length > 0
+        @sniffer = args.sniff
+      else
+        @sniffer = Reek::Sniffer.new($stdin.to_reek_source('$stdin'))
+      end
+    end
+
+    def reek
+      examine_sources
+      # SMELL:
+      # This should use the actual type of report selected by the user's options
+      puts Report.new(@sniffer.sniffers).full_report
+      return @sniffer.smelly? ? 2 : 0
+    end
+
+    def execute
+      begin
+        return reek
+      rescue SystemExit => ex
+        return ex.status
+      rescue Exception => error
+        $stderr.puts "Error: #{error}"
+        return 1
+      end
+    end
+  end
+end

data/lib/reek/adapters/core_extras.rb

@@ -0,0 +1,72 @@
+require 'reek/adapters/source'
+require 'reek/sniffer'
+
+class Object
+  #
+  # Creates a new +Sniffer+ that assumes this object contains Ruby source
+  # code and examines that code for smells. Calls +to_reek_source+ on self
+  # to obtain the +Source+ object wrapper.
+  #
+  def sniff
+    Reek::Sniffer.new(self.to_reek_source)
+  end
+
+  #
+  # Constructs a Sniffer which examines this object for code smells.
+  # (This feature is only enabled if you have the ParseTree gem installed.)
+  #
+  def to_reek_source
+    ObjectSource.new(self, self.to_s)
+  end
+end
+
+class File
+  #
+  # Creates a new +Source+ that assumes this File contains Ruby source
+  # code and prepares it to be examined for code smells.
+  #
+  def to_reek_source
+    Reek::SourceFile.new(self)
+  end
+end
+
+class IO
+  #
+  # Creates a new +Source+ that assumes this IO stream contains Ruby source
+  # code and prepares it to be examined for code smells.
+  #
+  def to_reek_source(description = 'io')
+    Reek::Source.new(self.readlines.join, description)
+  end
+end
+
+class String
+  #
+  # Creates a new +Source+ that assumes this string contains Ruby source
+  # code and prepares it to be examined for code smells.
+  #
+  def to_reek_source
+    Reek::Source.new(self, 'string')
+  end
+end
+
+class Array
+  def paths
+    self.map do |path|
+      if test 'd', path
+        Dir["#{path}/**/*.rb"].paths
+      else
+        path
+      end
+    end.flatten.sort
+  end
+
+  #
+  # Creates a new +Sniffer+ that assumes this Array contains the names
+  # of Ruby source files and examines those files for smells.
+  #
+  def sniff
+    sniffers = paths.map {|path| File.new(path).sniff}
+    Reek::SnifferSet.new(sniffers, 'dir')
+  end
+end

data/lib/reek/{object_source.rb → adapters/object_source.rb}

@@ -1,3 +1,5 @@
+require 'reek/adapters/source'
+
 module Reek
   class ObjectSource < Source   # :nodoc:
 
@@ -9,9 +11,10 @@ module Reek
       return unifier.process(sexp[0])
     end
 
-    def initialize(code, desc, sniffer)     # :nodoc:
+    def configure(sniffer)
       super
-      @sniffer.disable(LargeClass)
+      disabled_config = {Reek::Smells::SmellDetector::ENABLED_KEY => false}
+      sniffer.configure(LargeClass, disabled_config)
     end
 
     def can_parse_objects?
@@ -39,9 +42,7 @@ class Object
   # Constructs a Sniffer which examines this object for code smells.
   # (This feature is only enabled if you have the ParseTree gem installed.)
   #
-  def sniff
-    result = Sniffer.new
-    ObjectSource.new(self, self.to_s, result)
-    result
+  def to_reek_source
+    ObjectSource.new(self, self.to_s)
   end
 end

data/lib/reek/{rake_task.rb → adapters/rake_task.rb}

@@ -59,7 +59,7 @@ module Reek
     # Defines a new task, using the name +name+.
     def initialize(name = :reek)
       @name = name
-      @libs = [File.expand_path(File.dirname(__FILE__) + '/../../lib')]
+      @libs = [File.expand_path(File.dirname(__FILE__) + '/../../../lib')]
       @source_files = nil
       @ruby_opts = []
       @reek_opts = ''
@@ -87,7 +87,7 @@ private
     end
 
     def self.reek_script
-      File.expand_path(File.dirname(__FILE__) + '/../../bin/reek')
+      File.expand_path(File.dirname(__FILE__) + '/../../../bin/reek')
     end
 
     def self.ruby_exe