kevinrutherford-reek 1.1.3.10 → 1.1.3.11

data/reek.gemspec

@@ -2,17 +2,17 @@
 
 Gem::Specification.new do |s|
   s.name = %q{reek}
-  s.version = "1.1.3.10"
+  s.version = "1.1.3.11"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Kevin Rutherford"]
-  s.date = %q{2009-07-15}
+  s.date = %q{2009-07-23}
   s.default_executable = %q{reek}
   s.description = %q{Code smell detector for Ruby}
   s.email = ["kevin@rutherford-software.com"]
   s.executables = ["reek"]
   s.extra_rdoc_files = ["History.txt", "License.txt", "README.txt"]
-  s.files = ["History.txt", "License.txt", "README.txt", "Rakefile", "bin/reek", "config/defaults.reek", "features/masking_smells.feature", "features/options.feature", "features/rake_task.feature", "features/reports.feature", "features/samples.feature", "features/stdin.feature", "features/step_definitions/reek_steps.rb", "features/support/env.rb", "lib/reek.rb", "lib/reek/block_context.rb", "lib/reek/class_context.rb", "lib/reek/code_context.rb", "lib/reek/code_parser.rb", "lib/reek/config_file.rb", "lib/reek/core_extras.rb", "lib/reek/detector_stack.rb", "lib/reek/exceptions.reek", "lib/reek/if_context.rb", "lib/reek/method_context.rb", "lib/reek/module_context.rb", "lib/reek/name.rb", "lib/reek/object_refs.rb", "lib/reek/object_source.rb", "lib/reek/options.rb", "lib/reek/rake_task.rb", "lib/reek/report.rb", "lib/reek/sexp_formatter.rb", "lib/reek/singleton_method_context.rb", "lib/reek/smell_warning.rb", "lib/reek/smells/control_couple.rb", "lib/reek/smells/duplication.rb", "lib/reek/smells/feature_envy.rb", "lib/reek/smells/large_class.rb", "lib/reek/smells/long_method.rb", "lib/reek/smells/long_parameter_list.rb", "lib/reek/smells/long_yield_list.rb", "lib/reek/smells/nested_iterators.rb", "lib/reek/smells/smell_detector.rb", "lib/reek/smells/uncommunicative_name.rb", "lib/reek/smells/utility_function.rb", "lib/reek/sniffer.rb", "lib/reek/source.rb", "lib/reek/spec.rb", "lib/reek/stop_context.rb", "lib/reek/yield_call_context.rb", "reek.gemspec", "spec/reek/block_context_spec.rb", "spec/reek/class_context_spec.rb", "spec/reek/code_context_spec.rb", "spec/reek/code_parser_spec.rb", "spec/reek/config_spec.rb", "spec/reek/if_context_spec.rb", "spec/reek/method_context_spec.rb", "spec/reek/module_context_spec.rb", "spec/reek/name_spec.rb", "spec/reek/object_refs_spec.rb", "spec/reek/object_source_spec.rb", "spec/reek/options_spec.rb", "spec/reek/report_spec.rb", "spec/reek/should_reek_of_spec.rb", "spec/reek/should_reek_only_of_spec.rb", "spec/reek/should_reek_spec.rb", "spec/reek/singleton_method_context_spec.rb", "spec/reek/smell_warning_spec.rb", "spec/reek/smells/control_couple_spec.rb", "spec/reek/smells/duplication_spec.rb", "spec/reek/smells/feature_envy_spec.rb", "spec/reek/smells/large_class_spec.rb", "spec/reek/smells/long_method_spec.rb", "spec/reek/smells/long_parameter_list_spec.rb", "spec/reek/smells/nested_iterators_spec.rb", "spec/reek/smells/smell_detector_spec.rb", "spec/reek/smells/uncommunicative_name_spec.rb", "spec/reek/smells/utility_function_spec.rb", "spec/reek/sniffer_spec.rb", "spec/samples/all_but_one_masked/clean_one.rb", "spec/samples/all_but_one_masked/dirty.rb", "spec/samples/all_but_one_masked/masked.reek", "spec/samples/clean_due_to_masking/clean_one.rb", "spec/samples/clean_due_to_masking/clean_three.rb", "spec/samples/clean_due_to_masking/clean_two.rb", "spec/samples/clean_due_to_masking/dirty_one.rb", "spec/samples/clean_due_to_masking/dirty_two.rb", "spec/samples/clean_due_to_masking/masked.reek", "spec/samples/corrupt_config_file/corrupt.reek", "spec/samples/corrupt_config_file/dirty.rb", "spec/samples/empty_config_file/dirty.rb", "spec/samples/empty_config_file/empty.reek", "spec/samples/inline.rb", "spec/samples/masked/dirty.rb", "spec/samples/masked/masked.reek", "spec/samples/mixed_results/clean_one.rb", "spec/samples/mixed_results/clean_three.rb", "spec/samples/mixed_results/clean_two.rb", "spec/samples/mixed_results/dirty_one.rb", "spec/samples/mixed_results/dirty_two.rb", "spec/samples/optparse.rb", "spec/samples/redcloth.rb", "spec/samples/three_clean_files/clean_one.rb", "spec/samples/three_clean_files/clean_three.rb", "spec/samples/three_clean_files/clean_two.rb", "spec/samples/two_smelly_files/dirty_one.rb", "spec/samples/two_smelly_files/dirty_two.rb", "spec/slow/inline_spec.rb", "spec/slow/optparse_spec.rb", "spec/slow/redcloth_spec.rb", "spec/slow/reek_source_spec.rb", "spec/spec.opts", "spec/spec_helper.rb", "tasks/reek.rake", "tasks/test.rake"]
+  s.files = ["History.txt", "License.txt", "README.txt", "Rakefile", "bin/reek", "config/defaults.reek", "features/masking_smells.feature", "features/options.feature", "features/reports.feature", "features/samples.feature", "features/stdin.feature", "features/step_definitions/reek_steps.rb", "features/support/env.rb", "lib/reek.rb", "lib/reek/adapters/application.rb", "lib/reek/adapters/config_file.rb", "lib/reek/adapters/core_extras.rb", "lib/reek/adapters/object_source.rb", "lib/reek/adapters/rake_task.rb", "lib/reek/adapters/report.rb", "lib/reek/adapters/source.rb", "lib/reek/adapters/spec.rb", "lib/reek/block_context.rb", "lib/reek/class_context.rb", "lib/reek/code_context.rb", "lib/reek/code_parser.rb", "lib/reek/command_line.rb", "lib/reek/detector_stack.rb", "lib/reek/exceptions.reek", "lib/reek/if_context.rb", "lib/reek/method_context.rb", "lib/reek/module_context.rb", "lib/reek/name.rb", "lib/reek/object_refs.rb", "lib/reek/sexp_formatter.rb", "lib/reek/singleton_method_context.rb", "lib/reek/smell_warning.rb", "lib/reek/smells/control_couple.rb", "lib/reek/smells/duplication.rb", "lib/reek/smells/feature_envy.rb", "lib/reek/smells/large_class.rb", "lib/reek/smells/long_method.rb", "lib/reek/smells/long_parameter_list.rb", "lib/reek/smells/long_yield_list.rb", "lib/reek/smells/nested_iterators.rb", "lib/reek/smells/smell_detector.rb", "lib/reek/smells/uncommunicative_name.rb", "lib/reek/smells/utility_function.rb", "lib/reek/sniffer.rb", "lib/reek/stop_context.rb", "lib/reek/yield_call_context.rb", "reek.gemspec", "spec/quality/reek_source_spec.rb", "spec/reek/adapters/report_spec.rb", "spec/reek/adapters/should_reek_of_spec.rb", "spec/reek/adapters/should_reek_only_of_spec.rb", "spec/reek/adapters/should_reek_spec.rb", "spec/reek/block_context_spec.rb", "spec/reek/class_context_spec.rb", "spec/reek/code_context_spec.rb", "spec/reek/code_parser_spec.rb", "spec/reek/config_spec.rb", "spec/reek/if_context_spec.rb", "spec/reek/method_context_spec.rb", "spec/reek/module_context_spec.rb", "spec/reek/name_spec.rb", "spec/reek/object_refs_spec.rb", "spec/reek/object_source_spec.rb", "spec/reek/singleton_method_context_spec.rb", "spec/reek/smell_warning_spec.rb", "spec/reek/smells/control_couple_spec.rb", "spec/reek/smells/duplication_spec.rb", "spec/reek/smells/feature_envy_spec.rb", "spec/reek/smells/large_class_spec.rb", "spec/reek/smells/long_method_spec.rb", "spec/reek/smells/long_parameter_list_spec.rb", "spec/reek/smells/nested_iterators_spec.rb", "spec/reek/smells/smell_detector_spec.rb", "spec/reek/smells/uncommunicative_name_spec.rb", "spec/reek/smells/utility_function_spec.rb", "spec/reek/sniffer_spec.rb", "spec/samples/all_but_one_masked/clean_one.rb", "spec/samples/all_but_one_masked/dirty.rb", "spec/samples/all_but_one_masked/masked.reek", "spec/samples/clean_due_to_masking/clean_one.rb", "spec/samples/clean_due_to_masking/clean_three.rb", "spec/samples/clean_due_to_masking/clean_two.rb", "spec/samples/clean_due_to_masking/dirty_one.rb", "spec/samples/clean_due_to_masking/dirty_two.rb", "spec/samples/clean_due_to_masking/masked.reek", "spec/samples/corrupt_config_file/corrupt.reek", "spec/samples/corrupt_config_file/dirty.rb", "spec/samples/empty_config_file/dirty.rb", "spec/samples/empty_config_file/empty.reek", "spec/samples/inline.rb", "spec/samples/masked/dirty.rb", "spec/samples/masked/masked.reek", "spec/samples/mixed_results/clean_one.rb", "spec/samples/mixed_results/clean_three.rb", "spec/samples/mixed_results/clean_two.rb", "spec/samples/mixed_results/dirty_one.rb", "spec/samples/mixed_results/dirty_two.rb", "spec/samples/not_quite_masked/dirty.rb", "spec/samples/not_quite_masked/masked.reek", "spec/samples/optparse.rb", "spec/samples/redcloth.rb", "spec/samples/three_clean_files/clean_one.rb", "spec/samples/three_clean_files/clean_three.rb", "spec/samples/three_clean_files/clean_two.rb", "spec/samples/two_smelly_files/dirty_one.rb", "spec/samples/two_smelly_files/dirty_two.rb", "spec/spec.opts", "spec/spec_helper.rb", "tasks/reek.rake", "tasks/test.rake"]
   s.homepage = %q{http://wiki.github.com/kevinrutherford/reek}
   s.post_install_message = %q{
 For more information on reek, see http://wiki.github.com/kevinrutherford/reek

data/spec/quality/reek_source_spec.rb

@@ -0,0 +1,15 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+describe 'Reek source code' do
+  it 'has no smells' do
+    Dir['lib/**/*.rb'].should_not reek
+  end
+
+  nucleus = Dir['lib/reek/**.rb'] - Dir['lib/reek/adapters/**/*.rb']
+  nucleus.each do |src|
+    it "#{src} contains no references from the nucleus out to the adapters" do
+      File.new(src).lines.grep(/adapters/).should be_empty
+    end
+  end
+
+end

data/spec/reek/adapters/report_spec.rb

@@ -0,0 +1,48 @@
+require File.dirname(__FILE__) + '/../../spec_helper.rb'
+
+require 'reek/adapters/core_extras'
+require 'reek/adapters/report'
+require 'reek/adapters/source'
+require 'reek/smells/feature_envy'
+
+include Reek
+
+describe ReportSection, " when empty" do
+  before(:each) do
+    @rpt = ReportSection.new(''.sniff)
+  end
+
+  it 'has an empty quiet_report' do
+    @rpt.quiet_report.should == ''
+  end
+end
+
+describe ReportSection, "smell_list" do
+  before(:each) do
+    rpt = ReportSection.new('def simple(a) a[3] end'.sniff)
+    @lines = rpt.smell_list.split("\n")
+  end
+
+  it 'should mention every smell name' do
+    @lines.should have_at_least(2).lines
+    @lines[0].should match(/[Utility Function]/)
+    @lines[1].should match(/[Feature Envy]/)
+  end
+end
+
+describe ReportSection, " as a SortedSet" do
+  it 'should only add a smell once' do
+    rpt = ReportSection.new(''.sniff)
+    rpt << SmellWarning.new(Smells::FeatureEnvy.new, "self", 'too many!')
+    rpt << SmellWarning.new(Smells::FeatureEnvy.new, "self", 'too many!')
+    lines = rpt.smell_list.split("\n")
+    lines.should have(1).lines
+  end
+
+  it 'should not count an identical masked smell' do
+    rpt = ReportSection.new(''.sniff)
+    rpt << SmellWarning.new(Smells::FeatureEnvy.new, "self", 'too many!')
+    rpt.record_masked_smell(SmellWarning.new(Smells::FeatureEnvy.new, "self", 'too many!'))
+    rpt.header.should == 'string -- 1 warning'
+  end
+end

data/spec/reek/{should_reek_of_spec.rb → adapters/should_reek_of_spec.rb}

@@ -1,7 +1,9 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
+require File.dirname(__FILE__) + '/../../spec_helper.rb'
 
-require 'reek/spec'
+require 'reek/adapters/report'
+require 'reek/adapters/spec'
 
+include Reek
 include Reek::Spec
 
 describe ShouldReekOf, 'rdoc demo example' do
@@ -37,7 +39,7 @@ describe ShouldReekOf, 'checking code in a string' do
 
   it 'reports the smells when should_not fails' do
     @matcher.matches?(@smelly_code).should be_true
-    @matcher.failure_message_for_should_not.should include(@smelly_code.sniff.quiet_report)
+    @matcher.failure_message_for_should_not.should include(Report.new(@smelly_code.sniff).quiet_report)
   end
 end
 
@@ -58,7 +60,7 @@ describe ShouldReekOf, 'checking code in a Dir' do
 
   it 'reports the smells when should_not fails' do
     @matcher.matches?(@smelly_dir).should be_true
-    @matcher.failure_message_for_should_not.should include(@smelly_dir.sniff.quiet_report)
+    @matcher.failure_message_for_should_not.should include(Report.new(@smelly_dir.sniff.sniffers).quiet_report)
   end
 end
 
@@ -79,15 +81,17 @@ describe ShouldReekOf, 'checking code in a File' do
 
   it 'reports the smells when should_not fails' do
     @matcher.matches?(@smelly_file).should be_true
-    @matcher.failure_message_for_should_not.should include(@smelly_file.sniff.quiet_report)
+    @matcher.failure_message_for_should_not.should include(Report.new(@smelly_file.sniff).quiet_report)
   end
 end
 
 describe ShouldReekOf, 'report formatting' do
   before :each do
-    @smelly_dir = Dir['spec/samples/mixed_results/*.rb']
+    sn_clean = 'def clean() @thing = 4; end'.sniff
+    sn_dirty = 'def dirty() thing.cool + thing.cool; end'.sniff
+    sniffers = SnifferSet.new([sn_clean, sn_dirty], '')
     @matcher = ShouldReekOf.new(:UncommunicativeName, [/Dirty/, /@s/])
-    @matcher.matches?(@smelly_dir)
+    @matcher.matches?(sniffers)
     @lines = @matcher.failure_message_for_should_not.split("\n").map {|str| str.chomp}
     @error_message = @lines.shift
     @smells = @lines.grep(/^  /)
@@ -95,11 +99,10 @@ describe ShouldReekOf, 'report formatting' do
   end
 
   it 'mentions every smell in the report' do
-    @smells.should have(12).warnings
+    @smells.should have(2).warnings
   end
 
-  it 'doesnt mention the clean files' do
-    @headers.should have(2).headers
-    @headers.should_not include('clean')
+  it 'doesnt mention the clean source' do
+    @headers.should have(1).headers
   end
 end

data/spec/reek/{should_reek_only_of_spec.rb → adapters/should_reek_only_of_spec.rb}

@@ -1,7 +1,9 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
+require File.dirname(__FILE__) + '/../../spec_helper.rb'
 
-require 'reek/spec'
+require 'reek/adapters/report'
+require 'reek/adapters/spec'
 
+include Reek
 include Reek::Spec
 
 describe ShouldReekOnlyOf, 'checking code in a string' do
@@ -42,7 +44,7 @@ describe ShouldReekOnlyOf, 'checking code in a Dir' do
 
   it 'reports the smells when should_not fails' do
     @matcher.matches?(@smelly_dir).should be_true
-    @matcher.failure_message_for_should.should include(@smelly_dir.sniff.quiet_report)
+    @matcher.failure_message_for_should.should include(Report.new(@smelly_dir.sniff.sniffers).quiet_report)
   end
 end
 
@@ -63,7 +65,7 @@ describe ShouldReekOnlyOf, 'checking code in a File' do
 
   it 'reports the smells when should_not fails' do
     @matcher.matches?(@smelly_file).should be_true
-    @matcher.failure_message_for_should.should include(@smelly_file.sniff.quiet_report)
+    @matcher.failure_message_for_should.should include(Report.new(@smelly_file.sniff).quiet_report)
   end
 end
 

data/spec/reek/{should_reek_spec.rb → adapters/should_reek_spec.rb}

@@ -1,7 +1,9 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
+require File.dirname(__FILE__) + '/../../spec_helper.rb'
 
-require 'reek/spec'
+require 'reek/adapters/report'
+require 'reek/adapters/spec'
 
+include Reek
 include Reek::Spec
 
 describe ShouldReek, 'checking code in a string' do
@@ -21,7 +23,7 @@ describe ShouldReek, 'checking code in a string' do
 
   it 'reports the smells when should_not fails' do
     @matcher.matches?(@smelly_code).should be_true
-    @matcher.failure_message_for_should_not.should include(@smelly_code.sniff.quiet_report)
+    @matcher.failure_message_for_should_not.should include(Report.new(@smelly_code.sniff).quiet_report)
   end
 end
 
@@ -42,7 +44,7 @@ describe ShouldReek, 'checking code in a Dir' do
 
   it 'reports the smells when should_not fails' do
     @matcher.matches?(@smelly_dir).should be_true
-    @matcher.failure_message_for_should_not.should include(@smelly_dir.sniff.quiet_report)
+    @matcher.failure_message_for_should_not.should include(Report.new(@smelly_dir.sniff.sniffers).quiet_report)
   end
 end
 
@@ -63,15 +65,17 @@ describe ShouldReek, 'checking code in a File' do
 
   it 'reports the smells when should_not fails' do
     @matcher.matches?(@smelly_file).should be_true
-    @matcher.failure_message_for_should_not.should include(@smelly_file.sniff.quiet_report)
+    @matcher.failure_message_for_should_not.should include(Report.new(@smelly_file.sniff).quiet_report)
   end
 end
 
 describe ShouldReek, 'report formatting' do
   before :each do
-    @smelly_dir = Dir['spec/samples/mixed_results/*.rb']
+    sn_clean = 'def clean() @thing = 4; end'.sniff
+    sn_dirty = 'def dirty() thing.cool + thing.cool; end'.sniff
+    sniffers = SnifferSet.new([sn_clean, sn_dirty], '')
     @matcher = ShouldReek.new
-    @matcher.matches?(@smelly_dir)
+    @matcher.matches?(sniffers)
     @lines = @matcher.failure_message_for_should_not.split("\n").map {|str| str.chomp}
     @error_message = @lines.shift
     @smells = @lines.grep(/^  /)
@@ -79,11 +83,10 @@ describe ShouldReek, 'report formatting' do
   end
 
   it 'mentions every smell in the report' do
-    @smells.should have(12).warnings
+    @smells.should have(2).warnings
   end
 
   it 'doesnt mention the clean files' do
-    @headers.should have(2).headers
-    @headers.should_not include('clean')
+    @headers.should have(1).headers
   end
 end

data/spec/reek/block_context_spec.rb

@@ -37,4 +37,10 @@ describe BlockContext do
     bctx.record_local_variable(:q2)
     bctx.variable_names.should include(Name.new(:q2))
   end
+
+  it 'copes with a yield to an ivar' do
+    scope = BlockContext.new(StopContext.new, [s(:iasgn, :@list), s(:self)])
+    scope.record_instance_variable(:@list)
+    scope.variable_names.should == [:@list]
+  end
 end

data/spec/reek/code_parser_spec.rb

@@ -1,7 +1,6 @@
 require File.dirname(__FILE__) + '/../spec_helper.rb'
 
 require 'reek/code_parser'
-require 'reek/report'
 
 include Reek
 
@@ -32,3 +31,9 @@ end'
     source.should_not reek
   end
 end
+
+describe CodeParser do
+  it 'copes with a yield to an ivar' do
+    'def options() ozz.on { |@list| @prompt = !@list } end'.should_not reek
+  end
+end

data/spec/reek/config_spec.rb

@@ -1,11 +1,11 @@
 require File.dirname(__FILE__) + '/../spec_helper.rb'
 
-require 'reek/smells/smells'
+require 'reek/sniffer'
 require 'yaml'
 
 include Reek
 
-describe 'Config' do
+describe Hash do
   before :each do
     @first = {
       'one' => {'two' => 3, 'three' => 4},
@@ -32,7 +32,7 @@ describe 'Config' do
   end
 end
 
-describe Config, 'merging arrays' do
+describe Hash, 'merging arrays' do
   it 'should merge array values' do
     first = {'key' => {'one' => [1,2,3]}}
     second = {'key' => {'one' => [4,5]}}

data/spec/reek/smell_warning_spec.rb

@@ -1,6 +1,7 @@
 require File.dirname(__FILE__) + '/../spec_helper.rb'
 
-require 'reek/smells/smells'
+require 'reek/smell_warning'
+require 'reek/smells/feature_envy'
 
 include Reek
 

data/spec/reek/smells/duplication_spec.rb

@@ -1,5 +1,5 @@
 require File.dirname(__FILE__) + '/../../spec_helper.rb'
-require 'reek/report'
+
 require 'reek/method_context'
 require 'reek/stop_context'
 require 'reek/smells/duplication'

data/spec/reek/smells/large_class_spec.rb

@@ -1,7 +1,8 @@
 require File.dirname(__FILE__) + '/../../spec_helper.rb'
+
+require 'reek/class_context'
+require 'reek/stop_context'
 require 'reek/code_parser'
-require 'reek/report'
-require 'reek/object_source'
 require 'reek/smells/large_class'
 
 include Reek

data/spec/reek/smells/long_method_spec.rb

@@ -1,15 +1,16 @@
 require File.dirname(__FILE__) + '/../../spec_helper.rb'
 
 require 'reek/code_parser'
-require 'reek/report'
+require 'reek/sniffer'
 require 'reek/smells/long_method'
 
 include Reek
 include Reek::Smells
 
 def process_method(src)
-  sniffer = src.sniff
-  CodeParser.new(sniffer).process_defn(sniffer.source.syntax_tree)
+  source = src.to_reek_source
+  sniffer = Sniffer.new(source)
+  CodeParser.new(sniffer).process_defn(source.syntax_tree)
 end
 
 describe LongMethod do

data/spec/reek/smells/long_parameter_list_spec.rb

@@ -1,8 +1,6 @@
 require File.dirname(__FILE__) + '/../../spec_helper.rb'
 
-require 'reek/object_source'
 require 'reek/smells/long_parameter_list'
-require 'reek/report'
 
 include Reek
 include Reek::Smells

data/spec/reek/smells/smell_detector_spec.rb

@@ -1,8 +1,9 @@
 require File.dirname(__FILE__) + '/../../spec_helper.rb'
 
-require 'reek/report'
+require 'reek/adapters/report'
 require 'reek/smells/duplication'
 require 'reek/smells/large_class'
+require 'reek/smells/long_method'
 
 include Reek
 include Reek::Smells
@@ -35,21 +36,6 @@ describe SmellDetector, 'when copied' do
   end
 end
 
-describe SmellDetector, 'when masked' do
-  before(:each) do
-    @detector = Duplication.new
-    @detector.be_masked
-    @detector.found(nil, 'help')
-  end
-
-  it 'reports smells as masked' do
-    rpt = Report.new(Sniffer.new)
-    @detector.report_on(rpt)
-    rpt.length.should == 0
-    rpt.num_masked_smells.should == 1
-  end
-end
-
 describe SmellDetector, 'configuration' do
 #  it 'stays enabled when not disabled' do
 #    @detector = LargeClass.new

data/spec/reek/smells/uncommunicative_name_spec.rb

@@ -1,6 +1,5 @@
 require File.dirname(__FILE__) + '/../../spec_helper.rb'
-require 'ostruct'
-require 'reek/core_extras'
+
 require 'reek/method_context'
 require 'reek/smells/uncommunicative_name'
 

data/spec/reek/smells/utility_function_spec.rb

@@ -39,6 +39,10 @@ describe UtilityFunction do
     end
     Son.should_not reek
   end
+
+  it 'does not report a method that calls super' do
+    'def child(arg) super; arg.to_s; end'.should_not reek
+  end
   
   it 'should recognise a deep call' do
     src = <<EOS

data/spec/samples/not_quite_masked/dirty.rb

@@ -0,0 +1,8 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end
+

data/spec/samples/not_quite_masked/masked.reek

@@ -0,0 +1,5 @@
+---
+UncommunicativeName:
+  accept:
+    - x
+

data/spec/spec_helper.rb

@@ -8,6 +8,6 @@ rescue LoadError
   require 'spec/expectations'
 end
 
-require 'reek/spec'
+require 'reek/adapters/spec'
 
 SAMPLES_DIR = 'spec/samples' unless Object.const_defined?('SAMPLES_DIR')

data/tasks/reek.rake

@@ -1,10 +1,10 @@
 begin
-  require 'reek/rake_task'
+  require 'reek/adapters/rake_task'
 
   Reek::RakeTask.new do |t|
     t.fail_on_error = true
     t.verbose = false
-  #  t.reek_opts = '-f "Smell: %s: %c %w"'
+    t.reek_opts = '--quiet --show-all'
   end
 rescue Gem::LoadError
 end

data/tasks/test.rake

@@ -5,24 +5,24 @@ require 'spec'
 require 'spec/rake/spectask'
 
 namespace 'test' do
-  FAST = FileList['spec/reek/**/*_spec.rb']
-  SLOW = FileList['spec/slow/**/*_spec.rb']
+  UNIT_TESTS = FileList['spec/reek/**/*_spec.rb']
+  QUALITY_TESTS = FileList['spec/quality/**/*_spec.rb']
 
   Spec::Rake::SpecTask.new('spec') do |t|
-    t.spec_files = FAST
+    t.spec_files = UNIT_TESTS
     t.ruby_opts = ['-Ilib']
     t.rcov = false
   end
 
-  Spec::Rake::SpecTask.new('slow') do |t|
-    t.spec_files = SLOW
+  Spec::Rake::SpecTask.new('quality') do |t|
+    t.spec_files = QUALITY_TESTS
     t.ruby_opts = ['-Ilib']
     t.rcov = false
   end
 
   desc 'Runs all unit tests under RCov'
   Spec::Rake::SpecTask.new('rcov') do |t|
-    t.spec_files = FAST + SLOW
+    t.spec_files = UNIT_TESTS + QUALITY_TESTS
     t.rcov = true
     t.rcov_dir = 'build/coverage'
   end
@@ -31,8 +31,8 @@ namespace 'test' do
     t.cucumber_opts = "features --format progress --no-color"
   end
 
-  desc 'Runs all unit tests and acceptance tests'
-  task 'all' => ['test:spec', 'test:slow', 'test:features']
+  desc 'Runs all unit tests, acceptance tests and quality checks'
+  task 'all' => ['test:spec', 'test:features', 'test:quality']
 end
 
 task 'clobber_rcov' => 'test:clobber_rcov'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: kevinrutherford-reek
 version: !ruby/object:Gem::Version 
-  version: 1.1.3.10
+  version: 1.1.3.11
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-07-15 00:00:00 -07:00
+date: 2009-07-23 00:00:00 -07:00
 default_executable: reek
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -62,19 +62,25 @@ files:
 - config/defaults.reek
 - features/masking_smells.feature
 - features/options.feature
-- features/rake_task.feature
 - features/reports.feature
 - features/samples.feature
 - features/stdin.feature
 - features/step_definitions/reek_steps.rb
 - features/support/env.rb
 - lib/reek.rb
+- lib/reek/adapters/application.rb
+- lib/reek/adapters/config_file.rb
+- lib/reek/adapters/core_extras.rb
+- lib/reek/adapters/object_source.rb
+- lib/reek/adapters/rake_task.rb
+- lib/reek/adapters/report.rb
+- lib/reek/adapters/source.rb
+- lib/reek/adapters/spec.rb
 - lib/reek/block_context.rb
 - lib/reek/class_context.rb
 - lib/reek/code_context.rb
 - lib/reek/code_parser.rb
-- lib/reek/config_file.rb
-- lib/reek/core_extras.rb
+- lib/reek/command_line.rb
 - lib/reek/detector_stack.rb
 - lib/reek/exceptions.reek
 - lib/reek/if_context.rb
@@ -82,10 +88,6 @@ files:
 - lib/reek/module_context.rb
 - lib/reek/name.rb
 - lib/reek/object_refs.rb
-- lib/reek/object_source.rb
-- lib/reek/options.rb
-- lib/reek/rake_task.rb
-- lib/reek/report.rb
 - lib/reek/sexp_formatter.rb
 - lib/reek/singleton_method_context.rb
 - lib/reek/smell_warning.rb
@@ -101,11 +103,14 @@ files:
 - lib/reek/smells/uncommunicative_name.rb
 - lib/reek/smells/utility_function.rb
 - lib/reek/sniffer.rb
-- lib/reek/source.rb
-- lib/reek/spec.rb
 - lib/reek/stop_context.rb
 - lib/reek/yield_call_context.rb
 - reek.gemspec
+- spec/quality/reek_source_spec.rb
+- spec/reek/adapters/report_spec.rb
+- spec/reek/adapters/should_reek_of_spec.rb
+- spec/reek/adapters/should_reek_only_of_spec.rb
+- spec/reek/adapters/should_reek_spec.rb
 - spec/reek/block_context_spec.rb
 - spec/reek/class_context_spec.rb
 - spec/reek/code_context_spec.rb
@@ -117,11 +122,6 @@ files:
 - spec/reek/name_spec.rb
 - spec/reek/object_refs_spec.rb
 - spec/reek/object_source_spec.rb
-- spec/reek/options_spec.rb
-- spec/reek/report_spec.rb
-- spec/reek/should_reek_of_spec.rb
-- spec/reek/should_reek_only_of_spec.rb
-- spec/reek/should_reek_spec.rb
 - spec/reek/singleton_method_context_spec.rb
 - spec/reek/smell_warning_spec.rb
 - spec/reek/smells/control_couple_spec.rb
@@ -156,6 +156,8 @@ files:
 - spec/samples/mixed_results/clean_two.rb
 - spec/samples/mixed_results/dirty_one.rb
 - spec/samples/mixed_results/dirty_two.rb
+- spec/samples/not_quite_masked/dirty.rb
+- spec/samples/not_quite_masked/masked.reek
 - spec/samples/optparse.rb
 - spec/samples/redcloth.rb
 - spec/samples/three_clean_files/clean_one.rb
@@ -163,10 +165,6 @@ files:
 - spec/samples/three_clean_files/clean_two.rb
 - spec/samples/two_smelly_files/dirty_one.rb
 - spec/samples/two_smelly_files/dirty_two.rb
-- spec/slow/inline_spec.rb
-- spec/slow/optparse_spec.rb
-- spec/slow/redcloth_spec.rb
-- spec/slow/reek_source_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb
 - tasks/reek.rake

data/features/rake_task.feature

@@ -1,9 +0,0 @@
-@rake
-Feature: RakeTask
-  In order to run reek as part of my CI process
-  As a developer
-  I want to create rake tasks to run reek
-
-  Scenario: reports no smells in reek's own source code
-    When I run rake reek
-    Then it succeeds