kevinrutherford-reek 1.1.3.9 → 1.1.3.10

data/spec/reek/smells/long_parameter_list_spec.rb

@@ -1,6 +1,6 @@
 require File.dirname(__FILE__) + '/../../spec_helper.rb'
 
-require 'reek/code_parser'
+require 'reek/object_source'
 require 'reek/smells/long_parameter_list'
 require 'reek/report'
 

data/spec/reek/smells/smell_detector_spec.rb

@@ -43,7 +43,7 @@ describe SmellDetector, 'when masked' do
   end
 
   it 'reports smells as masked' do
-    rpt = Report.new
+    rpt = Report.new(Sniffer.new)
     @detector.report_on(rpt)
     rpt.length.should == 0
     rpt.num_masked_smells.should == 1

data/spec/reek/smells/uncommunicative_name_spec.rb

@@ -1,5 +1,6 @@
 require File.dirname(__FILE__) + '/../../spec_helper.rb'
 require 'ostruct'
+require 'reek/core_extras'
 require 'reek/method_context'
 require 'reek/smells/uncommunicative_name'
 
@@ -85,7 +86,7 @@ end
 describe UncommunicativeName, "several names" do
 
   it 'should report all bad names' do
-    ruby = Source.from_s('class Oof; def y(x) @z = x end end')
+    ruby = 'class Oof; def y(x) @z = x end end'.sniff
     ruby.should reek_of(:UncommunicativeName, /'x'/)
     ruby.should reek_of(:UncommunicativeName, /'y'/)
     ruby.should reek_of(:UncommunicativeName, /'@z'/)

data/spec/reek/sniffer_spec.rb

@@ -0,0 +1,10 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+include Reek
+
+describe Sniffer do
+  it 'detects smells in a file' do
+    dirty_file = Dir['spec/samples/two_smelly_files/*.rb'][0]
+    File.new(dirty_file).sniff.should be_smelly
+  end
+end

data/spec/samples/all_but_one_masked/clean_one.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/all_but_one_masked/dirty.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/all_but_one_masked/masked.reek

@@ -0,0 +1,5 @@
+---
+Duplication:
+  enabled: false
+UncommunicativeName:
+  enabled: false

data/spec/samples/clean_due_to_masking/clean_one.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/clean_due_to_masking/clean_three.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/clean_due_to_masking/clean_two.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/clean_due_to_masking/dirty_one.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/clean_due_to_masking/dirty_two.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/clean_due_to_masking/masked.reek

@@ -0,0 +1,7 @@
+---
+Duplication:
+  enabled: false
+NestedIterators:
+  enabled: false
+UncommunicativeName:
+  enabled: false

data/spec/samples/mixed_results/clean_one.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/mixed_results/clean_three.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/mixed_results/clean_two.rb

@@ -0,0 +1,6 @@
+class Clean
+  def assign
+    puts @sub.title
+    @sub.map {|para| para.name }
+  end
+end

data/spec/samples/mixed_results/dirty_one.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/mixed_results/dirty_two.rb

@@ -0,0 +1,7 @@
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/slow/inline_spec.rb

@@ -1,8 +1,12 @@
 require File.dirname(__FILE__) + '/../spec_helper.rb'
 
+require 'reek/report'
+
+include Reek
+
 describe 'sample gem source code' do
   it "reports the correct smells in inline.rb" do
-    ruby = File.new("#{SAMPLES_DIR}/inline.rb").to_source
+    ruby = File.new("#{SAMPLES_DIR}/inline.rb").sniff
     ruby.should reek_of(:ControlCouple, /Inline::C#parse_signature/, /raw/)
     ruby.should reek_of(:ControlCouple, /Module#inline/, /options/)
     ruby.should reek_of(:Duplication, /Inline::C#build/, /\(\$\?\ == 0\)/)
@@ -35,6 +39,6 @@ describe 'sample gem source code' do
     ruby.should reek_of(:UncommunicativeName, /Inline::C#module_name/, /'x'/)
     ruby.should reek_of(:UncommunicativeName, /Inline::C#parse_signature/, /'x'/)
     ruby.should reek_of(:UtilityFunction, /Inline::C#strip_comments/)
-    ruby.report.should have_at_most(32).smells
+    Report.new(ruby).length.should == 32
   end
 end

data/spec/slow/optparse_spec.rb

@@ -1,8 +1,12 @@
 require File.dirname(__FILE__) + '/../spec_helper.rb'
 
+require 'reek/report'
+
+include Reek
+
 describe 'sample gem source code' do
   it "reports the correct smells in optparse.rb" do
-    ruby = File.new("#{SAMPLES_DIR}/optparse.rb").to_source
+    ruby = File.new("#{SAMPLES_DIR}/optparse.rb").sniff
     ruby.should reek_of(:ControlCouple, /OptionParser#List#accept/, /pat/)
     ruby.should reek_of(:ControlCouple, /OptionParser#List#update/, /lopts/)
     ruby.should reek_of(:ControlCouple, /OptionParser#List#update/, /sopts/)
@@ -103,6 +107,6 @@ describe 'sample gem source code' do
     ruby.should reek_of(:UncommunicativeName, /OptionParser#summarize/, /'l'/)
     ruby.should reek_of(:UncommunicativeName, /OptionParser#ver/, /'v'/)
     ruby.should reek_of(:UncommunicativeName, /block/, /'q'/)
-    ruby.report.should have_at_most(117).smells
+    Report.new(ruby).length.should == 117
   end
 end

data/spec/slow/redcloth_spec.rb

@@ -1,8 +1,12 @@
 require File.dirname(__FILE__) + '/../spec_helper.rb'
 
+require 'reek/report'
+
+include Reek
+
 describe 'sample gem source code' do
   it "reports the correct smells in redcloth.rb" do
-    ruby = File.new("#{SAMPLES_DIR}/redcloth.rb").to_source
+    ruby = File.new("#{SAMPLES_DIR}/redcloth.rb").sniff
     ruby.should reek_of(:ControlCouple, /RedCloth#blocks\/block/, /deep_code/)
     ruby.should reek_of(:ControlCouple, /RedCloth#check_refs/, /text/)
     ruby.should reek_of(:ControlCouple, /RedCloth#pba/, /text_in/)
@@ -96,6 +100,6 @@ describe 'sample gem source code' do
     ruby.should reek_of(:UtilityFunction, /RedCloth#incoming_entities/)
     ruby.should reek_of(:UtilityFunction, /RedCloth#no_textile/)
     ruby.should reek_of(:UtilityFunction, /RedCloth#v_align/)
-    ruby.report.should have_at_most(93).smells
+    Report.new(ruby).length.should == 93
   end
 end

data/tasks/test.rake

@@ -35,6 +35,8 @@ namespace 'test' do
   task 'all' => ['test:spec', 'test:slow', 'test:features']
 end
 
+task 'clobber_rcov' => 'test:clobber_rcov'
+
 desc 'synonym for test:spec'
 task 'spec' => 'test:spec'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: kevinrutherford-reek
 version: !ruby/object:Gem::Version 
-  version: 1.1.3.9
+  version: 1.1.3.10
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-07-06 00:00:00 -07:00
+date: 2009-07-15 00:00:00 -07:00
 default_executable: reek
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -51,9 +51,11 @@ extensions: []
 
 extra_rdoc_files: 
 - History.txt
+- License.txt
 - README.txt
 files: 
 - History.txt
+- License.txt
 - README.txt
 - Rakefile
 - bin/reek
@@ -72,6 +74,7 @@ files:
 - lib/reek/code_context.rb
 - lib/reek/code_parser.rb
 - lib/reek/config_file.rb
+- lib/reek/core_extras.rb
 - lib/reek/detector_stack.rb
 - lib/reek/exceptions.reek
 - lib/reek/if_context.rb
@@ -116,6 +119,9 @@ files:
 - spec/reek/object_source_spec.rb
 - spec/reek/options_spec.rb
 - spec/reek/report_spec.rb
+- spec/reek/should_reek_of_spec.rb
+- spec/reek/should_reek_only_of_spec.rb
+- spec/reek/should_reek_spec.rb
 - spec/reek/singleton_method_context_spec.rb
 - spec/reek/smell_warning_spec.rb
 - spec/reek/smells/control_couple_spec.rb
@@ -128,7 +134,16 @@ files:
 - spec/reek/smells/smell_detector_spec.rb
 - spec/reek/smells/uncommunicative_name_spec.rb
 - spec/reek/smells/utility_function_spec.rb
-- spec/reek/spec_spec.rb
+- spec/reek/sniffer_spec.rb
+- spec/samples/all_but_one_masked/clean_one.rb
+- spec/samples/all_but_one_masked/dirty.rb
+- spec/samples/all_but_one_masked/masked.reek
+- spec/samples/clean_due_to_masking/clean_one.rb
+- spec/samples/clean_due_to_masking/clean_three.rb
+- spec/samples/clean_due_to_masking/clean_two.rb
+- spec/samples/clean_due_to_masking/dirty_one.rb
+- spec/samples/clean_due_to_masking/dirty_two.rb
+- spec/samples/clean_due_to_masking/masked.reek
 - spec/samples/corrupt_config_file/corrupt.reek
 - spec/samples/corrupt_config_file/dirty.rb
 - spec/samples/empty_config_file/dirty.rb
@@ -136,6 +151,11 @@ files:
 - spec/samples/inline.rb
 - spec/samples/masked/dirty.rb
 - spec/samples/masked/masked.reek
+- spec/samples/mixed_results/clean_one.rb
+- spec/samples/mixed_results/clean_three.rb
+- spec/samples/mixed_results/clean_two.rb
+- spec/samples/mixed_results/dirty_one.rb
+- spec/samples/mixed_results/dirty_two.rb
 - spec/samples/optparse.rb
 - spec/samples/redcloth.rb
 - spec/samples/three_clean_files/clean_one.rb
@@ -147,7 +167,6 @@ files:
 - spec/slow/optparse_spec.rb
 - spec/slow/redcloth_spec.rb
 - spec/slow/reek_source_spec.rb
-- spec/slow/source_list_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb
 - tasks/reek.rake

data/spec/slow/source_list_spec.rb

@@ -1,40 +0,0 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
-
-require 'reek/source'
-
-include Reek
-
-describe SourceList, 'from_pathlist' do
-
-  describe 'with no smells in any source' do
-    before :each do
-      @src = Dir['lib/reek/*.rb'].to_source
-    end
-
-    it 'reports no smells' do
-      @src.report.length.should == 0
-    end
-
-    it 'is empty' do
-      @src.report.should be_empty
-    end
-  end
-
-  describe 'with smells in one source' do
-    before :each do
-      @src = Source.from_pathlist(["#{SAMPLES_DIR}/inline.rb", 'lib/reek.rb'])
-    end
-
-    it 'reports some smells in the samples' do
-      @src.report.should have_at_least(30).smells
-    end
-
-    it 'is smelly' do
-      @src.should be_smelly
-    end
-
-    it 'reports an UncommunicativeName' do
-      @src.report.any? {|warning| warning.report =~ /Uncommunicative Name/}.should be_true
-    end
-  end
-end