kevinrutherford-reek 1.1.3.5 → 1.1.3.6

data/History.txt

@@ -1,6 +1,7 @@
 == 1.2 (in git)
 
 === Major Changes
+* Reek's RDoc is now hosted at http://rdoc.info/projects/kevinrutherford/reek
 * Reek's output reports are now formatted differently:
 ** Reek is no longer silent about smell-free source code
 ** Output now reports on all files examined, even if they have no smells

data/Rakefile

@@ -7,7 +7,6 @@ PROJECT_NAME = 'reek'
 
 BUILD_DIR = 'build'; directory BUILD_DIR
 PKG_DIR = "#{BUILD_DIR}/pkg"; directory PKG_DIR
-RDOC_DIR = "#{BUILD_DIR}/rdoc"; directory RDOC_DIR
 
 GEM_MANIFEST = "Manifest.txt"
 VERSION_FILE = 'lib/reek.rb'

data/lib/reek.rb

@@ -1,5 +1,5 @@
 $:.unshift File.dirname(__FILE__)
 
 module Reek # :doc:
-  VERSION = '1.1.3.5'
+  VERSION = '1.1.3.6'
 end

data/lib/reek/report.rb

@@ -19,6 +19,14 @@ module Reek
       @report.each { |smell| yield smell }
     end
 
+    #
+    # Checks this report for instances of +smell_class+, and returns +true+
+    # only if one of them has a report string matching all of the +patterns+.
+    #
+    def has_smell?(smell_class, patterns)
+      @report.any? { |smell| smell.matches?(smell_class, patterns) }
+    end
+
     def <<(smell)  # :nodoc:
       @report << smell
       true
@@ -90,12 +98,16 @@ module Reek
       @sources.inject(0) {|sum, src| sum + src.report.length }
     end
 
-    def smelly_sources
-      @sources.select {|src| src.smelly? }
-    end
-
     def full_report
       @sources.map { |src| src.full_report }.join
     end
+
+    #
+    # Checks this report for instances of +smell_class+, and returns +true+
+    # only if one of them has a report string matching all of the +patterns+.
+    #
+    def has_smell?(smell_class, patterns)
+      @sources.any? { |smell| smell.has_smell?(smell_class, patterns) }
+    end
   end
-end
+end

data/lib/reek/source.rb

@@ -92,7 +92,7 @@ module Reek
     # only if one of them has a report string matching all of the +patterns+.
     #
     def has_smell?(smell_class, patterns)
-      report.any? { |smell| smell.matches?(smell_class, patterns) }
+      report.has_smell?(smell_class, patterns)
     end
 
     # Creates a formatted report of all the +Smells::SmellWarning+ objects recorded in
@@ -114,6 +114,14 @@ module Reek
       @sources = sources
     end
 
+    #
+    # Checks this source for instances of +smell_class+, and returns +true+
+    # only if one of them has a report string matching all of the +patterns+.
+    #
+    def has_smell?(smell_class, patterns=[])
+      report.has_smell?(smell_class, patterns)
+    end
+
     def smelly?
       @sources.any? {|source| source.smelly? }
     end

data/reek.gemspec

@@ -2,17 +2,17 @@
 
 Gem::Specification.new do |s|
   s.name = %q{reek}
-  s.version = "1.1.3.5"
+  s.version = "1.1.3.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Kevin Rutherford"]
-  s.date = %q{2009-06-29}
+  s.date = %q{2009-06-30}
   s.default_executable = %q{reek}
   s.description = %q{Code smell detector for Ruby}
   s.email = ["kevin@rutherford-software.com"]
   s.executables = ["reek"]
   s.extra_rdoc_files = ["History.txt", "README.txt"]
-  s.files = ["History.txt", "README.txt", "Rakefile", "bin/reek", "config/defaults.reek", "features/masking_smells.feature", "features/options.feature", "features/rake_task.feature", "features/reports.feature", "features/samples.feature", "features/stdin.feature", "features/step_definitions/reek_steps.rb", "features/support/env.rb", "lib/reek.rb", "lib/reek/block_context.rb", "lib/reek/class_context.rb", "lib/reek/code_context.rb", "lib/reek/code_parser.rb", "lib/reek/exceptions.reek", "lib/reek/if_context.rb", "lib/reek/method_context.rb", "lib/reek/module_context.rb", "lib/reek/name.rb", "lib/reek/object_refs.rb", "lib/reek/object_source.rb", "lib/reek/options.rb", "lib/reek/rake_task.rb", "lib/reek/report.rb", "lib/reek/sexp_formatter.rb", "lib/reek/singleton_method_context.rb", "lib/reek/smell_warning.rb", "lib/reek/smells/control_couple.rb", "lib/reek/smells/duplication.rb", "lib/reek/smells/feature_envy.rb", "lib/reek/smells/large_class.rb", "lib/reek/smells/long_method.rb", "lib/reek/smells/long_parameter_list.rb", "lib/reek/smells/long_yield_list.rb", "lib/reek/smells/nested_iterators.rb", "lib/reek/smells/smell_detector.rb", "lib/reek/smells/uncommunicative_name.rb", "lib/reek/smells/utility_function.rb", "lib/reek/sniffer.rb", "lib/reek/source.rb", "lib/reek/spec.rb", "lib/reek/stop_context.rb", "lib/reek/yield_call_context.rb", "reek.gemspec", "spec/reek/block_context_spec.rb", "spec/reek/class_context_spec.rb", "spec/reek/code_context_spec.rb", "spec/reek/code_parser_spec.rb", "spec/reek/config_spec.rb", "spec/reek/if_context_spec.rb", "spec/reek/method_context_spec.rb", "spec/reek/module_context_spec.rb", "spec/reek/name_spec.rb", "spec/reek/object_refs_spec.rb", "spec/reek/options_spec.rb", "spec/reek/report_spec.rb", "spec/reek/singleton_method_context_spec.rb", "spec/reek/smell_warning_spec.rb", "spec/reek/smells/control_couple_spec.rb", "spec/reek/smells/duplication_spec.rb", "spec/reek/smells/feature_envy_spec.rb", "spec/reek/smells/large_class_spec.rb", "spec/reek/smells/long_method_spec.rb", "spec/reek/smells/long_parameter_list_spec.rb", "spec/reek/smells/nested_iterators_spec.rb", "spec/reek/smells/smell_detector_spec.rb", "spec/reek/smells/uncommunicative_name_spec.rb", "spec/reek/smells/utility_function_spec.rb", "spec/samples/corrupt_config_file/corrupt.reek", "spec/samples/corrupt_config_file/dirty.rb", "spec/samples/empty_config_file/dirty.rb", "spec/samples/empty_config_file/empty.reek", "spec/samples/inline.rb", "spec/samples/masked/dirty.rb", "spec/samples/masked/masked.reek", "spec/samples/optparse.rb", "spec/samples/redcloth.rb", "spec/samples/two_smelly_files/dirty_one.rb", "spec/samples/two_smelly_files/dirty_two.rb", "spec/slow/inline_spec.rb", "spec/slow/optparse_spec.rb", "spec/slow/redcloth_spec.rb", "spec/slow/reek_source_spec.rb", "spec/slow/source_list_spec.rb", "spec/spec.opts", "spec/spec_helper.rb", "tasks/reek.rake", "tasks/rspec.rake"]
+  s.files = ["History.txt", "README.txt", "Rakefile", "bin/reek", "config/defaults.reek", "features/masking_smells.feature", "features/options.feature", "features/rake_task.feature", "features/reports.feature", "features/samples.feature", "features/stdin.feature", "features/step_definitions/reek_steps.rb", "features/support/env.rb", "lib/reek.rb", "lib/reek/block_context.rb", "lib/reek/class_context.rb", "lib/reek/code_context.rb", "lib/reek/code_parser.rb", "lib/reek/exceptions.reek", "lib/reek/if_context.rb", "lib/reek/method_context.rb", "lib/reek/module_context.rb", "lib/reek/name.rb", "lib/reek/object_refs.rb", "lib/reek/object_source.rb", "lib/reek/options.rb", "lib/reek/rake_task.rb", "lib/reek/report.rb", "lib/reek/sexp_formatter.rb", "lib/reek/singleton_method_context.rb", "lib/reek/smell_warning.rb", "lib/reek/smells/control_couple.rb", "lib/reek/smells/duplication.rb", "lib/reek/smells/feature_envy.rb", "lib/reek/smells/large_class.rb", "lib/reek/smells/long_method.rb", "lib/reek/smells/long_parameter_list.rb", "lib/reek/smells/long_yield_list.rb", "lib/reek/smells/nested_iterators.rb", "lib/reek/smells/smell_detector.rb", "lib/reek/smells/uncommunicative_name.rb", "lib/reek/smells/utility_function.rb", "lib/reek/sniffer.rb", "lib/reek/source.rb", "lib/reek/spec.rb", "lib/reek/stop_context.rb", "lib/reek/yield_call_context.rb", "reek.gemspec", "spec/reek/block_context_spec.rb", "spec/reek/class_context_spec.rb", "spec/reek/code_context_spec.rb", "spec/reek/code_parser_spec.rb", "spec/reek/config_spec.rb", "spec/reek/if_context_spec.rb", "spec/reek/method_context_spec.rb", "spec/reek/module_context_spec.rb", "spec/reek/name_spec.rb", "spec/reek/object_refs_spec.rb", "spec/reek/object_source_spec.rb", "spec/reek/options_spec.rb", "spec/reek/report_spec.rb", "spec/reek/singleton_method_context_spec.rb", "spec/reek/smell_warning_spec.rb", "spec/reek/smells/control_couple_spec.rb", "spec/reek/smells/duplication_spec.rb", "spec/reek/smells/feature_envy_spec.rb", "spec/reek/smells/large_class_spec.rb", "spec/reek/smells/long_method_spec.rb", "spec/reek/smells/long_parameter_list_spec.rb", "spec/reek/smells/nested_iterators_spec.rb", "spec/reek/smells/smell_detector_spec.rb", "spec/reek/smells/uncommunicative_name_spec.rb", "spec/reek/smells/utility_function_spec.rb", "spec/samples/corrupt_config_file/corrupt.reek", "spec/samples/corrupt_config_file/dirty.rb", "spec/samples/empty_config_file/dirty.rb", "spec/samples/empty_config_file/empty.reek", "spec/samples/inline.rb", "spec/samples/masked/dirty.rb", "spec/samples/masked/masked.reek", "spec/samples/optparse.rb", "spec/samples/redcloth.rb", "spec/samples/two_smelly_files/dirty_one.rb", "spec/samples/two_smelly_files/dirty_two.rb", "spec/slow/inline_spec.rb", "spec/slow/optparse_spec.rb", "spec/slow/redcloth_spec.rb", "spec/slow/reek_source_spec.rb", "spec/slow/source_list_spec.rb", "spec/spec.opts", "spec/spec_helper.rb", "tasks/reek.rake", "tasks/test.rake"]
   s.homepage = %q{http://wiki.github.com/kevinrutherford/reek}
   s.post_install_message = %q{
 For more information on reek, see http://wiki.github.com/kevinrutherford/reek

data/spec/reek/object_source_spec.rb

@@ -0,0 +1,14 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+include Reek
+
+describe Dir do
+  it 'reports correct smells via the Dir matcher' do
+    Dir['spec/samples/two_smelly_files/*.rb'].should reek_of(:UncommunicativeName)
+  end
+
+  it 'reports correct smells via SourceList' do
+    src = Dir['spec/samples/two_smelly_files/*.rb'].to_source
+    src.has_smell?(:UncommunicativeName).should be_true
+  end
+end

data/tasks/test.rake

@@ -0,0 +1,42 @@
+require 'rubygems'
+require 'cucumber'
+require 'cucumber/rake/task'
+require 'spec'
+require 'spec/rake/spectask'
+
+namespace 'test' do
+  FAST = FileList['spec/reek/**/*_spec.rb']
+  SLOW = FileList['spec/slow/**/*_spec.rb']
+
+  Spec::Rake::SpecTask.new('spec') do |t|
+    t.spec_files = FAST
+    t.ruby_opts = ['-Ilib']
+    t.rcov = false
+  end
+
+  Spec::Rake::SpecTask.new('slow') do |t|
+    t.spec_files = SLOW
+    t.ruby_opts = ['-Ilib']
+    t.rcov = false
+  end
+
+  desc 'Runs all unit tests under RCov'
+  Spec::Rake::SpecTask.new('rcov') do |t|
+    t.spec_files = FAST + SLOW
+    t.rcov = true
+    t.rcov_dir = 'build/coverage'
+  end
+
+  Cucumber::Rake::Task.new(:features) do |t|
+    t.cucumber_opts = "features --format progress --no-color"
+  end
+
+  desc 'Runs all unit tests and acceptance tests'
+  task 'all' => ['test:spec', 'test:slow', 'test:features']
+end
+
+desc 'synonym for test:spec'
+task 'spec' => 'test:spec'
+
+desc 'synonym for test:all'
+task 'test' => 'test:all'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: kevinrutherford-reek
 version: !ruby/object:Gem::Version 
-  version: 1.1.3.5
+  version: 1.1.3.6
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-29 00:00:00 -07:00
+date: 2009-06-30 00:00:00 -07:00
 default_executable: reek
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -111,6 +111,7 @@ files:
 - spec/reek/module_context_spec.rb
 - spec/reek/name_spec.rb
 - spec/reek/object_refs_spec.rb
+- spec/reek/object_source_spec.rb
 - spec/reek/options_spec.rb
 - spec/reek/report_spec.rb
 - spec/reek/singleton_method_context_spec.rb
@@ -144,7 +145,7 @@ files:
 - spec/spec.opts
 - spec/spec_helper.rb
 - tasks/reek.rake
-- tasks/rspec.rake
+- tasks/test.rake
 has_rdoc: false
 homepage: http://wiki.github.com/kevinrutherford/reek
 post_install_message: |

data/tasks/rspec.rake

@@ -1,22 +0,0 @@
-require 'spec'
-require 'spec/rake/spectask'
-
-namespace 'rspec' do
-  FAST = FileList['spec/reek/**/*_spec.rb']
-  SLOW = FileList['spec/slow/**/*_spec.rb']
-
-  Spec::Rake::SpecTask.new('fast') do |t|
-    t.spec_files = FAST
-    t.ruby_opts = ['-Ilib']
-    t.rcov = false
-  end
-
-  Spec::Rake::SpecTask.new('all') do |t|
-    t.spec_files = FAST + SLOW
-    t.rcov = true
-    t.rcov_dir = 'build/coverage'
-  end
-end
-
-desc 'runs the unit tests'
-task 'spec' => 'rspec:fast'