kevinrutherford-reek 1.1.3.14 → 1.1.3.15

data/History.txt

@@ -2,6 +2,8 @@
 
 === Major Changes
 * Reek passes all its tests under ruby 1.8.6, 1.8.7 and 1.9.1 (fixed #16)
+* New smell -- Data Clump:
+** Looks within a class for 3 or more methods taking the same 2 or more parameters
 * New smell -- Simulated Polymorphism:
 ** Currently only performs basic check for multiple tests of same value
 * Reek's output reports are now formatted differently:

data/config/defaults.reek

@@ -48,6 +48,12 @@ SimulatedPolymorphism:
 
   enabled: true
   max_ifs: 2
+DataClump: 
+  exclude: []
+
+  enabled: true
+  max_copies: 2
+  min_clump_size: 2
 ControlCouple: 
   exclude: 
   - initialize

data/features/samples.feature

@@ -9,8 +9,9 @@ Feature: Basic smell detection
     Then it fails with exit status 2
     And it reports:
     """
-    spec/samples/inline.rb -- 35 warnings (+1 masked):
+    spec/samples/inline.rb -- 36 warnings (+1 masked):
       Inline::C has at least 13 instance variables (Large Class)
+      Inline::C takes parameters [options, src] to 5 methods (Data Clump)
       Inline::C tests $DEBUG at least 7 times (Simulated Polymorphism)
       Inline::C tests $TESTING at least 4 times (Simulated Polymorphism)
       Inline::C tests @@type_map.has_key?(type) at least 3 times (Simulated Polymorphism)
@@ -183,8 +184,9 @@ Feature: Basic smell detection
     Then it fails with exit status 2
     And it reports:
     """
-    spec/samples/redcloth.rb -- 99 warnings:
+    spec/samples/redcloth.rb -- 100 warnings:
       RedCloth has at least 44 methods (Large Class)
+      RedCloth takes parameters [atts, cite, content, tag] to 3 methods (Data Clump)
       RedCloth tests atts at least 6 times (Simulated Polymorphism)
       RedCloth tests codepre.zero? at least 3 times (Simulated Polymorphism)
       RedCloth tests href at least 3 times (Simulated Polymorphism)

data/lib/reek/class_context.rb

@@ -24,7 +24,7 @@ module Reek
       CodeParser.new(sniffer).process_class(source.syntax_tree)
     end
 
-    attr_reader :conditionals
+    attr_reader :conditionals, :parsed_methods
 
     # SMELL: inconsistent with other contexts (not linked to the sexp)
     def initialize(outer, name, superclass = nil)
@@ -62,8 +62,8 @@ module Reek
       @instance_variables << Name.new(sym)
     end
 
-    def record_method(name)
-      @parsed_methods << name.to_s
+    def record_method(meth)
+      @parsed_methods << meth
     end
 
     def outer_name
@@ -81,5 +81,9 @@ module Reek
     def record_conditional(exp)
       @conditionals << exp
     end
+
+    def parameterized_methods(min_clump_size)
+      parsed_methods.select {|meth| meth.parameters.length >= min_clump_size }
+    end
   end
 end

data/lib/reek/code_parser.rb

@@ -74,9 +74,7 @@ module Reek
       handle_context(SingletonMethodContext, :defs, exp)
     end
 
-    def process_args(exp)
-      exp[1..-1].each {|sym| @element.record_parameter(sym) }
-    end
+    def process_args(exp) end
 
     def process_attrset(exp)
       @element.record_depends_on_self if /^@/ === exp[1].to_s
@@ -95,11 +93,6 @@ module Reek
       process(exp[1])
       handle_context(BlockContext, :iter, exp[2..-1])
     end
-    
-    def process_dasgn_curr(exp)
-      @element.record_parameter(exp[1])
-      process_default(exp)
-    end
 
     def process_block(exp)
       @element.count_statements(CodeParser.count_statements(exp))

data/lib/reek/method_context.rb

@@ -2,7 +2,55 @@ require 'reek/name'
 require 'reek/code_context'
 require 'reek/object_refs'
 
+class Array
+  def power_set
+    self.inject([[]]) { |cum, element| cum.cross(element) }
+  end
+
+  def bounded_power_set(lower_bound)
+    power_set.select {|ps| ps.length > lower_bound}
+  end
+
+  def cross(element)
+    result = []
+    self.each do |set|
+      result << set
+      result << (set + [element])
+    end
+    result
+  end
+
+  def intersection
+    self.inject { |res, elem| elem & res }
+  end
+end
+
 module Reek
+
+  module MethodParameters
+    def self.is_arg?(param)
+      return false if (Array === param and param[0] == :block)
+      return !(param.to_s =~ /^\&/)
+    end
+
+    def names
+      return @names if @names
+      @names = self[1..-1].select {|arg| MethodParameters.is_arg?(arg)}.map {|arg| Name.new(arg)}
+    end
+
+    def length
+      names.length
+    end
+
+    def include?(name)
+      names.include?(name)
+    end
+
+    def to_s
+      "[#{names.map{|nm| nm.to_s}.join(', ')}]"
+    end
+  end
+
   class MethodContext < CodeContext
     attr_reader :parameters
     attr_reader :calls
@@ -11,14 +59,16 @@ module Reek
 
     def initialize(outer, exp, record = true)
       super(outer, exp)
-      @parameters = []
+      @parameters = exp[exp[0] == :defn ? 2 : 3]  # SMELL: SimulatedPolymorphism
+      @parameters ||= []
+      @parameters.extend(MethodParameters)
       @local_variables = []
       @name = Name.new(exp[1])
       @num_statements = 0
       @calls = Hash.new(0)
       @depends_on_self = false
       @refs = ObjectRefs.new
-      @outer.record_method(@name)    # TODO: should be children of outer?
+      @outer.record_method(self)
     end
 
     def count_statements(num)
@@ -63,14 +113,6 @@ module Reek
       @local_variables << Name.new(sym)
     end
 
-    def self.is_block_arg?(param)
-      (Array === param and param[0] == :block) or (param.to_s =~ /^\&/)
-    end
-
-    def record_parameter(param)
-      @parameters << Name.new(param) unless MethodContext.is_block_arg?(param)
-    end
-
     def outer_name
       "#{@outer.outer_name}#{@name}/"
     end
@@ -85,7 +127,7 @@ module Reek
     end
 
     def variable_names
-      @parameters + @local_variables
+      @parameters.names + @local_variables
     end
   end
 end

data/lib/reek/name.rb

@@ -32,16 +32,22 @@ module Reek
       @name.hash
     end
 
+    def eql?(other)
+      self == other
+    end
+
     def <=>(other)  # :nodoc:
       @name <=> other.to_s
     end
 
-    alias eql? <=>
-
     def effective_name
       @name.gsub(/^@*/, '')
     end
 
+    def inspect
+      @name.inspect
+    end
+
     def to_s
       @name
     end

data/lib/reek/smells/data_clump.rb

@@ -0,0 +1,88 @@
+require 'reek/smells/smell_detector'
+require 'reek/smell_warning'
+require 'reek/sexp_formatter'
+
+module Reek
+  module Smells
+
+    #
+    # A Data Clump occurs when the same two or three items frequently
+    # appear together in classes and parameter lists, or when a group
+    # of instance variable names start or end with similar substrings.
+    #
+    # The recurrence of the items often means there is duplicate code
+    # spread around to handle them. There may be an abstraction missing
+    # from the code, making the system harder to understand.
+    #
+    # Currently Reek looks for a group of two or more parameters with
+    # the same names that are expected by three or more methods of a class.
+    #
+    class DataClump < SmellDetector
+
+      def self.contexts      # :nodoc:
+        [:class]
+      end
+
+      # The name of the config field that sets the maximum allowed
+      # copies of any clump.
+      MAX_COPIES_KEY = 'max_copies'
+
+      DEFAULT_MAX_COPIES = 2
+
+      MIN_CLUMP_SIZE_KEY = 'min_clump_size'
+      DEFAULT_MIN_CLUMP_SIZE = 2
+
+      def self.default_config
+        super.adopt(
+          MAX_COPIES_KEY => DEFAULT_MAX_COPIES,
+          MIN_CLUMP_SIZE_KEY => DEFAULT_MIN_CLUMP_SIZE
+        )
+      end
+
+      def initialize(config = DataClump.default_config)
+        super(config)
+      end
+
+      #
+      # Checks the given ClassContext for multiple identical conditional tests.
+      # Remembers any smells found.
+      #
+      def examine_context(klass)
+        max_copies = value(MAX_COPIES_KEY, klass, DEFAULT_MAX_COPIES)
+        min_clump_size = value(MIN_CLUMP_SIZE_KEY, klass, DEFAULT_MIN_CLUMP_SIZE)
+        MethodGroup.new(klass, min_clump_size, max_copies).clumps.each do |clump, occurs|
+          found(klass, "takes parameters #{DataClump.print_clump(clump)} to #{occurs} methods")
+        end
+      end
+
+      def self.print_clump(clump)
+        "[#{clump.map {|name| name.to_s}.join(', ')}]"
+      end
+    end
+  end
+
+  # Represents a group of methods
+  class MethodGroup   # :nodoc:
+
+    def self.intersection_of_parameters_of(methods)
+      methods.map {|meth| meth.parameters.names.sort}.intersection
+    end
+
+    def initialize(klass, min_clump_size, max_copies)
+      @klass = klass
+      @min_clump_size = min_clump_size
+      @max_copies = max_copies
+    end
+
+    def clumps
+      results = Hash.new(0)
+      @klass.parameterized_methods(@min_clump_size).bounded_power_set(@max_copies).each do |methods|
+        clump = MethodGroup.intersection_of_parameters_of(methods)
+        if clump.length >= @min_clump_size
+          results[clump] = [methods.length, results[clump]].max
+        end
+      end
+      results
+    end
+  end
+end

data/lib/reek/sniffer.rb

@@ -2,6 +2,7 @@ require 'reek/detector_stack'
 
 # SMELL: Duplication -- all these should be found automagically
 require 'reek/smells/control_couple'
+require 'reek/smells/data_clump'
 require 'reek/smells/duplication'
 require 'reek/smells/feature_envy'
 require 'reek/smells/large_class'
@@ -44,27 +45,29 @@ end
 module Reek
   class Sniffer
 
-    # SMELL: Duplication
-    # This list should be calculated by looking in the source folder.
-    SMELL_CLASSES = [
-      Smells::ControlCouple,
-      Smells::Duplication,
-      Smells::FeatureEnvy,
-      Smells::LargeClass,
-      Smells::LongMethod,
-      Smells::LongParameterList,
-      Smells::LongYieldList,
-      Smells::NestedIterators,
-      Smells::SimulatedPolymorphism,
-      Smells::UncommunicativeName,
-      Smells::UtilityFunction,
-    ]
+    def self.smell_classes
+      # SMELL: Duplication -- these should be loaded by listing the files
+      [
+        Smells::ControlCouple,
+        Smells::DataClump,
+        Smells::Duplication,
+        Smells::FeatureEnvy,
+        Smells::LargeClass,
+        Smells::LongMethod,
+        Smells::LongParameterList,
+        Smells::LongYieldList,
+        Smells::NestedIterators,
+        Smells::SimulatedPolymorphism,
+        Smells::UncommunicativeName,
+        Smells::UtilityFunction,
+      ]
+    end
 
     def initialize(src)
       @already_checked_for_smells = false
       @typed_detectors = nil
       @detectors = Hash.new
-      SMELL_CLASSES.each { |klass| @detectors[klass] = DetectorStack.new(klass.new) }
+      Sniffer.smell_classes.each { |klass| @detectors[klass] = DetectorStack.new(klass.new) }
       @source = src
       src.configure(self)
     end

data/lib/reek.rb

@@ -1,5 +1,5 @@
 $:.unshift File.dirname(__FILE__)
 
 module Reek # :doc:
-  VERSION = '1.1.3.14'
+  VERSION = '1.1.3.15'
 end

data/reek.gemspec

@@ -2,17 +2,17 @@
 
 Gem::Specification.new do |s|
   s.name = %q{reek}
-  s.version = "1.1.3.14"
+  s.version = "1.1.3.15"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Kevin Rutherford"]
-  s.date = %q{2009-08-20}
+  s.date = %q{2009-09-03}
   s.default_executable = %q{reek}
   s.description = %q{Code smell detector for Ruby}
   s.email = ["kevin@rutherford-software.com"]
   s.executables = ["reek"]
   s.extra_rdoc_files = ["History.txt", "License.txt", "README.txt"]
-  s.files = ["History.txt", "License.txt", "README.txt", "Rakefile", "bin/reek", "config/defaults.reek", "features/masking_smells.feature", "features/options.feature", "features/reports.feature", "features/samples.feature", "features/stdin.feature", "features/step_definitions/reek_steps.rb", "features/support/env.rb", "lib/reek.rb", "lib/reek/adapters/application.rb", "lib/reek/adapters/config_file.rb", "lib/reek/adapters/core_extras.rb", "lib/reek/adapters/object_source.rb", "lib/reek/adapters/rake_task.rb", "lib/reek/adapters/report.rb", "lib/reek/adapters/source.rb", "lib/reek/adapters/spec.rb", "lib/reek/block_context.rb", "lib/reek/class_context.rb", "lib/reek/code_context.rb", "lib/reek/code_parser.rb", "lib/reek/command_line.rb", "lib/reek/configuration.rb", "lib/reek/detector_stack.rb", "lib/reek/exceptions.reek", "lib/reek/if_context.rb", "lib/reek/method_context.rb", "lib/reek/module_context.rb", "lib/reek/name.rb", "lib/reek/object_refs.rb", "lib/reek/sexp_formatter.rb", "lib/reek/singleton_method_context.rb", "lib/reek/smell_warning.rb", "lib/reek/smells/control_couple.rb", "lib/reek/smells/duplication.rb", "lib/reek/smells/feature_envy.rb", "lib/reek/smells/large_class.rb", "lib/reek/smells/long_method.rb", "lib/reek/smells/long_parameter_list.rb", "lib/reek/smells/long_yield_list.rb", "lib/reek/smells/nested_iterators.rb", "lib/reek/smells/simulated_polymorphism.rb", "lib/reek/smells/smell_detector.rb", "lib/reek/smells/uncommunicative_name.rb", "lib/reek/smells/utility_function.rb", "lib/reek/sniffer.rb", "lib/reek/stop_context.rb", "lib/reek/yield_call_context.rb", "reek.gemspec", "spec/quality/reek_source_spec.rb", "spec/reek/adapters/report_spec.rb", "spec/reek/adapters/should_reek_of_spec.rb", "spec/reek/adapters/should_reek_only_of_spec.rb", "spec/reek/adapters/should_reek_spec.rb", "spec/reek/block_context_spec.rb", "spec/reek/class_context_spec.rb", "spec/reek/code_context_spec.rb", "spec/reek/code_parser_spec.rb", "spec/reek/config_spec.rb", "spec/reek/configuration_spec.rb", "spec/reek/if_context_spec.rb", "spec/reek/method_context_spec.rb", "spec/reek/module_context_spec.rb", "spec/reek/name_spec.rb", "spec/reek/object_refs_spec.rb", "spec/reek/object_source_spec.rb", "spec/reek/singleton_method_context_spec.rb", "spec/reek/smell_warning_spec.rb", "spec/reek/smells/control_couple_spec.rb", "spec/reek/smells/duplication_spec.rb", "spec/reek/smells/feature_envy_spec.rb", "spec/reek/smells/large_class_spec.rb", "spec/reek/smells/long_method_spec.rb", "spec/reek/smells/long_parameter_list_spec.rb", "spec/reek/smells/nested_iterators_spec.rb", "spec/reek/smells/simulated_polymorphism_spec.rb", "spec/reek/smells/smell_detector_spec.rb", "spec/reek/smells/uncommunicative_name_spec.rb", "spec/reek/smells/utility_function_spec.rb", "spec/reek/sniffer_spec.rb", "spec/samples/all_but_one_masked/clean_one.rb", "spec/samples/all_but_one_masked/dirty.rb", "spec/samples/all_but_one_masked/masked.reek", "spec/samples/clean_due_to_masking/clean_one.rb", "spec/samples/clean_due_to_masking/clean_three.rb", "spec/samples/clean_due_to_masking/clean_two.rb", "spec/samples/clean_due_to_masking/dirty_one.rb", "spec/samples/clean_due_to_masking/dirty_two.rb", "spec/samples/clean_due_to_masking/masked.reek", "spec/samples/corrupt_config_file/corrupt.reek", "spec/samples/corrupt_config_file/dirty.rb", "spec/samples/empty_config_file/dirty.rb", "spec/samples/empty_config_file/empty.reek", "spec/samples/exceptions.reek", "spec/samples/inline.rb", "spec/samples/masked/dirty.rb", "spec/samples/masked/masked.reek", "spec/samples/mixed_results/clean_one.rb", "spec/samples/mixed_results/clean_three.rb", "spec/samples/mixed_results/clean_two.rb", "spec/samples/mixed_results/dirty_one.rb", "spec/samples/mixed_results/dirty_two.rb", "spec/samples/not_quite_masked/dirty.rb", "spec/samples/not_quite_masked/masked.reek", "spec/samples/optparse.rb", "spec/samples/overrides/masked/dirty.rb", "spec/samples/overrides/masked/lower.reek", "spec/samples/overrides/upper.reek", "spec/samples/redcloth.rb", "spec/samples/three_clean_files/clean_one.rb", "spec/samples/three_clean_files/clean_three.rb", "spec/samples/three_clean_files/clean_two.rb", "spec/samples/two_smelly_files/dirty_one.rb", "spec/samples/two_smelly_files/dirty_two.rb", "spec/spec.opts", "spec/spec_helper.rb", "tasks/reek.rake", "tasks/test.rake"]
+  s.files = ["History.txt", "License.txt", "README.txt", "Rakefile", "bin/reek", "config/defaults.reek", "features/masking_smells.feature", "features/options.feature", "features/reports.feature", "features/samples.feature", "features/stdin.feature", "features/step_definitions/reek_steps.rb", "features/support/env.rb", "lib/reek.rb", "lib/reek/adapters/application.rb", "lib/reek/adapters/config_file.rb", "lib/reek/adapters/core_extras.rb", "lib/reek/adapters/object_source.rb", "lib/reek/adapters/rake_task.rb", "lib/reek/adapters/report.rb", "lib/reek/adapters/source.rb", "lib/reek/adapters/spec.rb", "lib/reek/block_context.rb", "lib/reek/class_context.rb", "lib/reek/code_context.rb", "lib/reek/code_parser.rb", "lib/reek/command_line.rb", "lib/reek/configuration.rb", "lib/reek/detector_stack.rb", "lib/reek/exceptions.reek", "lib/reek/if_context.rb", "lib/reek/method_context.rb", "lib/reek/module_context.rb", "lib/reek/name.rb", "lib/reek/object_refs.rb", "lib/reek/sexp_formatter.rb", "lib/reek/singleton_method_context.rb", "lib/reek/smell_warning.rb", "lib/reek/smells/control_couple.rb", "lib/reek/smells/data_clump.rb", "lib/reek/smells/duplication.rb", "lib/reek/smells/feature_envy.rb", "lib/reek/smells/large_class.rb", "lib/reek/smells/long_method.rb", "lib/reek/smells/long_parameter_list.rb", "lib/reek/smells/long_yield_list.rb", "lib/reek/smells/nested_iterators.rb", "lib/reek/smells/simulated_polymorphism.rb", "lib/reek/smells/smell_detector.rb", "lib/reek/smells/uncommunicative_name.rb", "lib/reek/smells/utility_function.rb", "lib/reek/sniffer.rb", "lib/reek/stop_context.rb", "lib/reek/yield_call_context.rb", "reek.gemspec", "spec/quality/reek_source_spec.rb", "spec/reek/adapters/report_spec.rb", "spec/reek/adapters/should_reek_of_spec.rb", "spec/reek/adapters/should_reek_only_of_spec.rb", "spec/reek/adapters/should_reek_spec.rb", "spec/reek/block_context_spec.rb", "spec/reek/class_context_spec.rb", "spec/reek/code_context_spec.rb", "spec/reek/code_parser_spec.rb", "spec/reek/config_spec.rb", "spec/reek/configuration_spec.rb", "spec/reek/if_context_spec.rb", "spec/reek/method_context_spec.rb", "spec/reek/module_context_spec.rb", "spec/reek/name_spec.rb", "spec/reek/object_refs_spec.rb", "spec/reek/object_source_spec.rb", "spec/reek/singleton_method_context_spec.rb", "spec/reek/smell_warning_spec.rb", "spec/reek/smells/control_couple_spec.rb", "spec/reek/smells/data_clump_spec.rb", "spec/reek/smells/duplication_spec.rb", "spec/reek/smells/feature_envy_spec.rb", "spec/reek/smells/large_class_spec.rb", "spec/reek/smells/long_method_spec.rb", "spec/reek/smells/long_parameter_list_spec.rb", "spec/reek/smells/nested_iterators_spec.rb", "spec/reek/smells/simulated_polymorphism_spec.rb", "spec/reek/smells/smell_detector_spec.rb", "spec/reek/smells/uncommunicative_name_spec.rb", "spec/reek/smells/utility_function_spec.rb", "spec/reek/sniffer_spec.rb", "spec/samples/all_but_one_masked/clean_one.rb", "spec/samples/all_but_one_masked/dirty.rb", "spec/samples/all_but_one_masked/masked.reek", "spec/samples/clean_due_to_masking/clean_one.rb", "spec/samples/clean_due_to_masking/clean_three.rb", "spec/samples/clean_due_to_masking/clean_two.rb", "spec/samples/clean_due_to_masking/dirty_one.rb", "spec/samples/clean_due_to_masking/dirty_two.rb", "spec/samples/clean_due_to_masking/masked.reek", "spec/samples/corrupt_config_file/corrupt.reek", "spec/samples/corrupt_config_file/dirty.rb", "spec/samples/empty_config_file/dirty.rb", "spec/samples/empty_config_file/empty.reek", "spec/samples/exceptions.reek", "spec/samples/inline.rb", "spec/samples/masked/dirty.rb", "spec/samples/masked/masked.reek", "spec/samples/mixed_results/clean_one.rb", "spec/samples/mixed_results/clean_three.rb", "spec/samples/mixed_results/clean_two.rb", "spec/samples/mixed_results/dirty_one.rb", "spec/samples/mixed_results/dirty_two.rb", "spec/samples/not_quite_masked/dirty.rb", "spec/samples/not_quite_masked/masked.reek", "spec/samples/optparse.rb", "spec/samples/overrides/masked/dirty.rb", "spec/samples/overrides/masked/lower.reek", "spec/samples/overrides/upper.reek", "spec/samples/redcloth.rb", "spec/samples/three_clean_files/clean_one.rb", "spec/samples/three_clean_files/clean_three.rb", "spec/samples/three_clean_files/clean_two.rb", "spec/samples/two_smelly_files/dirty_one.rb", "spec/samples/two_smelly_files/dirty_two.rb", "spec/spec.opts", "spec/spec_helper.rb", "tasks/reek.rake", "tasks/test.rake"]
   s.homepage = %q{http://wiki.github.com/kevinrutherford/reek}
   s.post_install_message = %q{
 For more information on reek, see http://wiki.github.com/kevinrutherford/reek

data/spec/reek/block_context_spec.rb

@@ -27,7 +27,7 @@ describe BlockContext do
   end
 
   it "should not pass parameters upward" do
-    mc = MethodContext.new(StopContext.new, s(:defn, :help))
+    mc = MethodContext.new(StopContext.new, s(:defn, :help, s(:args)))
     element = BlockContext.new(mc, s(s(:lasgn, :x)))
     mc.variable_names.should be_empty
   end

data/spec/reek/name_spec.rb

@@ -11,3 +11,27 @@ describe Name, 'resolving symbols' do
     res[1].should == "LargeClass"
   end
 end
+
+describe Name do
+  it 'compares correctly' do
+    a1 = [Name.new('conts'), Name.new('p1'), Name.new('p2'), Name.new('p3')]
+    a2 = [Name.new('name'), Name.new('windowH'), Name.new('windowW')]
+    (a1 & a2).should == []
+  end
+
+  it do
+    [Name.new(:fred)].should include(Name.new(:fred))
+  end
+
+  it do
+    set = Set.new
+    set << Name.new(:fred)
+    set.should include(Name.new(:fred))
+  end
+
+  it do
+    fred = Name.new(:fred)
+    fred.should eql(fred)
+    fred.should eql(Name.new(:fred))
+  end
+end

data/spec/reek/singleton_method_context_spec.rb

@@ -11,7 +11,7 @@ describe SingletonMethodContext, 'outer_name' do
   it "should report full context" do
     element = StopContext.new
     element = ModuleContext.new(element, Name.new(:mod))
-    element = SingletonMethodContext.new(element,  [:defs, [:call, nil, :a, [:arglist]], :b, nil])
+    element = SingletonMethodContext.new(element, s(:defs, s(:call, nil, :a, s(:arglist)), :b, s(:args)))
     element.outer_name.should match(/mod::a\.b/)
   end
 end

data/spec/reek/smells/data_clump_spec.rb

@@ -0,0 +1,87 @@
+require File.dirname(__FILE__) + '/../../spec_helper.rb'
+
+require 'reek/smells/data_clump'
+
+include Reek::Smells
+
+describe DataClump do
+  it 'should not report small parameter sets' do
+    src = <<EOS
+class Scrunch
+  def first(pa) @field == :sym ? 0 : 3; end
+  def second(pa) @field == :sym; end
+  def third(pa) pa - pb + @fred; end
+end
+EOS
+
+    src.should_not reek
+  end
+
+  it 'should report 3 identical pairs in a class' do
+    src = <<EOS
+class Scrunch
+  def first(pa, pb) @field == :sym ? 0 : 3; end
+  def second(pa, pb) @field == :sym; end
+  def third(pa, pb) pa - pb + @fred; end
+end
+EOS
+
+    src.should reek_of(:DataClump, /\[pa, pb\]/, /3 methods/)
+  end
+
+  it 'should report 3 swapped pairs in a class' do
+    src = <<EOS
+class Scrunch
+  def one(pa, pb) @field == :sym ? 0 : 3; end
+  def two(pb, pa) @field == :sym; end
+  def tri(pa, pb) pa - pb + @fred; end
+end
+EOS
+
+    src.should reek_of(:DataClump, /\[pa, pb\]/, /3 methods/)
+  end
+
+  it 'should report 3 identical parameter sets in a class' do
+    src = <<EOS
+class Scrunch
+  def first(pa, pb, pc) @field == :sym ? 0 : 3; end
+  def second(pa, pb, pc) @field == :sym; end
+  def third(pa, pb, pc) pa - pb + @fred; end
+end
+EOS
+
+    src.should reek_of(:DataClump, /\[pa, pb, pc\]/, /3 methods/)
+    src.should_not reek_of(:DataClump, /\[pa, pb\]/, /3 methods/)
+    src.should_not reek_of(:DataClump, /\[pa, pc\]/, /3 methods/)
+    src.should_not reek_of(:DataClump, /\[pb, pc\]/, /3 methods/)
+  end
+
+  it 'should recognise re-ordered identical parameter sets' do
+    src = <<EOS
+class Scrunch
+  def first(pb, pa, pc) @field == :sym ? 0 : 3; end
+  def second(pc, pb, pa) @field == :sym; end
+  def third(pa, pb, pc) pa - pb + @fred; end
+end
+EOS
+
+    src.should reek_of(:DataClump, /\[pa, pb, pc\]/, /3 methods/)
+    src.should_not reek_of(:DataClump, /\[pa, pb\]/, /3 methods/)
+    src.should_not reek_of(:DataClump, /\[pa, pc\]/, /3 methods/)
+    src.should_not reek_of(:DataClump, /\[pb, pc\]/, /3 methods/)
+  end
+
+  it 'should count only identical parameter sets' do
+    src = <<EOS
+class RedCloth
+  def fa(p1, p2, p3, conten) end
+  def fb(p1, p2, p3, conten) end
+  def fc(name, windowW, windowH) end
+end
+EOS
+
+    src.should_not reek_of(:DataClump)
+  end
+
+  # TODO: include singleton methods in the calcs
+end

data/spec/reek/smells/large_class_spec.rb

@@ -39,7 +39,7 @@ describe LargeClass, 'checking Class objects' do
     it 'should not report class with 10 ivars' do
       pending('test requires ParseTree') unless ObjectSource.can_parse_objects?
       class ManyIvars
-        def method
+        def meth
           @vara = @varb = @varc = @vard = @vare
           @varf = @varg = @varh = @vari = @varj
         end

data/spec/reek/smells/uncommunicative_name_spec.rb

@@ -125,12 +125,12 @@ describe UncommunicativeName, '#examine' do
   end
   
   it 'should return true when reporting a smell' do
-    mc = MethodContext.new(StopContext.new, [:defn, :x, nil])
+    mc = MethodContext.new(StopContext.new, s(:defn, :x, s(:args)))
     @uc.examine(mc).should == true
   end
   
   it 'should return false when not reporting a smell' do
-    mc = MethodContext.new(StopContext.new, [:defn, :not_bad, nil])
+    mc = MethodContext.new(StopContext.new, s(:defn, :not_bad, s(:args)))
     @uc.examine(mc).should == false
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: kevinrutherford-reek
 version: !ruby/object:Gem::Version 
-  version: 1.1.3.14
+  version: 1.1.3.15
 platform: ruby
 authors: 
 - Kevin Rutherford
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-08-20 00:00:00 -07:00
+date: 2009-09-03 00:00:00 -07:00
 default_executable: reek
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -93,6 +93,7 @@ files:
 - lib/reek/singleton_method_context.rb
 - lib/reek/smell_warning.rb
 - lib/reek/smells/control_couple.rb
+- lib/reek/smells/data_clump.rb
 - lib/reek/smells/duplication.rb
 - lib/reek/smells/feature_envy.rb
 - lib/reek/smells/large_class.rb
@@ -128,6 +129,7 @@ files:
 - spec/reek/singleton_method_context_spec.rb
 - spec/reek/smell_warning_spec.rb
 - spec/reek/smells/control_couple_spec.rb
+- spec/reek/smells/data_clump_spec.rb
 - spec/reek/smells/duplication_spec.rb
 - spec/reek/smells/feature_envy_spec.rb
 - spec/reek/smells/large_class_spec.rb
@@ -179,7 +181,6 @@ files:
 - tasks/test.rake
 has_rdoc: false
 homepage: http://wiki.github.com/kevinrutherford/reek
-licenses: 
 post_install_message: |
   
   For more information on reek, see http://wiki.github.com/kevinrutherford/reek
@@ -204,7 +205,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: reek
-rubygems_version: 1.3.5
+rubygems_version: 1.2.0
 signing_key: 
 specification_version: 3
 summary: Code smell detector for Ruby