kevinrutherford-reek 0.3.1.4

data/spec/samples/redcloth_spec.rb

@@ -0,0 +1,93 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+describe 'sample gem source code' do
+  it "reports the correct smells in redcloth.rb" do
+    ruby = File.new('spec/samples/redcloth.rb').to_source
+    ruby.should reek_of(:ControlCouple, /RedCloth#blocks\/block/, /deep_code/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#check_refs/, /text/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#pba/, /text_in/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_bq/, /atts/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_bq/, /cite/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_fn_/, /atts/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_p/, /atts/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth.last/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth.last.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth\[i\]/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /line_id.-\(1\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /lines\[line_id.-\(1\)\]/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /tl.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#clean_html/, /tags\[tag\]/)
+    ruby.should reek_of(:Duplication, /RedCloth#pba/, /\$1.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /@pre_list.last/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /@pre_list.last.<<\(line\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /codepre.-\(used_offtags.length\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /codepre.-\(used_offtags.length\).>\(0\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /codepre.zero?/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /used_offtags.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /used_offtags\[notextile\]/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#clean_html/, /tags/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#clean_white_space/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#flush_left/, /indt/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#flush_left/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#htmlesc/, /str/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#no_textile/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#pba/, /style/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#pba/, /text/)
+    ruby.should reek_of(:LargeClass, /RedCloth/)
+    ruby.should reek_of(:LongMethod, /RedCloth#block_markdown_bq/)
+    ruby.should reek_of(:LongMethod, /RedCloth#block_textile_lists/)
+    ruby.should reek_of(:LongMethod, /RedCloth#block_textile_table/)
+    ruby.should reek_of(:LongMethod, /RedCloth#blocks/)
+    ruby.should reek_of(:LongMethod, /RedCloth#clean_html/)
+    ruby.should reek_of(:LongMethod, /RedCloth#clean_white_space/)
+    ruby.should reek_of(:LongMethod, /RedCloth#glyphs_textile/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_markdown_link/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_markdown_reflink/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_textile_image/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_textile_link/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_textile_span/)
+    ruby.should reek_of(:LongMethod, /RedCloth#pba/)
+    ruby.should reek_of(:LongMethod, /RedCloth#rip_offtags/)
+    ruby.should reek_of(:LongMethod, /RedCloth#to_html/)
+    ruby.should reek_of(:LongParameterList, /RedCloth#textile_bq/)
+    ruby.should reek_of(:LongParameterList, /RedCloth#textile_fn_/)
+    ruby.should reek_of(:LongParameterList, /RedCloth#textile_p/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_lists/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_lists/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_table/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_table/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#blocks/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#clean_html/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#clean_html/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#inline/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#inline_textile_span/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block/, /'a'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block/, /'b'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block_textile_lists/, /'i'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block_textile_lists/, /'v'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block_textile_table/, /'x'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#clean_html/, /'q'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#clean_html/, /'q2'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#initialize/, /'r'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_markdown_link/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_markdown_reflink/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_code/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_image/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_link/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_span/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#refs_markdown/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#refs_textile/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#retrieve/, /'i'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#retrieve/, /'r'/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#block_markdown_rule/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#clean_html/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#flush_left/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#footnote_ref/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#h_align/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#htmlesc/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#incoming_entities/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#no_textile/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#v_align/)
+    ruby.report.length.should == 85
+  end
+end

data/spec/spec.opts

@@ -0,0 +1 @@
+--colour

data/spec/spec_helper.rb

@@ -0,0 +1,15 @@
+$:.unshift File.dirname(__FILE__) + '/../lib'
+
+begin
+  require 'spec'
+rescue LoadError
+  require 'rubygems'
+  gem 'rspec'
+  require 'spec'
+end
+
+require 'reek/spec'
+
+Spec::Runner.configure do |config|
+  config.include(Reek::Spec)
+end

data/tasks/reek.rake

@@ -0,0 +1,20 @@
+require 'reek/rake_task'
+
+Reek::RakeTask.new do |t|
+  t.fail_on_error = true
+  t.verbose = false
+#  t.reek_opts = '-f "Smell: %s: %c %w"'
+end
+
+begin
+  require 'flay'
+
+  desc 'Check for code duplication'
+  task 'flay' do
+    files = FileList['lib/**/*.rb']
+    flayer = Flay.new(16)
+    flayer.process(*files)
+    flayer.report
+  end
+rescue LoadError
+end

data/tasks/rspec.rake

@@ -0,0 +1,22 @@
+require 'rake/clean'
+require 'spec'
+require 'spec/rake/spectask'
+
+namespace 'rspec' do
+  FAST = FileList['spec/reek/**/*_spec.rb']
+  SLOW = FileList['spec/integration/**/*_spec.rb'] + FileList['spec/samples/**/*_spec.rb']
+
+  Spec::Rake::SpecTask.new('fast') do |t|
+    t.spec_files = FAST
+    t.ruby_opts = ['-Ilib']
+    t.rcov = false
+  end
+
+  Spec::Rake::SpecTask.new('all') do |t|
+    t.spec_files = FAST + SLOW
+    t.rcov = false
+  end
+end
+
+desc 'runs the unit tests'
+task 'spec' => 'rspec:fast'

metadata

@@ -0,0 +1,167 @@
+--- !ruby/object:Gem::Specification 
+name: kevinrutherford-reek
+version: !ruby/object:Gem::Version 
+  version: 0.3.1.4
+platform: ruby
+authors: 
+- Kevin Rutherford
+autorequire: 
+bindir: bin
+cert_chain: []
+
+date: 2009-03-31 00:00:00 -07:00
+default_executable: reek
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: ParseTree
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: "3.0"
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: sexp_processor
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: "3.0"
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: newgem
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 1.3.0
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: hoe
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 1.8.0
+    version: 
+description: ""
+email: 
+- kevin@rutherford-software.com
+executables: 
+- reek
+extensions: []
+
+extra_rdoc_files: 
+- History.txt
+- README.txt
+files: 
+- History.txt
+- README.txt
+- Rakefile
+- bin/reek
+- config/defaults.reek
+- lib/reek.rb
+- lib/reek/block_context.rb
+- lib/reek/class_context.rb
+- lib/reek/code_context.rb
+- lib/reek/code_parser.rb
+- lib/reek/exceptions.reek
+- lib/reek/if_context.rb
+- lib/reek/method_context.rb
+- lib/reek/module_context.rb
+- lib/reek/name.rb
+- lib/reek/object_refs.rb
+- lib/reek/options.rb
+- lib/reek/rake_task.rb
+- lib/reek/report.rb
+- lib/reek/smell_warning.rb
+- lib/reek/source.rb
+- lib/reek/spec.rb
+- lib/reek/sexp_formatter.rb
+- lib/reek/singleton_method_context.rb
+- lib/reek/smells/control_couple.rb
+- lib/reek/smells/duplication.rb
+- lib/reek/smells/feature_envy.rb
+- lib/reek/smells/large_class.rb
+- lib/reek/smells/long_method.rb
+- lib/reek/smells/long_parameter_list.rb
+- lib/reek/smells/long_yield_list.rb
+- lib/reek/smells/nested_iterators.rb
+- lib/reek/smells/smell_detector.rb
+- lib/reek/smells/smells.rb
+- lib/reek/smells/uncommunicative_name.rb
+- lib/reek/smells/utility_function.rb
+- lib/reek/stop_context.rb
+- lib/reek/yield_call_context.rb
+- spec/integration/reek_source_spec.rb
+- spec/integration/script_spec.rb
+- spec/reek/class_context_spec.rb
+- spec/reek/code_context_spec.rb
+- spec/reek/code_parser_spec.rb
+- spec/reek/config_spec.rb
+- spec/reek/module_context_spec.rb
+- spec/reek/object_refs_spec.rb
+- spec/reek/options_spec.rb
+- spec/reek/report_spec.rb
+- spec/reek/sexp_formatter_spec.rb
+- spec/reek/singleton_method_context_spec.rb
+- spec/reek/smells/control_couple_spec.rb
+- spec/reek/smells/duplication_spec.rb
+- spec/reek/smells/feature_envy_spec.rb
+- spec/reek/smells/large_class_spec.rb
+- spec/reek/smells/long_method_spec.rb
+- spec/reek/smells/long_parameter_list_spec.rb
+- spec/reek/smells/nested_iterators_spec.rb
+- spec/reek/smells/smell_spec.rb
+- spec/reek/smells/uncommunicative_name_spec.rb
+- spec/reek/smells/utility_function_spec.rb
+- spec/samples/inline.rb
+- spec/samples/inline_spec.rb
+- spec/samples/optparse.rb
+- spec/samples/optparse_spec.rb
+- spec/samples/redcloth.rb
+- spec/samples/redcloth_spec.rb
+- spec/spec.opts
+- spec/spec_helper.rb
+- tasks/reek.rake
+- tasks/rspec.rake
+has_rdoc: true
+homepage: http://wiki.github.com/kevinrutherford/reek
+post_install_message: |
+  
+  For more information on reek, see http://wiki.github.com/kevinrutherford/reek
+
+rdoc_options: 
+- --main
+- README.txt
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+requirements: []
+
+rubyforge_project: reek
+rubygems_version: 1.2.0
+signing_key: 
+specification_version: 2
+summary: Code smell detector for Ruby
+test_files: []
+