kettle-family 1.3.6 → 1.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8d912f3b7a33740ace19f7f0568177189b662819bec18bf94312de460f640fd9
-  data.tar.gz: d70a03c67ed0a96ce645d00ff769a920b500b3d1d3b231324a2d8170ea683cf1
+  metadata.gz: ec4f59e4397fe55738de3f0e3e482a2053d3c771716e9d94de40478f76ba80ae
+  data.tar.gz: 7ea569f07fa6cc8cc46cf5351cf93441ece85870c80ab51aed2458e0ce66346a
 SHA512:
-  metadata.gz: ca24fe1d3dff219117a561ecd8ff6d45edd6c1a4d4fb6db9172c874f8964676162747de8d3d45fa0caf1aa7707ec2733141eda5a993bbbcbc8d0fd81d5f8543c
-  data.tar.gz: b3f48464d35121fdee21d6d23158e81630ac373676a6581d876f2887e735cc60d5cb70c4a87359090b124a56707b544d13dd1b30f5745ecf93ef81775eb03bed
+  metadata.gz: 9dac940565396b2209bd67e957af7f2e015318d70572c05cca684e8de26c43d75755a142727d994baa5fbd646ce674fa7ab6c84bdb913ca9c6685824fd3beca6
+  data.tar.gz: 53c75a31e0896365a67c7b0ec46a45830d1e71abe37843dc715ee7f086f39166fbf39c36620efc0760d00848a6ce11238da0ee81cf84cfa6ced5e192e13178e4

data/CHANGELOG.md

@@ -30,6 +30,32 @@ Please file a bug if you notice a violation of semantic versioning.
 
 ### Security
 
+## [1.3.7] - 2026-10-09
+
+- TAG: [v1.3.7][1.3.7t]
+- COVERAGE: 93.30% -- 6778/7265 lines in 38 files
+- BRANCH COVERAGE: 77.95% -- 2757/3537 branches in 38 files
+- 34.47% documented
+
+### Changed
+
+- Reject --start-at for template and test instead of silently dropping members. Those commands dispatch in dependency waves and a concurrent queue, so the set of members that still need work is not a suffix of the configured order and no positional value can select it. The flag now exits 1 with a message pointing at the equivalent --only selection. release is deliberately left accepting --start-at: it uses MEMBER@BRANCH to select a branch lane via release_target_branches, and its own resume hints already use --only rather than --start-at. Sequentially dispatched commands (lint, bup, check, docs, install, sync, push, pull, bump) keep positional --start-at, which is correct because they abort at the first failure so pending genuinely is a suffix.
+
+- [kc] kettle-jem/prepare: updated 5 project files:
+  - dependencies (5)
+
+- [kc] kettle-jem/template: updated 2 project files:
+  - code and tests (1)
+  - other (1)
+
+### Fixed
+
+- Fix clean-unreleased missing locally installed unreleased versions. Under `bundle exec`, every RubyGems enumeration API (find_all_by_name, stubs_for, Specification.all) reports only the versions the active bundle resolves, not everything installed in the gem home. An unreleased version that was built and installed but is not pinned by the lockfile was therefore invisible, so cleanup reported "no unreleased installed versions found" with outcome success while leaving the offender installed -- blind in exactly the state it exists to correct, since re-resolving the lockfile to released versions is what hides the offender. Installed versions are now read by scanning the specification directories under each Gem.path root, which sees every installed version regardless of bundle activation and still excludes PATH/git source checkouts. Verified against the kettle-dev family: the fix now surfaces 10 unreleased members (kettle-rb 0.1.16, kettle-test 2.0.24, token-resolver 2.0.13, and others) that the previous implementation reported as none, while correctly leaving the two released members (kettle-dev 3.1.8, kettle-family 1.3.6) alone.
+
+- Fix clean-unreleased --execute reporting success when gem uninstall removes nothing. RubyGems exits 0 and prints "Gem 'name' is not installed" when the target is absent from GEM_HOME, so an exit-status check could not distinguish a completed cleanup from one that silently did nothing -- the same silent-success failure mode as the enumeration bug. The batch outcome is now verified by re-enumerating installed versions afterwards, and any survivor turns the result into a failure that names it. Investigated and deliberately not implemented: `gem uninstall -i <root>` is not a workaround for a gem home other than GEM_HOME, because it fails with the same "not installed in GEM_HOME" error even when the path equals GEM_HOME. That case already fails loudly with a non-zero exit rather than being reported as success.
+
+- Fix the resume hint for template and test silently dropping members that never ran. Those commands do not dispatch positionally: template groups members into dependency waves derived from gemspec dependencies, test uses a concurrent work queue, and in both a failure only sets a stop flag that prevents threads from popping further work -- members already in flight finish while later waves never run. The pending set is therefore interleaved through the configured order rather than being a suffix of it, so the emitted positional `--start-at <failed member>` dropped every pending member ordered ahead of the failure. Measured on the kettle-dev family: nomono failed in template wave 1 and left kettle-dev, kettle-changelog, kettle-family and kettle-soup-cover pending at ordered positions 6, 8, 9 and 11 while kettle-drift at 7 and kettle-wash at 10 had succeeded, so `--start-at nomono` resumed only nomono and token-resolver and reported outcome success having never templated the other four. Resume hints for these commands are now set-based, mirroring release: one `--only` hint per failure plus a combined `--only` hint naming every member that never ran. Sequentially dispatched commands keep positional `--start-at`, which remains correct because they abort at the first failure. A failed family-root phase still restarts the whole command, since it aborts before member dispatch. Note that template and test ignore the configured `release.waves`, which only affect release ordering.
+
 ## [1.3.6] - 2026-10-07
 
 - TAG: [v1.3.6][1.3.6t]
@@ -2905,7 +2931,9 @@ Please file a bug if you notice a violation of semantic versioning.
 - Fixed CI load failures on engines without compatible `pty` support by falling back to Open3 for interactive release commands.
 - Fixed Ruby 3.2 version-bump support by loading Prism lazily and wiring the Prism gem only for MRI versions that need it.
 
-[Unreleased]: https://github.com/kettle-dev/kettle-family/compare/v1.3.6...HEAD
+[Unreleased]: https://github.com/kettle-dev/kettle-family/compare/v1.3.7...HEAD
+[1.3.7]: https://github.com/kettle-dev/kettle-family/compare/v1.3.6...v1.3.7
+[1.3.7t]: https://github.com/kettle-dev/kettle-family/releases/tag/v1.3.7
 [1.3.6]: https://github.com/kettle-dev/kettle-family/compare/v1.3.5...v1.3.6
 [1.3.6t]: https://github.com/kettle-dev/kettle-family/releases/tag/v1.3.6
 [1.3.5]: https://github.com/kettle-dev/kettle-family/compare/v1.3.4...v1.3.5

data/lib/kettle/family/cli.rb

@@ -715,6 +715,7 @@ module Kettle
       def build_report(command, options)
         config = Config.load(root: options[:root], path: options[:config])
         start_at = parse_start_at(options[:start_at])
+        Selection.validate_positional_start_at!(command, start_at.member)
         effective_only = default_only_filter(command: command, only: options[:only])
         discovery = Discovery.new(
           config: config,

data/lib/kettle/family/report.rb

@@ -711,11 +711,42 @@ module Kettle
         release_resume_hints
       end
 
+      # Commands whose member dispatch is not positional are defined once, on
+      # Selection, because that is also where --start-at is rejected for them.
+      # Report needs the same classification to emit a set-based resume hint
+      # instead of a positional one. See the documentation on
+      # Selection::NON_POSITIONAL_DISPATCH_COMMANDS for the measured evidence.
+      def non_positional_dispatch?
+        Selection.non_positional_dispatch?(command)
+      end
+
       def non_release_resume_hints
+        return non_positional_resume_hints if non_positional_dispatch?
+
         failed = results.find { |result| !result.ok? }
         failed ? [resume_hint_for(failed)] : []
       end
 
+      # Mirrors release_resume_hints: one hint per failure, plus a single set-based
+      # hint naming every member that never ran. --only selects by name rather
+      # than position, so it resumes exactly the unfinished members regardless of
+      # how dispatch ordered them, and the wave grouping is re-derived from the
+      # selected subset.
+      #
+      # A family-root failure takes precedence and suppresses the set-based hint:
+      # that phase aborts the entire run before member dispatch, so every member
+      # needs the whole command re-run rather than a subset resumed by name.
+      def non_positional_resume_hints
+        root_failure = results.find { |result| !result.ok? && family_root_phase?(result.phase) }
+        return [resume_hint_for(root_failure)] if root_failure
+
+        failed_hints = visible_results.reject(&:ok?).filter_map { |result| resume_hint_for(result) }.uniq
+        pending_names = summary_pending.map { |entry| entry.fetch("member") }
+        return failed_hints if pending_names.empty?
+
+        [*failed_hints, "kettle-family #{command} --only #{pending_names.join(",")}"]
+      end
+
       def release_resume_hints
         failed_hints = visible_results.reject(&:ok?).filter_map { |result| resume_hint_for(result) }.uniq
         pending_names = summary_pending.map { |entry| entry.fetch("member") }
@@ -726,11 +757,18 @@ module Kettle
 
       def resume_hint_for(result)
         return release_resume_hint(result) if command == "release"
-        return "kettle-family #{command}" if result.phase.start_with?("family_root_") || result.phase == "commit_family_root_bundle_update"
+        return "kettle-family #{command}" if family_root_phase?(result.phase)
+        # A positional --start-at would silently drop pending members that are
+        # ordered ahead of this one, so wave-dispatched commands resume by name.
+        return "kettle-family #{command} --only #{result.member_name}" if non_positional_dispatch?
 
         "kettle-family #{command} --start-at #{result.member_name}"
       end
 
+      def family_root_phase?(phase)
+        phase.to_s.start_with?("family_root_") || phase == "commit_family_root_bundle_update"
+      end
+
       def release_resume_hint(result)
         return result.resume_command if result.respond_to?(:resume_command) && !result.resume_command.to_s.empty?
         return nil if result.phase == "aggregate_github_release"

data/lib/kettle/family/selection.rb

@@ -13,6 +13,43 @@ module Kettle
         "bump" => "bump_release_pending"
       }.freeze
 
+      # Commands whose member dispatch is not positional, so `--start-at` cannot
+      # express "the members that still need work" for them.
+      #
+      # template groups members into dependency waves derived from gemspec
+      # dependencies and test uses a concurrent work queue. In both, a failure only
+      # sets a stop flag that prevents threads from popping further work: members
+      # already in flight finish while later waves never run. The pending set is
+      # therefore interleaved through the configured order rather than being a
+      # suffix of it, so no --start-at value selects exactly that set.
+      #
+      # Measured on the kettle-dev family: nomono failed in template wave 1 and
+      # left kettle-dev, kettle-changelog, kettle-family and kettle-soup-cover
+      # pending at ordered positions 6, 8, 9 and 11, while kettle-drift at 7 and
+      # kettle-wash at 10 had already succeeded. The pending positions were
+      # [5, 7, 8, 10] against a required suffix of [9, 10, 11, 12].
+      #
+      # These commands ignore the configured `release.waves`, which only feed
+      # display_members_for and so only affect release ordering.
+      NON_POSITIONAL_DISPATCH_COMMANDS = %w[template test].freeze
+
+      def self.non_positional_dispatch?(command)
+        NON_POSITIONAL_DISPATCH_COMMANDS.include?(command)
+      end
+
+      # Rejects `--start-at` for commands whose dispatch is not positional, rather
+      # than letting it silently drop members. Mirrors the class-method validation
+      # convention used by validate_release_state_only_filter! so callers in the CLI
+      # do not have to know which commands are affected.
+      def self.validate_positional_start_at!(command, start_at)
+        return if start_at.nil? || start_at.to_s.empty?
+        return unless non_positional_dispatch?(command)
+
+        raise Error, "--start-at is not supported for #{command}: members are dispatched in dependency " \
+                     "waves, so a positional resume would silently skip members that never ran. " \
+                     "Use --only #{start_at} (or the resume hint from the previous report) instead."
+      end
+
       def self.status_tokens
         STATUS_TOKEN_KEYS.keys
       end

data/lib/kettle/family/unreleased_gem_cleanup.rb

@@ -102,13 +102,14 @@ module Kettle
       # Installed versions newer than anything published, as [name, version] pairs.
       #
       # Only genuinely installed gems count. Under `bundle exec`, bundler adds
-      # PATH and git sources to the load path, so
-      # Gem::Specification.find_all_by_name also returns specs whose
-      # full_gem_path points at a source checkout rather than a gem home — e.g.
-      # tree_haver 7.1.10 resolving to gems/tree_haver. Those are not installed
-      # gems and `gem uninstall` cannot remove them, so treating them as
-      # candidates would report work that can never succeed. Filtering on
-      # Gem.path membership excludes them.
+      # PATH and git sources to the load path, so a source checkout can appear as
+      # a spec — e.g. tree_haver 7.1.10 resolving to gems/tree_haver rather than a
+      # gem home. That is not an installed gem and `gem uninstall` cannot remove
+      # it, so treating it as a candidate would report work that can never
+      # succeed, and once batched one such candidate would abort the whole
+      # removal. installed_versions therefore scans only specification
+      # directories under a Gem.path root, which excludes source checkouts by
+      # construction.
       def unreleased_candidates(member:, release_state:)
         return [] unless release_state&.ok?
 
@@ -130,21 +131,53 @@ module Kettle
         nil
       end
 
+      # Versions present in a gem home, oldest first.
+      #
+      # This scans the filesystem rather than asking RubyGems, because every
+      # RubyGems enumeration API is bundle-scoped: under `bundle exec`,
+      # find_all_by_name, stubs_for and Specification.all all report only the
+      # versions the active bundle resolves. An unreleased version installed in
+      # the gem home but not pinned by the lockfile is therefore invisible, which
+      # makes cleanup blind in exactly the state it exists to correct — once the
+      # lockfile re-resolves to released versions, the offenders it should remove
+      # stop being enumerated and the run reports "no unreleased installed
+      # versions found" with outcome success while leaving them installed.
+      # Observed live with kettle-rb: `gem list` showed 0.1.14, 0.1.15 and
+      # 0.1.16, while find_all_by_name under bundle exec returned only 0.1.15.
       def installed_versions(name)
-        Gem::Specification.find_all_by_name(name)
-          .select { |spec| installed_spec?(spec) }
-          .map(&:version)
-          .uniq
-          .sort
+        gem_home_specification_dirs.flat_map { |dir| installed_spec_versions_in(dir, name) }.uniq.sort
       end
 
-      def installed_spec?(spec)
-        path = spec.full_gem_path.to_s
-        return false if path.empty?
+      # Only specification directories under a Gem.path root are scanned. A PATH
+      # or git source checkout that bundler put on the load path is not in a gem
+      # home, so it stays excluded: `gem uninstall` cannot remove one, and one
+      # bogus candidate would abort the whole batch.
+      def gem_home_specification_dirs
+        Gem::Specification.dirs.select do |dir|
+          path = dir.to_s
+          !path.empty? && Gem.path.any? { |root| path.start_with?("#{root}#{File::SEPARATOR}") }
+        end
+      end
 
-        Gem.path.any? { |root| path.start_with?("#{root}#{File::SEPARATOR}") }
-      rescue
-        false
+      # Specifications are stored as `name-VERSION.gemspec`, or
+      # `name-VERSION-PLATFORM.gemspec` for a native gem. The version is the part
+      # before the first hyphen, which matches Gem::Specification#version and so
+      # excludes the platform exactly as the previous implementation did. A
+      # filename whose version part does not parse is skipped rather than guessed
+      # at, so a similarly named gem (name-extra) cannot become a candidate.
+      def installed_spec_versions_in(dir, name)
+        prefix = "#{name}-"
+        Dir.glob(File.join(dir, "#{prefix}*.gemspec")).filter_map do |file|
+          version_text = File.basename(file, ".gemspec").delete_prefix(prefix).split("-", 2).first.to_s
+          version = parse_version(version_text)
+          version unless version.nil?
+        end
+      end
+
+      def parse_version(text)
+        Gem::Version.new(text)
+      rescue ArgumentError, TypeError
+        nil
       end
 
       # Runs the batch once, then reports that one outcome against every member
@@ -159,13 +192,42 @@ module Kettle
         # gem uninstall does not depend on the working directory, so the first
         # contributing member provides a real directory to execute in.
         host = contributors.first.fetch(:member)
-        outcome = execute ? runner.call(member: host, phase: PHASE, command: command) : dry_run_outcome(command)
+        outcome = execute ? verified_outcome(candidates, host, command) : dry_run_outcome(command)
 
         contributors.map do |entry|
           member_result(entry.fetch(:member), outcome, entry.fetch(:candidates))
         end
       end
 
+      # `gem uninstall` exits 0 and prints "Gem 'name' is not installed" when it
+      # removes nothing, so the exit status alone cannot distinguish a completed
+      # cleanup from one that found the wrong gem home and silently did nothing.
+      # Reporting ok in that case is the same failure mode as the enumeration bug
+      # this class exists to prevent: a success verdict over work that never
+      # happened. The candidates are therefore re-enumerated after the batch, and
+      # any version still present turns the outcome into a failure that names it.
+      def verified_outcome(candidates, host, command)
+        outcome = runner.call(member: host, phase: PHASE, command: command)
+        return outcome unless outcome.success && !outcome.skipped
+
+        remaining = candidates.select { |name, version| installed_versions(name).include?(version) }
+        return outcome if remaining.empty?
+
+        CommandResult.new(
+          member_name: nil,
+          phase: PHASE,
+          command: command,
+          workdir: host.root,
+          status: outcome.status,
+          success: false,
+          stdout: outcome.stdout.to_s,
+          stderr: "#{outcome.stderr}still installed after gem uninstall: #{describe(remaining)}".strip,
+          elapsed_seconds: outcome.elapsed_seconds,
+          skipped: false,
+          reason: "gem uninstall reported success but #{describe(remaining)} remains installed"
+        )
+      end
+
       def dry_run_outcome(command)
         CommandResult.new(
           member_name: nil,

data/lib/kettle/family/version.rb

@@ -5,7 +5,7 @@ module Kettle
     # Version namespace for this gem.
     module Version
       # Current gem version.
-      VERSION = "1.3.6"
+      VERSION = "1.3.7"
     end
     # Current gem version exposed at the traditional constant location.
     VERSION = Version::VERSION # Traditional Constant Location

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kettle-family
 version: !ruby/object:Gem::Version
-  version: 1.3.6
+  version: 1.3.7
 platform: ruby
 authors:
 - Peter H. Boling
@@ -324,7 +324,7 @@ dependencies:
         version: '3.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.13
+        version: 3.2.14
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -334,7 +334,7 @@ dependencies:
         version: '3.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.13
+        version: 3.2.14
 - !ruby/object:Gem::Dependency
   name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
@@ -389,6 +389,26 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.0.15
+- !ruby/object:Gem::Dependency
+  name: gem_mine
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.3
 - !ruby/object:Gem::Dependency
   name: webrick
   requirement: !ruby/object:Gem::Requirement
@@ -460,10 +480,10 @@ licenses:
 - AGPL-3.0-only
 metadata:
   homepage_uri: https://kettle-family.galtzo.com
-  source_code_uri: https://github.com/kettle-dev/kettle-family/tree/v1.3.6
-  changelog_uri: https://github.com/kettle-dev/kettle-family/blob/v1.3.6/CHANGELOG.md
+  source_code_uri: https://github.com/kettle-dev/kettle-family/tree/v1.3.7
+  changelog_uri: https://github.com/kettle-dev/kettle-family/blob/v1.3.7/CHANGELOG.md
   bug_tracker_uri: https://github.com/kettle-dev/kettle-family/issues
-  documentation_uri: https://www.rubydoc.info/gems/kettle-family/1.3.6
+  documentation_uri: https://www.rubydoc.info/gems/kettle-family/1.3.7
   funding_uri: https://github.com/sponsors/pboling
   wiki_uri: https://github.com/kettle-dev/kettle-family/wiki
   news_uri: https://www.railsbling.com/tags/kettle-family