kettle-dev 3.0.25 → 3.0.27

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2cd8d91c81ccdd9583d9891fca16e33847e99c5f27d7730c7d10f45cd4964c8f
-  data.tar.gz: 71bfd99738051fb53d744386489a866a90c9477613d1af2a82921bb7a4a51523
+  metadata.gz: f2c4229bf9687d5eeb37b3969ae097bd1826819756082e26053970f9c953048f
+  data.tar.gz: 6eaf217455b0f4215bb3c4699e0a5651d1367524208567121ea869a482cf9ca9
 SHA512:
-  metadata.gz: 350321f82985a5dc9fd911e2e0fb11c9c5441cbc3abe8d43d64a550bab64c5a9f5a327700780eb191eeb11dbb7d5215492f5c2150f37f46618a7440d493fefb1
-  data.tar.gz: 45f92406c0e64bd0d16252bb14099746aac35b7a346309497ef3e8fc3d9b30adaf2497ced7b93aca7535406cecb7d6e9e840b85f2171b72ddfef18e9b3947e27
+  metadata.gz: 21ba6652f5ed37d6b67674b7869604c4700a94b8618185c8891e652271de5c71b85ea9eea576b5936ec1c43715c4a95f18ef9c117b3f2b74fac07546ad1d3fed
+  data.tar.gz: dc321c0c5531ff7b006bcbb83f3dee87a693b70b000619e4907e7e037fd597791446b1e75907a2895cc6135f0c25af62caaf4e782baa9ef4f089dca8ac504255

data/CHANGELOG.md

@@ -30,6 +30,32 @@ Please file a bug if you notice a violation of semantic versioning.
 
 ### Security
 
+## [3.0.27] - 2026-08-31
+
+- TAG: [v3.0.27][3.0.27t]
+- COVERAGE: 91.68% -- 5998/6542 lines in 47 files
+- BRANCH COVERAGE: 76.20% -- 2296/3013 branches in 47 files
+- 50.24% documented
+
+### Added
+
+- Emit GitHub Release creation and asset-upload lifecycle events, including retry attempts.
+
+### Fixed
+
+- Retry transient GitHub Release asset uploads and report every failed asset.
+
+## [3.0.26] - 2026-08-31
+
+- TAG: [v3.0.26][3.0.26t]
+- COVERAGE: 91.60% -- 5967/6514 lines in 47 files
+- BRANCH COVERAGE: 76.17% -- 2286/3001 branches in 47 files
+- 50.47% documented
+
+### Fixed
+
+- Refresh existing GitHub Release notes while backfilling missing assets.
+
 ## [3.0.25] - 2026-08-31
 
 - TAG: [v3.0.25][3.0.25t]
@@ -3736,7 +3762,11 @@ Please file a bug if you notice a violation of semantic versioning.
   - Selecting will run the selected workflow via `act`
   - This may move to its own gem in the future.
 
-[Unreleased]: https://github.com/kettle-dev/kettle-dev/compare/v3.0.25...HEAD
+[Unreleased]: https://github.com/kettle-dev/kettle-dev/compare/v3.0.27...HEAD
+[3.0.27]: https://github.com/kettle-dev/kettle-dev/compare/v3.0.26...v3.0.27
+[3.0.27t]: https://github.com/kettle-dev/kettle-dev/releases/tag/v3.0.27
+[3.0.26]: https://github.com/kettle-dev/kettle-dev/compare/v3.0.25...v3.0.26
+[3.0.26t]: https://github.com/kettle-dev/kettle-dev/releases/tag/v3.0.26
 [3.0.25]: https://github.com/kettle-dev/kettle-dev/compare/v3.0.24...v3.0.25
 [3.0.25t]: https://github.com/kettle-dev/kettle-dev/releases/tag/v3.0.25
 [3.0.24]: https://github.com/kettle-dev/kettle-dev/compare/v3.0.23...v3.0.24

data/README.md

@@ -1066,7 +1066,7 @@ Thanks for RTFM. ☺️
 [📌gitmoji]: https://gitmoji.dev
 [📌gitmoji-img]: https://img.shields.io/badge/gitmoji_commits-%20%F0%9F%98%9C%20%F0%9F%98%8D-34495e.svg?style=flat-square
 [🧮kloc]: https://www.youtube.com/watch?v=dQw4w9WgXcQ
-[🧮kloc-img]: https://img.shields.io/badge/KLOC-6.516-FFDD67.svg?style=for-the-badge&logo=YouTube&logoColor=blue
+[🧮kloc-img]: https://img.shields.io/badge/KLOC-6.542-FFDD67.svg?style=for-the-badge&logo=YouTube&logoColor=blue
 [🔐security]: https://github.com/kettle-dev/kettle-dev/blob/main/SECURITY.md
 [🔐security-img]: https://img.shields.io/badge/security-policy-259D6C.svg?style=flat
 [📄copyright-notice-explainer]: https://opensource.stackexchange.com/questions/5778/why-do-licenses-such-as-the-mit-license-specify-a-single-year

data/exe/kettle-gh-release

@@ -26,6 +26,7 @@ $LOAD_PATH.unshift(repo_lib) if File.directory?(repo_lib) && !$LOAD_PATH.include
 
 begin
   require "kettle/dev"
+  require "kettle/ndjson"
   require "kettle/dev/executable_version"
   Kettle::Dev::ExecutableVersion.print_and_exit!(script_basename, ARGV)
   Kettle::Dev::ExecutableVersion.print_header(script_basename)
@@ -52,7 +53,7 @@ if ARGV.include?("-h") || ARGV.include?("--help")
       version=<VERSION>           # Backward-compatible explicit version form
       --check                     # Verify RubyGems, remote tag, changelog, and token without creating a release
       --update                    # Update an existing GitHub Release title/body from CHANGELOG.md
-      --events                    # Emit the final result as one NDJSON event
+      --events                    # Emit GitHub Release lifecycle and asset NDJSON events
       --allow-unpublished         # Skip the RubyGems publication requirement (for intentionally non-RubyGems projects)
       --asset PATH                # Attach an artifact to the GitHub release (repeatable)
 
@@ -106,7 +107,8 @@ if !explicit_version.nil? && explicit_version.empty?
 end
 
 begin
-  cli = Kettle::Dev::ReleaseCLI.new(start_step: 18)
+  event_stream = events ? Kettle::Ndjson.event_stream($stdout, types: "github_release") : nil
+  cli = Kettle::Dev::ReleaseCLI.new(start_step: 18, event_stream: event_stream)
   version = explicit_version || cli.send(:detect_version)
   result = cli.send(:github_release_backfill_check, version, require_rubygems: !allow_unpublished)
 
@@ -135,22 +137,11 @@ begin
   exit 1 unless result.fetch("ok")
   exit 0 if check_only
 
-  created, message = if update_only
+  created, _message = if update_only
     cli.send(:maybe_update_github_release!, version)
   else
     cli.send(:maybe_create_github_release!, version, assets: assets)
   end
-  if events
-    puts JSON.generate(
-      event_version: 1,
-      type: "github_release",
-      action: update_only ? "update" : "create",
-      status: created ? "ok" : "failed",
-      version: result.fetch("version"),
-      tag: result.fetch("tag"),
-      result: message
-    )
-  end
   exit(created ? 0 : 1)
 rescue LoadError => e
   warn("#{script_basename}: could not load dependency: #{e.class}: #{e.message}")

data/lib/kettle/dev/release_cli.rb

@@ -7,6 +7,7 @@ require "shellwords"
 require "time"
 require "fileutils"
 require "net/http"
+require "openssl"
 require "json"
 require "uri"
 require "yaml"
@@ -27,6 +28,8 @@ module Kettle
     class ReleaseCLI
       RUBYGEMS_INVALID_OTP = /Your OTP code is incorrect\. Please check it and retry\./.freeze
       OTP_RETRY_DELAY_SECONDS = 2
+      GITHUB_RELEASE_ASSET_UPLOAD_ATTEMPTS = 3
+      GITHUB_RELEASE_ASSET_UPLOAD_RETRY_DELAY_SECONDS = 1
       QUIET_ENV = {
         "KETTLE_JEM_QUIET" => "true",
         "KETTLE_JEM_DEBUG" => "false",
@@ -2880,7 +2883,9 @@ module Kettle
 
         tag = "v#{version}"
         puts "Creating GitHub release #{owner}/#{repo} #{tag}..."
+        emit_github_release_event(action: "create", status: "started", tag: tag, assets: Array(assets).length)
         ok, msg = github_create_release(owner: owner, repo: repo, token: token, tag: tag, title: tag, body: body, assets: assets)
+        emit_github_release_event(action: "create", status: ok ? "ok" : "failed", tag: tag, assets: Array(assets).length, reason: msg)
         if ok
           puts "GitHub release created for #{tag}."
         else
@@ -3063,17 +3068,18 @@ module Kettle
 
           release = JSON.parse(res.body)
           asset_messages = Array(assets).map { |asset| github_upload_release_asset(release.fetch("id"), owner: owner, repo: repo, token: token, path: asset) }
-          failed_asset = asset_messages.find { |ok, _message| !ok }
-          failed_asset || [true, "created with #{asset_messages.length} assets"]
+          github_release_asset_result(asset_messages, "created")
         else
           if res.code.to_s == "422" && res.body.to_s.include?("already_exists")
             return [true, "already exists"] if Array(assets).empty?
 
-            upload_missing_github_release_assets(
+            update_existing_github_release_with_assets(
               owner: owner,
               repo: repo,
               token: token,
               tag: tag,
+              title: title,
+              body: body,
               assets: assets
             )
           else
@@ -3084,20 +3090,36 @@ module Kettle
         [false, "#{e.class}: #{e.message}"]
       end
 
-      def upload_missing_github_release_assets(owner:, repo:, token:, tag:, assets:)
+      def update_existing_github_release_with_assets(owner:, repo:, token:, tag:, title:, body:, assets:)
         release, error = github_release_for_tag(owner: owner, repo: repo, token: token, tag: tag)
         return [false, error] unless release
 
+        updated, error = github_update_release_by_id(
+          release.fetch("id"),
+          owner: owner,
+          repo: repo,
+          token: token,
+          title: title,
+          body: body
+        )
+        return [false, error] unless updated
+
         existing_names = Array(release["assets"]).filter_map { |asset| asset["name"] }.to_set
         missing_assets = Array(assets).reject { |asset| existing_names.include?(File.basename(asset)) }
-        return [true, "already exists with all assets present"] if missing_assets.empty?
+        return [true, "updated existing release with all assets present"] if missing_assets.empty?
 
         asset_messages = missing_assets.map do |asset|
           github_upload_release_asset(release.fetch("id"), owner: owner, repo: repo, token: token, path: asset)
         end
-        failed_asset = asset_messages.find { |ok, _message| !ok }
+        github_release_asset_result(asset_messages, "updated existing release")
+      end
+
+      def github_release_asset_result(asset_messages, success_prefix)
+        failures = asset_messages.reject(&:first).map(&:last)
+        return [false, failures.join("; ")] unless failures.empty?
+
         asset_noun = asset_messages.one? ? "asset" : "assets"
-        failed_asset || [true, "already exists with #{asset_messages.length} #{asset_noun} uploaded"]
+        [true, "#{success_prefix} with #{asset_messages.length} #{asset_noun} uploaded"]
       end
 
       def github_release_for_tag(owner:, repo:, token:, tag:)
@@ -3118,6 +3140,42 @@ module Kettle
         path = File.expand_path(path)
         return [false, "asset does not exist: #{path}"] unless File.file?(path)
 
+        attempts = GITHUB_RELEASE_ASSET_UPLOAD_ATTEMPTS
+        attempts.times do |attempt|
+          emit_github_release_event(
+            action: "asset_upload",
+            status: "started",
+            asset: File.basename(path),
+            attempt: attempt + 1,
+            attempts: attempts
+          )
+          result = github_upload_release_asset_once(release_id, owner: owner, repo: repo, token: token, path: path)
+          retrying = !result.first && retryable_github_release_asset_upload_result?(result.last) && attempt < attempts - 1
+          status = if result.first
+            "ok"
+          elsif retrying
+            "retrying"
+          else
+            "failed"
+          end
+          emit_github_release_event(
+            action: "asset_upload",
+            status: status,
+            asset: File.basename(path),
+            attempt: attempt + 1,
+            attempts: attempts,
+            reason: result.first ? nil : result.last
+          )
+          return result unless retrying
+
+          warn("GitHub release asset upload failed for #{File.basename(path)}; retrying #{attempt + 2}/#{attempts}.")
+          sleep(GITHUB_RELEASE_ASSET_UPLOAD_RETRY_DELAY_SECONDS)
+        end
+      rescue => e
+        [false, "asset #{File.basename(path)}: #{e.class}: #{e.message}"]
+      end
+
+      def github_upload_release_asset_once(release_id, owner:, repo:, token:, path:)
         uri = URI("https://uploads.github.com/repos/#{owner}/#{repo}/releases/#{release_id}/assets")
         uri.query = URI.encode_www_form(name: File.basename(path))
         req = Net::HTTP::Post.new(uri)
@@ -3130,20 +3188,39 @@ module Kettle
         return [true, File.basename(path)] if res.is_a?(Net::HTTPSuccess) || res.is_a?(Net::HTTPCreated)
 
         [false, "asset #{File.basename(path)}: HTTP #{res.code}: #{res.body}"]
-      rescue => e
+      rescue OpenSSL::SSL::SSLError, IOError, SystemCallError, Timeout::Error => e
         [false, "asset #{File.basename(path)}: #{e.class}: #{e.message}"]
       end
 
+      def retryable_github_release_asset_upload_result?(message)
+        message.match?(/(?:OpenSSL::SSL::SSLError|IOError|Errno::|(?:Net::)?(?:Open|Read)Timeout|HTTP (?:429|5\d\d))/)
+      end
+
+      def emit_github_release_event(action:, status:, tag: nil, asset: nil, assets: nil, attempt: nil, attempts: nil, reason: nil)
+        Kettle::Ndjson.emit_event(
+          @event_recorder,
+          "github_release",
+          action: action,
+          phase: "release",
+          status: status,
+          tag: tag,
+          asset: asset,
+          assets: assets,
+          attempt: attempt,
+          attempts: attempts,
+          reason: reason,
+          mark: release_progress_mark(status)
+        )
+      end
+
       def github_update_release(owner:, repo:, token:, tag:, title:, body:)
-        lookup = URI("https://api.github.com/repos/#{owner}/#{repo}/releases/tags/#{tag}")
-        get = Net::HTTP::Get.new(lookup)
-        get["Accept"] = "application/vnd.github+json"
-        get["Authorization"] = "token #{token}"
-        get["User-Agent"] = "kettle-dev-release-cli"
-        release = Net::HTTP.start(lookup.host, lookup.port, use_ssl: true) { |http| http.request(get) }
-        return [false, "release #{tag} was not found (HTTP #{release.code})"] unless release.is_a?(Net::HTTPSuccess)
-
-        id = JSON.parse(release.body).fetch("id")
+        release, error = github_release_for_tag(owner: owner, repo: repo, token: token, tag: tag)
+        return [false, error] unless release
+
+        github_update_release_by_id(release.fetch("id"), owner: owner, repo: repo, token: token, title: title, body: body)
+      end
+
+      def github_update_release_by_id(id, owner:, repo:, token:, title:, body:)
         uri = URI("https://api.github.com/repos/#{owner}/#{repo}/releases/#{id}")
         request = Net::HTTP::Patch.new(uri)
         request["Accept"] = "application/vnd.github+json"

data/lib/kettle/dev/version.rb

@@ -5,7 +5,7 @@ module Kettle
     # Version namespace for this gem.
     module Version
       # Current gem version.
-      VERSION = "3.0.25"
+      VERSION = "3.0.27"
     end
     # Current gem version exposed at the traditional constant location.
     VERSION = Version::VERSION # Traditional Constant Location

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kettle-dev
 version: !ruby/object:Gem::Version
-  version: 3.0.25
+  version: 3.0.27
 platform: ruby
 authors:
 - Peter H. Boling
@@ -80,7 +80,7 @@ dependencies:
         version: '0.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.14
+        version: 0.1.15
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -90,7 +90,7 @@ dependencies:
         version: '0.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.14
+        version: 0.1.15
 - !ruby/object:Gem::Dependency
   name: kettle-rb
   requirement: !ruby/object:Gem::Requirement
@@ -400,10 +400,10 @@ licenses:
 - AGPL-3.0-only
 metadata:
   homepage_uri: https://kettle-dev.galtzo.com
-  source_code_uri: https://github.com/kettle-dev/kettle-dev/tree/v3.0.25
-  changelog_uri: https://github.com/kettle-dev/kettle-dev/blob/v3.0.25/CHANGELOG.md
+  source_code_uri: https://github.com/kettle-dev/kettle-dev/tree/v3.0.27
+  changelog_uri: https://github.com/kettle-dev/kettle-dev/blob/v3.0.27/CHANGELOG.md
   bug_tracker_uri: https://github.com/kettle-dev/kettle-dev/issues
-  documentation_uri: https://www.rubydoc.info/gems/kettle-dev/3.0.25
+  documentation_uri: https://www.rubydoc.info/gems/kettle-dev/3.0.27
   funding_uri: https://github.com/sponsors/pboling
   wiki_uri: https://github.com/kettle-dev/kettle-dev/wiki
   news_uri: https://www.railsbling.com/tags/kettle-dev