kennel 2.12.1 → 2.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 820cb0c4f746cbbafc79598199ba6c4e6d8d762e8505b432af9bf3c27de3ca74
-  data.tar.gz: d1c54c6ecd55bfd00e432b9258dfb6c6f16fa15c9181f862adca7bd885a0c4c2
+  metadata.gz: 4ad7fc83d72816d45830ddf3c46d266d8a6baba0c163d16c85ae69dcdc5058bd
+  data.tar.gz: 2ab1212ba1a378cdfe758e0821251661a977adbea8f57f88156e38131d9fac81
 SHA512:
-  metadata.gz: e001bd09798e846ddabdd5dae8b47aa9174cdd19be8f4af77b52d2eb877ed2cb6043a2022c229f23e0c232700104c930902ec89ecb2db416e77de2e29074ef0b
-  data.tar.gz: bd930e26de4108718b8228056b726a5aeb41407ddef31175879b8126b250639e027b2d1e05cbabe47d5e94399aa8a8c609dddc3bb0163eeb920051d436186b1d
+  metadata.gz: bf31a0b076d4d961c04bfb670d5969d71419eeb97388bcdfcd9410192efad429cb2b2de04cd02ad1798534abe61f8c9f3c65689a7f34b27d2c6d8b7dee150bcd
+  data.tar.gz: cedb8aaa36eaaa1f67cc137419891048d56b1fb1b103a51e8743cf2eecdd10d10d8bdcf609435def8fad3b8d92e8cd3c53a03f7dacd4d6996796e9f79db73b15

data/lib/kennel/api.rb

@@ -109,7 +109,9 @@ module Kennel
 
     def request(method, path, body: nil, params: {}, ignore_404: false)
       path = "#{path}?#{Faraday::FlatParamsEncoder.encode(params)}" if params.any?
-      with_cache ENV["FORCE_GET_CACHE"] && method == :get, path do
+      cached = (ENV["FORCE_GET_CACHE"] && method == :get)
+
+      with_cache cached, path do
         response = nil
         tries = 2
 
@@ -128,7 +130,8 @@ module Kennel
             redo
           end
 
-          break if i == tries - 1 || method != :get || response.status < 500
+          last_try = (i == tries - 1)
+          break if last_try || ![:get, :put].include?(method) || response.status < 500
           Kennel.err.puts "Retrying on server error #{response.status} for #{path}"
         end
 

data/lib/kennel/models/monitor.rb

@@ -33,6 +33,7 @@ module Kennel
       DEFAULT_ESCALATION_MESSAGE = ["", nil].freeze
       ALLOWED_PRIORITY_CLASSES = [NilClass, Integer].freeze
       SKIP_NOTIFY_NO_DATA_TYPES = ["event alert", "event-v2 alert", "log alert"].freeze
+      ON_MISSING_DATA_UNSUPPORTED_TYPES = ["composite", "datadog-usage alert"].freeze
       MINUTES_PER_UNIT = {
         "m" => 1,
         "h" => 60,
@@ -155,14 +156,19 @@ module Kennel
         action ||= "default" if type == "event-v2 alert"
 
         # TODO: mark setting action && !notify.nil? at all as invalid
-        if action && timeframe
-          invalid! :invalid_no_data_config, "set either no_data_timeframe or on_missing_data"
-        end
-        if type == "composite" && action
-          invalid! :invalid_no_data_config, "cannot use on_missing_data with composite monitor"
-        end
-        if action == "resolve" && timeout_h.to_i != 0
-          invalid! :invalid_no_data_config, "timeout_h cannot be set and non-zero when on_missing_data is `resolve`"
+        if action
+          if ON_MISSING_DATA_UNSUPPORTED_TYPES.include?(type)
+            invalid! :invalid_no_data_config, "cannot use on_missing_data with #{type} monitor"
+          end
+          if timeframe
+            invalid! :invalid_no_data_config, "set either no_data_timeframe or on_missing_data"
+          end
+          if action != "default" && type == "query alert" && query.to_s.include?("default_zero(") # is allowed for log alert for example
+            invalid! :invalid_no_data_config, "set on_missing_data to `default` when using default_zero"
+          end
+          if action == "resolve" && timeout_h.to_i != 0
+            invalid! :invalid_no_data_config, "timeout_h cannot be set and non-zero when on_missing_data is `resolve`"
+          end
         end
 
         # on_missing_data cannot be used with notify_no_data + no_data_timeframe

data/lib/kennel/models/slo.rb

@@ -73,7 +73,7 @@ module Kennel
       end
 
       def self.parse_url(url)
-        url[/[?&]slo_id=([a-z\d]{10,})/, 1] || url[/\/slo\/([a-z\d]{10,})\/edit(\?|$)/, 1]
+        url[/[?&]slo_id=([a-z\d]{10,})/, 1] || url[/\/slo\/([a-z\d]{10,})(:?\/edit)?(\?|$)/, 1]
       end
 
       def resolve_linked_tracking_ids!(id_map, **args)

data/lib/kennel/projects_provider.rb

@@ -18,7 +18,7 @@ module Kennel
     private
 
     def loaded_projects
-      Models::Project.recursive_subclasses
+      Models::Project.recursive_subclasses.reject(&:abstract_class?)
     end
 
     # "require" requested .rb files under './projects',

data/lib/kennel/subclass_tracking.rb

@@ -9,8 +9,16 @@ module Kennel
       @subclasses ||= []
     end
 
+    def abstract_class?
+      !!@abstract_class
+    end
+
     private
 
+    def abstract_class!
+      @abstract_class = true # not inherited by children
+    end
+
     def inherited(child)
       super
       subclasses << child

data/lib/kennel/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Kennel
-  VERSION = "2.12.1"
+  VERSION = "2.13.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kennel
 version: !ruby/object:Gem::Version
-  version: 2.12.1
+  version: 2.13.0
 platform: ruby
 authors:
 - Michael Grosser
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-01-12 00:00:00.000000000 Z
+date: 2026-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: diff-lcs