kennel 1.99.0 → 1.102.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0363ce2c85e194b4c6eca7e657a614d3eb0e27d7c0a5f4a55871bf39fc90f5f9
-  data.tar.gz: 075f01f5fa4f153f1a8c07ec000b7abf246e3c0dd9082d5709661240191b07f1
+  metadata.gz: a2bb74d0c3edadadde342a244ba9978b571da0a2306b8c5aacaafd60a745f431
+  data.tar.gz: abbb833ba16df03e64e2fea46c4094b7ad2aa07780c13e0cebe981f9c77e4753
 SHA512:
-  metadata.gz: 6834defb05ea8844a19fdaa80a8e3cb7154305bbf3dbc6a66c24d76cc4b050305020c14ca7712a105d1514c421cf4a1f4674b9dfccc93b694e17daba8d8abf8b
-  data.tar.gz: 87f2c790faa21b2e63beaca026c565e6c940aa9dae0cc624b7060d81ed4b6cfce7894c77ccf56b60751a9fb3d1ed0b1dfc2c2c27a893ea88e0097b2d44138a05
+  metadata.gz: d0aea7c75a482f3a4a2d4996bca4c3b2990564f3720f027366749b5c287f50bc805e29782315e697a2711f5029f9aecbda05b4aae0b1f6204d371f6991e6e76b
+  data.tar.gz: 47037941ef3eedbefb74061545ea68c62d36367ec2b24a3acd3e6e2e08aaa9ef44f2735482012aa4af202aca5ee2cf2330af9df40ee717500d01c43940c9e436

data/lib/kennel/id_map.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+module Kennel
+  class IdMap
+    NEW = :new # will be created during this run
+
+    def initialize
+      @map = Hash.new { |h, k| h[k] = {} }
+    end
+
+    def get(type, tracking_id)
+      @map[type][tracking_id]
+    end
+
+    def set(type, tracking_id, id)
+      @map[type][tracking_id] = id
+    end
+
+    def new?(type, tracking_id)
+      @map[type][tracking_id] == NEW
+    end
+  end
+end

data/lib/kennel/models/dashboard.rb

@@ -189,16 +189,17 @@ module Kennel
           when "uptime"
             if ids = definition[:monitor_ids]
               definition[:monitor_ids] = ids.map do |id|
-                tracking_id?(id) ? (resolve_link(id, :monitor, id_map, **args) || id) : id
+                resolve(id, :monitor, id_map, **args) || id
               end
             end
           when "alert_graph"
-            if (id = definition[:alert_id]) && tracking_id?(id)
-              definition[:alert_id] = (resolve_link(id, :monitor, id_map, **args) || id).to_s
+            if id = definition[:alert_id]
+              resolved = resolve(id, :monitor, id_map, **args) || id
+              definition[:alert_id] = resolved.to_s # even though it's a monitor id
             end
           when "slo"
-            if (id = definition[:slo_id]) && tracking_id?(id)
-              definition[:slo_id] = (resolve_link(id, :slo, id_map, **args) || id).to_s
+            if id = definition[:slo_id]
+              definition[:slo_id] = resolve(id, :slo, id_map, **args) || id
             end
           end
         end
@@ -206,10 +207,6 @@ module Kennel
 
       private
 
-      def tracking_id?(id)
-        id.is_a?(String) && id.include?(":")
-      end
-
       # creates queries from metadata to avoid having to keep q and expression in sync
       #
       # {q: :metadata, metadata: [{expression: "sum:bar", alias_name: "foo"}, ...], }

data/lib/kennel/models/monitor.rb

@@ -121,7 +121,7 @@ module Kennel
         when "composite", "slo alert"
           type = (as_json[:type] == "composite" ? :monitor : :slo)
           as_json[:query] = as_json[:query].gsub(/%{(.*?)}/) do
-            resolve_link($1, type, id_map, **args) || $&
+            resolve($1, type, id_map, **args) || $&
           end
         end
       end

data/lib/kennel/models/record.rb

@@ -100,9 +100,20 @@ module Kennel
 
       private
 
+      def resolve(value, type, id_map, force:)
+        if tracking_id?(value)
+          return resolve_link(value, type, id_map, force: force)
+        end
+
+        value
+      end
+
+      def tracking_id?(id)
+        id.is_a?(String) && id.include?(":")
+      end
+
       def resolve_link(tracking_id, type, id_map, force:)
-        id = id_map[tracking_id]
-        if id == :new
+        if id_map.new?(type.to_s, tracking_id)
           if force
             invalid!(
               "#{type} #{tracking_id} was referenced but is also created by the current run.\n" \
@@ -111,7 +122,7 @@ module Kennel
           else
             nil # will be re-resolved after the linked object was created
           end
-        elsif id
+        elsif id = id_map.get(type.to_s, tracking_id)
           id
         else
           invalid! "Unable to find #{type} #{tracking_id} (does not exist and is not being created by the current run)"

data/lib/kennel/models/slo.rb

@@ -70,7 +70,7 @@ module Kennel
       def resolve_linked_tracking_ids!(id_map, **args)
         return unless as_json[:monitor_ids] # ignore_default can remove it
         as_json[:monitor_ids] = as_json[:monitor_ids].map do |id|
-          id.is_a?(String) ? (resolve_link(id, :monitor, id_map, **args) || id) : id
+          resolve(id, :monitor, id_map, **args) || id
         end
       end
 

data/lib/kennel/syncer.rb

@@ -122,7 +122,7 @@ module Kennel
     def calculate_diff
       @update = []
       @delete = []
-      @id_map = {}
+      @id_map = IdMap.new
 
       actual = Progress.progress("Downloading definitions") { download_definitions }
 
@@ -254,11 +254,32 @@ module Kennel
     end
 
     def populate_id_map(expected, actual)
+      # mark everything as new
+      expected.each do |e|
+        @id_map.set(e.class.api_resource, e.tracking_id, IdMap::NEW)
+        if e.class.api_resource == "synthetics/tests"
+          @id_map.set(Kennel::Models::Monitor.api_resource, e.tracking_id, IdMap::NEW)
+        end
+      end
+
+      # override resources that exist with their id
+      project_prefix = @project_filter && "#{@project_filter}:"
       actual.each do |a|
+        # ignore when not managed by kennel
         next unless tracking_id = a.fetch(:tracking_id)
-        @id_map[tracking_id] = a.fetch(:id)
+
+        # ignore when deleted from the codebase
+        # (when running with project filter we cannot see the other resources in the codebase)
+        api_resource = a.fetch(:klass).api_resource
+        next if
+          !@id_map.get(api_resource, tracking_id) &&
+          (!project_prefix || tracking_id.start_with?(project_prefix))
+
+        @id_map.set(api_resource, tracking_id, a.fetch(:id))
+        if a[:klass].api_resource == "synthetics/tests"
+          @id_map.set(Kennel::Models::Monitor.api_resource, tracking_id, a.fetch(:monitor_id))
+        end
       end
-      expected.each { |e| @id_map[e.tracking_id] ||= :new }
     end
 
     def resolve_linked_tracking_ids!(list, force: false)

data/lib/kennel/tasks.rb

@@ -3,6 +3,7 @@ require "English"
 require "kennel"
 require "kennel/unmuted_alerts"
 require "kennel/importer"
+require "json"
 
 module Kennel
   module Tasks
@@ -89,7 +90,7 @@ namespace :kennel do
     Kennel::UnmutedAlerts.print(Kennel.send(:api), tag)
   end
 
-  desc "show monitors with no data by TAG, for example TAG=team:foo"
+  desc "show monitors with no data by TAG, for example TAG=team:foo [THRESHOLD_DAYS=7] [FORMAT=json]"
   task nodata: :environment do
     tag = ENV["TAG"] || Kennel::Tasks.abort("Call with TAG=foo:bar")
     monitors = Kennel.send(:api).list("monitor", monitor_tags: tag, group_states: "no data")
@@ -97,16 +98,45 @@ namespace :kennel do
     monitors.reject! { |m| m[:tags].include? "nodata:ignore" }
     if monitors.any?
       Kennel.err.puts <<~TEXT
-        This is a useful task to find monitors that have mis-spelled metrics or never received data at any time.
-        To ignore monitors with nodata, tag the monitor with "nodata:ignore"
+        To ignore monitors with expected nodata, tag it with "nodata:ignore"
 
       TEXT
     end
 
+    now = Time.now
     monitors.each do |m|
-      Kennel.out.puts m[:name]
-      Kennel.out.puts Kennel::Utils.path_to_url("/monitors/#{m[:id]}")
-      Kennel.out.puts
+      m[:days_in_no_data] =
+        if m[:overall_state_modified]
+          since = Date.parse(m[:overall_state_modified]).to_time
+          ((now - since) / (24 * 60 * 60)).to_i
+        else
+          999
+        end
+    end
+
+    if threshold = ENV["THRESHOLD_DAYS"]
+      monitors.select! { |m| m[:days_in_no_data] > Integer(threshold) }
+    end
+
+    monitors.each { |m| m[:url] = Kennel::Utils.path_to_url("/monitors/#{m[:id]}") }
+
+    if ENV["FORMAT"] == "json"
+      report = monitors.map do |m|
+        match = m[:message].to_s.match(/-- Managed by kennel (\S+:\S+) in (\S+), /) || []
+        m.slice(:url, :name, :tags, :days_in_no_data).merge(
+          kennel_tracking_id: match[1],
+          kennel_source: match[2]
+        )
+      end
+
+      Kennel.out.puts JSON.pretty_generate(report)
+    else
+      monitors.each do |m|
+        Kennel.out.puts m[:name]
+        Kennel.out.puts Kennel::Utils.path_to_url("/monitors/#{m[:id]}")
+        Kennel.out.puts "No data since #{m[:days_in_no_data]}d"
+        Kennel.out.puts
+      end
     end
   end
 

data/lib/kennel/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Kennel
-  VERSION = "1.99.0"
+  VERSION = "1.102.1"
 end

data/lib/kennel.rb

@@ -9,6 +9,7 @@ require "kennel/version"
 require "kennel/utils"
 require "kennel/progress"
 require "kennel/syncer"
+require "kennel/id_map"
 require "kennel/api"
 require "kennel/github_reporter"
 require "kennel/subclass_tracking"
@@ -69,7 +70,8 @@ module Kennel
           path = "generated/#{part.tracking_id.tr("/", ":").sub(":", "/")}.json"
           used << File.dirname(path) # only 1 level of sub folders, so this is safe
           used << path
-          write_file_if_necessary(path, JSON.pretty_generate(part.as_json) << "\n")
+          payload = part.as_json.merge(api_resource: part.class.api_resource)
+          write_file_if_necessary(path, JSON.pretty_generate(payload) << "\n")
         end
 
         # deleting all is slow, so only delete the extras

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kennel
 version: !ruby/object:Gem::Version
-  version: 1.99.0
+  version: 1.102.1
 platform: ruby
 authors:
 - Michael Grosser
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-11-05 00:00:00.000000000 Z
+date: 2021-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -77,6 +77,7 @@ files:
 - lib/kennel/api.rb
 - lib/kennel/file_cache.rb
 - lib/kennel/github_reporter.rb
+- lib/kennel/id_map.rb
 - lib/kennel/importer.rb
 - lib/kennel/models/base.rb
 - lib/kennel/models/dashboard.rb