kennel 1.160.0 → 1.162.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 305e0eb2205f87e8f993c0a6d19936f8ab2b2bdffa20316cc54dd241932cdad0
-  data.tar.gz: aea7a8fe0cbb8981e777bf83cdcfdf07489581c0621140f299aa9ec4a3447ac3
+  metadata.gz: 8412928c5e979ad1f46ac333e0f51a9d2601fa435a6ec2951390211515b0b35b
+  data.tar.gz: 2d25fbf232b3d784f3ea04ff51a38aeea2c7f034969e2065c4ddbb6dbbd3ea99
 SHA512:
-  metadata.gz: 19ebc04a7b038919f635a33fc9e8f9e94500c62d9e8c68f6a51df9d66d4d8bc9e4b0036cd48b04f1215cfaa23d28321982ac28f90b26fd091cbac6da671b1f22
-  data.tar.gz: cddea78b6c4050cfbb3b7de37346ea91022a00f72f3da62368870878c8630a2024988b894bb102be81e05f80002c0e9ffcf2ce1ae434673eca43fc342c902f44
+  metadata.gz: 320fbf356dbfb89826f99b7a3b90f3f41af07022b8ab783b546af7cb6a7430081fa955431bfd642fbda50de31e6308b863912c9c6d0af768622ff2f9b302b4e1
+  data.tar.gz: ef91e1bebe47fd623d65a5a308c726930e077632ac3b993241986f8625b695312789675e2bc5de4ee55ea2bfc1828252e110fbc65f81b91307ba0f6773efaf9f

data/lib/kennel/importer.rb

@@ -47,7 +47,9 @@ module Kennel
         data.merge!(data.delete(:thresholds) || {})
 
         # clean up values that are the default
-        data.delete(:notify_no_data) if data[:notify_no_data] # Monitor uses true by default
+        if !!data[:notify_no_data] == !Models::Monitor::SKIP_NOTIFY_NO_DATA_TYPES.include?(data[:type])
+          data.delete(:notify_no_data)
+        end
         data.delete(:notify_audit) unless data[:notify_audit] # Monitor uses false by default
 
         # keep all values that are settable

data/lib/kennel/models/monitor.rb

@@ -30,6 +30,7 @@ module Kennel
       }.freeze
       DEFAULT_ESCALATION_MESSAGE = ["", nil].freeze
       ALLOWED_PRIORITY_CLASSES = [NilClass, Integer].freeze
+      SKIP_NOTIFY_NO_DATA_TYPES = ["event alert", "event-v2 alert", "log alert"].freeze
 
       settings(
         :query, :name, :message, :escalation_message, :critical, :type, :renotify_interval, :warning, :timeout_h, :evaluation_delay,
@@ -44,7 +45,9 @@ module Kennel
         renotify_interval: -> { project.team.renotify_interval },
         warning: -> { nil },
         ok: -> { nil },
-        notify_no_data: -> { true }, # datadog UI sets this to false by default, but true is safer
+        # datadog UI sets this to false by default, but true is safer
+        # except for log alerts which will always have "no error" gaps and should default to false
+        notify_no_data: -> { !SKIP_NOTIFY_NO_DATA_TYPES.include?(type) },
         no_data_timeframe: -> { 60 },
         notify_audit: -> { MONITOR_OPTION_DEFAULTS.fetch(:notify_audit) },
         new_host_delay: -> { MONITOR_OPTION_DEFAULTS.fetch(:new_host_delay) },

data/lib/kennel/projects_provider.rb

@@ -1,6 +1,20 @@
 # frozen_string_literal: true
 module Kennel
   class ProjectsProvider
+    class AutoloadFailed < StandardError
+    end
+
+    # @return [Array<Models::Project>]
+    #   All projects in the system. This is a slow operation.
+    #   Use `projects` to get all projects in the system.
+    def all_projects
+      load_all
+      Models::Project.recursive_subclasses.map(&:new)
+    end
+
+    # @return [Array<Models::Project>]
+    #   All projects in the system. This is a slow operation.
+
     def projects
       load_all
       Models::Project.recursive_subclasses.map(&:new)
@@ -21,9 +35,7 @@ module Kennel
       Dir.exist?("teams") && loader.push_dir("teams", namespace: Teams)
       Dir.exist?("parts") && loader.push_dir("parts")
 
-      # TODO: verify this works by running generate and also running generate for each possible PROJECT
-      # in isolation, then remove AUTOLOAD_PROJECTS
-      if ENV["AUTOLOAD_PROJECTS"]
+      if (autoload = ENV["AUTOLOAD_PROJECTS"]) && autoload != "false"
         loader.push_dir("projects")
         loader.setup
 
@@ -32,7 +44,7 @@ module Kennel
           # so when loading a project we need to find anything that could be a project source
           # sorting by name and nesting level to avoid confusion
           segments = project.split("_")
-          search = /#{segments[0...-1].map { |p| "#{p}[_/]" }.join}#{segments[-1]}(\.rb|\/project\.rb)/
+          search = /#{segments[0...-1].map { |p| "#{p}[_/]" }.join}#{segments[-1]}(\.rb|\/project\.rb|\/base\.rb)/
 
           projects_path = "#{File.expand_path("projects")}/"
           known_paths = loader.all_expected_cpaths.keys
@@ -41,17 +53,19 @@ module Kennel
           end.sort.min_by { |p| p.count("/") }
           if project_path
             require project_path
-          else
+          elsif autoload != "abort"
             Kennel.err.puts(
               "No projects/ file matching #{search} found" \
               ", falling back to slow loading of all projects instead"
             )
             loader.eager_load
+          else
+            raise AutoloadFailed, "No projects/ file matching #{search} found"
           end
-        else
+        else # all projects needed
           loader.eager_load
         end
-      else
+      else # old style without autoload
         loader.setup
         loader.eager_load # TODO: this should not be needed but we see hanging CI processes when it's not added
         # TODO: also auto-load projects and update expected path too

data/lib/kennel/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Kennel
-  VERSION = "1.160.0"
+  VERSION = "1.162.0"
 end

data/lib/kennel.rb

@@ -131,13 +131,13 @@ module Kennel
 
     # performance: this takes ~100ms on large codebases, tried rewriting with Set or Hash but it was slower
     def validate_unique_tracking_ids(parts)
-      parts.group_by(&:tracking_id).each do |tracking_id, same|
-        next if same.size == 1
-        raise <<~ERROR
-          #{tracking_id} is defined #{same.size} times
-          use a different `kennel_id` when defining multiple projects/monitors/dashboards to avoid this conflict
-        ERROR
-      end
+      bad = parts.group_by(&:tracking_id).select { |_, same| same.size > 1 }
+      return if bad.empty?
+      raise <<~ERROR
+        #{bad.map { |tracking_id, same| "#{tracking_id} is defined #{same.size} times" }.join("\n")}
+
+        use a different `kennel_id` when defining multiple projects/monitors/dashboards to avoid this conflict
+      ERROR
     end
 
     def definitions(**kwargs)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kennel
 version: !ruby/object:Gem::Version
-  version: 1.160.0
+  version: 1.162.0
 platform: ruby
 authors:
 - Michael Grosser
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-04-10 00:00:00.000000000 Z
+date: 2025-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: diff-lcs