kennel 1.160.0 → 1.161.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 305e0eb2205f87e8f993c0a6d19936f8ab2b2bdffa20316cc54dd241932cdad0
-  data.tar.gz: aea7a8fe0cbb8981e777bf83cdcfdf07489581c0621140f299aa9ec4a3447ac3
+  metadata.gz: 856d925b4aeee8af7171cb092b746c70c8e21cfa06a1987910a25ef193e79a50
+  data.tar.gz: c174845463912362beba00a86f63d11316ec54f0a57459e4c6cd32e0d1d358d4
 SHA512:
-  metadata.gz: 19ebc04a7b038919f635a33fc9e8f9e94500c62d9e8c68f6a51df9d66d4d8bc9e4b0036cd48b04f1215cfaa23d28321982ac28f90b26fd091cbac6da671b1f22
-  data.tar.gz: cddea78b6c4050cfbb3b7de37346ea91022a00f72f3da62368870878c8630a2024988b894bb102be81e05f80002c0e9ffcf2ce1ae434673eca43fc342c902f44
+  metadata.gz: 328b385c98c37473d65799e1721da32f9a8ff4d4d238be42a37196aea6e880d5ce1ae76dfb5ec8ffd4e6f60c70c99af070566b09c3fa4c34032d431b4e2a6189
+  data.tar.gz: f74557a8ff3fe9ee436034774ed1fe5c5176e9919114e48241f08f3ffbc3950b2a32d25574d9d99c1a3c6470d3381d2880b356a7a54cc2795c2f13b4843980af

data/lib/kennel/importer.rb

@@ -47,7 +47,9 @@ module Kennel
         data.merge!(data.delete(:thresholds) || {})
 
         # clean up values that are the default
-        data.delete(:notify_no_data) if data[:notify_no_data] # Monitor uses true by default
+        if !!data[:notify_no_data] == !Models::Monitor::SKIP_NOTIFY_NO_DATA_TYPES.include?(data[:type])
+          data.delete(:notify_no_data)
+        end
         data.delete(:notify_audit) unless data[:notify_audit] # Monitor uses false by default
 
         # keep all values that are settable

data/lib/kennel/models/monitor.rb

@@ -30,6 +30,7 @@ module Kennel
       }.freeze
       DEFAULT_ESCALATION_MESSAGE = ["", nil].freeze
       ALLOWED_PRIORITY_CLASSES = [NilClass, Integer].freeze
+      SKIP_NOTIFY_NO_DATA_TYPES = ["event alert", "event-v2 alert", "log alert"].freeze
 
       settings(
         :query, :name, :message, :escalation_message, :critical, :type, :renotify_interval, :warning, :timeout_h, :evaluation_delay,
@@ -44,7 +45,9 @@ module Kennel
         renotify_interval: -> { project.team.renotify_interval },
         warning: -> { nil },
         ok: -> { nil },
-        notify_no_data: -> { true }, # datadog UI sets this to false by default, but true is safer
+        # datadog UI sets this to false by default, but true is safer
+        # except for log alerts which will always have "no error" gaps and should default to false
+        notify_no_data: -> { !SKIP_NOTIFY_NO_DATA_TYPES.include?(type) },
         no_data_timeframe: -> { 60 },
         notify_audit: -> { MONITOR_OPTION_DEFAULTS.fetch(:notify_audit) },
         new_host_delay: -> { MONITOR_OPTION_DEFAULTS.fetch(:new_host_delay) },

data/lib/kennel/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Kennel
-  VERSION = "1.160.0"
+  VERSION = "1.161.0"
 end

data/lib/kennel.rb

@@ -131,13 +131,13 @@ module Kennel
 
     # performance: this takes ~100ms on large codebases, tried rewriting with Set or Hash but it was slower
     def validate_unique_tracking_ids(parts)
-      parts.group_by(&:tracking_id).each do |tracking_id, same|
-        next if same.size == 1
-        raise <<~ERROR
-          #{tracking_id} is defined #{same.size} times
-          use a different `kennel_id` when defining multiple projects/monitors/dashboards to avoid this conflict
-        ERROR
-      end
+      bad = parts.group_by(&:tracking_id).select { |_, same| same.size > 1 }
+      return if bad.empty?
+      raise <<~ERROR
+        #{bad.map { |tracking_id, same| "#{tracking_id} is defined #{same.size} times" }.join("\n")}
+
+        use a different `kennel_id` when defining multiple projects/monitors/dashboards to avoid this conflict
+      ERROR
     end
 
     def definitions(**kwargs)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kennel
 version: !ruby/object:Gem::Version
-  version: 1.160.0
+  version: 1.161.0
 platform: ruby
 authors:
 - Michael Grosser
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-04-10 00:00:00.000000000 Z
+date: 2025-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: diff-lcs