kennel 1.159.0 → 1.161.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: afa96484d3351de6a715ca440d8a22d3eb81012866a08987b0ddce36b568ae48
-  data.tar.gz: 5f8d189f4447e998711ae07a1ee245c56c0453569a5a43e12ca8a9e9c3184030
+  metadata.gz: 856d925b4aeee8af7171cb092b746c70c8e21cfa06a1987910a25ef193e79a50
+  data.tar.gz: c174845463912362beba00a86f63d11316ec54f0a57459e4c6cd32e0d1d358d4
 SHA512:
-  metadata.gz: a3886ae264c55d8112de1f16e7d0af92b97d1ecbf470219ff7131cb45df6fa115ef14142cc3c31056e88a135bb2c4091d15fd9a160a624875f2758db23ad70d8
-  data.tar.gz: 072d6d09e64c55e1a0c167ec884dfcf17102c05fdba614b5bbc1132e3c582cb5699c6bfdf1faf4d6a5d5d0b7b702adbc94b82753b20530d1d3d435593cea774a
+  metadata.gz: 328b385c98c37473d65799e1721da32f9a8ff4d4d238be42a37196aea6e880d5ce1ae76dfb5ec8ffd4e6f60c70c99af070566b09c3fa4c34032d431b4e2a6189
+  data.tar.gz: f74557a8ff3fe9ee436034774ed1fe5c5176e9919114e48241f08f3ffbc3950b2a32d25574d9d99c1a3c6470d3381d2880b356a7a54cc2795c2f13b4843980af

data/lib/kennel/api.rb

@@ -7,7 +7,7 @@ module Kennel
 
     RateLimitParams = Data.define(:limit, :period, :remaining, :reset, :name)
 
-    def self.tag(api_resource, reply)
+    def self.with_tracking(api_resource, reply)
       klass = Models::Record.api_resource_map[api_resource]
       return reply unless klass # do not blow up on unknown models
 
@@ -28,7 +28,7 @@ module Kennel
       response = request :get, "/api/v1/#{api_resource}/#{id}", params: params
       response = response.fetch(:data) if api_resource == "slo"
       response[:id] = response.delete(:public_id) if api_resource == "synthetics/tests"
-      self.class.tag(api_resource, response)
+      self.class.with_tracking(api_resource, response)
     end
 
     def list(api_resource, params = {})
@@ -44,7 +44,7 @@ module Kennel
         # ignore monitor synthetics create and that inherit the kennel_id, we do not directly manage them
         response.reject! { |m| m[:type] == "synthetics alert" } if api_resource == "monitor"
 
-        response.map { |r| self.class.tag(api_resource, r) }
+        response.map { |r| self.class.with_tracking(api_resource, r) }
       end
     end
 
@@ -52,13 +52,13 @@ module Kennel
       response = request :post, "/api/v1/#{api_resource}", body: attributes
       response = response.fetch(:data).first if api_resource == "slo"
       response[:id] = response.delete(:public_id) if api_resource == "synthetics/tests"
-      self.class.tag(api_resource, response)
+      self.class.with_tracking(api_resource, response)
     end
 
     def update(api_resource, id, attributes)
       response = request :put, "/api/v1/#{api_resource}/#{id}", body: attributes
       response[:id] = response.delete(:public_id) if api_resource == "synthetics/tests"
-      self.class.tag(api_resource, response)
+      self.class.with_tracking(api_resource, response)
     end
 
     # - force=true to not dead-lock on dependent monitors+slos

data/lib/kennel/importer.rb

@@ -14,10 +14,6 @@ module Kennel
     end
 
     def import(resource, id)
-      if ["screen", "dash"].include?(resource)
-        raise ArgumentError, "resource 'screen' and 'dash' are deprecated, use 'dashboard'"
-      end
-
       model =
         Kennel::Models::Record.subclasses.detect { |c| c.api_resource == resource } ||
         raise(ArgumentError, "#{resource} is not supported")
@@ -51,7 +47,9 @@ module Kennel
         data.merge!(data.delete(:thresholds) || {})
 
         # clean up values that are the default
-        data.delete(:notify_no_data) if data[:notify_no_data] # Monitor uses true by default
+        if !!data[:notify_no_data] == !Models::Monitor::SKIP_NOTIFY_NO_DATA_TYPES.include?(data[:type])
+          data.delete(:notify_no_data)
+        end
         data.delete(:notify_audit) unless data[:notify_audit] # Monitor uses false by default
 
         # keep all values that are settable

data/lib/kennel/models/dashboard.rb

@@ -34,7 +34,8 @@ module Kennel
           },
           time: {},
           title_align: "left",
-          title_size: "16"
+          title_size: "16",
+          show_legend: true
         },
         "note" => {
           show_tick: false,

data/lib/kennel/models/monitor.rb

@@ -30,6 +30,7 @@ module Kennel
       }.freeze
       DEFAULT_ESCALATION_MESSAGE = ["", nil].freeze
       ALLOWED_PRIORITY_CLASSES = [NilClass, Integer].freeze
+      SKIP_NOTIFY_NO_DATA_TYPES = ["event alert", "event-v2 alert", "log alert"].freeze
 
       settings(
         :query, :name, :message, :escalation_message, :critical, :type, :renotify_interval, :warning, :timeout_h, :evaluation_delay,
@@ -44,7 +45,9 @@ module Kennel
         renotify_interval: -> { project.team.renotify_interval },
         warning: -> { nil },
         ok: -> { nil },
-        notify_no_data: -> { true }, # datadog UI sets this to false by default, but true is safer
+        # datadog UI sets this to false by default, but true is safer
+        # except for log alerts which will always have "no error" gaps and should default to false
+        notify_no_data: -> { !SKIP_NOTIFY_NO_DATA_TYPES.include?(type) },
         no_data_timeframe: -> { 60 },
         notify_audit: -> { MONITOR_OPTION_DEFAULTS.fetch(:notify_audit) },
         new_host_delay: -> { MONITOR_OPTION_DEFAULTS.fetch(:new_host_delay) },

data/lib/kennel/syncer.rb

@@ -91,21 +91,7 @@ module Kennel
         matching, unmatched_expected, unmatched_actual = MatchedExpected.partition(expected, actual)
         unmatched_actual.select! { |a| a.fetch(:tracking_id) } # ignore items that were never managed by kennel
 
-        # if there is a new item that has the same name/title as a to be deleted item, we should just update it
-        # careful with unmatched_expected being huge since it has all api resources
-        unmatched_expected.reject! do |e|
-          actual = unmatched_actual.detect do |a|
-            a[:klass] == e.class &&
-              Kennel::Models::Record::TITLE_FIELDS.any? { |f| (set = a[f]) && set == e.as_json.fetch(f) }
-          end
-          next false unless actual # keep in unmatched
-
-          unmatched_actual.delete(actual)
-          actual[:tracking_id] = e.tracking_id
-          matching << [e, actual]
-
-          true # remove from unmatched
-        end
+        convert_replace_into_update!(matching, unmatched_actual, unmatched_expected)
 
         validate_expected_id_not_missing unmatched_expected
         fill_details! matching # need details to diff later
@@ -137,6 +123,32 @@ module Kennel
       end
     end
 
+    # if there is a new item that has the same name or title as an "to be deleted" item,
+    # update it instead to avoid old urls from becoming invalid
+    # - careful with unmatched_actual being huge since it has all api resources
+    # - don't do it when a monitor type is changing since that would block the update
+    def convert_replace_into_update!(matching, unmatched_actual, unmatched_expected)
+      unmatched_expected.reject! do |e|
+        e_field, e_value = Kennel::Models::Record::TITLE_FIELDS.detect do |field|
+          next unless (value = e.as_json[field])
+          break [field, value]
+        end
+        raise unless e_field #  uncovered: should never happen ...
+        e_monitor_type = e.as_json[:type]
+
+        actual = unmatched_actual.detect do |a|
+          a[:klass] == e.class && a[e_field] == e_value && a[:type] == e_monitor_type
+        end
+        next false unless actual # keep in unmatched
+
+        # add as update and remove from unmatched
+        unmatched_actual.delete(actual)
+        actual[:tracking_id] = e.tracking_id
+        matching << [e, actual]
+        true
+      end
+    end
+
     # fill details of things we need to compare
     def fill_details!(details_needed)
       details_needed = details_needed.map { |e, a| a if e && e.class.api_resource == "dashboard" }.compact

data/lib/kennel/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Kennel
-  VERSION = "1.159.0"
+  VERSION = "1.161.0"
 end

data/lib/kennel.rb

@@ -131,13 +131,13 @@ module Kennel
 
     # performance: this takes ~100ms on large codebases, tried rewriting with Set or Hash but it was slower
     def validate_unique_tracking_ids(parts)
-      parts.group_by(&:tracking_id).each do |tracking_id, same|
-        next if same.size == 1
-        raise <<~ERROR
-          #{tracking_id} is defined #{same.size} times
-          use a different `kennel_id` when defining multiple projects/monitors/dashboards to avoid this conflict
-        ERROR
-      end
+      bad = parts.group_by(&:tracking_id).select { |_, same| same.size > 1 }
+      return if bad.empty?
+      raise <<~ERROR
+        #{bad.map { |tracking_id, same| "#{tracking_id} is defined #{same.size} times" }.join("\n")}
+
+        use a different `kennel_id` when defining multiple projects/monitors/dashboards to avoid this conflict
+      ERROR
     end
 
     def definitions(**kwargs)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kennel
 version: !ruby/object:Gem::Version
-  version: 1.159.0
+  version: 1.161.0
 platform: ruby
 authors:
 - Michael Grosser
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-04-02 00:00:00.000000000 Z
+date: 2025-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: diff-lcs